[pve-devel] applied: [PATCH v2 qemu-server] Fix #2728: die/warn if target is not a replication target when live-migrating

2020-07-23 Thread Fabian Grünbichler
with T-B included. since this is pre-config-lock and outside the flocked section, it might make sense to repeat the check in QemuMigrate? then again, creating/deleting replication jobs only locks the replication config and not the VM config, so without changes there it won't be race-free eithe

Re: [pve-devel] Enabling mips/mipsel support in Hypervisor

2020-07-23 Thread Fabian Grünbichler
On July 24, 2020 2:23 am, Skyler Mäntysaari wrote: > Hi all, > > I would like to ask how can I get mips/mipsel arch qemu working on Proxmox? quoting my own post in the forum thread you linked ;) > we only build the amd64 emulation, and install qemu-system-amd64 as > "kvm" binary. so no, this do

[pve-devel] Enabling mips/mipsel support in Hypervisor

2020-07-23 Thread Skyler Mäntysaari
Hi all, I would like to ask how can I get mips/mipsel arch qemu working on Proxmox? This forum post, seems to indicate it should be rather simple, but why was it disabled to begin with? # apt install qemu-system-mip

[pve-devel] [PATCH manager] Allow setting device class on osd create

2020-07-23 Thread Alwin Antreich
In some situations Ceph's auto-detection doesn't recognize the device class correctly. The option allows to set it directly on osd create, instead of altering it afterwards. This way the cluster doesn't need to shift data back and forth unnecessarily. Signed-off-by: Alwin Antreich --- PVE/API2/C

Re: [pve-devel] [PATCH proxmox-backup-qemu] fix #2866: invalidate bitmap on crypt_mode change

2020-07-23 Thread Fabian Grünbichler
On July 23, 2020 12:43 pm, Stefan Reiter wrote: > On 7/23/20 12:34 PM, Fabian Grünbichler wrote: >> On July 23, 2020 12:07 pm, Stefan Reiter wrote: >>> idea looks ok, comments inline >>> >>> On 7/23/20 11:21 AM, Fabian Grünbichler wrote: signed and plain backups share chunks, so bitmap reusal

Re: [pve-devel] [PATCH proxmox-backup-qemu] fix #2866: invalidate bitmap on crypt_mode change

2020-07-23 Thread Stefan Reiter
On 7/23/20 12:34 PM, Fabian Grünbichler wrote: On July 23, 2020 12:07 pm, Stefan Reiter wrote: idea looks ok, comments inline On 7/23/20 11:21 AM, Fabian Grünbichler wrote: signed and plain backups share chunks, so bitmap reusal is okay for those combinations. switching from encrypted to not e

Re: [pve-devel] [PATCH proxmox-backup-qemu] fix #2866: invalidate bitmap on crypt_mode change

2020-07-23 Thread Fabian Grünbichler
On July 23, 2020 12:07 pm, Stefan Reiter wrote: > idea looks ok, comments inline > > On 7/23/20 11:21 AM, Fabian Grünbichler wrote: >> signed and plain backups share chunks, so bitmap reusal is okay for >> those combinations. switching from encrypted to not encrypted or >> vice-versa could have pr

Re: [pve-devel] [PATCH proxmox-backup-qemu] fix #2866: invalidate bitmap on crypt_mode change

2020-07-23 Thread Stefan Reiter
idea looks ok, comments inline On 7/23/20 11:21 AM, Fabian Grünbichler wrote: signed and plain backups share chunks, so bitmap reusal is okay for those combinations. switching from encrypted to not encrypted or vice-versa could have pretty fatal consequences - either referencing plain-text chunk

[pve-devel] [PATCH proxmox-backup-qemu] fix #2866: invalidate bitmap on crypt_mode change

2020-07-23 Thread Fabian Grünbichler
signed and plain backups share chunks, so bitmap reusal is okay for those combinations. switching from encrypted to not encrypted or vice-versa could have pretty fatal consequences - either referencing plain-text chunks in 'encrypted' backups, or referencing encrypted chunks in 'unencrypted' backup

Re: [pve-devel] [PATCH docs 1/2] pvecm: Add required -r to rm

2020-07-23 Thread Dominic Jäger
On Wed, Jul 22, 2020 at 12:31:53PM +0200, Thomas Lamprecht wrote: > On 22.07.20 12:20, Dominic Jäger wrote: > > /etc/corosync/* includes the directory uidgid.d. > > Consequentlly, a correct rm call requires -r. > > Does leaving this directory left-over causes any issues? When I tested this it was