Re: [Puppet Users] Review of new type & provider

2011-09-21 Thread Jacob Helwig
On Tue, 20 Sep 2011 23:19:36 -0700, James Turnbull wrote: > > Jesse Peterson wrote: > > Hello, > > > > I'm new to both Ruby and Puppet. Puppet is fantastic - loving it so > > far. > > > > I created a new type & provider (of parsed file type) for modifying > > newsyslog.conf files and am hoping s

Re: [Puppet Users] Review of new type & provider

2011-09-20 Thread James Turnbull
Jesse Peterson wrote: > Hello, > > I'm new to both Ruby and Puppet. Puppet is fantastic - loving it so > far. > > I created a new type & provider (of parsed file type) for modifying > newsyslog.conf files and am hoping some folks would be willing to > review it to make sure there are no glaring m

[Puppet Users] Review of new type & provider

2011-09-20 Thread Jesse Peterson
Hello, I'm new to both Ruby and Puppet. Puppet is fantastic - loving it so far. I created a new type & provider (of parsed file type) for modifying newsyslog.conf files and am hoping some folks would be willing to review it to make sure there are no glaring mistakes or perhaps some shortcuts or l

Re: [Puppet Users] review

2011-06-28 Thread Adrien Thebo
Hi Guillaume, I would say that the fact looks pretty solid, with one little detail. The way facter was designed was to contain all of the logic to resolve a fact within the setcode block. If one of the requires fail, ruby will throw a LoadError, which facter will catch. However, if any of the logi

[Puppet Users] review

2011-06-28 Thread Guillaume Rousse
Hello. Here is a custom fact I created for enumerating netgroups from an ldap directory. As I'm a total ruby newbie, I'd be interested by review for it. -- BOFH excuse #439: Hot Java has gone cold -- You received this message because you are subscribed to the Google Groups "Puppet Users" grou