Re: [Puppet Users] puppet-lint & Syntax

2018-02-20 Thread Christopher Wood
Taking a stab at this... The puppet parser will always be the authoritative source for one's puppet code validation since that is what will be parsing the code via agent or server. It will introduce any number of bugs and inconsistencies and delay to have puppet-lint keep up with what puppet do

Re: [Puppet Users] puppet-lint & Syntax

2018-02-20 Thread Albert Shih
20/02/2018 à 14:01:23+0100, Maria Elena a écrit > Hi Albert, > maybe cause puppet-lint checks only style (http://puppet-lint.com/). > Regards. You're perfectly right. But in fact I'm not very good in english, so I will rephrase... Can puppet-lint check also the syntax ? So we don't need to launc

Re: [Puppet Users] puppet-lint & Syntax

2018-02-20 Thread Maria Elena
Hi Albert, maybe cause puppet-lint checks only style (http://puppet-lint.com/). Regards. M.E. On Tue, Feb 20, 2018 at 1:53 PM, Albert Shih wrote: > Hi everyone, > > I'm wonder why puppet-lint don't show any syntax error. > > For example I just delete a "," at the end of a line and > > [root@io

Re: [Puppet Users] puppet-lint & Syntax

2018-02-20 Thread Albert Shih
Le 20/02/2018 à 14:00:04+0100, Martin Alfke a écrit Hi, > > some lint checks are not available in lint core, but are within a lint plugin. > In your case check: > https://github.com/voxpupuli/puppet-lint-trailing_comma-check.git > > Complete list can be found on voxpupuli: > https://voxpupuli.or

Re: [Puppet Users] puppet-lint & Syntax

2018-02-20 Thread Martin Alfke
Hi Albert, some lint checks are not available in lint core, but are within a lint plugin. In your case check: https://github.com/voxpupuli/puppet-lint-trailing_comma-check.git Complete list can be found on voxpupuli: https://voxpupuli.org/plugins/#puppet-lint Best, Martin > On 20. Feb 2018,

[Puppet Users] puppet-lint & Syntax

2018-02-20 Thread Albert Shih
Hi everyone, I'm wonder why puppet-lint don't show any syntax error. For example I just delete a "," at the end of a line and [root@io manifests]$ puppet-lint init.pp [root@io manifests]$ puppet parser validate init.pp Error: Could not parse for environment production: Syntax error at 'Boolean'

Re: [Puppet Users] puppet-lint 2.0.1 is released

2016-08-18 Thread Ramin K
Oh excellent. Thanks for reverting. I may see if I can spend some time or it if only to write more complete tests so it doesn't flip flop in the future. Ramin On 8/18/16 8:37 PM, Rob Nelson wrote: Ramin, No worries, it's a legitimate complaint. Puppet-lint 2.0.2 was just released which rever

Re: [Puppet Users] puppet-lint 2.0.1 is released

2016-08-18 Thread Rob Nelson
Ramin, No worries, it's a legitimate complaint. Puppet-lint 2.0.2 was just released which reverted that issue. We're back to the original problem in #504 but it's not worse than it was in 2.0.0 at least. Rob Nelson rnels...@gmail.com On Thu, Aug 18, 2016 at 9:56 PM, Ramin K wrote: > On 8/18/1

Re: [Puppet Users] puppet-lint 2.0.1 is released

2016-08-18 Thread Ramin K
On 8/18/16 9:35 AM, Rob Nelson wrote: All, I'm happy to announce that puppet-lint 2.0.1 has been released today. Please checkout the changelog below for details. Please open a ticket on the project if you discover any issues with it. This is the second release of puppet-lint this year and we ho

[Puppet Users] puppet-lint 2.0.1 is released

2016-08-18 Thread Rob Nelson
All, I'm happy to announce that puppet-lint 2.0.1 has been released today. Please checkout the changelog below for details. Please open a ticket on the project if you discover any issues with it. This is the second release of puppet-lint this year and we hope to keep the pace up in the coming mon

Re: [Puppet Users] puppet-lint questions

2014-04-10 Thread Rich Burroughs
Oh that's clever, thanks :) Rich On Thursday, April 10, 2014, John Warburton wrote: > We are in the middle of a similar task > > We are manually fixing lint issues and putting a string '#PUPPET_LINT' at > the end of each fixed file. The pre commit hook checks for this string > before doing the

Re: [Puppet Users] puppet-lint questions

2014-04-10 Thread John Warburton
We are in the middle of a similar task We are manually fixing lint issues and putting a string '#PUPPET_LINT' at the end of each fixed file. The pre commit hook checks for this string before doing the lint check All new puppet modules get the string put in immediately At some time in the future,

[Puppet Users] puppet-lint questions

2014-04-10 Thread Rich Burroughs
I saw one of the Puppet Labs webinars about setting up your Puppet development environment, and at one point it mentioned using a git hook to run puppet-lint before committing. We do that where I work with "puppet parser validate," but right now a lot of our code would not pass a puppet-lint ru

Re: [Puppet Users] puppet-lint -- learning stuff about style but also generating questions

2013-07-01 Thread Jakov Sosic
On 04/11/2013 05:22 PM, Dan White wrote: > puppet-lint does not like template files at all. > I keep getting this: ERROR: Syntax error (try running `puppet parser validate > `) puppet-lint checks adherence to codestyle. For erb's you can check syntax with something like this: $ erb -x -T - my

Re: [Puppet Users] puppet-lint -- learning stuff about style but also generating questions

2013-04-11 Thread Dan White
On Apr 11, 2013, at 1:53 PM, llowder wrote: > On Thursday, April 11, 2013 10:22:54 AM UTC-5, Ygor wrote: > Now for a question: > > puppet-lint does not like template files at all. > I keep getting this: ERROR: Syntax error (try running `puppet parser validate > `) > > My first thought is to

[Puppet Users] puppet-lint -- learning stuff about style but also generating questions

2013-04-11 Thread Dan White
Here's one I learned: I originally had # Ensure /etc/hosts contains the basics host { "${fqdn}": host_aliases => $hostname, ip => $ipaddress, } And thru some trial and error, got down to this (which puppet-lint does not gripe about) # Ensure /etc/hosts contains the basics host

[Puppet Users] puppet-lint: class_inherits_from_params_class

2012-09-27 Thread Antidot SAS
Hi everyone, I might have missed something but is it normal to have warning with the use of params class inheritance? --- modules/rush/manifests/init.pp - WARNING: class inheriting from params class on line 19 --- Is the 'params' class not needed anymore with puppet? I am aware of the new impleme

Re: [Puppet Users] puppet-lint status error

2012-09-20 Thread Erik Dalén
I believe it was fixed in https://github.com/rodjek/puppet-lint/pull/141 But it might not have been released yet as a gem. On 20 September 2012 10:34, Antidot SAS wrote: > Hi everyone, > > > I have recently updated the puppet-lint: > # puppet-lint -v > Puppet-lint 0.2.1 > # > > And now I don't ha

[Puppet Users] puppet-lint status error

2012-09-20 Thread Antidot SAS
Hi everyone, I have recently updated the puppet-lint: # puppet-lint -v Puppet-lint 0.2.1 # And now I don't have error status comming up: # puppet-lint --no-80chars-check --no-2sp_soft_tabs-check --no-hard_tabs-check --no-autoloader_layout-check --fail-on-warnings manifests/s_templates/s_ntp.pp ;

Re: [Puppet Users] puppet-lint

2012-09-13 Thread Antidot SAS
Hey, Yep, I though the code was more important then the comment from a formatting point of view but I might be confused. On Thu, Sep 13, 2012 at 4:35 PM, Tim Sharpe wrote: > Hi, > > Why is it OK to have trailing whitespace in comments but not code? > > On Thursday, 13 September 2012 at 4:43

Re: [Puppet Users] puppet-lint

2012-09-13 Thread Tim Sharpe
Hi, Why is it OK to have trailing whitespace in comments but not code? On Thursday, 13 September 2012 at 4:43 AM, Antidot SAS wrote: > Hi, > > I don't want to remove the error when it is accurate just when it is in a > comment line, just asking not a big deal though... > > > > On Thu,

Re: [Puppet Users] puppet-lint

2012-09-13 Thread Antidot SAS
Hi, I don't want to remove the error when it is accurate just when it is in a comment line, just asking not a big deal though... On Thu, Sep 13, 2012 at 12:42 PM, Anton Lindström wrote: > Hi, > > The README on Github has a nice section about disabling checks: > https://github.com/rodjek/puppe

Re: [Puppet Users] puppet-lint

2012-09-13 Thread Anton Lindström
Hi, The README on Github has a nice section about disabling checks: https://github.com/rodjek/puppet-lint Try the --no--check flag to disable a check, I guess for the trailing whitespace the --no-trailing-whitespace-check can be used. Regards, Anton On Sep 13, 2012, at 11:46 AM, Antidot SAS

[Puppet Users] puppet-lint

2012-09-13 Thread Antidot SAS
Hi everyone, Is it possible not to notify error with puppet-lint when "trailing whitespace" are found in a comment line? Just asking. Regards, JM -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-u

Re: [Puppet Users] puppet-lint and 80 characters line limit?

2012-08-20 Thread Jakov Sosic
On 08/20/2012 08:21 PM, Tim Mooney wrote: > I asked the same question on May 21st, check the group archives for the > thread and some options. I believe the subject was "linting manifests > with long lines". > > My solution: > > 01:20 PM dogbert ~$ cat ~/.puppet-lintrc --no-80chars-check Oh, I

Re: [Puppet Users] puppet-lint and 80 characters line limit?

2012-08-20 Thread Tim Mooney
In regard to: [Puppet Users] puppet-lint and 80 characters line limit?,...: I'm getting lots of warning like this one from puppet-lint: WARNING: line 67 has more than 80 characters Now, I don't like warnings, so any idea how should I rewrite this line for example, to void t

[Puppet Users] puppet-lint and 80 characters line limit?

2012-08-20 Thread Jakov Sosic
Hi. I'm getting lots of warning like this one from puppet-lint: WARNING: line 67 has more than 80 characters Now, I don't like warnings, so any idea how should I rewrite this line for example, to void the warning? package {'rpmforge-release': ensure => '0.5.2-2.el6.rf', provider => 'rpm',

Re: [Puppet Users] puppet-lint crashes and burns

2012-07-11 Thread Tim Sharpe
Hi Peter, Could I get you to file a bug report an https://github.com/rodjek/puppet-lint/issues with all the relevant info? Cheers, Tim On Thursday, 12 July 2012 at 12:11 AM, Peter Berghold wrote: > Hi there, > > After seeing a tweet about puppet-lint I went ahead and installed puppet-li

Re: [Puppet Users] puppet-lint crashes and burns

2012-07-11 Thread Denmat
Enterprise ruby? http://www.rubyenterpriseedition.com/download.html On 12/07/2012, at 1:25, Peter Berghold wrote: > Unfortunately in this case I'm stuck with whatever my VPS provider provides > as templates. Fortunately they seem to have added CentOS 6.2 since I created > this VPS (less than

Re: [Puppet Users] puppet-lint crashes and burns

2012-07-11 Thread Peter Berghold
Unfortunately in this case I'm stuck with whatever my VPS provider provides as templates. Fortunately they seem to have added CentOS 6.2 since I created this VPS (less than a year ago) so an update might be in order. There are other factors I've run into with CentOS though that make me crazy. So

Re: [Puppet Users] puppet-lint crashes and burns

2012-07-11 Thread Matthias Saou
On Wed, 11 Jul 2012 10:55:07 -0400 Peter Berghold wrote: > [peter@chits1 manifests]$ ruby -v > ruby 1.8.5 (2006-08-25) [x86_64-linux] > [peter@chits1 manifests]$ ruby -v > ruby 1.8.5 (2006-08-25) [x86_64-linux] > [peter@chits1 manifests]$ uname -a > Linux chits1.chi.sharkrivertech.com 2.6.18-308.

Re: [Puppet Users] puppet-lint crashes and burns

2012-07-11 Thread Felix Frank
Hi, On 07/11/2012 04:55 PM, Peter Berghold wrote: > [peter@chits1 manifests]$ cat /etc/redhat-release > CentOS release 5.8 (Final) haven't danced with it in awhile, but isn't el5 comparable to Debian 4, age-wise? Wouldn't a CentOS 6 upgrade be a smaller hassle? Just my 2c. -- You received this

Re: [Puppet Users] puppet-lint crashes and burns

2012-07-11 Thread Alexander Bien
On 11.07.2012 16:55, Peter Berghold wrote: [peter@chits1 manifests]$ ruby -v ruby 1.8.5 (2006-08-25) [x86_64-linux] [peter@chits1 manifests]$ ruby -v ruby 1.8.5 (2006-08-25) [x86_64-linux] [peter@chits1 manifests]$ uname -a Linux chits1.chi.sharkrivertech.com

Re: [Puppet Users] puppet-lint crashes and burns

2012-07-11 Thread Peter Berghold
[peter@chits1 manifests]$ ruby -v ruby 1.8.5 (2006-08-25) [x86_64-linux] [peter@chits1 manifests]$ ruby -v ruby 1.8.5 (2006-08-25) [x86_64-linux] [peter@chits1 manifests]$ uname -a Linux chits1.chi.sharkrivertech.com 2.6.18-308.1.1.el5xen #1 SMP Wed Mar 7 04:57:35 EST 2012 x86_64 x86_64 x86_64 GNU/

Re: [Puppet Users] puppet-lint crashes and burns

2012-07-11 Thread Matthias Saou
On Wed, 11 Jul 2012 10:39:44 -0400 Peter Berghold wrote: > Yet another reason for me to rebuild that machine with Debian. > CentOS tends to be behind in versions... :-( Not sure what you mean... [root@puppet ~]# rpm -q ruby ruby-1.8.7.352-7.el6_2.x86_64 [root@puppet ~]# cat /etc/redhat-release

Re: [Puppet Users] puppet-lint crashes and burns

2012-07-11 Thread Aaron Russo
Had this exact same problem last night. String.starts_with? wasn't introduced until Ruby 1.8.7. Make sure you have Ruby 1.8.7 or greater installed. Regards, Aaron On Jul 11, 2012, at 7:11 AM, Peter Berghold wrote: Hi there, After seeing a tweet about puppet-lint I went ahead and installed p

Re: [Puppet Users] puppet-lint error

2012-04-19 Thread Patrick Carlisle
It looks like an incompatibility between puppet-lint and ruby 1.9, which removed the String#each method that was in earlier versions. On Wed, Apr 18, 2012 at 11:30 PM, Joseph wrote: > Hi, this is not strictly puppet related but I am hoping someone here > who uses puppet-lint can tell me what is

[Puppet Users] puppet-lint error

2012-04-19 Thread Joseph
Hi, this is not strictly puppet related but I am hoping someone here who uses puppet-lint can tell me what is going on here. $ puppet-lint init.pp /Users/jc/.rvm/rubies/ruby-1.9.3-p125/lib/ruby/site_ruby/1.9.1/ rubygems/custom_require.rb:36:in `require': iconv will be deprecated in the fut