[Puppet Users] Re: Modules review

2010-08-19 Thread Garrett Honeycutt
On Aug 19, 4:04 am, Dennis Hoppe wrote: > Hello, > > i have written some modules for Puppet and would be thankful, if someone > could take a look for quality enhancements. > >        http://194.94.79.17/hotkey/puppet.tar.gz > > The only nasty part is, that i have defined some global variables at

[Puppet Users] Re: Modules review

2010-08-19 Thread John Lyman
Instead of the case statements in init.pp, I do something like this: if defined("foo::$release") { include "foo::$release" } ... not necessarily a "quality enhancement," but it saves on the typing. On Aug 19, 7:04 am, Dennis Hoppe wrote: > Hello, > > i have written some modules for Puppet and w