+1
On Mon, May 24, 2010 at 5:10 PM, Jesse Wolfe wrote:
> This patch allows the puppet single-executable to invoke external,
> hyphenated subcommands, much like how git does.
>
> Signed-off-by: Jesse Wolfe
> ---
> lib/puppet/util.rb | 1 +
> lib/puppet/util/command_line.rb | 15
I'm working on a custom type/provider to handle the config file for a
piece of internal software. The config file is .ini-like and looks
something like this:
[common]
key1 = value1
key2 = value2
[section1]
key3 = value3
key4 = value4
...
[sectionN]
key3 = valueN
key4 = valueN
In other words, t
+.5 because I'm not 100% confident in my comprehension of the code.
But I really like it!
On Mon, May 10, 2010 at 11:55 PM, Luke Kanies wrote:
> (Changes to parser.rb have been removed from this email.)
>
> This is just a first, simplest version, but you can
> now specify relationships directly i
From: Paul Lathrop
Signed-off-by: Paul Lathrop
---
lib/puppet/reports/log.rb |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/puppet/reports/log.rb b/lib/puppet/reports/log.rb
index 8dfeedb..d993334 100644
--- a/lib/puppet/reports/log.rb
+++ b/lib/puppet/reports
On Wed, Apr 21, 2010 at 10:56 AM, Luke Kanies wrote:
> On Apr 21, 2010, at 10:15 AM, Paul Lathrop wrote:
>
>> On Wed, Apr 21, 2010 at 9:55 AM, Luke Kanies wrote:
>>>
>>> On Apr 20, 2010, at 7:02 PM, Paul Lathrop wrote:
>>>
>>>> I'm tryin
On Wed, Apr 21, 2010 at 9:55 AM, Luke Kanies wrote:
> On Apr 20, 2010, at 7:02 PM, Paul Lathrop wrote:
>
>> I'm trying to add support for logging to Scribe. I *think* what I need
>> to do is the following:
>>
>> * Add a "feature" that checks if th
I'm trying to add support for logging to Scribe. I *think* what I need
to do is the following:
* Add a "feature" that checks if the scribe gem is installed. (add a
file lib/puppet/feature/scribe.rb)
* Add configuration options for the scribe server, port, and category.
* Create a new Puppet::Util:
Hey all,
I'm not sure where I originally snagged this sysctl type/provider, but
we were using it w/o problems until we upgraded to 0.25.x and I'm
having trouble debugging the issue. The error we're getting is:
Apr 19 15:46:19 s0005 puppetmasterd[21382]:
(//digg-cassandra/Sysctl[net.ipv4.tcp_max_s
On Wed, Apr 14, 2010 at 12:07 PM, Jesse Wolfe wrote:
>
> the new puppet single-executable is in master, but I think the names of the
> commands should be up for discussion. These are something that we may have
> to live with for a long time.
>
> Here's what's currently in master:
> bin/filebucket
+1
On Tue, Apr 13, 2010 at 1:50 PM, Jesse Wolfe wrote:
> A typo prevents the Rakefile from finding tests in spec/integration
>
> Signed-off-by: Jesse Wolfe
> ---
> Rakefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Rakefile b/Rakefile
> index 7b6983a..026e7b
+1
On Tue, Apr 13, 2010 at 5:12 PM, Jesse Wolfe wrote:
> test_hostsparse could, under some circumstances, leak its target
> filenames into later tests. test_modifyingfile and test_simplehost would
> then write their test data over the data in test/data/types/hosts/* ,
> which would cause subseque
Also adds rspec tests for generate().
Signed-off-by: Paul Lathrop
---
lib/puppet/parser/functions/generate.rb |6 +++-
spec/unit/parser/functions/generate.rb | 41 +++
2 files changed, 45 insertions(+), 2 deletions(-)
create mode 100755 spec/unit/parser
7;t want to be the one who makes the call.
>
> On Apr 6, 2010, at 4:49 PM, Paul Lathrop wrote:
>
>> This is accomplished by adding the --force-yes option to the apt-get
>> command line when a package version is specified.
>>
>> Signed-off-by: Paul Lathrop
>>
On Mon, Apr 5, 2010 at 4:09 PM, James Cammarata wrote:
>
> On Tue, 6 Apr 2010 18:01:36 -0700, Paul Lathrop
> wrote:
>> I wouldn't ask, but I'm not sure how to Google this specific type of
>> question.
>>
>> I'm looking at lib/puppet/util.rb at
I wouldn't ask, but I'm not sure how to Google this specific type of question.
I'm looking at lib/puppet/util.rb at the execute function. The
function definition looks like:
def execute(command, arguments = {:failonfail => true, :combine => true})
What's going on there with that arguments =
This is accomplished by adding the --force-yes option to the apt-get
command line when a package version is specified.
Signed-off-by: Paul Lathrop
---
lib/puppet/provider/package/apt.rb |3 ++-
spec/unit/provider/package/apt.rb |7 +++
2 files changed, 9 insertions(+), 1 deletions
The wiki page at
http://projects.reductivelabs.com/projects/puppet/wiki/Development_Development_Lifecycle
appears to be at least slightly out of date:
"NOTE: It is important to note that currently “master” is the
development branch and 0.24.x is stable, so you will almost always
want to do your de
On Sun, Mar 21, 2010 at 10:37 PM, Luke Kanies wrote:
> Hi all,
>
> I kinda expect blank stares in response to this question, but I'll do what I
> can to both describe what I'm trying to do and to do it in an interesting
> way.
>
> One of the things I've always wanted Puppet to be able to do is to
On Fri, Nov 13, 2009 at 4:25 PM, Markus Roberts
wrote:
> Paul --
>
> I share your intuition--it smells like a bug to me too.
>
> Specifically, it smells like #2630
> (http://projects.reductivelabs.com/issues/2630) though it may be unrelated.
>
> We deferred that as just an efficiency issue (in th
Hiya,
Since upgrading our puppetmaster to 0.25.1, we've noticed a behavior
change which is causing us some problems, and I'm not sure if it is
expected behavior. We have the following resource definition (inside
of a define):
file {
"/var/lib/mysql/extdbfiles/$name":
owner => mysql
On Mon, Oct 26, 2009 at 11:34 AM, Markus Roberts
wrote:
> We have a ticket open (#2748) over a change in behaviour between 0.24.x and
> 0.25.x.
>
> In 0.24.x, the environment specified in the client's configuration file
> could be overridden by the server using the external_nodes information.
>
>
On Thu, Oct 1, 2009 at 4:13 PM, Paul Lathrop wrote:
> Again, there is not (to my knowledge) a plan to pass this information
> into Puppet as yet. Certainly that sounds like a good feature request.
Correction. I watched Luke get a fair amount of this integration
hacked up yesterday. Sho
On Thu, Oct 1, 2009 at 4:08 PM, R.I.Pienaar wrote:
> Can you tell those who aren't at the camp what the useage of this meta data
> will be, will this for dependencies between modules somehow or is it merely a
> compile time aid, or something else completely?
At the moment, the meta data will b
On Thu, Oct 1, 2009 at 3:57 PM, Luke Kanies wrote:
> So (Paul Lathrop will correct me if I'm wrong, I hope), it looks like
> we decided on the following simplistic metadata for modules:
>
> * version
> * name
> * author
> * source (i.e., a URL)
> * requires
* licens
On Wed, Sep 16, 2009 at 11:04 AM, Luke Kanies wrote:
>
> On Sep 16, 2009, at 1:57 AM, R.I.Pienaar wrote:
>
>>
>> hello,
>>
>> - "Luke Kanies" wrote:
>>
Really if you use role classes you most certainly will not be
including both so the silent failure you suggest just wont happen in
+1
On Mon, Aug 10, 2009 at 10:17 AM, Larry Ludwig wrote:
> IMHO the two are pretty clear, and are completely different issues but can
> be inclusive of each other. I think they should be defined as such:
> - needs more information - before the ticket can be investigated we need
> more info from
; or something better named, but
intended for showcasing the various approaches we take to this.
If others agree with me, I'll draft my proposed replacement and
structure on the wiki, and you can all flame me to death for it here
:-) Let me know what you think.
--Paul (Lathrop)
--~--~-~
- there are only seven days in the week.
>
> I don't know the reason for the change from 0-6 to 0-7; if math must
> be done because our period starts at 0, then so be it, but we can't
> make the week 8 days long.
>
> On May 26, 2009, at 7:11 PM, Paul Lathrop wrote:
>
&g
Totally insignificant detail, but you should also change the line that says:
"Optional; if specified, must be between 0 and 6, inclusive, with" to
be "between 0 and 7"
--Paul
On Tue, May 26, 2009 at 2:20 PM, Calimero wrote:
>
> Hi,
>
> As described in ticket #2293 in redmine, the Cron resource
On Mon, Apr 6, 2009 at 10:44 PM, Ohad Levy wrote:
>>
>> >
>> > if you have 5 memcached, the client will contact one of them for
>> > storing the hash key (some algorithm to choose the server based on
>> > the hash name and server name).
>> > so it actually means, that the cache would be across al
On Fri, Feb 27, 2009 at 3:04 PM, Luke Kanies wrote:
>>> Got a reasonable alternate executable proposal? Something we could
>>> reasonably use to, at least, merge puppetca and puppetclean, and
>>> probably merge filebucket into it, too. I could see adding ralsh to
>>> it, also.
>>> puppetcli?
>>
master does the right thing:
if time < 1
puts "Exiting; no certificate found and waitforcert is disabled"
exit(1)
end
On Fri, Feb 27, 2009 at 1:05 PM, Paul Lathrop wrote:
> On Fri, Feb 27, 2009 at 12:48 PM, Luke Kanies wrote:
>
call.
--Paul
On Fri, Feb 27, 2009 at 1:12 PM, Luke Kanies wrote:
>
> I'm fine removing it; just wanted to be clear it was a positive
> change. :)
>
> On Feb 27, 2009, at 3:08 PM, Paul Lathrop wrote:
>
>>
>> On Fri, Feb 27, 2009 at 1:07 PM, Luke Kanies wrote:
&
On Fri, Feb 27, 2009 at 1:07 PM, Luke Kanies wrote:
>
> What's up with all the whitespace changes in this patch?
Oh dammit!
I use emacs with delete-trailing-whitespace as a save hook.
I'll fix the patch (again).
Sorry.
--Paul
--~--~-~--~~~---~--~~
You receive
This version doesn't have the typo.
On Fri, Feb 27, 2009 at 1:03 PM, Paul Lathrop wrote:
>
> "You can turn off waiting for certificates by specifying a time of 0."
>
> Also add a test to ensure we catch any future regression of this behavior.
>
> Signed-off-by:
On Fri, Feb 27, 2009 at 12:48 PM, Luke Kanies wrote:
>
> Note that the certhandler module is gone in master; most of the
> functionality has moved to ssl/host.rb.
I'll make sure the behavior is correct there and submit a separate
patch if appropriate.
--Paul
--~--~-~--~~---
"You can turn off waiting for certificates by specifying a time of 0."
Also add a test to ensure we catch any future regression of this behavior.
Signed-off-by: Paul Lathrop
---
lib/puppet/executables/client/certhandler.rb |7 ++-
spec/unit/executables/client/certhandler.
Also add a test to ensure we catch any future regression of this behavior.
Signed-off-by: Paul Lathrop
---
lib/puppet/executables/client/certhandler.rb |7 ++-
spec/unit/executables/client/certhandler.rb | 13 +
2 files changed, 19 insertions(+), 1 deletions(-)
diff
On Fri, Feb 27, 2009 at 10:56 AM, Luke Kanies wrote:
> Do you really care if waitforcert 0 is missing, since waitforcert 1 is
> essentially equivalent?
Good point. No I don't care.
> In looking at other timeout values (e.g., filetimeout) we usually use
> '0' to mean disabling it, so I think we
On Thu, Feb 26, 2009 at 10:39 AM, Brice Figureau
wrote:
>
> On 26/02/09 19:28, Paul Lathrop wrote:
>> So, I realized there are two reasonable ways to resolve
>> http://projects.reductivelabs.com/issues/2031
>>
>> 1) Change the documentation to match the actual behav
make use of the
existing behavior of 'waitforcert 0', but I wanted to run it by the
list before I patched. Thoughts?
--Paul Lathrop
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"Puppet Developers"
On Mon, Feb 16, 2009 at 7:53 AM, Luke Kanies wrote:
> It makes sense, I'm just concerned about the repercussions. Is it
> unreasonable for people to want to override a given parameter more
> than once?
Yes, if it happens outside of a class hierarchy.
> I'm torn here, because I agree that the i
+1
On Fri, Feb 13, 2009 at 7:01 AM, Luke Kanies wrote:
>
> Signed-off-by: Luke Kanies
> ---
> lib/puppet/file_collection.rb| 20 +++
> lib/puppet/file_collection/lookup.rb | 16
> spec/unit/file_collection.rb | 45
> ++
On Fri, Feb 13, 2009 at 4:07 PM, Luke Kanies wrote:
> I don't know that it's a subtlety; there are cases where you'd want to
> override a given parameter multiple times; linux, then debian, then
> ubuntu, for instance.
>
> I agree that the current override system is clumsy, though, and I'm
> open
+1, looks good.
On Thu, Feb 12, 2009 at 9:00 PM, Luke Kanies wrote:
>
> Applying slightly modified patch.
>
> Also added tests.
>
> Signed-off-by: Luke Kanies
> ---
> lib/puppet/indirector/facts/facter.rb |8 ++--
> spec/unit/indirector/facts/facter.rb | 22 --
>
+.5
It looks good to me, but I'm not sure I totally understand, so I don't
want my vote to count as a full vote. :-(
On Thu, Feb 12, 2009 at 8:30 AM, Paul Nasrat wrote:
>
> This patch fixes up the puppetmasterd tests to run locally.
>
> Signed-off-by: Paul Nasrat
> ---
> spec/integration/bin/
I was thinking about resource overrides last night, and how they
require inheritance. This is a restriction that has caused me to use
convoluted logic to get around it on numerous occasions, and I feel
like it is sub-optimal. Before I go spouting off about how to fix it,
though, I wanted to make s
+1
I must say, this whole process of seeing the patches come through the
list has improved my code reading skills quite significantly!
--Paul L.
On Wed, Feb 11, 2009 at 2:56 PM, Luke Kanies wrote:
>
> There were apparently some circumstances that
> resulted in the connection not being closed;
+1 - much easier to digest.
On Wed, Feb 11, 2009 at 2:56 PM, Luke Kanies wrote:
>
> I split it all into smaller, manageable chunks,
> and used methods for each step, instead
> of having one huge call.
>
> Note that I made all of the tests first, then
> refactored the code, so I'm confident there
+1
On Wed, Feb 11, 2009 at 12:54 PM, James Turnbull
wrote:
>
>
> Signed-off-by: James Turnbull
> ---
> CHANGELOG |2 ++
> lib/puppet/network/xmlrpc/client.rb |2 +-
> 2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/CHANGELOG b/CHANGELOG
> ind
On Tue, Feb 10, 2009 at 5:12 PM, Luke Kanies wrote:
> * Do we actually want the above functionality (validation, etc.) when
> defining resource types, classes, etc., in the language?
+1
> * Does it make sense to develop this DSL as something that can
> eventually (even if not immediately) be th
+1
On Tue, Feb 3, 2009 at 4:41 PM, Luke Kanies wrote:
>
> Facts that raise exceptions just return nil now.
>
> Signed-off-by: Luke Kanies
> ---
> lib/facter/util/resolution.rb |3 +++
> spec/unit/util/resolution.rb |6 ++
> 2 files changed, 9 insertions(+), 0 deletions(-)
>
> diff
+1
On Fri, Jan 30, 2009 at 2:29 AM, James Turnbull wrote:
>
>
> Signed-off-by: James Turnbull
> ---
> lib/facter/timezone.rb |5 +
> 1 files changed, 5 insertions(+), 0 deletions(-)
> create mode 100644 lib/facter/timezone.rb
>
> diff --git a/lib/facter/timezone.rb b/lib/facter/timezo
On Wed, Jan 28, 2009 at 7:55 AM, Luke Kanies wrote:
> So, we'll have a dev call a week from today, at 4pm CST.
I'll try to be there too. Just to be clear, that's February 4th at 4pm CST?
--Paul
--~--~-~--~~~---~--~~
You received this message because you are subs
On Thu, Jan 22, 2009 at 8:16 PM, Luke Kanies wrote:
> Node terminii can't add resources to the catalog, they can just set
> parameters and classes on nodes.
How cast-in-stone is this constraint? It seems like a great place to
allow arbitrary resource injection, if it isn't too hard to add the
ca
On Thu, Jan 22, 2009 at 6:41 PM, Nigel Kersten wrote:
> Have you gotten far so far?
Well, I've made progress, but not very much. This post from Luke:
http://groups.google.com/group/puppet-dev/browse_thread/thread/abf4c4163b0b35b0/512950879f3e5aa3?hl=en&lnk=gst&q=dev+call+this+week#512950879f3e5
Who has tried their hand at developing a custom Node Terminus?
I've dug through the wiki but I can't seem to find a lot of
information about the process. I'd love to hear any tips you might
have. If I'm the first to dive into this, no problem: I'll pester Luke
for help and then write up some docu
Thanks,
Paul
On Tue, Jan 20, 2009 at 10:30 PM, James Turnbull
wrote:
>
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Paul Lathrop wrote:
>> On Mon, Jan 19, 2009 at 3:01 PM, Paul Nasrat wrote:
>>
>> +1 to what (the other) Paul said; and also James.
&
On Mon, Jan 19, 2009 at 3:01 PM, Paul Nasrat wrote:
+1 to what (the other) Paul said; and also James.
I'm hearing a consensus that having the official repo reflected on
GitHub is desirable, even if it is via a scheduled mirror or
something. Is that correct?
--Paul
--~--~-~--~~
On Fri, Jan 16, 2009 at 9:11 AM, Luke Kanies wrote:
>> I have no major issues but some concerns:
>>
>> Availability and stability - we've had some issues with this in the
>> past
>> on Github. Be annoying if GitHub deadpooled too.
>
> I agree with that, but I also agree with Paul that it's been
This was refactored based on Luke's feedback and a conversation in IRC
about tests/code being committed together.
On Thu, Jan 15, 2009 at 11:48 AM, Paul Lathrop wrote:
>
> Adds an rspec test which demonstrates #1560 and a custom 'process'
> method for the aliases pro
uses a 'limited' split() to break the line on
the first separator only.
This commit fixes #1560
Signed-off-by: Paul Lathrop
---
lib/puppet/provider/mailalias/aliases.rb |8 ++
spec/integration/provider/mailalias/aliases.rb | 25 +
test/data/provider
On Thu, Jan 15, 2009 at 11:28 AM, Luke Kanies wrote:
>
> On Jan 15, 2009, at 1:01 PM, Paul Lathrop wrote:
>
>>
>> Bug in the aliases provider which causes problems if the recipient
>> field contains a ':'
>>
>> Signed-off-by: Paul Lathrop
The default processing uses split() to break the line into records on
the separator, which breaks if records can contain the separator. The
custom method I've added uses a 'limited' split() to break the line on
the first separator only.
This commit fixes #1560
Signed-off-b
Bug in the aliases provider which causes problems if the recipient field
contains a ':'
Signed-off-by: Paul Lathrop
---
spec/unit/provider/mailalias/aliases.rb | 26 +
test/data/providers/mailalias/aliases/test1 | 28 +++
2 fil
I've refactored this fix based on Paul Nasrat's feedback. Thanks, Paul!
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com
To
On Thu, Jan 15, 2009 at 10:40 AM, Paul Nasrat wrote:
> White space damage, you can rebase interactively choose to edit this
> commit and remove this part as it's just noise.
I'll fix this when I fix below:
>> +def process(line)
>> + ret = {}
>> + # Everything up to the
Bug in the aliases provider which causes problems if the recipient field
contains a ':'
Signed-off-by: Paul Lathrop
---
spec/unit/provider/mailalias/aliases.rb | 26 +
test/data/providers/mailalias/aliases/test1 | 28 +++
2 fil
The default processing uses split() to break the line into records on the
separator, which breaks if records can contain the separator.
This commit fixes #1560
Signed-off-by: Paul Lathrop
---
lib/puppet/provider/mailalias/aliases.rb | 13 -
1 files changed, 12 insertions(+), 1
I've added an rspec test to demonstrate the problem. The default processing
won't work for this provider because of the use of split() to divide the line
into records, so I added a custom process() method, which seemed like The Right
Way to do it.
--~--~-~--~~~---~
Hey devs,
I was wondering if people thought it might be a good idea to host the
official git repo on GitHub. I don't have a strong opinion on this, I
just thought it might be nice to have access to some of GitHub's
features that we would get if we could 'fork' the project on GitHub to
create our
On Wed, Dec 3, 2008 at 1:40 PM, Luke Kanies <[EMAIL PROTECTED]> wrote:
> We can start with 'contains' and 'containedby', unless someone else
> has a better term than 'containedby'.
I stand firmly by my suggestion of 'container' instead of 'containedby'
--Paul
--~--~-~--~~---
On Tue, Dec 2, 2008 at 1:34 PM, Luke Kanies <[EMAIL PROTECTED]> wrote:
> I see now what you mean about above/below being reasonable terms; you
> have to add the bottom lego then the above lego, and vice versa for
> deletion. I have to say, though, legos weren't exactly my first
> thought for the
On Sat, Nov 29, 2008 at 9:43 PM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>
> On Nov 12, 2008, at 3:10 AM, Lorenz Schori wrote:
>
>>
>> Hi Luke,
>>
>> On Sun, 9 Nov 2008 23:16:03 -0600
>> Luke Kanies <[EMAIL PROTECTED]> wrote:
>>
>>> [...]
I did some more research in redmine and found #428 (Del
+1
On Mon, Sep 29, 2008 at 1:48 PM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>
> Hi all,
>
> There is currently a 'vendor' directory in the puppet repository,
> containing rspec and mocha gems.
>
> I'm in the process of doing some other Ruby development[1] and finding
> that I need these same gems
On Tue, Sep 23, 2008 at 8:29 PM, Adam Jacob <[EMAIL PROTECTED]> wrote:
> "To recap the discussion, others have complained that many Puppet
> resource types have default values for 'ensure', so they can't mention
> a resource without auto-creating it, making it difficult to manage
> those resources
On Tue, Sep 16, 2008 at 9:29 AM, Adam Jacob <[EMAIL PROTECTED]> wrote:
>
> On Tue, Sep 16, 2008 at 9:00 AM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>>> package { "foo": }
>>
>> It's obvious that the above code shouldn't do anything destructive,
>> but it's less obvious that it should do anything at
Steve,
I think a clearer explanation of what you are trying to accomplish
would help. What do you mean by "access the contents of 'cells'"?
Remember that Puppet's language is declarative. I think you might be
trying to "do" something with cells, when the Puppet Way is to just
declare cells and d
+100 :-)
On Wed, Aug 20, 2008 at 9:35 AM, James Turnbull <[EMAIL PROTECTED]> wrote:
>
>
> Signed-off-by: James Turnbull <[EMAIL PROTECTED]>
> ---
> CHANGELOG|4 +
> lib/puppet/parser/functions.rb | 224
> +-
> lib/puppet
+1 (and tested on my Mac)
On Mon, Jul 21, 2008 at 11:58 AM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>
> Darwin has a case-insensitive FS, so the test was failing
> because it was specifically testing case sensitivity.
>
> Signed-off-by: Luke Kanies <[EMAIL PROTECTED]>
> ---
> lib/puppet/sslcertif
Right on, should be able to get started on this today. Thanks.
On Fri, Jul 18, 2008 at 11:39 AM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>
> (Only replying to puppet-dev, rather than the whole cc list.)
>
> On Jul 18, 2008, at 1:34 PM, Paul Lathrop wrote:
>>
>> Is t
+1
On Sun, Jul 6, 2008 at 6:13 AM, James Turnbull <[EMAIL PROTECTED]> wrote:
>
>
> Signed-off-by: James Turnbull <[EMAIL PROTECTED]>
> ---
> lib/puppet/parser/ast/function.rb |2 +-
> lib/puppet/parser/functions.rb|8
> 2 files changed, 9 insertions(+), 1 deletions(-)
>
> di
+1
On Mon, Jun 16, 2008 at 4:47 PM, James Turnbull <[EMAIL PROTECTED]> wrote:
>
>
> Signed-off-by: James Turnbull <[EMAIL PROTECTED]>
> ---
> test/util/loadedfile.rb | 121
> ---
> 1 files changed, 0 insertions(+), 121 deletions(-)
> delete mode 100
+1
On Mon, Jun 16, 2008 at 4:44 PM, James Turnbull <[EMAIL PROTECTED]> wrote:
>
>
> Signed-off-by: James Turnbull <[EMAIL PROTECTED]>
> ---
> bin/puppet |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/bin/puppet b/bin/puppet
> index 23b1750..5e10ad4 100755
> --- a/
+1
On Sun, Jun 15, 2008 at 2:48 PM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>
>
> Signed-off-by: Luke Kanies <[EMAIL PROTECTED]>
> ---
> CHANGELOG|3 +++
> lib/puppet/ssl/base.rb |2 +-
> lib/puppet/ssl/host.rb |2 +-
> spec/unit
+1
On Sun, Jun 15, 2008 at 2:34 PM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>
>
> Signed-off-by: Luke Kanies <[EMAIL PROTECTED]>
> ---
> CHANGELOG|5 +
> lib/puppet/defaults.rb |8 ++--
> spec/integration/defaults.rb |8 +++-
> 3 files changed, 18
+1 with a comment/question.
I like to see a 'return' statement when the function is going out of
its way to return a specific value like "strings". Just a style thing
that I feel makes things clearer. I'm not mentioning it as criticism,
I'm just wondering if my preference goes against the "Ruby W
+1
On Sun, Jun 15, 2008 at 12:03 PM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>
>
> Signed-off-by: Luke Kanies <[EMAIL PROTECTED]>
> ---
> CHANGELOG |6 ++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/CHANGELOG b/CHANGELOG
> index d51e3f0..66c1e99 100644
> --- a/CHAN
+1
On Sun, Jun 15, 2008 at 11:59 AM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>
> This just splits the method into smaller pieces, so it's a
> bit easier to maintain.
>
> Signed-off-by: Luke Kanies <[EMAIL PROTECTED]>
> ---
> lib/puppet/indirector/node/ldap.rb | 102
> ---
+1
On Sun, Jun 15, 2008 at 11:59 AM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>
>
> Signed-off-by: Luke Kanies <[EMAIL PROTECTED]>
> ---
> spec/unit/node.rb |7 ---
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/spec/unit/node.rb b/spec/unit/node.rb
> index 6603f6b..2d
+1
On Sun, Jun 15, 2008 at 5:48 AM, James Turnbull <[EMAIL PROTECTED]> wrote:
>
>
> Signed-off-by: James Turnbull <[EMAIL PROTECTED]>
> ---
> Rakefile |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Rakefile b/Rakefile
> index f4f88f2..00444c2 100644
> --- a/Rakefi
+1
On Sat, Jun 14, 2008 at 12:02 PM, Andrew Shafer
<[EMAIL PROTECTED]> wrote:
>
> Removed logic to reuse parser and log on server when there is a parsing error.
>
> Now we just make a new parser and if there is an error, raise it up, which
> will result in errors on the client logs.
>
> Signed-o
+1
On Fri, Jun 13, 2008 at 2:08 PM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>
>
> Signed-off-by: Luke Kanies <[EMAIL PROTECTED]>
> ---
> spec/integration/indirector/rest.rb |3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/spec/integration/indirector/rest.rb
> b/spe
+1
On Fri, Jun 13, 2008 at 11:40 AM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>
>
> Signed-off-by: Luke Kanies <[EMAIL PROTECTED]>
> ---
> lib/puppet/network/http/mongrel/rest.rb|2 +-
> .../database/001_add_created_at_to_all_tables.rb | 28 +-
> spec/integration/indirector/res
+1
On Fri, Jun 13, 2008 at 11:40 AM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>
> There was a save_object method in the http/handler module, but it
> seemed unnecessary and was undocumented. I don't know I missed
> it causing failures, but I've added it back with appropriate
> documention.
>
> Sig
+1
On Fri, Jun 13, 2008 at 11:40 AM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>
>
> Signed-off-by: Luke Kanies <[EMAIL PROTECTED]>
> ---
> spec/integration/indirector/rest.rb |1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/spec/integration/indirector/rest.rb
> b/spec
+1
On Fri, Jun 13, 2008 at 11:40 AM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>
>
> Signed-off-by: Luke Kanies <[EMAIL PROTECTED]>
> ---
> spec/integration/indirector/rest.rb|2 ++
> spec/integration/network/server/mongrel.rb |4 +++-
> spec/integration/network/server/webrick.rb |
+1
On Fri, Jun 13, 2008 at 11:40 AM, Luke Kanies <[EMAIL PROTECTED]> wrote:
>
>
> Signed-off-by: Luke Kanies <[EMAIL PROTECTED]>
> ---
> 0 files changed, 0 insertions(+), 0 deletions(-)
> mode change 100644 => 100755 spec/integration/indirector/rest.rb
> mode change 100644 => 100755 spec/integ
After thinking about it for a bit, I thought I'd take a crack at
adding upwards recursion to the file type (Ticket #86). It seemed to
me that this would be relatively easy. Upwards recursion is *much*
simpler than downwards recursion in this case; everything upwards of
the resource is always going
+1
On Wed, Jun 4, 2008 at 5:25 PM, James Turnbull <[EMAIL PROTECTED]> wrote:
>
>
> Signed-off-by: James Turnbull <[EMAIL PROTECTED]>
> ---
> bin/puppetd |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/bin/puppetd b/bin/puppetd
> index 96d0e5e..e133cdc 100755
> ---
1 - 100 of 115 matches
Mail list logo
