Signed-off-by: James Turnbull
---
Local-branch: tickets/next/7481
lib/puppet/parser/functions/regsubst.rb | 26 ++
lib/puppet/parser/functions/shellquote.rb | 26 ++
lib/puppet/parser/functions/sprintf.rb| 26 ++
> > Yea, you're probably right. FWIW, here's the offending block of code
> > in lib/puppet/interface/option_builder.rb:19:
>
> [...]
> > Puppet::Interface::Option.instance_methods.grep(/=$/).each do |
> > setter|
> >next if setter =~ /^=/
> >dsl = setter.to_s.sub(/=$/, '')
>
> Yeah, tha
On Tue, May 10, 2011 at 10:49, ajsharp wrote:
> Yea, you're probably right. FWIW, here's the offending block of code
> in lib/puppet/interface/option_builder.rb:19:
[...]
> Puppet::Interface::Option.instance_methods.grep(/=$/).each do |
> setter|
> next if setter =~ /^=/
> dsl = setter.to
Yea, you're probably right. FWIW, here's the offending block of code
in lib/puppet/interface/option_builder.rb:19:
Puppet::Interface::Option.instance_methods.grep(/=$/).each do |
setter|
next if setter =~ /^=/
dsl = setter.sub(/=$/, '')
unless private_instance_methods.include? dsl
Ruby 1.9 removed Symbol#sub, and it's used in various places
in the puppet codebase.
This is a very simple patch that converts the symbol to a
string, performs the #sub on the string and then reconverts
the string back to a symbol. Crude, but it should work. Still,
once the specs are running under
I am torn: I like the idea of getting my embarrassing bug out of the
way, but I would rather get the right solution in place (or, at least,
know what it is) before we go ahead and write or commit them.
Daniel
On Tue, May 10, 2011 at 10:19, ajsharp wrote:
> Cool. If I stick with the monkey patch
Cool. If I stick with the monkey patch approach, I'll stick it in
monkey_patches.rb. I agree, a monkey patch here is definitely not the
most desirable solution, but maybe it's an acceptable approach at
least to get the specs running. After the specs run under 1.9, I'd be
in favor of finding a more
Robin Bowes wrote:
> Are you going to be updating your repo to include this?
Eventually, just been busy. If you look at the changelog from rc1,
you'll see that 2.6.8 final only adds some things to tests, so for an
end user it is functionally identical.
--
ToddOpenPGP -> KeyID: 0xBEAF0CE
On 10 May 2011 01:39, Nigel Kersten wrote:
> Facter 1.5.9rc6 is a maintenance release containing fixes and updates.
>
> The keen-eyed observers amongst you will notice it's been a month since our
> last RC5 of Facter 1.5.9, which is most certainly not our normal process.
> We simply missed the "re
On 27/04/11 22:30, Jacob Helwig wrote:
> This release addresses issues with the Puppet 2.6.x series.
>
> Bug #4884:
>
> Shell exec provider that executes code as a raw shell script
>
> Bug #5670:
>
> Failed resources don't improperly trigger a refresh
>
> Feature #2331:
>
> New macports
10 matches
Mail list logo
