[Puppet-dev] Re: [PATCH/puppet 1/1] Least kludgy patch for #2675

2009-10-26 Thread Luke Kanies
On Oct 26, 2009, at 11:11 PM, Markus Roberts wrote: > > This makes types responsible for the canonicalization of their titles, > provides a default (nil) implementation and moves the File version > into > that method. Changes references to use it and does a minimal test. > > Signed-off-by: Mar

[Puppet-dev] [PATCH/puppet 1/1] Least kludgy patch for #2675

2009-10-26 Thread Markus Roberts
This makes types responsible for the canonicalization of their titles, provides a default (nil) implementation and moves the File version into that method. Changes references to use it and does a minimal test. Signed-off-by: Markus Roberts --- lib/puppet/resource/catalog.rb |2 +-

[Puppet-dev] [PATCH/puppet 1/1] Fixing #2689 - file owner warnings are reduced

2009-10-26 Thread Luke Kanies
We now only warn when there's an actual change to make, and we only make one warning per process run. Signed-off-by: Luke Kanies --- lib/puppet/type/file/owner.rb | 11 +++ spec/unit/type/file/owner.rb | 14 ++ 2 files changed, 17 insertions(+), 8 deletions(-) diff --g

[Puppet-dev] Re: Setting environments in 0.25

2009-10-26 Thread Luke Kanies
On Oct 26, 2009, at 4:06 PM, Paul Lathrop wrote: > > On Mon, Oct 26, 2009 at 11:34 AM, Markus Roberts > wrote: >> We have a ticket open (#2748) over a change in behaviour between >> 0.24.x and >> 0.25.x. >> >> In 0.24.x, the environment specified in the client's configuration >> file >> coul

[Puppet-dev] Re: Setting environments in 0.25

2009-10-26 Thread Luke Kanies
On Oct 26, 2009, at 12:16 PM, R.I.Pienaar wrote: > > hello, > > - "Luke Kanies" wrote: > >> On Oct 26, 2009, at 11:40 AM, R.I.Pienaar wrote: >> >>> >>> hello, >>> >>> - "Markus Roberts" wrote: >>> * Sites that need this functionality can set up a starting environment for

[Puppet-dev] Re: [PATCH/puppet 1/1] Fixes #2752 - require function does not work in 'puppet'

2009-10-26 Thread Luke Kanies
On Oct 26, 2009, at 6:15 PM, James Turnbull wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Luke Kanies wrote: >> On Oct 26, 2009, at 4:05 PM, James Turnbull wrote: >> >>> 2009/10/27 Luke Kanies : As discussed on IRC, it's not a question of executables, it's a question of

[Puppet-dev] [PATCH/puppet 1/2] Fixing some recently broken Scope tests

2009-10-26 Thread Luke Kanies
Signed-off-by: Luke Kanies --- spec/unit/parser/scope.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/spec/unit/parser/scope.rb b/spec/unit/parser/scope.rb index 0859ead..d7800e4 100755 --- a/spec/unit/parser/scope.rb +++ b/spec/unit/parser/scope.rb @@ -43,7 +43,7 @@

[Puppet-dev] [PATCH/puppet 0/2] Fixing #2752 - "require" loads "include"

2009-10-26 Thread Luke Kanies
A simple patch to fix #2752, plus fix a set of tests failing because of a missing stub. lib/puppet/parser/functions/require.rb |5 - spec/unit/parser/functions/require.rb |6 ++ spec/unit/parser/scope.rb |2 +- 3 files changed, 11 insertions(+), 2 deletions(-) --~

[Puppet-dev] [PATCH/puppet 2/2] Fixing #2752 - "require" loads "include"

2009-10-26 Thread Luke Kanies
Signed-off-by: Luke Kanies --- lib/puppet/parser/functions/require.rb |5 - spec/unit/parser/functions/require.rb |6 ++ 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/lib/puppet/parser/functions/require.rb b/lib/puppet/parser/functions/require.rb index 3a2032d

[Puppet-dev] Re: [PATCH/puppet 1/1] Re-fixed #2750 - Stop disabling the CRL or checking for a disabled CRL

2009-10-26 Thread James Turnbull
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Luke Kanies wrote: > I'd definitely like to see a couple other people test this, but looks > good. > I'll test this now. Regards James Turnbull - -- Author of: * Pro Linux System Administration (http://tinyurl.com/linuxadmin) * Pulling Strings

[Puppet-dev] Re: [PATCH/puppet 1/1] Fixes #2752 - require function does not work in 'puppet'

2009-10-26 Thread James Turnbull
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Luke Kanies wrote: > On Oct 26, 2009, at 4:05 PM, James Turnbull wrote: > >> 2009/10/27 Luke Kanies : >>> As discussed on IRC, it's not a question of executables, it's a >>> question of autoloading - you're unlikely to have much of a manifest >>> in

[Puppet-dev] Re: [PATCH/puppet 1/1] Fixes #2752 - require function does not work in 'puppet'

2009-10-26 Thread Luke Kanies
On Oct 26, 2009, at 4:05 PM, James Turnbull wrote: > > 2009/10/27 Luke Kanies : >> As discussed on IRC, it's not a question of executables, it's a >> question of autoloading - you're unlikely to have much of a manifest >> in your server without using (and thus autoloading) 'include' at >> least

[Puppet-dev] Re: [PATCH/puppet 1/1] Re-fixed #2750 - Stop disabling the CRL or checking for a disabled CRL

2009-10-26 Thread Luke Kanies
I'd definitely like to see a couple other people test this, but looks good. On Oct 26, 2009, at 2:24 PM, John A. Barbuto wrote: > > This was deprecated in commit 1cfb0215 and was keeping puppetd from > starting in listen mode. > > Signed-off-by: John A. Barbuto > --- > lib/puppet/applicatio

[Puppet-dev] Re: [PATCH/puppet 1/1] Fixed #2750 - Set :cacrl to nil instead of 'false' in puppetd

2009-10-26 Thread Luke Kanies
On Oct 26, 2009, at 1:00 PM, John A. Barbuto wrote: > > On Sun, Oct 25, 2009 at 9:21 PM, Luke Kanies wrote: >> >> There are actually about three places in the code that check for >> whether the cacrl setting is set to 'false', so I'm not quite sure >> this is the right fix. >> >> Can you give a

[Puppet-dev] Re: possible #651 patch

2009-10-26 Thread amrset
Hello James, It's below: Regards, -Roy --- type.rb.0.25.1.rc2.stock2009-10-21 15:56:41.0 -0600 +++ type.rb2009-10-26 09:01:26.0 -0600 @@ -25,6 +25,7 @@ include Puppet::Util::Cacher include Puppet::FileCollection::Lookup include Puppet::Util::Tagging +i

[Puppet-dev] Re: Setting environments in 0.25

2009-10-26 Thread Paul Lathrop
On Mon, Oct 26, 2009 at 11:34 AM, Markus Roberts wrote: > We have a ticket open (#2748) over a change in behaviour between 0.24.x and > 0.25.x. > > In 0.24.x, the environment specified in the client's configuration file > could be overridden by the server using the external_nodes information. > >

[Puppet-dev] Re: [PATCH/puppet 1/1] Fixes #2752 - require function does not work in 'puppet'

2009-10-26 Thread James Turnbull
2009/10/27 Luke Kanies : > As discussed on IRC, it's not a question of executables, it's a > question of autoloading - you're unlikely to have much of a manifest > in your server without using (and thus autoloading) 'include' at least > once, but 'puppet' is usually used for sample manifests that

[Puppet-dev] Re: Setting environments in 0.25

2009-10-26 Thread Nigel Kersten
On Mon, Oct 26, 2009 at 3:07 PM, Markus Roberts wrote: > I'm not sure I follow how setting the environment with a fact works (the > nuts and bolts that is; I understand the idea in the abstract).  Could > someone elucidate? You don't define it in the conf file, and you simply create a fact that

[Puppet-dev] Re: Setting environments in 0.25

2009-10-26 Thread Markus Roberts
I'm not sure I follow how setting the environment with a fact works (the nuts and bolts that is; I understand the idea in the abstract). Could someone elucidate? -- Markus --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Gro

[Puppet-dev] [PATCH/puppet 1/1] Re-fixed #2750 - Stop disabling the CRL or checking for a disabled CRL

2009-10-26 Thread John A. Barbuto
This was deprecated in commit 1cfb0215 and was keeping puppetd from starting in listen mode. Signed-off-by: John A. Barbuto --- lib/puppet/application/puppetd.rb |7 --- lib/puppet/network/http_server/webrick.rb |5 + lib/puppet/ssl/certificate_revocation_list.r

[Puppet-dev] Re: possible #651 patch

2009-10-26 Thread James Turnbull
2009/10/27 Roy Nielsen : > Should work now, patched type.rb by hand and uploaded the code. > Can you please re-send the updated patch to the list please. Thanks James Turnbull -- Author of: * Pro Linux System Administration (http://tinyurl.com/linuxadmin) * Pulling Strings with Puppet (http:/

[Puppet-dev] New webgui to survey your puppet activities

2009-10-26 Thread Philip
Hi everybody I wrote another web application to monitor puppet like puppetview or puppetshow. Sorry i was bored by the existing solutions and needed something what looked a bit sexy. Please have a look to http://puppetsurvey.sourceforge.net for more information and don't hesitate to contact me

[Puppet-dev] Re: [PATCH/puppet 1/1] Fixed #2750 - Set :cacrl to nil instead of 'false' in puppetd

2009-10-26 Thread John A. Barbuto
On Sun, Oct 25, 2009 at 9:21 PM, Luke Kanies wrote: > > There are actually about three places in the code that check for > whether the cacrl setting is set to 'false', so I'm not quite sure > this is the right fix. > > Can you give a bit more background on it, and on why you didn't change > the o

[Puppet-dev] Re: Setting environments in 0.25

2009-10-26 Thread Nigel Kersten
On Mon, Oct 26, 2009 at 12:16 PM, R.I.Pienaar wrote: > > hello, > > - "Luke Kanies" wrote: > >> On Oct 26, 2009, at 11:40 AM, R.I.Pienaar wrote: >> >> > >> > hello, >> > >> > - "Markus Roberts" wrote: >> > >> >> * Sites that need this functionality can set up a starting >> >> environmen

[Puppet-dev] Re: Setting environments in 0.25

2009-10-26 Thread R.I.Pienaar
hello, - "Luke Kanies" wrote: > On Oct 26, 2009, at 11:40 AM, R.I.Pienaar wrote: > > > > > hello, > > > > - "Markus Roberts" wrote: > > > >> * Sites that need this functionality can set up a starting > >> environment > >> for nodes that only pushes the configuration file, and the >

[Puppet-dev] Re: [PATCH/puppet 1/1] Fix #2753 - Do not "global allow" plugins/modules mount if some rules have been parsed

2009-10-26 Thread Luke Kanies
+1 On Oct 26, 2009, at 12:07 PM, Brice Figureau wrote: > > When fixing #2424, we were adding a global allow (ie allow(*)) to > the plugins/modules mount. > Unfortunately global allow always win against any other rules that > can be defined in fileserver.conf. > > This patch makes sure we add tho

[Puppet-dev] Re: Setting environments in 0.25

2009-10-26 Thread Luke Kanies
On Oct 26, 2009, at 11:40 AM, R.I.Pienaar wrote: > > hello, > > - "Markus Roberts" wrote: > >> * Sites that need this functionality can set up a starting >> environment >> for nodes that only pushes the configuration file, and the >> configuration file can be a template filled in with the

[Puppet-dev] Re: skip instead of exit

2009-10-26 Thread Roy Nielsen
makes sense, didn't think of that :) Thanks Luke, -Roy On Mon, Oct 26, 2009 at 11:39 AM, Luke Kanies wrote: > > On Oct 26, 2009, at 8:44 AM, Roy Nielsen wrote: > > > Hello, > > > > I'm working on adding a parameter to a type. If a condition is met, > > skip the resource & keep processing. At

[Puppet-dev] [PATCH/puppet 1/1] Fix #2753 - Do not "global allow" plugins/modules mount if some rules have been parsed

2009-10-26 Thread Brice Figureau
When fixing #2424, we were adding a global allow (ie allow(*)) to the plugins/modules mount. Unfortunately global allow always win against any other rules that can be defined in fileserver.conf. This patch makes sure we add those global allow entries only if we didn't get any rules from fileserve

[Puppet-dev] Re: Setting environments in 0.25

2009-10-26 Thread R.I.Pienaar
hello, - "Markus Roberts" wrote: > * Sites that need this functionality can set up a starting environment > for nodes that only pushes the configuration file, and the > configuration file can be a template filled in with the appropriate > external_node parameters. This will require an extra

[Puppet-dev] Setting environments in 0.25

2009-10-26 Thread Markus Roberts
We have a ticket open (#2748) over a change in behaviour between 0.24.x and 0.25.x. In 0.24.x, the environment specified in the client's configuration file could be overridden by the server using the external_nodes information. In 0.25.x, all requests from the client contain the environment as pa

[Puppet-dev] Re: skip instead of exit

2009-10-26 Thread Luke Kanies
On Oct 26, 2009, at 8:44 AM, Roy Nielsen wrote: > Hello, > > I'm working on adding a parameter to a type. If a condition is met, > skip the resource & keep processing. At least that's what I'd like > to do. > > I can get the condition met, but the only thing I can get to work is > to use

[Puppet-dev] Re: [PATCH/puppet 1/1] Bug #2534 Raise error if property appears twice

2009-10-26 Thread Luke Kanies
+1 On Oct 26, 2009, at 12:57 AM, Jesse Wolfe wrote: > > This patch changes Puppet::Parser::Resource to check if it has been > passed two Puppet::Parser::Resource::Param objects with the same name. > > Signed-off-by: Jesse Wolfe > --- > lib/puppet/parser/resource.rb |6 ++ > spec/unit/par

[Puppet-dev] Re: [PATCH/puppet 1/1] Bug #1908 cron environment should allow empty vals

2009-10-26 Thread Luke Kanies
+1 On Oct 25, 2009, at 11:17 PM, Jesse Wolfe wrote: > > Change regexp to allow cron environment => "MAILTO=" > > Signed-off-by: Jesse Wolfe > --- > lib/puppet/type/cron.rb |2 +- > spec/unit/type/cron.rb | 33 + > 2 files changed, 34 insertions(+), 1 deletio

[Puppet-dev] Re: [PATCH/puppet 1/1] Fixes #2752 - require function does not work in 'puppet'

2009-10-26 Thread Luke Kanies
On Oct 26, 2009, at 8:43 AM, Brice Figureau wrote: > > On Mon, 2009-10-26 at 08:40 -0700, Luke Kanies wrote: >> I'd like to see a test in this, and probably a comment as to why that >> line is there. > > I'm not even sure this is the right way to fix the issue... > I know I suggested Volcane this

[Puppet-dev] skip instead of exit

2009-10-26 Thread Roy Nielsen
Hello, I'm working on adding a parameter to a type. If a condition is met, skip the resource & keep processing. At least that's what I'd like to do. I can get the condition met, but the only thing I can get to work is to use Puppet::Error, or Puppet::DevError - which exits the puppet run. Some

[Puppet-dev] Re: [PATCH/puppet 1/1] Fixes #2752 - require function does not work in 'puppet'

2009-10-26 Thread Brice Figureau
On Mon, 2009-10-26 at 08:40 -0700, Luke Kanies wrote: > I'd like to see a test in this, and probably a comment as to why that > line is there. I'm not even sure this is the right way to fix the issue... I know I suggested Volcane this way of hotfixing the issue, but I don't really understand wh

[Puppet-dev] Re: [PATCH/puppet 1/1] Fixes #2752 - require function does not work in 'puppet'

2009-10-26 Thread Luke Kanies
I'd like to see a test in this, and probably a comment as to why that line is there. On Oct 26, 2009, at 3:09 AM, James Turnbull wrote: > > Thanks for R.I. Pienaar for the fix > > Signed-off-by: James Turnbull > --- > lib/puppet/parser/functions/require.rb |3 +++ > 1 files changed, 3 inse

[Puppet-dev] Re: possible #651 patch

2009-10-26 Thread Roy Nielsen
Should work now, patched type.rb by hand and uploaded the code. Regards, -Roy On Thu, Oct 22, 2009 at 5:43 PM, Roy Nielsen wrote: > Hello Luke, > > I've updated the ticket with a link to the code (modified from 0.25.1rc2) > > code here: http://github.com/amrset/puppet/blob/master/lib/puppet/typ

[Puppet-dev] Re: [PATCH/puppet] conf/redhat/*.init: Use -p option to killproc

2009-10-26 Thread David Lutterkort
On Sun, 2009-10-25 at 12:01 -0400, Todd Zullinger wrote: > If a puppetd run was started manually and 'service puppet stop' was run > the killproc function used would kill the manually started puppetd. On > Fedora and newer RHEL (>= 5) we now use the -p option to prevent this. > > This fixes #275

[Puppet-dev] [PATCH/puppet 1/1] Fixes #2752 - require function does not work in 'puppet'

2009-10-26 Thread James Turnbull
Thanks for R.I. Pienaar for the fix Signed-off-by: James Turnbull --- lib/puppet/parser/functions/require.rb |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/lib/puppet/parser/functions/require.rb b/lib/puppet/parser/functions/require.rb index 3a2032d..a110f53 100644

[Puppet-dev] Re: [PATCH/puppet] Use notice() in the versioncmp() docs

2009-10-26 Thread James Turnbull
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26/10/09 Todd Zullinger wrote: > versioncmp-docs-typo Pushed in commit d383ab897937a7e7e5fcf2929a63241e894f7616 in branch 0.25.x. Regards James Turnbull - -- Author of: * Pro Linux Systems Administration (http://tinyurl.com/linuxadmin) * Pullin

[Puppet-dev] [PATCH/puppet 1/1] Bug #2534 Raise error if property appears twice

2009-10-26 Thread Jesse Wolfe
This patch changes Puppet::Parser::Resource to check if it has been passed two Puppet::Parser::Resource::Param objects with the same name. Signed-off-by: Jesse Wolfe --- lib/puppet/parser/resource.rb |6 ++ spec/unit/parser/resource.rb | 15 ++- 2 files changed, 20 insert