Re: xsasl_cyrus_client_get_passwd signature is inconsistent with sasl_getcallback_t

2021-03-11 Thread Viktor Dukhovni
On Thu, Mar 11, 2021 at 11:01:19AM +, Vincent Pelletier wrote: > On Wed, 10 Mar 2021 09:49:13 -0500 (EST), Wietse Venema > wrote: > > FYI, All Postfix implementations have the same xxx_get_passwd() > > implementation, since this code was contributed in 1999: > > Thanks, I wanted to check but

Re: xsasl_cyrus_client_get_passwd signature is inconsistent with sasl_getcallback_t

2021-03-11 Thread Vincent Pelletier
On Wed, 10 Mar 2021 09:49:13 -0500 (EST), Wietse Venema wrote: > FYI, All Postfix implementations have the same xxx_get_passwd() > implementation, since this code was contributed in 1999: Thanks, I wanted to check but could not find a VCS to check the history. > So either these functions were n

Re: xsasl_cyrus_client_get_passwd signature is inconsistent with sasl_getcallback_t

2021-03-10 Thread Vincent Pelletier
On Wed, 10 Mar 2021 21:55:43 +0100, Christian Göttsche wrote: > Am Mi., 10. März 2021 um 21:44 Uhr schrieb Wietse Venema > : > > > > Christian G?ttsche: > > > -g -O2 -I. -I../../include -DLINUX4 -c xsasl_cyrus_server.c > > > xsasl_cyrus_server.c:185:26: warning: initialization of ?int > > > (*

Re: xsasl_cyrus_client_get_passwd signature is inconsistent with sasl_getcallback_t

2021-03-10 Thread Christian Göttsche
Am Mi., 10. März 2021 um 21:44 Uhr schrieb Wietse Venema : > > Christian G?ttsche: > > -g -O2 -I. -I../../include -DLINUX4 -c xsasl_cyrus_server.c > > xsasl_cyrus_server.c:185:26: warning: initialization of ?int > > (*)(void)? from incompatible pointer type ?int (*)(void *, char **)? > > [-Wincompa

Re: xsasl_cyrus_client_get_passwd signature is inconsistent with sasl_getcallback_t

2021-03-10 Thread Wietse Venema
Christian G?ttsche: > -g -O2 -I. -I../../include -DLINUX4 -c xsasl_cyrus_server.c > xsasl_cyrus_server.c:185:26: warning: initialization of ?int > (*)(void)? from incompatible pointer type ?int (*)(void *, char **)? > [-Wincompatible-pointer-types] > 185 | {SASL_CB_GETCONFPATH,&xsasl_getconfp

Re: xsasl_cyrus_client_get_passwd signature is inconsistent with sasl_getcallback_t

2021-03-10 Thread Christian Göttsche
FWIW: the Debian build log (https://buildd.debian.org/status/fetch.php?pkg=postfix&arch=amd64&ver=3.5.6-1&stamp=1596413023&raw=0) shows: make: Entering directory '/<>/src/xsasl' gcc -fPIC -I. -I../../include -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security

Re: xsasl_cyrus_client_get_passwd signature is inconsistent with sasl_getcallback_t

2021-03-10 Thread Wietse Venema
Vincent Pelletier: > Hello, > > While debugging an smtp process segfault during sasl authentication > with gmail servers in xoauth2 (xoauth2 authentication which I am in the > process of setting up, so I have no idea if this is a recent > regression), I discover this: FYI, All Postfix implementat

Re: xsasl_cyrus_client_get_passwd signature is inconsistent with sasl_getcallback_t

2021-03-10 Thread Vincent Pelletier
On Wed, 10 Mar 2021 00:31:18 +, Vincent Pelletier wrote: > Note how the caller (here, libkdexoauth2.so) is calling with: > - context > - id > - result > - null > but xsasl_cyrus_client_get_passwd's signature is: > sasl_conn_t *conn, void *context, int id, sasl_secret_t **psecret > which cau

Re: xsasl_cyrus_client_get_passwd signature is inconsistent with sasl_getcallback_t

2021-03-09 Thread Vincent Pelletier
On Wed, 10 Mar 2021 00:31:18 +, Vincent Pelletier wrote: > While debugging an smtp process segfault during sasl authentication > with gmail servers in xoauth2 (xoauth2 authentication which I am in the > process of setting up, so I have no idea if this is a recent > regression), I discover thi

xsasl_cyrus_client_get_passwd signature is inconsistent with sasl_getcallback_t

2021-03-09 Thread Vincent Pelletier
Hello, While debugging an smtp process segfault during sasl authentication with gmail servers in xoauth2 (xoauth2 authentication which I am in the process of setting up, so I have no idea if this is a recent regression), I discover this: (gdb) bt #0 xsasl_cyrus_client_get_passwd (conn=0x55b2ee53