Re: Segmentation fault in xsasl_dovecot_server.c

2019-08-27 Thread Wietse Venema
Eray Aslan: > On Sun, Aug 25, 2019 at 01:23:09PM -0400, Wietse Venema wrote: > > Updated patch follows. I would appreciate it if someone could verify > > that this reports no errors with a real Dovecot server. > > PLAIN / LOGIN works as expected for me on a lightly loaded server. Thanks.

Re: Segmentation fault in xsasl_dovecot_server.c

2019-08-26 Thread Eray Aslan
On Sun, Aug 25, 2019 at 01:23:09PM -0400, Wietse Venema wrote: > Updated patch follows. I would appreciate it if someone could verify > that this reports no errors with a real Dovecot server. PLAIN / LOGIN works as expected for me on a lightly loaded server. -- Eray

Re: Segmentation fault in xsasl_dovecot_server.c

2019-08-25 Thread Wietse Venema
Wietse Venema: > Tim D?sterhus: > > Yes, I understand that if I'm pretending to be Dovecot that I should > > talk like Dovecot or at least follow the protocol as documented in > > Dovecot's Wiki. The protocol error in my implementation is already fixed. > > > > It's just that Postfix never ever cr

Re: Segmentation fault in xsasl_dovecot_server.c

2019-08-25 Thread Wietse Venema
Tim D?sterhus: > Yes, I understand that if I'm pretending to be Dovecot that I should > talk like Dovecot or at least follow the protocol as documented in > Dovecot's Wiki. The protocol error in my implementation is already fixed. > > It's just that Postfix never ever crashed on me before and I be

Re: Segmentation fault in xsasl_dovecot_server.c

2019-08-24 Thread Tim Düsterhus
Yes, I understand that if I'm pretending to be Dovecot that I should talk like Dovecot or at least follow the protocol as documented in Dovecot's Wiki. The protocol error in my implementation is already fixed. It's just that Postfix never ever crashed on me before and I believe that it should neve

Re: Segmentation fault in xsasl_dovecot_server.c

2019-08-24 Thread Wietse Venema
What can I say? The XSASL Dovecot client assumes that it is talking to Dovecot. There may be other errors when you send unexpected responses from a non-Dovecot server. Wietse --- ./src/xsasl/xsasl_dovecot_server.c- 2016-01-23 19:50:54.0 -0500 +++ ./src/xsasl/xsasl_dovecot_server.

Segmentation fault in xsasl_dovecot_server.c

2019-08-23 Thread Tim Düsterhus
Dear List while implementing the Dovecot SASL protocol in a custom server I noticed that the `smtpd` process crashes with a segmentation fault if a specific protocol error occurs. To reproduce I downloaded Postfix 3.4.6 and compiled it with: make makefiles CCARGS='-DUSE_SASL_AUTH \ -DDEF