Re: postfix-2.12 BC-warnings: confusing linenumbers

2014-10-13 Thread Wietse Venema
Wietse Venema: > I have a version that reports the first and last non-empty, non-comment > line numbers of a master.cf entry, or just one line number if the > two are the same: ... > But I'll drop the "last" line number because it is unnecessary given > that we now have a precise start line number

Re: postfix-2.12 BC-warnings: confusing linenumbers

2014-10-13 Thread Wietse Venema
Viktor Dukhovni: > On Sun, Oct 12, 2014 at 09:20:41PM +0200, A. Schulze wrote: > > > >How would Postfix know that "relay" ends at line 2? Comments may > > >appear IN THE MIDDLE of a master.cf entry. > > > > Technically correct. > > I read "line 3" but should read "the entry starting somewhere an

Re: postfix-2.12 BC-warnings: confusing linenumbers

2014-10-12 Thread Wietse Venema
> wietse: > That's why I am implementint line RANGES to shut up people like you. A. Schulze: > honestly, I only try to help ... I know. In the end Postfix will be better. Wietse

Re: postfix-2.12 BC-warnings: confusing linenumbers

2014-10-12 Thread A. Schulze
wietse: That's why I am implementint line RANGES to shut up people like you. honestly, I only try to help ...

Re: postfix-2.12 BC-warnings: confusing linenumbers

2014-10-12 Thread Wietse Venema
A. Schulze: > > Viktor Dukhovni: > > > Try the patch below: > > works with one exception. my master.cf start with comment lines > > 1: # > 2: # documentation > 3: relay unix - - - - - smtp > 4: -o smtp_fallback_relay= > 5: > 6: flush

Re: postfix-2.12 BC-warnings: confusing linenumbers

2014-10-12 Thread A. Schulze
Viktor Dukhovni: Try the patch below: works with one exception. my master.cf start with comment lines 1: # 2: # documentation 3: relay unix - - - - - smtp 4: -o smtp_fallback_relay= 5: 6: flush unix n - - 1000? 0 flush 7

Re: postfix-2.12 BC-warnings: confusing linenumbers

2014-10-12 Thread Viktor Dukhovni
On Sun, Oct 12, 2014 at 09:20:41PM +0200, A. Schulze wrote: > >How would Postfix know that "relay" ends at line 2? Comments may > >appear IN THE MIDDLE of a master.cf entry. > > Technically correct. > I read "line 3" but should read "the entry starting somewhere and end in > line 3" It is perha

Re: postfix-2.12 BC-warnings: confusing linenumbers

2014-10-12 Thread A. Schulze
wietse: $ head -n 3 /etc/postfix/master.cf relay unix - - - - - smtp -o smtp_fallback_relay= # line with comment flush unix n - y 1000? 0 flush How would Postfix know that "relay" ends at line 2? Comments may appear I

Re: postfix-2.12 BC-warnings: confusing linenumbers

2014-10-12 Thread Bastian Blank
On Sun, Oct 12, 2014 at 03:09:30PM -0400, Wietse Venema wrote: > > I just installed 2.12-20140911 and got multiple BC warnings. > > The linenumbers are confusing... > > Most users would expect a warning about line 1 and 4 because line 3 is > > obviously a comment ( same happen if line 3 is empty

Re: postfix-2.12 BC-warnings: confusing linenumbers

2014-10-12 Thread Wietse Venema
A. Schulze: > > Hello Wietse, > > I just installed 2.12-20140911 and got multiple BC warnings. > The linenumbers are confusing... > > $ head -n 3 /etc/postfix/master.cf > relay unix - - - - - smtp > -o smtp_fallback_relay= > # line with comment > flush

Re: postfix-2.12 BC-warnings: confusing linenumbers

2014-10-12 Thread li...@rhsoft.net
Am 12.10.2014 um 20:43 schrieb A. Schulze: I just installed 2.12-20140911 and got multiple BC warnings. The linenumbers are confusing... $ head -n 3 /etc/postfix/master.cf relay unix - - - - - smtp -o smtp_fallback_relay= # line with comment flush