On 2016-12-27 09:45, John Fawcett wrote:
On 12/26/2016 10:35 PM, Wietse Venema wrote:
John Fawcett:
so long as the loop continues in the presence of a zero return
code from mysql_next_result() and mysql_store_result is called for
each one we will stay in sync. With the break above we will be ok
On 12/26/2016 10:35 PM, Wietse Venema wrote:
> John Fawcett:
>> so long as the loop continues in the presence of a zero return
>> code from mysql_next_result() and mysql_store_result is called for
>> each one we will stay in sync. With the break above we will be ok,
>> since the loop stops only whe
John Fawcett:
> so long as the loop continues in the presence of a zero return
> code from mysql_next_result() and mysql_store_result is called for
> each one we will stay in sync. With the break above we will be ok,
> since the loop stops only when there are no more results -1 normal
> condition f
On 12/26/2016 01:45 AM, Wietse Venema wrote:
> I see room for two improvements:
> - Don't loop on mysql_next_result() if that function returns an
> error, to avoid going into an infinite loop.
A break is needed in the case of >0 return code from mysql_next_result.
while ((next_res_st
John Fawcett:
> > Noted. Meanwhile I have separated 1) the code that handles the
> > result set with the lookup result, from 2) the code that handles
> > all other result sets.
> >
> > Without interleaving 1) and 2), the code becomes easier to follow.
> > It's uploaded as postfix-3.2-20161225-nonpr
On 12/25/2016 08:45 PM, Wietse Venema wrote:
> John Fawcett:
>>> I'll diff your new patch against the previous version and see what
>>> changes you made.
>> if you break out of the loop without reading all the result data you
>> will get the following mysql error on the next query.
>>
>> Commands o
John Fawcett:
> > I'll diff your new patch against the previous version and see what
> > changes you made.
>
> if you break out of the loop without reading all the result data you
> will get the following mysql error on the next query.
>
> Commands out of sync; you can't run this command now
Not
On 12/25/2016 04:46 PM, Wietse Venema wrote:
> John Fawcett:
> [ Charset windows-1252 converted... ]
>> On 12/25/2016 09:30 AM, John Fawcett wrote:
>>> On 12/25/2016 01:17 AM, Wietse Venema wrote:
John Fawcett:
> Revised patch to improve error reporting when no result set containing
>
John Fawcett:
[ Charset windows-1252 converted... ]
> On 12/25/2016 09:30 AM, John Fawcett wrote:
> > On 12/25/2016 01:17 AM, Wietse Venema wrote:
> >> John Fawcett:
> >>> Revised patch to improve error reporting when no result set containing
> >>> data is returned
> >> This code is now part of pos
On 12/25/2016 09:30 AM, John Fawcett wrote:
> On 12/25/2016 01:17 AM, Wietse Venema wrote:
>> John Fawcett:
>>> Revised patch to improve error reporting when no result set containing
>>> data is returned
>> This code is now part of postfix-3.2-20161224-nonprod, slightly
>> edited to simplify error
On 12/25/2016 01:17 AM, Wietse Venema wrote:
> John Fawcett:
>> Revised patch to improve error reporting when no result set containing
>> data is returned
> This code is now part of postfix-3.2-20161224-nonprod, slightly
> edited to simplify error handling. I would be interested to hear
> if it sti
John Fawcett:
> Revised patch to improve error reporting when no result set containing
> data is returned
This code is now part of postfix-3.2-20161224-nonprod, slightly
edited to simplify error handling. I would be interested to hear
if it still works with queries that don't call a stored procedu
12 matches
Mail list logo
