Re: Coverity & clang scan

2021-04-03 Thread Wietse Venema
Viktor Dukhovni: > > 88. postfix-3.5.8/src/global/maillog_client.c:256:10: note: Null pointer > > passed to 2nd parameter expecting 'nonnull' > > # if (setenv(POSTLOG_SERVICE_ENV, service_path, 1) < 0) > > # ^ > > # 254|m

Re: Coverity & clang scan

2021-04-03 Thread Wietse Venema
Wietse Venema: > Viktor Dukhovni: > > On Fri, Mar 19, 2021 at 11:18:27AM -0400, Jaroslav Skarvada wrote: > > > > > 14. postfix-3.5.8/src/util/dict_inline.c:124: uninit_use_in_call: Using > > > uninitialized value "value" when calling "dict_file_to_b64". > > > 17. postfix-3.5.8/src/util/dict_inlin

Re: Coverity & clang scan

2021-04-03 Thread Wietse Venema
Viktor Dukhovni: > On Fri, Mar 19, 2021 at 11:18:27AM -0400, Jaroslav Skarvada wrote: > > > 14. postfix-3.5.8/src/util/dict_inline.c:124: uninit_use_in_call: Using > > uninitialized value "value" when calling "dict_file_to_b64". > > 17. postfix-3.5.8/src/util/dict_inline.c:125: overwrite_var: Ove

Re: Coverity & clang scan

2021-03-19 Thread Viktor Dukhovni
On Fri, Mar 19, 2021 at 11:18:27AM -0400, Jaroslav Skarvada wrote: > 14. postfix-3.5.8/src/util/dict_inline.c:124: uninit_use_in_call: Using > uninitialized value "value" when calling "dict_file_to_b64". > 17. postfix-3.5.8/src/util/dict_inline.c:125: overwrite_var: Overwriting > "err" in "err =

Coverity & clang scan

2021-03-19 Thread Jaroslav Skarvada
Hi, we run coverity & clang scans time to time. I filtered all the false positives and the following are results which seemed suspicious to me. It's mostly for unlikely code paths which could be triggered by error state or invalid input. I am not familiar with the code internals, so maybe it's unl