Hi,
> In sump, just replacing the two memcpy with memmove seems the way to go.
> If you want to send a diff, I'll ok it, or I can do it.
Here's the diff; bump up revision 18 and simply replace memcpy() to memmove()
(two places for explode.c, one for inflate.c).
Regards,
Index: Makefile
committed, thanks!
uaa@
On Mon, Jan 13, 2025 at 06:24:13PM +0900, SASANO Takayoshi wrote:
> Hi,
>
> > In sump, just replacing the two memcpy with memmove seems the way to go.
> > If you want to send a diff, I'll ok it, or I can do it.
>
> Here's the diff; bump up revision 18 and simply replace memcpy() to memmove()
> (t
On Mon, Jan 13, 2025 at 05:34:27PM +0900, SASANO Takayoshi wrote:
> Hi,
>
> > The check in explode.c seems correct since it doesn't have this cast.
> >>
> >> I didn't say about cast.
> >
> > But I did...
>
> Yes, I know. No problem.
>
> >> Your diff looks only the fix of inflate.c.
> >> Doe
Hi,
> The check in explode.c seems correct since it doesn't have this cast.
>>
>> I didn't say about cast.
>
> But I did...
Yes, I know. No problem.
>> Your diff looks only the fix of inflate.c.
>> Does explode.c not replace with memmove()? That's my question.
>
> You're right It actually
On Mon, Jan 13, 2025 at 02:52:48PM +0900, SASANO Takayoshi wrote:
> Hi,
>
> > As I mentioned:
> >
> >>> The check in explode.c seems correct since it doesn't have this cast.
>
> I didn't say about cast.
But I did...
> My issue is OpenBSD's memcpy() cannot handle overlapped area
> and memcpy()
SASANO Takayoshi wrote:
> Does explode.c not replace with memmove()? That's my question.
Imagine a world where people got so paranoid about their memcpy() use, that
they would follow this 2-step process:
1. Replace all memcpy() with memmove(). Absolutely every single one of them.
ALL OF THE
SASANO Takayoshi wrote:
> My issue is OpenBSD's memcpy() cannot handle overlapped area
> and memcpy() within
Those are incorrect words.
The issue is that memcpy() as defined by the standard does not
handle overlapping areas, it is UNDEFINED what happens if you
overlap the strings.
The CSRG bco
Hi,
> As I mentioned:
>
>>> The check in explode.c seems correct since it doesn't have this cast.
I didn't say about cast.
My issue is OpenBSD's memcpy() cannot handle overlapped area
and memcpy() within #ifndef NOMEMCPY / #endif should be replaced with
memmove(). Otherwise use NOMEMCPY --- I c
On Mon, Jan 13, 2025 at 08:03:15AM +0900, SASANO Takayoshi wrote:
> > Looking at the comment for NOMEMCPY in inflate.c, it's quite possible
> > it was added precisely to work around this bug.
>
> Only inflate.c issue, replacing with memmove() will be good choice.
> But the same problem is still re
> Looking at the comment for NOMEMCPY in inflate.c, it's quite possible
> it was added precisely to work around this bug.
Only inflate.c issue, replacing with memmove() will be good choice.
But the same problem is still remain explode.c so I choose NOMEMCPY.
I compared execution time, NOMEMCPY is
On Sun, Jan 12, 2025 at 05:02:30PM +0100, Theo Buehler wrote:
> On Sun, Jan 12, 2025 at 10:11:47PM +0900, SASANO Takayoshi wrote:
> > Hi,
> >
> > I could not extract GenEi-Latin font (TTF archive) at
> > https://okoneya.jp/font/GenEiLatin-Separate_v2.1.zip with unzip-6.0p17,
> > and I found "unzip
On Sun, Jan 12, 2025 at 10:11:47PM +0900, SASANO Takayoshi wrote:
> Hi,
>
> I could not extract GenEi-Latin font (TTF archive) at
> https://okoneya.jp/font/GenEiLatin-Separate_v2.1.zip with unzip-6.0p17,
> and I found "unzip: backwards memcpy" in /var/log messages.
>
> Remedy is simple, add -DNOM
On Sun, Jan 12, 2025 at 10:11:47PM +0900, SASANO Takayoshi wrote:
> Hi,
>
> I could not extract GenEi-Latin font (TTF archive) at
> https://okoneya.jp/font/GenEiLatin-Separate_v2.1.zip with unzip-6.0p17,
> and I found "unzip: backwards memcpy" in /var/log messages.
>
> Remedy is simple, add -DNOM
ok.
On 2025/01/12 22:11, SASANO Takayoshi wrote:
> Hi,
>
> I could not extract GenEi-Latin font (TTF archive) at
> https://okoneya.jp/font/GenEiLatin-Separate_v2.1.zip with unzip-6.0p17,
> and I found "unzip: backwards memcpy" in /var/log messages.
>
> Remedy is simple, add -DNOMEMCPY.
> ok?
>
15 matches
Mail list logo
