Re: removing mutt patches

2023-06-24 Thread Derek Schrock
On Thu, May 04, 2023 at 06:33:05PM EDT, Derek Schrock wrote: > tl;dr Removing feature patches in mail/mutt! Do you care? If you're looking to comment/test anything before hand. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272194 https://reviews.freebsd.org/D40754

Re: removing mutt patches

2023-05-05 Thread Alex Kozlov
On Fri, May 05, 2023 at 01:18:43PM -0400, Derek Schrock wrote: > On Fri, May 05, 2023 at 01:04:00AM EDT, Alex Kozlov wrote: > > I use %I specifier from vvv.initials (QUOTE_PATCH option), but have > > vvv.quote > > commented out in the port's Makefile. I don't remember exactly why, it seems > > cau

Re: removing mutt patches

2023-05-05 Thread Edward Sanford Sutton, III
On 5/5/23 15:49, Derek Schrock wrote: On Fri, May 05, 2023 at 06:45:48PM EDT, Edward Sanford Sutton, III wrote: Not saying what to do but trying to continue to build up my understanding of ports tree structure in general with my questions. Wouldn't telling users after install/upgrade be tell

Re: removing mutt patches

2023-05-05 Thread Derek Schrock
On Fri, May 05, 2023 at 06:45:48PM EDT, Edward Sanford Sutton, III wrote: >Not saying what to do but trying to continue to build up my > understanding of ports tree structure in general with my questions. > Wouldn't telling users after install/upgrade be telling them that there > is now a pr

Re: removing mutt patches

2023-05-05 Thread Edward Sanford Sutton, III
On 5/5/23 15:07, Derek Schrock wrote: On Fri, May 05, 2023 at 06:04:35PM EDT, Amar Takhar wrote: It would be nice to have a message in pkg-message explaining the port is now vanilla outside of fixes and anyone looking for former patches should try NeoMutt. Yeah, I'm looking right now at adding

Re: removing mutt patches

2023-05-05 Thread Derek Schrock
On Fri, May 05, 2023 at 06:04:35PM EDT, Amar Takhar wrote: > It would be nice to have a message in pkg-message explaining the port is now > vanilla outside of fixes and anyone looking for former patches should try > NeoMutt. Yeah, I'm looking right now at adding a pkg-message to output a message

Re: removing mutt patches

2023-05-05 Thread Amar Takhar
On 2023-05-05 20:19 +0200, Felix Palmen wrote: > > So, again IMHO, let's stick to the "only patch ustream when really > needed to fix something" policy with Mutt as well. I've used Mutt from the first version when I was eager to switch from Pine. I have to admit I have never heard of NeoMutt.

Re: removing mutt patches

2023-05-05 Thread Derek Schrock
On Fri, May 05, 2023 at 01:04:00AM EDT, Alex Kozlov wrote: > I use %I specifier from vvv.initials (QUOTE_PATCH option), but have vvv.quote > commented out in the port's Makefile. I don't remember exactly why, it seems > caused some formatting issues. It seems you're already building locally? If t

Re: removing mutt patches

2023-05-04 Thread Alex Kozlov
On Thu, May 04, 2023 at 06:33:05PM -0400, Derek Schrock wrote: > tl;dr Removing feature patches in mail/mutt! Do you care? > > A recent bug [1] has been created with a claim that one of the remote > patches QUOTE_PATCH [2] causes issues even without using the feature. > This patch was originally

Re: removing mutt patches

2023-05-04 Thread Tomek CEDRO
On Fri, May 5, 2023 at 12:33 AM Derek Schrock wrote: > > tl;dr Removing feature patches in mail/mutt! Do you care? > (..) > So do any of the ports/pkg mutt users deeply depend on any feature > patches from the port and would the world end if you didn't have them? I mainly use mutt to quickly revi

removing mutt patches

2023-05-04 Thread Derek Schrock
tl;dr Removing feature patches in mail/mutt! Do you care? A recent bug [1] has been created with a claim that one of the remote patches QUOTE_PATCH [2] causes issues even without using the feature. This patch was originally a vvv patch [3] left unmaintained then later taken over by some capacity