Re: glib2 deprecated declarations failing on clang16

2023-07-04 Thread Nuno Teixeira
Hello all, Ticket opened at upstream: https://sourceforge.net/p/bluefish/tickets/75/ https://cgit.freebsd.org/ports/commit/?id=e95c4bea425b3e3c49b63e0cf4eff24af40c574b Thank you! Charlie Li escreveu no dia terça, 4/07/2023 à(s) 18:33: > Nuno Teixeira wrote: > > (...) > > > > Should this be ap

Re: glib2 deprecated declarations failing on clang16

2023-07-04 Thread Charlie Li
Nuno Teixeira wrote: (...) Should this be applied upstream? I could open a upstream PR about it. After looking through some history on the glib side (which have been fixing incompatible function pointer conditions as they appear), G_CALLBACK() should be applied to bluefish. Upstreaming is a g

Re: glib2 deprecated declarations failing on clang16

2023-07-04 Thread Nuno Teixeira
(...) Should this be applied upstream? I could open a upstream PR about it. Thanks, Nuno Teixeira escreveu no dia terça, 4/07/2023 à(s) 15:42: > And run test sucess at main-n263935-e8423423737e > > I will do more testport builds with gtk2 and gtk3. > > I will use something like in commit msg:

Re: glib2 deprecated declarations failing on clang16

2023-07-04 Thread Nuno Teixeira
And run test sucess at main-n263935-e8423423737e I will do more testport builds with gtk2 and gtk3. I will use something like in commit msg: --- Fix build with clang16 Use G_CALLBACK() macro to silence incompatible function pointer warnings and disables any argument checks. Reported by: dim ---

Re: glib2 deprecated declarations failing on clang16

2023-07-04 Thread Dimitry Andric
I got to exactly the same patches. This is due to how glib's gclosure.h header declares its callback function type as '(void)', even though in reality the number and type of the arguments varies: /** * GCallback: * * The type used for callback functions in structure definitions and func

Re: glib2 deprecated declarations failing on clang16

2023-07-04 Thread Nuno Teixeira
Hello Danilo! Yes, it builds ok. I will do a run test tomorrow on bluefish. Any hint on how to explain it in commit: --- --- src/bftextview2_autocomp.c.orig 2023-07-04 14:09:37 UTC +++ src/bftextview2_autocomp.c @@ -429,7 +429,7 @@ acwin_create(BluefishTextView * btv) /*gtk_widget_s

Re: glib2 deprecated declarations failing on clang16

2023-07-04 Thread Nuno Teixeira
So what could be done here? Suppress warnings at port or something need to be fixed at devel/glib20? Thanks, Dimitry Andric escreveu no dia terça, 4/07/2023 à(s) 14:56: > On 4 Jul 2023, at 14:37, Nuno Teixeira wrote: > > > > I'm getting build errors from current with www/bluefish about deprec

Re: glib2 deprecated declarations failing on clang16

2023-07-04 Thread Danilo Egea Gondolfo
On 04/07/2023 14:56, Dimitry Andric wrote: On 4 Jul 2023, at 14:37, Nuno Teixeira wrote: I'm getting build errors from current with www/bluefish about deprecated glib2 declarations and causing build to fail with clang16: --- /usr/local/include/glib-2.0/glib/gmacros.h:1262:37: note: expanded f

Re: glib2 deprecated declarations failing on clang16

2023-07-04 Thread Dimitry Andric
On 4 Jul 2023, at 14:37, Nuno Teixeira wrote: > > I'm getting build errors from current with www/bluefish about deprecated > glib2 declarations and causing build to fail with clang16: > --- > /usr/local/include/glib-2.0/glib/gmacros.h:1262:37: note: expanded from macro > 'G_DEPRECATED' > #defin

glib2 deprecated declarations failing on clang16

2023-07-04 Thread Nuno Teixeira
Hello, I'm getting build errors from current with www/bluefish about deprecated glib2 declarations and causing build to fail with clang16: --- /usr/local/include/glib-2.0/glib/gmacros.h:1262:37: note: expanded from macro 'G_DEPRECATED' #define G_DEPRECATED __attribute__((__deprecated__))