* Tatsuki Makino [20230820 05:52]:
> By the way,
>
> Felix Palmen wrote on 2023/08/18 03:00:
> >
> > .if ${ARCH} == amd64
> > PLIST_SUB+= AMD64="" NO_AMD64="@comment _nonexisting/"
> > .else
> > PLIST_SUB+= AMD64="@comment _nonexisting/" NO_AMD64=""
> > .endif
> > .if ${ARCH} == aarch64
By the way,
Felix Palmen wrote on 2023/08/18 03:00:
>
> .if ${ARCH} == amd64
> PLIST_SUB+= AMD64="" NO_AMD64="@comment _nonexisting/"
> .else
> PLIST_SUB+= AMD64="@comment _nonexisting/" NO_AMD64=""
> .endif
> .if ${ARCH} == aarch64
> PLIST_SUB+= AARCH64="" NO_AARCH64="@comment _nonex
* Mathieu Arnold [20230819 10:51]:
> On Wed, Aug 16, 2023 at 08:37:22PM +0200, Felix Palmen wrote:
> > IMHO, the straight-forward solution would be: A port hit by that should
> > add some "post-install-" (or -off) recipe explicitly removing the
> > unwanted files from ${STAGEDIR}.
>
> Well, it is
On Wed, Aug 16, 2023 at 08:37:22PM +0200, Felix Palmen wrote:
> IMHO, the straight-forward solution would be: A port hit by that should
> add some "post-install-" (or -off) recipe explicitly removing the
> unwanted files from ${STAGEDIR}.
Well, it is a solution, but it is slower.
How it works now
It is possible that @comment may not have been accurately shaved off in the
area near the following.
https://cgit.freebsd.org/ports/tree/Mk/Scripts/check-stagedir.sh?id=bb85795b3ad308152f367fece54d1fcae615aab4#n249
For example, I think we need to do the following.
echo "@comment @comment @comme
I would like to confirm, plist-check is correct for make check-plist (or
check-orphans), right?
It is run by Mk/Scripts/check-stagedir.sh, and from looking at it's contents,
it appears that some patterns are not reported as orphans.
In the function check_orphans_from_plist(), they are lined up a
* Tatsuki Makino [20230817 17:14]:
> Felix Palmen wrote on 2023/08/17 15:03:
> > It is, when some file doesn't exist for all architectures, but for more
> > than one of them.
> >
> > You first test the port on ARCH=foo. Then you test on ARCH=bar and find
> > that it builds/installs an additional
Felix Palmen wrote on 2023/08/17 15:03:
> * Tatsuki Makino [20230817 07:57]:
>> Switching @comment by ${ARCH} is also in print/epson-inkjet-printer-escpr2.
>> This is not a problem with check-orphans.
>
> It is, when some file doesn't exist for all architectures, but for more
> than one of them.
* Tatsuki Makino [20230817 07:57]:
> Switching @comment by ${ARCH} is also in print/epson-inkjet-printer-escpr2.
> This is not a problem with check-orphans.
It is, when some file doesn't exist for all architectures, but for more
than one of them.
You first test the port on ARCH=foo. Then you tes
Hello.
Switching @comment by ${ARCH} is also in print/epson-inkjet-printer-escpr2.
This is not a problem with check-orphans.
However, linuxulator ports often switch plist file itself for different ${ARCH}.
Regards.
* Felix Palmen [20230816 20:26]:
> * Jan Beich [20230816 20:20]:
> > Looks intentional per https://cgit.freebsd.org/ports/commit/?id=e15449a9eff5
> >
> > >- Fix showing files installed through unselected OPTIONS as orphans,
> > > by considering "@comment file" to be ignored. [2]
> > [..
* Jan Beich [20230816 20:20]:
> Looks intentional per https://cgit.freebsd.org/ports/commit/?id=e15449a9eff5
>
> >- Fix showing files installed through unselected OPTIONS as orphans,
> > by considering "@comment file" to be ignored. [2]
> [...]
> > [2] This is a partial solution, we may
Hi,
I had similar problems, if mode modifier is used in pkg-plist.
This line leads to error, if EXAMPLES is unset:
@(,,755) %%PORTEXAMPLESEXAMPLESDIR%%/bin/clca
This line goes without error, if EXAMPLES is unset:
%%PORTEXAMPLES%%@(,,755) %%EXAMPLESDIR%%/bin/clca
Regards, Sergei
On 8/16/2023
Felix Palmen writes:
> Hi all,
>
> I'm having unexpected trouble with plist-check. I have some custom
> PLIST_SUB expanding to "@comment " based on ${ARCH} and found that
> orphaned files from ${STAGEDIR} weren't properly reported.
>
> Then I tried to hardcode "@comment " in pkg-plist instead (to
14 matches
Mail list logo
