Re: Multiple new R ports

Hello Nuno, > On 2 Apr 2024, at 13:07, Nuno Teixeira wrote: > > Thanks for waiting and nice that you joined > https://reviews.freebsd.org/D44592 . > > Hope that this week we get all R ports on tree. > That would be fantastic! I wasn’t sure I could get such a large change committed upstream,

Re: Multiple new R ports

Hello Einer, Thanks for waiting and nice that you joined https://reviews.freebsd.org/D44592 . Hope that this week we get all R ports on tree. Cheers, Einar Bjarni Halldórsson escreveu (terça, 19/03/2024 à(s) 13:20): > > > On 19 Mar 2024, at 12:41, Nuno Teixeira wrote: > > > > The correct wa

Re: Multiple new R ports

> On 19 Mar 2024, at 12:41, Nuno Teixeira wrote: > > The correct way is to update diff in review so maintainer and > reviewers can take a look, do some tests and give approval if ok. > Ok, I updated the diff, with the updated dependecy on R-cran-cpp11. Should be ok now. Thanks for the help.

Re: Multiple new R ports

The correct way is to update diff in review so maintainer and reviewers can take a look, do some tests and give approval if ok. Cheers, Einar Bjarni Halldórsson escreveu (terça, 19/03/2024 à(s) 12:27): > > > > On 19 Mar 2024, at 12:12, Einar Bjarni Halldórsson wrote: > >> There's a missing depe

Re: Multiple new R ports

> On 19 Mar 2024, at 12:12, Einar Bjarni Halldórsson wrote: >> There's a missing dependency that needs to be added to fix build. >> You should have received an e-mail from review. >> > > I did. I’m sorry I missed it :( > I made a mistake when I tried to update the diff revision and unrelated

Re: Multiple new R ports

> On 19 Mar 2024, at 11:52, Nuno Teixeira wrote: > > Ok, I'll commit it. > Thanks. > There's a missing dependency that needs to be added to fix build. > You should have received an e-mail from review. > I did. I’m sorry I missed it :( einar

Re: Multiple new R ports

Ok, I'll commit it. There's a missing dependency that needs to be added to fix build. You should have received an e-mail from review. Cheers Einar Bjarni Halldórsson escreveu (terça, 19/03/2024 à(s) 10:54): > > > > On 19 Mar 2024, at 10:49, Nuno Teixeira wrote: > > > > By adding: > > Different

Re: Multiple new R ports

> On 19 Mar 2024, at 10:49, Nuno Teixeira wrote: > > By adding: > Differential Revision: > it will grant you commit bit. > What do you mean by this? Can I add this and get granted commit bit? Either way, I would prefer that you commit :) einar

Re: Multiple new R ports

Nice, Thanks. Related to D44074 do you need me as committer or wanna commit it yourself? By adding: Differential Revision: it will grant you commit bit. Please decide and let me know as we will start at this review as it is a requisite as dependency in R

Re: Multiple new R ports

Hi Nuno, > On 19 Mar 2024, at 08:14, Nuno Teixeira wrote: > > I'm ready to test ports. > Just to organize myself, which ones are the three primary ports? > graphics/R-cran-cowplot devel/R-cran-tidyverse databases/R-cran-dbplyr are the primary ports, the others are dependencies for those. Some

Re: Multiple new R ports

(...) D44074 is ready to commit. I will start from there. Nuno Teixeira escreveu (terça, 19/03/2024 à(s) 08:14): > > Hello, > > I'm ready to test ports. > Just to organize myself, which ones are the three primary ports? > > @Gleb Popov could you join review as reviewer too? > > Cheers, > > Einar

Re: Multiple new R ports

Hello, I'm ready to test ports. Just to organize myself, which ones are the three primary ports? @Gleb Popov could you join review as reviewer too? Cheers, Einar Bjarni Halldórsson escreveu (sexta, 15/03/2024 à(s) 09:02): > > Hi, > > >> I’ve got tests working on all the ports, except for R-cra

Re: Multiple new R ports

Hi, >> I’ve got tests working on all the ports, except for R-cran-systemfonts. >> I have a PR [1] for upstream to fix that. >> Upstream has merged my change and tests are working on R-cran-systemfonts now. Tests for databases/R-cran-dbplyr depend on a newer version of databases/R-cran-RSQLITE

Re: Multiple new R ports

Sugested packages are as they say: sugested. Usually I only add packages to TEST_DEPENDS as required to a success test. Also, please add a comment in Makefile when tests fail and respective bug url if available. Cheers, Einar Bjarni Halldórsson escreveu (sábado, 24/02/2024 à(s) 09:32): > > > >

Re: Multiple new R ports

> On 24 Feb 2024, at 06:24, Einar Bjarni Halldórsson wrote: > >> On 22 Feb 2024, at 11:43, Nuno Teixeira wrote: >> >> I did take a look at review and noticed that TEST_DEPENDS are not used >> and that could means that test target works without any depends or >> ports are not tested at all. >>

Re: Multiple new R ports

Hi Nuno, > On 22 Feb 2024, at 11:43, Nuno Teixeira wrote: > > I did take a look at review and noticed that TEST_DEPENDS are not used > and that could means that test target works without any depends or > ports are not tested at all. > My curiosity is what do you think about the importance (or no

Re: Multiple new R ports

Hello, I did take a look at review and noticed that TEST_DEPENDS are not used and that could means that test target works without any depends or ports are not tested at all. My curiosity is what do you think about the importance (or not) to have testunit feature working on R ports? I maintain a c

Re: Multiple new R ports

Hi, Could a committer take a look at https://reviews.freebsd.org/D43735 for me? Adds 3 R modules, with dependencies, 13 new ports in total. Builds in poudriere and used in production. einar On 2/4/24 13:34, Einar Bjarni Halldórsson wrote: On 3 Feb 2024, at 18:56, Gleb Popov wrote: On Sat, F

Re: Multiple new R ports

> On 3 Feb 2024, at 18:56, Gleb Popov wrote: > > On Sat, Feb 3, 2024 at 6:31 PM Einar Bjarni Halldórsson > wrote: >> >> Hi, >> >> I needed to create three new R ports, but with new ports for missing >> dependencies, it’s 13 new ports in total, all R packages. >> >> Should I create one PR

Re: Multiple new R ports

On Sat, Feb 3, 2024 at 6:31 PM Einar Bjarni Halldórsson wrote: > > Hi, > > I needed to create three new R ports, but with new ports for missing > dependencies, it’s 13 new ports in total, all R packages. > > Should I create one PR for them all, or one for each package with blockers > for depende