Re: In some places, WITH_${feature}_PORTS doesn't work

2024-04-12 Thread Tatsuki Makino
Mathieu Arnold wrote on 2024/04/12 15:53: > No, no, you should not do that, :) It is difficult to prioritize when there are two methods, WITH_*_PORTS and WITHOUT_*_PORTS. Perhaps we have experienced even something like "Order allow,deny Allow from ... Deny from ..." :) I wondered if a new variab

Re: In some places, WITH_${feature}_PORTS doesn't work

2024-04-11 Thread Mathieu Arnold
On Fri, Apr 12, 2024 at 06:31:45AM +0900, Tatsuki Makino wrote: > Gleb Popov wrote on 2024/04/12 02:57: > > Should be fixed now by > > https://cgit.FreeBSD.org/ports/commit/?id=665b0219e541019b849fd5a1efdf032081dcf610 > > Thank you very much. > > This would mean that there is more support for the

Re: In some places, WITH_${feature}_PORTS doesn't work

2024-04-11 Thread Tatsuki Makino
Gleb Popov wrote on 2024/04/12 02:57: > Should be fixed now by > https://cgit.FreeBSD.org/ports/commit/?id=665b0219e541019b849fd5a1efdf032081dcf610 Thank you very much. This would mean that there is more support for the use of _WITH_${feature} and _WITHOUT_${feature} in the future. It is expecte

Re: In some places, WITH_${feature}_PORTS doesn't work

2024-04-11 Thread Gleb Popov
Should be fixed now by https://cgit.FreeBSD.org/ports/commit/?id=665b0219e541019b849fd5a1efdf032081dcf610

Re: In some places, WITH_${feature}_PORTS doesn't work

2024-04-11 Thread Tatsuki Makino
Gleb Popov wrote on 2024/04/11 15:51: > Would like me to fix it or you'll do that yourself? Fixing this could conceivably break the functionality added in d697653cffd19ddaf3cdee2589a830c72ab39777, so it is better to fix it carefully or leave it alone. There is a workaround on my part. make -C /

Re: In some places, WITH_${feature}_PORTS doesn't work

2024-04-10 Thread Gleb Popov
On Thu, Apr 11, 2024 at 9:16 AM Tatsuki Makino wrote: > > Hello. > > Since everyone does not need to debug all ports, I assume the definition is > made like WITH_DEBUG_PORTS+=audio/libopenshot-audio . > This has changed the variable defined from WITH_DEBUT to _WITH_DEBUG, so the > part that swit