[Differential] [Request, 2 lines] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

2016-07-29 Thread net147 (Jonathan Liu)
net147 created this revision. net147 added a reviewer: Plasma. net147 set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I have many entries in the favori

[Differential] [Updated] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

2016-07-29 Thread net147 (Jonathan Liu)
net147 updated the summary for this revision. net147 updated the test plan for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2310 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, #plasma Cc: p

[Differential] [Commented On] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

2016-07-30 Thread net147 (Jonathan Liu)
net147 added a comment. In https://phabricator.kde.org/D2310#43102, @broulik wrote: > Thanks for your patch! > > Can you make sure you're working on the recent-most plasma-desktop master branch? I've recently changed the favorites sorting to reorder the items live as you drag them (l

[Differential] [Commented On] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

2016-07-30 Thread net147 (Jonathan Liu)
net147 added a comment. In https://phabricator.kde.org/D2310#43105, @broulik wrote: > Thanks. This fixes the issue for me. Do you have commit access? I don't have commit access. Please commit this for me. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabri

[Differential] [Request, 2 lines] D2322: [Kickoff] Fix start row for drag not always being correct

2016-07-31 Thread net147 (Jonathan Liu)
net147 created this revision. net147 added reviewers: Plasma, broulik. net147 set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The start row for the dra

[Differential] [Updated, 3 lines] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

2016-07-31 Thread net147 (Jonathan Liu)
net147 updated this revision to Diff 5592. net147 added a comment. Added copyright. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2310?vs=5566&id=5592 REVISION DETAIL https://phabricator.kde.org/D2310 AFFECTED FILES applets/kickoff/p

[Differential] [Request, 2 lines] D2338: [Kickoff] Fix start row for drag not always being correct

2016-08-02 Thread net147 (Jonathan Liu)
net147 created this revision. net147 added reviewers: broulik, Plasma. net147 set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The start row for the dra

[Differential] [Commented On] D2337: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

2016-08-02 Thread net147 (Jonathan Liu)
net147 added a comment. This is a backport of https://phabricator.kde.org/D2310 fix for Plasma 5.7. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2337 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, bro

[Differential] [Commented On] D2338: [Kickoff] Fix start row for drag not always being correct

2016-08-02 Thread net147 (Jonathan Liu)
net147 added a comment. This is a backport of https://phabricator.kde.org/D2322 fix for Plasma 5.7. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2338 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, bro

[Differential] [Updated] D2337: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

2016-08-02 Thread net147 (Jonathan Liu)
net147 added a reviewer: bshah. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2337 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, broulik, #plasma, bshah Cc: plasma-devel, ali-mohamed, jensreuterberg, abet

[Differential] [Updated] D2338: [Kickoff] Fix start row for drag not always being correct

2016-08-02 Thread net147 (Jonathan Liu)
net147 added a reviewer: bshah. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2338 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, broulik, #plasma, bshah Cc: plasma-devel, ali-mohamed, jensreuterberg, abet

[Differential] [Request, 3 lines] D2337: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

2016-08-02 Thread net147 (Jonathan Liu)
net147 created this revision. net147 added reviewers: broulik, Plasma. net147 set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 345741 TEST PLAN