[Differential] [Updated] D409: new mobile components

mart marked 5 inline comments as done. mart added a comment. REPOSITORY rPLASMAMOBILE plasma-mobile REVISION DETAIL https://phabricator.kde.org/D409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, Plasma: Mobile Cc: davidedmundson,

[Differential] [Updated, 916 lines] D409: new mobile components

mart updated this revision to Diff 1066. REPOSITORY rPLASMAMOBILE plasma-mobile CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D409?vs=1009&id=1066 REVISION DETAIL https://phabricator.kde.org/D409 AFFECTED FILES components/mobilecomponents/ActionGroup.qml components/mobilecompo

[Differential] [Commented On] D409: new mobile components

mart added inline comments. INLINE COMMENTS components/mobilecomponents/ActionGroup.qml:26 yes, to do a tree-like thing components/mobilecomponents/ContextDrawer.qml:40 I'm still not sure wether the dependencies should be. I think i'll go for using qqc and wrapping the other classes that i

[Differential] [Updated, 917 lines] D409: new mobile components

mart updated this revision to Diff 1110. REPOSITORY rPLASMAMOBILE plasma-mobile CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D409?vs=1066&id=1110 REVISION DETAIL https://phabricator.kde.org/D409 AFFECTED FILES components/mobilecomponents/ActionGroup.qml components/mobilecompo

[Differential] [Closed] D409: new mobile components

This revision was automatically updated to reflect the committed changes. mart marked 4 inline comments as done. Closed by commit rPLASMAMOBILEd3b28119a79f: new mobile components (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D409?vs=1110&id=1141#toc REPOSITORY rPLAS

[Differential] [Request, 3,636 lines] D502: RFC: start in making plasma deps optional

mart created this revision. mart added a reviewer: Plasma: Mobile. mart set the repository for this revision to rPLASMAMOBILE plasma-mobile. Herald added a subscriber: plasma-devel. REVISION SUMMARY make a wrapper for theme and units: one using plasma deps and one without, with more hardcoded

[Differential] [Updated, 9,642 lines] D502: RFC: start in making plasma deps optional

mart updated this revision to Diff 1329. mart added a comment. weekly update of the current status of the branch REPOSITORY rPLASMAMOBILE plasma-mobile CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D502?vs=1178&id=1329 REVISION DETAIL https://phabricator.kde.org/D502 AFFECTED FI

[Differential] [Closed] D502: RFC: start in making plasma deps optional

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAMOBILE962e592afdf2: RFC: start in making plasma deps optional (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D502?vs=1329&id=1436#toc REPOSITORY rPLASMAMOBILE plasma-mob

[Differential] [Accepted] D729: Add Package to activesettings module

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. We'll have to definitely get rid of that class, but for now just to unbreak things is fine REVISION DETAIL https://phabricator.kde.org/D729 EMAIL PREFERENCES https://phabricator.kde.org/sett

[Differential] [Accepted] D782: Require Qt 5.5

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH qt-increase-version REVISION DETAIL https://phabricator.kde.org/D782 EMAIL PREFERENCES https://phabri

[Differential] [Accepted] D821: Drop not needed KF5::Plasma dependency

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH drop-plasma-dependency REVISION DETAIL https://phabricator.kde.org/D821 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/

[Differential] [Accepted] D742: Wayland integration: support for server-side decorations

mart accepted this revision. This revision is now accepted and ready to land. INLINE COMMENTS src/platformtheme/kwaylandintegration.cpp:94 since is a long name already, going all the way, waylandserverdecoration ? REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANC

[Differential] [Accepted] D899: [notifications] Make the text selectable in the popup too

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH mklapetek/selectableTextInNotifications REVISION DETAIL https://phabricator.kde.org/D899 EMAIL PREFERENCES https://phabricator.k

[Differential] [Accepted] D902: [DesktopView] Allow Shift modifier for triggering KRunner

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D902 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broul

[Differential] [Accepted] D819: [shell] Listen for QEvent::PlatformSurface to perform Wayland integration

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH wayland-platform-surface REVISION DETAIL https://phabricator.kde.org/D819 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D948: Don't show applet handle outside of desktop

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH handle-position (branched from master) REVISION DETAIL https://phabricator.kde.org/D948 EMAIL PREFERENCES https://phabricator.kde.or

[Differential] [Accepted] D986: Revamp of the activity switcher backend

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D986 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, davidedmundson,

[Differential] [Request, 109 lines] D987: KSplash looking consistent to sddm and lockscreen

mart created this revision. mart set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY this makes kspash be in a rectanle that looks just like the one used now in lockscreen and sddm.

[Differential] [Updated] D987: KSplash looking consistent to sddm and lockscreen

mart added reviewers: davidedmundson, broulik, andreaska. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, broulik, andreaska Cc: plasma-de

[Differential] [Commented On] D987: KSplash looking consistent to sddm and lockscreen

mart added a comment. http://youtu.be/68FDY4t0cIE REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, broulik, andreaska Cc: plasma-devel

[Differential] [Updated, 108 lines] D987: KSplash looking consistent to sddm and lockscreen

mart updated this revision to Diff 2394. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D987?vs=2392&id=2394 REVISION DETAIL https://phabricator.kde.org/D987 AFFECTED FILES lookandfeel/contents/splash/Splash.qml EMAIL PREFERENCES ht

[Differential] [Accepted] D1009: Added indicator of whether there are windows in an activity to the switcher

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. it will take a lot of thinking on the wayland side ;) but yes, i like it REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1009 EMAIL P

[Differential] [Accepted] D1007: [server] Add a signal SeatInterface::focusedPointerChanged

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH server-seat-signal-pointer-changed REVISION DETAIL https://phabricator.kde.org/D1007 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

[Differential] [Accepted] D1037: fix build properly by adding the lib dir to the includes

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1037 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Accepted] D1045: Emit PaletteChanged when setting colors from look and feel package

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH kcm-laf (branched from master) REVISION DETAIL https://phabricator.kde.org/D1045 EMAIL PREFERENCES https://phabricator.kde.org/setti

[Differential] [Accepted] D904: [Baloo Runner] Allow opening parent folder

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D904 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broul

[Differential] [Accepted] D1050: Center contents of desktop toolbox

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. Good enough for 5.6 imo REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH toolbox-center (branched from master) REVISION DETAIL https://phabricator.kde.org/D10

[Differential] [Commented On] D1066: Fix saving correct length of panel

mart added a comment. In https://phabricator.kde.org/D1066#20181, @davidedmundson wrote: > this is a binding loop. > > PanelView.cpp has > > setResizeMode(QuickViewSharedEngine::SizeRootObjectToView); > > > so we resize the window to the root object, then resize the root

[Differential] [Commented On] D1066: Fix saving correct length of panel

mart added inline comments. INLINE COMMENTS desktoppackage/contents/views/Panel.qml:134 conceptually, this is actually correct (wether it actually works, is another thing ;)) the view is supposed to resize itself over the preferred size of the containment, as long as is in the maximum/min

[Differential] [Commented On] D1066: Fix saving correct length of panel

mart added a comment. > I don't understand what you mean about restoring. > We should restore the min and max, then the content size comes from the contents - we can't save that as that doesnt make much sense. yeah, you're right. right now it saves and restores "length". that should

[Differential] [Commented On] D1066: Fix saving correct length of panel

mart added a comment. In https://phabricator.kde.org/D1066#20228, @drosca wrote: > It would probably be worth for 5.7 to rename panel.length to panel.preferredLength. the config entry, is probably better to just remove it. the property, is not much important the name i think, si

[Differential] [Commented On] D1069: Fix length returned from PanelView::geometryByDistance

mart added a comment. hmm, how this can expose that bug in particular? seems quite unrelated REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1069 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma

[Differential] [Commented On] D1070: Make panel scripting setLength set min and max length

mart added a comment. hmm, this quite risks to lose min and max settings in unwanted moments.. do you know exactly from where setLength is called and where/when the problem happens? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1070 EMAIL PR

[Differential] [Accepted] D941: Fix position of new applets added with drag and drop

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH add-applet-offset (branched from master) REVISION DETAIL https://phabricator.kde.org/D941 EMAIL PREFERENCES https://phabricator.kde.

[Differential] [Accepted] D933: Fix minimum size of Applet handle with Folder View

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. visible only on few applets, those that have the run associated application button as well REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DET

[Differential] [Accepted] D1090: [krunner] Make it work on Wayland

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: grae

[Differential] [Accepted] D1120: LayoutManager: Restore rotation on remove applet undo

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH undo-rotation (branched from Plasma/5.6) REVISION DETAIL https://phabricator.kde.org/D1120 EMAIL PREFERENCES https://phabricator.kde

[Differential] [Accepted] D1128: Trigger a roundtrip after creating the ServerSideDecoration

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH kwayland-roundtrip-server REVISION DETAIL https://phabricator.kde.org/D1128 EMAIL PREFERENCES https:/

[Differential] [Commented On] D1134: Alternatives: Add new applet only after the old one was removed

mart added a comment. good that makes it look more uniform. tough at some point there was the idea of the possibility of running a script between the addition of the new one and the destruction of the old one, making possible for a script to try to convert some of the config between the two

[Differential] [Accepted] D1143: do not install development helper files via cmake

mart accepted this revision. mart added a reviewer: mart. REPOSITORY rBREEZEGTK Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D1143 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, graesslin, mart Cc: plasma-devel ___

[Differential] [Accepted] D1152: [client] Perform ConnectionThread::roundtrip through QPA interface

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH roundtrip-qpa-5.6 REVISION DETAIL https://phabricator.kde.org/D1152 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Accepted] D1153: [plugins/qpa] Add a roundtrip platform function

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH qpa-roundtrip-5.6 REVISION DETAIL https://phabricator.kde.org/D1153 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1171: simple cleanup in geometryByDistance

mart accepted this revision. mart added a reviewer: mart. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1171 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma, apol, mart C

[Differential] [Accepted] D1161: PanelView length cleanup

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH REVISION DETAIL https://phabricator.kde.org/D1161 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Request, 67 lines] D1170: Api to rename activities in desktop scripting

mart created this revision. mart set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY the api containment.name was incorrect and broken, (using it it actually breaks the whole layout sinc

[Differential] [Accepted] D1162: Panel cleanup

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. INLINE COMMENTS desktoppackage/contents/views/Panel.qml:120 what happens if the sequece of events happens: 1) preferredWidth changes, tries to update the length, but it can't because mi

[Differential] [Updated] D1170: Api to rename activities in desktop scripting

mart added a reviewer: Plasma. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1170 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, Plasma Cc: plasma-devel ___ Plasma

[Differential] [Accepted] D1155: Ensure panel, desktop and onscreendisplay windows cannot be moved/resized

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH plasma-shell-not-movable-5.6 REVISION DETAIL https://phabricator.kde.org/D1155 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

[Differential] [Accepted] D1205: Add a surface tree to DebugConsole

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH debug-console-surface-tree REVISION DETAIL https://phabricator.kde.org/D1205 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

[Differential] [Accepted] D1242: Guard round this delegate getting deleted during menu exec

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH crash_fix2 REVISION DETAIL https://phabricator.kde.org/D1242 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Accepted] D1247: [server] Add a convenient method to check whether a Surface is mapped

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH surface-interface-is-mapped REVISION DETAIL https://phabricator.kde.org/D1247 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai

[Differential] [Accepted] D1245: Disable text wrapping in BreezeHeading

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.6 REVISION DETAIL https://phabricator.kde.org/D1245 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

[Differential] [Accepted] D1253: Fix position of tooltips in systemtray

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. good catch REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1253 EMAIL PREFERENCES https://phabrica

[Differential] [Accepted] D1264: Input events mode in debug console

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. tested and works on a real touchscreen REPOSITORY rKWIN KWin BRANCH debug-console-input-events REVISION DETAIL https://phabricator.kde.org/D1264 EMAIL PREFE

[Differential] [Accepted] D1271: Use a QTabWidget for the different modes in DebugConsole

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. yes :D REPOSITORY rKWIN KWin BRANCH debug-console-tab-widget REVISION DETAIL https://phabricator.kde.org/D1271 EMAIL PREFERENCES https://phabricator.kde.o

[Differential] [Accepted] D1279: Add a template for Weather Ion dataengines

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH iontemplate REVISION DETAIL https://phabricator.kde.org/D1279 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Accepted] D1221: [Slideshow Wallpaper] Fix seconds always set to 1 when opening config dialog

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1221 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Accepted] D1220: [Applet / Wallpaper Configuration] Load config page with initial cfg properties already set

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1220 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Commented On] D1340: Rename AbstractBackend to Platform

mart added a comment. the new name sounds better, but.. didn't you want to keep kwayland binary compatible? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1340 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc

[Differential] [Accepted] D1338: Fix null values in currency conversion

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D1338 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

[Differential] [Accepted] D1391: systemtray: Align menu to item's topleft corner

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH systray-menupos REVISION DETAIL https://phabricator.kde.org/D1391 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Accepted] D1390: systemtray: Disable tooltip when applet is expanded

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH systray-currentpopup REVISION DETAIL https://phabricator.kde.org/D1390 EMAIL PREFERENCES https://phabricator.kde.org/settings/pa

[Differential] [Request, 98 lines] D1402: add X11Integration for xcb qpa workarounds

mart created this revision. mart added a reviewer: graesslin. mart set the repository for this revision to rPLASMAINTEGRATION Integration for Qt applications in Plasma. mart added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY this class will collec

[Differential] [Updated, 115 lines] D1402: add X11Integration for xcb qpa workarounds

mart updated this revision to Diff 3321. mart added a comment. an attempt of autotest REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1402?vs=3320&id=3321 REVISION DETAIL https://phabricator.kde.org/D1402 A

[Differential] [Updated, 138 lines] D1402: add X11Integration for xcb qpa workarounds

mart removed rPLASMAINTEGRATION Integration for Qt applications in Plasma as the repository for this revision. mart updated this revision to Diff 3328. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1402?vs=3321&id=3328 REVISION DETAIL https://phabricator.kde.org/D1402 AFFECTED FILE

[Differential] [Accepted] D1441: ShellClient's m_shellSurface might be null

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH preparation-xdg-shell-shell-surface-may-be-null REVISION DETAIL https://phabricator.kde.org/D1441 EMAIL PREFERENCES https://phabricator.kde.org/setting

[Differential] [Accepted] D1440: Move ShellClient initialization code into a dedicated init method

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH preparation-xdg-shell REVISION DETAIL https://phabricator.kde.org/D1440 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D1435: Add missing data role for closable state.

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH moveresize REVISION DETAIL https://phabricator.kde.org/D1435 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To

[Differential] [Accepted] D1419: Move the WindowBasedEdge into the X11 platform and create Edge through Platform

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH screen-edge-platform REVISION DETAIL https://phabricator.kde.org/D1419 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D1372: Fix unsetting associated application/urls for Plasma::Applets

mart accepted this revision. This revision is now accepted and ready to land. BRANCH allowAssignedUrlAppUnsetting REVISION DETAIL https://phabricator.kde.org/D1372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, mart Cc: plasma-devel, sebas ___

[Differential] [Abandoned] D987: KSplash looking consistent to sddm and lockscreen

mart abandoned this revision. mart marked 2 inline comments as done. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, broulik, andreaska Cc

[Differential] [Commented On] D1222: RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos

mart added a comment. +1 on it, tough kinda shows the limits of the kind of dbus interface it was chosen for doing osds, wouldn't know an alternative that looks less silly tough REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1222 EMAIL PREFER

[Differential] [Commented On] D1479: [Notifications] Limit notification size and scroll to the bottom if needed

mart added a comment. looks like you can see the top text only for a brief moment then it goes "away"? it makes sense even tough i think there should be some way to return to top to actually read it, and this should happen only in the popup, if it's a permentent one in the history is fi

[Differential] [Commented On] D1478: [Notifications] Don't group job finished notifications

mart added a comment. In https://phabricator.kde.org/D1478#27445, @colomar wrote: > Why are those notification even persistent in the first place? If a user misses the notification, they should notice that the job was finished by the fact that it's not running anymore. > Only errors s

[Differential] [Commented On] D1478: [Notifications] Don't group job finished notifications

mart added a comment. +1 from me(provided the commit excludes the osd stuff), would like Martin taking a final look at this REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1478 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Accepted] D1456: Fix loading of widgetStyle in KHintsSettings

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH fix-loading-style REVISION DETAIL https://phabricator.kde.org/D1456 EMAIL PREFERENCES https://phabric

[Differential] [Accepted] D1475: [OSD] Load QML file on demand

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1475 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Accepted] D1222: RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1222 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Accepted] D1504: [Service Runner] Search for Jump List Actions

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. INLINE COMMENTS runners/services/servicerunner.cpp:266 is this context enough? it seems to imply this is always about web browser, wouldn't be better saying explicitly "this is about jum

[Differential] [Commented On] D1507: Add support for xdg-shell version 5 interface

mart added a comment. togerther Shellclient? wasn't in kwayland usually one different class implementation per protocol? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1507 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graessli

[Differential] [Accepted] D1490: Don't call xcb_damage_subtract for Wayland windows

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH no-subtract-damage-for-wayland REVISION DETAIL https://phabricator.kde.org/D1490 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Accepted] D1455: Auto-test to verify that the empty defaults are loaded correctly in KHintsSettings

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH hintsettings-autotest-default REVISION DETAIL https://phabricator.kde.org/D1455 EMAIL PREFERENCES htt

[Differential] [Accepted] D1501: [autotest] Work around "cannot assign undefined" warning

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH autotest-memory-management REVISION DETAIL https://phabricator.kde.org/D1501 EMAIL PREFERENCES https:

[Differential] [Accepted] D1487: Don't depend on operation mode in WindowPixmap

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. even in my unexpertness of kwin, it makes sense to me tough REPOSITORY rKWIN KWin BRANCH window-pixmap-improve-checks REVISION DETAIL https://phabricator.kde

[Differential] [Accepted] D1478: [Notifications] Don't group job finished notifications

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. go for it but only master REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1478 EMAIL PREFERENCES https://phabricato

[Differential] [Accepted] D1539: Don't show knetattach in the menu, it's only useful from within a file manager/dialog

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1539 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell

[Differential] [Commented On] D1126: Remove Desktop.SystemSettings import

mart added a comment. fine for me, modulo just the >= REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1126 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, sebas Cc: sebas, mart, plasma-devel _

[Differential] [Accepted] D1578: [Notifications] Unbreak notification actions

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1578 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Accepted] D1567: [System Tray] Fix assigning global shortcuts to applets from the config interface

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. INLINE COMMENTS applets/systemtray/package/contents/ui/ConfigEntries.qml:233 may be more robust if the type (sni or applet) is actually a role in the model? REPOSITORY rPLASMAWORKSPACE

[Differential] [Accepted] D1564: [System Tray] Ensure pin is always on top

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1564 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Accepted] D1565: [System Tray] Forward keyboard input to expanded representation

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1565 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Accepted] D1584: start struts timer in resizeEvent

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1584 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Accepted] D1592: [Device Notifier] Add option to disable popup on new device

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. not completely sold on the need for the option, but yeah, go ahead REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D159

[Differential] [Accepted] D1591: [Shell Runner] Add "Run in Terminal" option

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. INLINE COMMENTS runners/places/placesrunner.h:53 this seems an unrelated change? runners/shell/shellrunner.h:50 cleanup of this maybe in separate commit? REPOSITORY rPLASMAWORKSPACE Pl

[Differential] [Accepted] D1590: [Places Runner] Add mimeDataForMatch

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1590 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Accepted] D1586: Delay maximize button click to next event cycle

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH fix-aurorae-maximize-5.6 REVISION DETAIL https://phabricator.kde.org/D1586 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

[Differential] [Commented On] D1583: fix sycoca init to pass in isolated testbeds without pre-existing sycoca

mart added a comment. +1 REPOSITORY rKDECLITOOLS KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D1583 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, dfaure Cc: mart, plasma-devel, sebas

[Differential] [Accepted] D1596: Do not limit mouse actions to titleBarArea but allow on complete titleBarPosition

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH titlebar-position-actions REVISION DETAIL https://phabricator.kde.org/D1596 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Accepted] D1607: add highlevel test for icon theming

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D1607 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Commented On] D1616: Fix the intial panel width when using xmonad (and probably other tiling WMs).

mart added a comment. well, setLength, is pretty much a shortcut for setting the proper size (width or height) given the location.. i think the patch kinda makes sense REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1616 EMAIL PREFERENCES ht

  1   2   3   4   5   6   7   8   9   10   >