franckarrecot created this revision.
franckarrecot added a reviewer: mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The point is that a project embedding kirigami as submodule would have
CMAKE_SOURCE_DIR wrong i
franckarrecot added inline comments.
INLINE COMMENTS
> apol wrote in CMakeLists.txt:16
> Sounds like `${kirigami_SOURCE_DIR}/kirigami.qrc` would be best. I don't
> really understand the `..` you added though.
Well my main problem is when embedding kirigami as submodule in my cmake
project, CMA
franckarrecot added a comment.
" CMAKE_SOURCE_DIR is pointing to my top level source dir, not kirigami' one,
"
> so : qt5_add_resources(RESOURCES ${CMAKE_SOURCE_DIR}/kirigami.qrc) would
refer to an incorrect path and then make cmake fails at config time, for any
projecting embedding kir
franckarrecot added inline comments.
INLINE COMMENTS
> apol wrote in CMakeLists.txt:16
> Sounds like `${kirigami_SOURCE_DIR}/kirigami.qrc` would be best. I don't
> really understand the `..` you added though.
In my case kirigami_SOURCE_DIR points to /MyProject/3rdparty/kirigami/src and
not kir
franckarrecot added a comment.
thanks, I can't push though, do I need special access or special urls to do
so ?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D3649
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: franckarrecot,
franckarrecot added a comment.
my current urls are :
origin git://anongit.kde.org/kirigami.git (fetch)
origin git://anongit.kde.org/kirigami.git (push)
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D3649
EMAIL PREFERENCES
https://phabricator.kde.org/sett
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:cd78b8ca4926: Make kirigami.qrc ressource path relative
to CMAKE_CURRENT_SOURCE_DIR (authored by franckarrecot).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D364
