[Differential] [Updated] D827: Suspend/Hibernate through daemon instead of greeter

broulik added a comment. +1 INLINE COMMENTS greeter/greeterapp.cpp:616 perhaps cache the end? for (auto it = m_views.constBegin(), end = m_views.constEnd(); it != end; ++it) powermanagement.cpp:110 I prefer returning a reference for singletons but I guess this way is just consistent w

[Differential] [Accepted] D827: Suspend/Hibernate through daemon instead of greeter

broulik accepted this revision. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH powermanagement-daemon REVISION DETAIL https://phabricator.kde.org/D827 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, bshah, broulik Cc: plasma-devel _

[Differential] [Accepted] D884: Async variant to check whether power management is inhibited

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Not really happy with 3rd party using InhibitionsChanged signal because I find it quite horrible in retrospect, and will probably need to change it for our future Inhibitions plasmoid but

[Differential] [Request, 24 lines] D901: [KRunner] Use time-based sorting rather than length for auto-completion

broulik created this revision. broulik added reviewers: Plasma, mck182. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This makes more recently typed queries take prece

[Differential] [Request, 2 lines] D902: [DesktopView] Allow Shift modifier for triggering KRunner

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY We were rejecting all key presses that had modifier in i

[Differential] [Request, 23 lines] D904: [Baloo Runner] Allow opening parent folder

broulik created this revision. broulik added reviewers: Plasma, vhanda. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This allows opening the folder a file is located.

[Differential] [Updated] D904: [Baloo Runner] Allow opening parent folder

broulik updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D904 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, vhanda Cc: plasma-devel __

[Differential] [Request, 13 lines] D908: [Baloo Runner] Add mime data to matches

broulik created this revision. broulik added reviewers: Plasma, vhanda. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Allows to drag and drop around found files.

[Differential] [Closed] D908: [Baloo Runner] Add mime data to matches

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE25dab5d872c6: [Baloo Runner] Add mime data to matches (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D908?vs=2208&id=2226#toc REPOSITORY rPLASMAWORKSPACE Pla

[Differential] [Closed] D902: [DesktopView] Allow Shift modifier for triggering KRunner

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEd7c5c99ad05c: [DesktopView] Allow Shift modifier for triggering KRunner (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator

[Differential] [Closed] D901: [KRunner] Use time-based sorting rather than length for auto-completion

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE598f7c99e6ba: [KRunner] Use time-based sorting rather than length for auto-completion (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https

[Differential] [Updated] D987: KSplash looking consistent to sddm and lockscreen

broulik added a comment. I use QT_DEVICE_PIXEL_RATIO=2 so for me it is larger than SDDM which doesn't do this. I like it, though. INLINE COMMENTS lookandfeel/contents/splash/Splash.qml:87 You don't import PlasmaCore REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://

[Differential] [Commented On] D1008: [Image Wallpaper] Make color picker visible for all positioning mode.

broulik added a comment. You would also need to adjust: - Line 298: remove the visible check to always set the appropriate color - main.qml, Lines 196ff: the background color rect also needs to be visible in all modes INLINE COMMENTS wallpapers/image/imagepackage/contents/ui/config.q

[Differential] [Request, 17 lines] D1020: [User Switcher] Fix session swicthing when screen locking is enabled

broulik created this revision. broulik added reviewers: Plasma, graesslin. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY When automatic screen locking is enabled, we w

[Differential] [Updated] D1020: [User Switcher] Fix session swicthing when screen locking is enabled

broulik updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1020 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, graesslin Cc: plasma-devel

[Differential] [Request, 82 lines] D1021: [FolderView] Allow chosing list or icon view in popup

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY While I really like the list view for the popup, I also

[Differential] [Commented On] D1021: [FolderView] Allow chosing list or icon view in popup

broulik added a comment. This review is all about that Bug 359618. I don't change the list view, it's just that if you don't like the list view in the popup (which is still the default) you can choose icon mode and there you can also choose the icon size. REPOSITORY rPLASMADESKTOP Pla

[Differential] [Updated, 142 lines] D1021: [FolderView] Allow chosing list or icon view in popup

broulik updated this revision to Diff 2458. broulik added a comment. - Fix updating popup position when changing icon size or view mode (it's always 3x2 icons no matter the icon size, would be cool to have a default popup size and then show more icons if more fit in there) - Fix stale deleg

[Differential] [Closed] D1020: [User Switcher] Fix session swicthing when screen locking is enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE7a0096ba99d7: [User Switcher] Fix session switching when automatic screen locking is enabled (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 1 line] D1025: [DrKonqi] Avoid duplicate "Help" button

broulik created this revision. broulik added reviewers: Plasma, dfaure. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY For some reason I got two "Help" buttons in the c

[Differential] [Updated] D1025: [DrKonqi] Avoid duplicate "Help" button

broulik updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1025 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, dfaure Cc: plasma-devel ___

[Differential] [Request, 10 lines] D1026: [FolderModel] Simplify deleting existing drag image

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Instead of looking up three times (contains, value, remo

[Differential] [Updated, 188 lines] D1021: [FolderView] Allow chosing list or icon view in popup

broulik updated this revision to Diff 2473. broulik added a comment. - Fix switching between list view and icon view at runtime Using States {} I can achieve atomic anchor changes; it seems when you use regular bindings and you have horizontal/verticalCenter and a left/right/top/bottom a

[Differential] [Closed] D1021: [FolderView] Allow chosing list or icon view in popup

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP28aae4bc188c: [FolderView] Allow chosing list or icon view in popup (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

[Differential] [Closed] D1026: [FolderModel] Simplify deleting existing drag image

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPd59af0bff7b2: [FolderModel] Simplify deleting existing drag image (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10

[Differential] [Request, 1 line] D1027: [FolderView] HIde tooltip when beginning drag

broulik created this revision. broulik added a reviewer: hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This prevents the tooltip from shooting to the top left corner

[Differential] [Closed] D1027: [FolderView] HIde tooltip when beginning drag

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP05de074748ab: [FolderView] Hide tooltip when beginning drag (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1027?vs=

[Differential] [Request, 83 lines] D1028: RFC: Remove custom RubberBand painter

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This removes the custom RubberBand that is painted using

[Differential] [Request, 38 lines] D1029: [FolderView] Fix Location config placement

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This gives the RadioButton a label so the entire thing i

[Differential] [Commented On] D1029: [FolderView] Fix Location config placement

broulik added a comment. F89490: Screenshot_20160227_133030.png REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1029 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, P

[Differential] [Request, 55 lines] D1034: [Task Manager] Don't show task is on all activities if there is just one running one

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This is similar to what we do with regards to virtual de

[Differential] [Closed] D1034: [Task Manager] Don't show task is on all activities if there is just one running one

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPf3c41c272572: [Task Manager] Don't show task is on all activities if there is just one… (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1034?vs=2487&id=2493#toc

[Differential] [Closed] D1025: [DrKonqi] Avoid duplicate "Help" button

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE75a80e751bc0: [DrKonqi] Avoid duplicate "Help" button (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1025?vs=

[Differential] [Request, 3 lines] D1044: [DrKonqi] Reliably quit when closing report assistant

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY The finished signal is not emitted when the dialog is ju

[Differential] [Updated] D1044: [DrKonqi] Reliably quit when closing report assistant

broulik updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1044 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: plasma-devel _

[Differential] [Closed] D904: [Baloo Runner] Allow opening parent folder

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEa18be0a6e61a: [Baloo Runner] Allow opening parent folder (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D904?vs=2199&id=2518#toc REPOSITORY rPLASMAWORKSPACE

[Differential] [Updated] D1075: Display mouse image in mouse kcm properly on highdpi screen

broulik added a comment. Doesn't make a difference on my machine. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1075 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, apol, broulik Cc: plasma-devel _

[Differential] [Request, 4 lines] D1085: [KSysGuardProcessList] Don't forward keys with modifiers (except shift) to the search field

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rLIBKSYSGUARD KSysguard Library. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This breaks shortcuts like Ctrl+A to select all. The same a

[Differential] [Commented On] D1088: [krunner] Don't call KWindowSystem::setState on every event

broulik added a comment. and suddenly I can no longer type faster than KRunner can process. Nice finding! +1 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1088 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences

[Differential] [Accepted] D1088: [krunner] Don't call KWindowSystem::setState on every event

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1088 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D1093: Opening the activity switcher as a delayed call

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1093 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, mart, b

[Differential] [Request, 2 lines] D1094: [KRunner] Don't override user input in history

broulik created this revision. broulik added reviewers: Plasma, xuetianweng. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY BUG: 360268 FIXED-IN: 5.6.0 TEST PLAN I

[Differential] [Closed] D1094: [KRunner] Don't override user input in history

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE20b97073bb3f: [KRunner] Don't override user input in history (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

[Differential] [Request, 45 lines] D1103: [Folder View] Add "Icon Size" to "Icons" context menu

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY As requested by VDG BUG: 360351 FIXED-IN: 5.7.0

[Differential] [Closed] D1103: [Folder View] Add "Icon Size" to "Icons" context menu

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP3bf5a5a1c592: [Folder View] Add "Icon Size" to "Icons" context menu (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1103?vs=2659&id=2661#toc REPOSITORY rPLASMA

[Differential] [Request, 4 lines] D1173: [Window Rules] Fix simple shortcut not being transfered to text field

broulik created this revision. broulik added reviewers: graesslin, luebking. broulik set the repository for this revision to rKWIN KWin. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY The dialog only had a "Close" button but the text was only transfere

[Differential] [Request, 3 lines] D1186: [Task Manager] Initiate drag only with left mouse button drag

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY BUG: 360720 FIXED-IN: 5.6.1 TEST PLAN mouse.button is al

[Differential] [Closed] D1173: [Window Rules] Fix simple shortcut not being transfered to text field

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINf9da3fb0eb76: [Window Rules] Fix simple shortcut not being transfered to text field (authored by broulik). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1173?vs=2838

[Differential] [Closed] D1044: [DrKonqi] Reliably quit when closing report assistant

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb7f7b4e18947: [DrKonqi] Reliably quit when closing report assistant (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde

[Differential] [Request, 76 lines] D1220: [Applet / Wallpaper Configuration] Load config page with initial cfg properties already set

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Rather than creating the config page and then setting the pro

[Differential] [Request, 25 lines] D1221: [Slideshow Wallpaper]

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. broulik added a dependency: D1220: [Applet / Wallpaper Configuration] Load config page with initial cfg properties a

[Differential] [Updated] D1221: [Slideshow Wallpaper]

broulik updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1221 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: plasma-devel _

[Differential] [Updated] D1220: [Applet / Wallpaper Configuration] Load config page with initial cfg properties already set

broulik added a dependent revision: D1221: [Slideshow Wallpaper]. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1220 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: plasma-devel

[Differential] [Closed] D1186: [Task Manager] Initiate drag only with left mouse button drag

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP57d7d66445ef: [Task Manager] Initiate drag only with left mouse button drag (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.k

[Differential] [Updated] D1221: [Slideshow Wallpaper] Fix seconds always set to 1 when opening config dialog

broulik retitled this revision from "[Slideshow Wallpaper]" to "[Slideshow Wallpaper] Fix seconds always set to 1 when opening config dialog". broulik updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1221 EMAIL

[Differential] [Request, 40 lines] D1222: RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design, jgrulich. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Whenever we turn something on o

[Differential] [Request, 32 lines] D1223: [Touchpad KDED module] Show OSD when toggling touchpad with keyboard shortcut

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a project: Plasma. broulik added a dependency: D1222: RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos. Her

[Differential] [Updated] D1222: RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos

broulik added a dependent revision: D1223: [Touchpad KDED module] Show OSD when toggling touchpad with keyboard shortcut. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1222 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

[Differential] [Commented On] D1222: RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos

broulik added a comment. F3: Screenshot_20160325_162127.png F4: Screenshot_20160325_16.png F5: Screenshot_20160325_162144.png REPOSITORY rPLASMAWORKSPACE P

[Differential] [Commented On] D1242: Guard round this delegate getting deleted during menu exec

broulik added a comment. Meh, I thought I tested it thorougly when I switched it from QMetaObject invokeMethod to QTimer with lambda :/ INLINE COMMENTS applets/taskmanager/plugin/backend.cpp:356 Doesn't this thing need an object to guard? QPointer guard(m_contextMenu) REPOSITORY rPLAS

[Differential] [Commented On] D1222: RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos

broulik added a comment. > Couldn't this be added to powerdevil? We could do that, the OSD is quite indifferent on who calls it. I'm just not sure whether having the global shortcuts for toggling WiFi et al in PowerDevil rather than plasma-nm which usually manages all networking and has

[Differential] [Commented On] D1289: Use default output device when changing global volume

broulik added a comment. > changing volume with wheel and muting with middle click on applet icon no longer shows OSD. Why? This makes it inconsistent with what battery does. Battery does only not show the OSD when the popup is opened as then it's obvious. REPOSITORY rPLASMAPA Plasma

[Differential] [Commented On] D1289: Use default output device when changing global volume

broulik added a comment. Fair enough... it's also what KMix used to do. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D1289 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma,

[Differential] [Closed] D1220: [Applet / Wallpaper Configuration] Load config page with initial cfg properties already set

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP3a401739e2c8: [Applet / Wallpaper Configuration] Load config page with initial cfg… (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabr

[Differential] [Closed] D1221: [Slideshow Wallpaper] Fix seconds always set to 1 when opening config dialog

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE7656fa02e680: [Slideshow Wallpaper] Fix seconds always set to 1 when opening config dialog (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Abandoned] D1028: RFC: Remove custom RubberBand painter

broulik abandoned this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1028 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, hein Cc: plasma-devel, sebas

[Differential] [Updated] D1085: [KSysGuardProcessList] Don't forward keys with modifiers (except shift) to the search field

broulik updated the summary for this revision. REPOSITORY rLIBKSYSGUARD KSysguard Library REVISION DETAIL https://phabricator.kde.org/D1085 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: plasma-devel, sebas __

[Differential] [Closed] D1085: [KSysGuardProcessList] Don't forward keys with modifiers (except shift) to the search field

This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSYSGUARD4b14421cf723: [KSysGuardProcessList] Don't forward keys with modifiers (except shift) to… (authored by broulik). REPOSITORY rLIBKSYSGUARD KSysguard Library CHANGES SINCE LAST UPDATE https:

[Differential] [Request, 151 lines] D1350: [Digital Clock] Allow copying current date to clipboard

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It allows copying the cur

[Differential] [Commented On] D1350: [Digital Clock] Allow copying current date to clipboard

broulik added a comment. F105986: Screenshot_20160407_205447.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1350 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Commented On] D1366: Add Event Sounds stream to Applications list

broulik added a comment. Not sure about the term *event* sounds. What about *notification* sounds? REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D1366 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosc

[Differential] [Commented On] D1393: Refactor models

broulik added a comment. Nice INLINE COMMENTS src/maps.h:92 Not too fond of allocating a list just to get an item from it, can we perhaps do something like (m_data.constBegin() + index).value(); src/pulseaudio.h:48 You don't need slots to connect to with the new connect syntax iirc REPO

[Differential] [Accepted] D1458: Don't include invalid conversions in result

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. INLINE COMMENTS runners/converter/converterrunner.cpp:237 Remove space betwen ! and v REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabr

[Differential] [Request, 76 lines] D1475: [OSD] Load QML file on demand

broulik created this revision. broulik added a reviewer: Plasma. broulik added a subscriber: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Started pla

[Differential] [Request, 96 lines] D1478: [Notifications] Don't group job finished notifications

broulik created this revision. broulik added reviewers: Plasma, mck182, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise you'll

[Differential] [Request, 111 lines] D1479: [Notifications] Limit notification size and scroll to the bottom if needed

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design, mck182. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This limits the s

[Differential] [Updated, 15 lines] D1479: [Notifications] Limit notification size and scroll to the bottom if needed

broulik removed rPLASMAWORKSPACE Plasma Workspace as the repository for this revision. broulik updated this revision to Diff 3498. broulik added a comment. Remove leftovers from other patch CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1479?vs=3497&id=3498 REVISION DETAIL https:

[Differential] [Commented On] D1479: [Notifications] Limit notification size and scroll to the bottom if needed

broulik added a comment. > Why can we not make it scroll? There's no technical reason we cannot, I just haven't added it :) I'll figure something out. REVISION DETAIL https://phabricator.kde.org/D1479 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To

[Differential] [Commented On] D1478: [Notifications] Don't group job finished notifications

broulik added a comment. Please ignore the OSD stuff in the patch :) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1478 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, Plasma: Design, mck18

[Differential] [Closed] D1475: [OSD] Load QML file on demand

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE79c081e2ea35: [OSD] Load QML file on demand (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1475?vs=3490&id=35

[Differential] [Closed] D1222: RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE37a70c0dca59: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1222?vs=2956&id=3548#toc REPOSITORY

[Differential] [Closed] D1223: [Touchpad KDED module] Show OSD when toggling touchpad with keyboard shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPcf0bf81ccd4c: [Touchpad KDED module] Show OSD when toggling touchpad with keyboard shortcut (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https

[Differential] [Request, 48 lines] D1504: [Service Runner] Search for Jump List Actions

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This makes the service ru

[Differential] [Commented On] D1504: [Service Runner] Search for Jump List Actions

broulik added a comment. F116902: Screenshot_20160427_235536.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1504 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Closed] D1504: [Service Runner] Search for Jump List Actions

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE00593d47e060: [Service Runner] Search for Jump List Actions (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1504?vs=3551&id=3571#toc REPOSITORY rPLASMAWORKSP

[Differential] [Request, 87 lines] D1514: [Milou] Optimize sources model

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rMILOU Milou. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This optimizes the sources model by avoiding model resets and

[Differential] [Commented On] D1478: [Notifications] Don't group job finished notifications

broulik added a comment. Ping. Also, should we target Plasma/5.6 with that? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1478 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, Plasma: D

[Differential] [Commented On] D1479: [Notifications] Limit notification size and scroll to the bottom if needed

broulik added a comment. Right, the limit should only be enforced in the popup. I'll add a scrollbar and leave the history unchanged. REVISION DETAIL https://phabricator.kde.org/D1479 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, Pla

[Differential] [Closed] D1478: [Notifications] Don't group job finished notifications

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE46229c9e4740: [Notifications] Don't group job finished notifications (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1478?vs=3496&id=3612#toc REPOSITORY rPLA

[Differential] [Commented On] D1539: Don't show knetattach in the menu, it's only useful from within a file manager/dialog

broulik added a comment. +1 > It's pretty useful to call it from the app menu That irony confused me. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1539 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D1367: PulseObjectFilterModel: Allow to set more filters

broulik added a comment. I hit the assert here: Q_ASSERT(enumerator.scope() == metaObject()->className()); REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D1367 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Request, 3 lines] D1562: [OSD] Enable wrapping into two lines

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In some languages, notably German, words

[Differential] [Request, 10 lines] D1563: RFC: Add OSD for when on-screen keyboard is enabled/disabled

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As suggested by Martin, t

[Differential] [Commented On] D1563: RFC: Add OSD for when on-screen keyboard is enabled/disabled

broulik added a comment. F122818: Screenshot_20160508_215318.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1563 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Updated, 7 lines] D1562: [OSD] Enable wrapping into two lines

broulik updated this revision to Diff 3705. broulik added a comment. Take into account label height for icon size REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1562?vs=3703&id=3705 REVISION DETAIL https://phabricator.kde.org/D1562

[Differential] [Request, 1 line] D1564: [System Tray] Ensure pin is always on top

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The MouseArea on the heading covered it

[Differential] [Request, 2 lines] D1565: [System Tray] Forward keyboard input to expanded representation

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This unbreaks keyboard input in System T

[Differential] [Request, 4 lines] D1566: [System Tray] Use units.longDuration for transitions

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The Qt default is too long and non-confi

[Differential] [Request, 7 lines] D1567: [System Tray] Fix assigning global shortcuts to applets from the config interface

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The model has changed and

[Differential] [Accepted] D1545: [libinput] Support toggleTouchpad

broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. Next step would be supporting the "automatically disable when plugging in an external mouse" option REPOSITORY rKWIN KWin BRANCH toggle-touchpad R

  1   2   3   4   5   6   7   8   9   10   >