Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

06/20/notes_Produkt_without_patch.png Note in Produkt theme with this patch http://git.reviewboard.kde.org/media/uploaded/files/2013/06/20/notes_Produkt_with_patch.png Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

anged that now. - Wolfgang --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110701/#review34750 --- On June 20, 2013, 1:42 p.m., Wo

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

package since a month ago. File Attachments Note in Produkt theme without this patch http://git.reviewboard.kde.org/media/uploaded/files/2013/06/20/notes_Produkt_without_patch.png Note in Produkt theme with this patch http://git.reviewboard.kde.org/media/uploaded/files/2013/06/20/not

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

e in Produkt theme without this patch http://git.reviewboard.kde.org/media/uploaded/files/2013/06/20/notes_Produkt_without_patch.png Note in Produkt theme with this patch http://git.reviewboard.kde.org/media/uploaded/files/2013/06/20/notes_Produkt_with_patch.png Thanks, Wolfgang Bauer ___

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

, 2013, 8:12 p.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110701/ > --- > >

Re: Review Request 113127: Fix click on trash plasmoid when on desktop and widgets are unlocked

13127/diff/ Testing --- - Add a trash plasmoid to the desktop, make sure widgets are unlocked. - Click on the trash - file manager gets started every time, without the patch nothing happens (most of the time). Thanks, Wolfgang Bauer ___ Plasma-

Re: Review Request 113127: Fix click on trash plasmoid when on desktop and widgets are unlocked

org/r/113127/diff/ Testing --- - Add a trash plasmoid to the desktop, make sure widgets are unlocked. - Click on the trash - file manager gets started every time, without the patch nothing happens (most of the time). Thanks, Wolfgang

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

this patch this works: there is a password input field, the session is unlocked when the user enters the password. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On March 26, 2014, 11:07 p.m., Thomas Lübking wrote: > > you could sighup or sigusr the greeter process and have it > > > > setImmediateLock(true); > > desktopResized(); > > > > in return > > Wolfgang Bauer wrote: > I agree, this would b

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

rd. With this patch this works: there is a password input field, the session is unlocked when the user enters the password. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

s way. - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56190 --- On April 22, 2014, 9:28 p.m., Wolfgang Ba

Re: Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker

> On April 20, 2014, 9:18 p.m., Christoph Feck wrote: > > Can someone more familiar with the screen locker please review this, or > > suggest someone who could review it? > > Christoph Feck wrote: > Felix, could you please add Wolfgang Bauer (wbauer) and maybe Tho

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

rd. With this patch this works: there is a password input field, the session is unlocked when the user enters the password. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

: https://git.reviewboard.kde.org/r/117091/#review56209 --- On April 22, 2014, 9:56 p.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-m

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56190 --- On April 22, 2014, 9:56 p.m., Wolfgang Bauer wrote: > > --

Review Request 117644: screenlocker: don't leave behind screensaver processes

and I even set the timeout to 1 minute). I also tried to terminate kscreenlocker_greet manually by running "killall kscreenlocker_greet" from a text console in case of a password required, and the locker didn't quit, you still have to

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

the password. With this patch this works: there is a password input field, the session is unlocked when the user enters the password. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

-) > > sigaction(SIGUSR1, &sa, NULL); // for later nullptr > > i doubt that you'll need another update for that, though. > > Wolfgang Bauer wrote: > Well, should I change it? > > In kscreensaver/libkscreensaver/main.cpp they used si

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

xt console in case of a password required, and the locker didn't quit, you still have to enter the password. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

ell, so you cannot unlock. - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56241 --- On April 22, 2014, 10:34 p

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644/#review56240 --- On April 22, 2014, 10:41 p.m., Wolfgang Bauer wrote: > > ---

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote: > > Is that only relevant for the legacy (XSS) locker or also for the new > > locker? I'm just wondering whether it needs to be ported to master > > Wolfgang Bauer wrote: > Yes. I just tried, and the scre

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

patch this works: there is a password input field, the session is unlocked when the user enters the password. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

p object, so that the signalhandler can call its methods. - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56294 ------

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

s m_ so one would assume > > it's a member variable, but that looks more like a static variable. > > > > So better make it static and use the s_ prefix > > Wolfgang Bauer wrote: > You're right. It is no member variable. No idea why I chose that name.

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

cannot resume the session by entering the password. With this patch this works: there is a password input field, the session is unlocked when the user enters the password. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

password required, and the locker didn't quit, you still have to enter the password. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

it again after the latest changes. - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56190 --- On April 24, 2014, 1

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

g/r/117091/#review56415 --- On April 24, 2014, 10:52 a.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> --- > > > > KDE Workspaces 4.11.9 tagging: > > Fr 25. Apr 01:59:00 CEST 2014 > > > > Would you be ok to give Martin until > > Fr 25. Apr 00:01:00 CEST 2014 > > and then push it (on my responsibility)? > > Wolfgang

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> --- > > > > KDE Workspaces 4.11.9 tagging: > > Fr 25. Apr 01:59:00 CEST 2014 > > > > Would you be ok to give Martin until > > Fr 25. Apr 00:01:00 CEST 2014 > > and then push it (on my responsibility)? > > Wolfgang

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

rd. With this patch this works: there is a password input field, the session is unlocked when the user enters the password. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

d the locker didn't quit, you still have to enter the password. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127125: [plasmashell] Disable Qt's fallback session management

f the user clicks "Cancel". Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127125: [plasmashell] Disable Qt's fallback session management

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127125/#review92583 --- On Feb. 20, 2016, 3:51 nachm., Wolfgang Bauer wrote: > > --

Re: Review Request 127125: [plasmashell] Disable Qt's fallback session management

he logout. With the patch, the desktop stays until logout is really confirmed, and is still usable if the user clicks "Cancel". Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127125: [plasmashell] Disable Qt's fallback session management

oes care about > > applications getting killed too early and this fixes it. > > This one is yours, I'll push the other ones. > > Wolfgang Bauer wrote: > Well, actually I want to thank *you* very much for taking care about the > general session management issues,

Re: Review Request 127125: [plasmashell] Disable Qt's fallback session management

Feb. 22, 2016, 12:55 nachm., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127125/ > ---

Review Request 127499: [showdesktop] Fix sizing of the plasmoid in the panel

/uploaded/files/2016/03/26/98a734d1-ca67-4905-8137-9ed5c7dca11c__after.png Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127499: [showdesktop] Fix sizing of the plasmoid in the panel

marked as submitted. Review request for Plasma and Kai Uwe Broulik. Changes --- Submitted with commit e164ae7c02f5579e02d26842bee6a4a450e01871 by Wolfgang Bauer to branch Plasma/5.6. Repository: kdeplasma-addons Description --- Since 5.6, if you add a "Show Desktop" p

Review Request 127623: [digital-clock] Fix display of seconds with certain locales

tch locale to C, seconds are shown now or not, depending on the applet's configuration, they were not shown before even when enabled. It still behaves as expected with my standard locale (de_AT). Thanks, Wolfgang Bauer ___ Plasma-devel mailing list

Re: Review Request 127616: Digital clock applet re-write

roduce, set the locale to "C" and enable "Show Seconds", the seconds won't be displayed. See https://git.reviewboard.kde.org/r/127623/ - Wolfgang Bauer On April 9, 2016, 5:23 nachm., Daniel Faust wrote: > > -

Re: Review Request 127623: [digital-clock] Fix display of seconds with certain locales

1 Diff: https://git.reviewboard.kde.org/r/127623/diff/ Testing --- Switch locale to C, seconds are shown now or not, depending on the applet's configuration, they were not shown before even when enabled. It still behaves as expected with my standard locale (de_AT). Tha

Review Request 118898: KGamma: Apply user setting at login/startup

ogout/login (or reboot), Gamma value gets set correctly. If there's no kgammarc file (or it contains no actual gamma settings), the Gamma value is not changed. It stays at what is configured for X (or its default). Thanks, Wolfgang Bauer ___

Re: Review Request 118898: KGamma: Apply user setting at login/startup

e user enters the KCM. But the point of this setting is to be applied automatically on login/startup. - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60

Re: Review Request 118898: KGamma: Apply user setting at login/startup

in 4.x, but the feature will be lost again > > > > Again, not super-privvy of the whole picture, but isn't color correction > > the correct solution here? > > Wolfgang Bauer wrote: > applykgammasettings is only called on login for people actually >

Re: Review Request 118898: KGamma: Apply user setting at login/startup

value is not changed. It stays at what is configured for X (or its default). Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118898: KGamma: Apply user setting at login/startup

in 4.x, but the feature will be lost again > > > > Again, not super-privvy of the whole picture, but isn't color correction > > the correct solution here? > > Wolfgang Bauer wrote: > applykgammasettings is only called on login for people actually >

Re: Review Request 118898: KGamma: Apply user setting at login/startup

anyway? But that's not really related to this bugfix, I'd say... - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60809 ----

Re: Review Request 118898: KGamma: Apply user setting at login/startup

> On June 23, 2014, 5:13 p.m., Martin Gräßlin wrote: > > kcmkgamma/init_kgamma.cpp, line 39 > > <https://git.reviewboard.kde.org/r/118898/diff/1/?file=283881#file283881line39> > > > > why delete config? I would just use a KSharedConfig::openConfig > >

Re: Review Request 118898: KGamma: Apply user setting at login/startup

rated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60866 ------- On June 23, 2014, 7:01 p.m., Wolfgang Bauer wrote: > > --- > This is a

Re: Review Request 118898: KGamma: Apply user setting at login/startup

at is configured for X (or its default). Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118898: KGamma: Apply user setting at login/startup

default). Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124171: Fix applying user settings at login

--- Change the Gamma settings and logout/login. The settings are now applied again during login, whereas they weren't before. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124171: Fix applying user settings at login

marked as submitted. Review request for Plasma and David Edmundson. Changes --- Submitted with commit 6663ebc14dd9b14f41498c617157e2f059165734 by Wolfgang Bauer to branch frameworks. Bugs: 218668 http://bugs.kde.org/show_bug.cgi?id=218668 Repository: kgamma Description

[kwrited] [Bug 351665] KDE shown hidden menu items available but not openable

https://bugs.kde.org/show_bug.cgi?id=351665 Wolfgang Bauer changed: What|Removed |Added CC||wba...@tmo.at --- Comment #1 from Wolfgang

[kwrited] [Bug 351665] KDE shown hidden menu items available but not openable

https://bugs.kde.org/show_bug.cgi?id=351665 Wolfgang Bauer changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution

[kwrited] [Bug 351665] KDE shown hidden menu items available but not openable

https://bugs.kde.org/show_bug.cgi?id=351665 --- Comment #4 from Wolfgang Bauer --- PS: (In reply to Nick Levinson from comment #2) > Clicking on the Software Updater icon or the Battery Monitor icon worked but > clicking on the Notifications icon did nothing. If that means there w

Review Request 125189: Fix loading of the configured cursor theme

-- Open the KCM, the currently configured Cursor theme is now shown correctly. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125189: Fix loading of the configured cursor theme

marked as submitted. Review request for Plasma and David Edmundson. Changes --- Submitted with commit c458a098c0271517ba59d65290d5b1b7c2577495 by Wolfgang Bauer to branch Plasma/5.4. Bugs: 344592 https://bugs.kde.org/show_bug.cgi?id=344592 Repository: sddm-kcm Description

Review Request 125191: Allow to set minimum user id lower than 1000

- src/advanceconfig.cpp 58e9f98 Diff: https://git.reviewboard.kde.org/r/125191/diff/ Testing --- Set the minimum user id to 500 e.g., it does now get saved correctly. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 125191: Allow to set minimum user id lower than 1000

alue for the setting, see line 81. - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125191/#review85249 --- On Sept. 12, 2015,

Re: Review Request 125191: Allow to set minimum user id lower than 1000

.conf). I just tried. - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125191/#review85249 --- On Sept. 12, 2015, 1:35 nachm.,

Re: Review Request 125191: Allow to set minimum user id lower than 1000

marked as submitted. Review request for Plasma and David Edmundson. Changes --- Submitted with commit 9afb3c627bb43969edf1a9bbe83b2107e002eb4f by Wolfgang Bauer to branch Plasma/5.4. Bugs: 347942 https://bugs.kde.org/show_bug.cgi?id=347942 Repository: sddm-kcm Description

Review Request 125462: Completely fix broken translations in keyboard KCM advanced page

/media/uploaded/files/2015/09/30/08a4ab30-b7ec-4db2-ae34-dce0bbc9e62e__after.png Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125462: Completely fix broken translations in keyboard KCM advanced page

. - Wolfgang --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125462/#review86152 --- On Sept. 30, 2015, 1:07 nachm., Wolfga

Re: Review Request 125462: Completely fix broken translations in keyboard KCM advanced page

lly generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125462/#review86153 ------- On Sept. 30, 2015, 1:07 nachm., Wolfgang Bauer wrote: > > --- > T

Re: Review Request 125462: Completely fix broken translations in keyboard KCM advanced page

https://git.reviewboard.kde.org/media/uploaded/files/2015/09/30/c3c67172-12fd-4cee-ad78-1a873edb62f2__before.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/09/30/08a4ab30-b7ec-4db2-ae34-dce0bbc9e62e__after.png Thanks, Wolfgang Bauer __

Re: Review Request 125462: Completely fix broken translations in keyboard KCM advanced page

marked as submitted. Review request for Plasma and David Edmundson. Changes --- Submitted with commit 6d192f58efc1f4fc34e4ee1d6d072ba11a6a29a1 by Wolfgang Bauer to branch Plasma/5.4. Bugs: 341527 https://bugs.kde.org/show_bug.cgi?id=341527 Repository: plasma-desktop Description

Review Request 127698: Always write the theme name to plasmarc, also if the default theme is chosen

patch Plasma will fall back to Air. Changing themes or the look&feel still works the same otherwise. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127623: [digital-clock] Fix display of seconds with certain locales

marked as submitted. Review request for Plasma, Kai Uwe Broulik and Martin Klapetek. Changes --- Submitted with commit a7a22de14c360fa5c975e0bae30fc22e4cd7cc43 by Wolfgang Bauer to branch Plasma/5.6. Repository: plasma-workspace Description --- Currently, "Show Seconds&qu

Re: Review Request 127698: Always write the theme name to plasmarc, also if the default theme is chosen

marked as submitted. Review request for Plasma. Changes --- Submitted with commit d884119f5a4a618eb30baaf5cd0ef058269b27f3 by Wolfgang Bauer to branch master. Repository: plasma-framework Description --- Currently, the "name" key is deleted from plasmarc when you

Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

K or Apply. Close it and open it again. The changes are still there now, before they were not applied and reverted to the system defaults. Thanks, Wolfgang Bauer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

mail. To reply, visit: https://git.reviewboard.kde.org/r/128055/#review96036 --- On Mai 30, 2016, 2:33 nachm., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

e/mime/packages/ or ~/.local/share/mime/, if they exist. Enter the file types editor and modify a file type (e.g. add/change the icon), then press OK or Apply. Close it and open it again. The changes are still there now, before they were not applied and reverted to the system defaults. Thanks,

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

marked as submitted. Review request for KDE Frameworks, Plasma and David Faure. Changes --- Submitted with commit c2aa2a46d51793d26dc6e93e60b5933cb1193e56 by Wolfgang Bauer to branch Plasma/5.6. Bugs: 356237 https://bugs.kde.org/show_bug.cgi?id=356237 Repository: kde-cli-tools

Review Request 128703: [kcm_input] Sync KDE4 kdeglobals after writing the KF5 settings

https://git.reviewboard.kde.org/r/128703/diff/ Testing --- Change between single-click and double-click and apply. The KDE4 setting is written correctly now, it is the same as for KF5. Before it was inverted, i.e. the previous one. Thanks, Wolfgang Bauer

Re: Review Request 128703: [kcm_mouse] Sync KDE4 kdeglobals after writing the KF5 settings

me as for KF5. Before it was inverted, i.e. the previous one. Thanks, Wolfgang Bauer

Re: Review Request 128703: [kcm_mouse] Sync KDE4 kdeglobals after writing the KF5 settings

e.cpp 3dbda19 Diff: https://git.reviewboard.kde.org/r/128703/diff/ Testing --- Change between single-click and double-click and apply. The KDE4 setting is written correctly now, it is the same as for KF5. Before it was inverted, i.e. the previous one. Thanks, Wolfgang Bauer

Re: Review Request 128703: [kcm_mouse] Sync KDE4 kdeglobals after writing the KF5 settings

ly, visit: https://git.reviewboard.kde.org/r/128703/#review98435 ------- On Aug. 17, 2016, 4:47 p.m., Wolfgang Bauer wrote: > > --- > This is an automatically gene

Re: Review Request 128703: [kcm_mouse] Sync KDE4 kdeglobals after writing the KF5 settings

128703/#review98441 --- On Aug. 17, 2016, 4:47 p.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://g

Re: Review Request 128703: [kcm_mouse] Sync KDE4 config after writing the KF5 settings, not before

s are written correctly now, they are the same as for KF5. Before, the old settings (before clicking Apply) were saved to KDE4, the Mouse settings in kcminputrc were not written at all. Thanks, Wolfgang Bauer

Re: Review Request 128703: [kcm_mouse] Sync KDE4 config after writing the KF5 settings, not before

r KF5. Before, the old settings (before clicking Apply) were saved to KDE4, the Mouse settings in kcminputrc were not written at all. Thanks, Wolfgang Bauer

Re: Review Request 128703: [kcm_mouse] Sync KDE4 config after writing the KF5 settings, not before

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 4f4da83327e66f125c8dd1749df8efe1b5084945 by Wolfgang Bauer to branch Plasma/5.7. Bugs: 348254 and 367074 https://bugs.kde.org/show_bug.cgi?id=348254 https://bugs.kde.org/show_bug.cgi?id=367074

Re: Review Request 128815: Fix themes list with SDDM 0.14

> On Sept. 2, 2016, 8:17 nachm., Fabian Vogt wrote: > > IMO you should use the same method as sddm, which is hardcoded at configure > > time: "@DATA_INSTALL_DIR@/themes". I agree. This change will still make it use ~/.local/share/sddm/themes/ if it should exist for some reason, and ignore /usr

[Powerdevil] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

https://bugs.kde.org/show_bug.cgi?id=366299 --- Comment #5 from Wolfgang Bauer --- (In reply to Pavel from comment #4) > but as far as I remember, there was a scrollbar on the right side > of the window, so I was able to scroll the frame with settings controls by > using this scrollbar

[Powerdevil] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

https://bugs.kde.org/show_bug.cgi?id=366299 --- Comment #7 from Wolfgang Bauer --- (In reply to Pavel from comment #6) > (In reply to Wolfgang Bauer from comment #5) > > For now, just open the settings in systemsettings5 ("Configure Desktop" in > > openSUSE), and they w

D14493: fontinst quits after KJob is done

wbauer added a comment. I can confirm that this patch does fix the problem with installing several fonts at once systemwide here. And fontinst still exits after some time of idleness. Btw, there's also BUG:349673 about the same problem. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D14493: fontinst quits after KJob is done

wbauer added a comment. Wouldn't it make sense to push this to the 5.12 and 5.13 branches as well? After all, there are quite a lot of bug reports about this... Should be answered by some Plasma developer though, I suppose. ;-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https:/

D14863: [kconf_update] Add "gtk-primary-button-warps-slider=0" to generated GTK3 config

wbauer created this revision. wbauer added reviewers: Breeze, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. wbauer requested review of this revision. REVISION SUMMARY This brings the default GTK3 settings more in line with Qt's behavior, and it's also the defa

D14863: [kconf_update] Add "gtk-primary-button-warps-slider=0" to generated GTK3 config

This revision was automatically updated to reflect the committed changes. Closed by commit R98:f5121ba89abf: [kconf_update] Add "gtk-primary-button-warps-slider=0" to generated GTK3 config (authored by wbauer). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.

D15598: Sort icon and cursor themes case-insensitively

wbauer added a comment. Well, I tried this patch (applied upon 4.13.90a) and it doesn't seem to change anything. I still get icon and cursor themes starting with a lower-case character sorted after all those with an upper-case character. I suppose that's because, according to the QSort

D15598: Sort icon and cursor themes case-insensitively

wbauer added a comment. In D15598#328747 , @wbauer wrote: > I suppose that's because, according to the QSortFilterProxyModel docs, `At this point, neither sorting nor filtering is enabled; the original data is displayed in the view.` > Appare

D15598: Sort icon and cursor themes case-insensitively

wbauer added a comment. In D15598#328791 , @broulik wrote: > > Although, I think that would need to be done every time the data changes. > > `QSortFilterProxyModel` does that automatically You mean it will keep the data sorted after ch

D15598: Sort icon and cursor themes case-insensitively

wbauer added a comment. Works (and looks) fine for me now. Btw, it wouldn't really be necessary to call `setSortRole(Qt::DisplayRole)`, as the default value is `Qt::DisplayRole` anyway. (but of course doing it is not wrong either...) REPOSITORY R99 KDE Gtk Configuration Tool BRANCH

D15598: Sort icon and cursor themes case-insensitively

wbauer added a comment. In D15598#328967 , @ngraham wrote: > Darn, looks like arc didn't notice my rebase on 5.14. Oh well, I guess this'll go into 5.15. Well, you could cherry-pick it into the 5.14 branch (using `git cherry-pick xxx`).

D17187: Set the default cursor theme to breeze_cursors

wbauer added a comment. Actually, if the cursor theme is not set to anything, GTK would just use the session's default. And that's how it should be IMHO. But at least in openSUSE, the cursor theme is explicitly set to Adwaita in the system-wide GTK config, /etc/gtk-3.0/settings.ini . REPOS

D17187: Set the default cursor theme to breeze_cursors

wbauer added a comment. In D17187#367118 , @fvogt wrote: > In D17187#367110 , @wbauer wrote: > > > Actually, if the cursor theme is not set to anything, GTK would just use the session's default. I.e.

D17187: Set the default cursor theme to breeze_cursors

wbauer added a comment. In D17187#367565 , @ngraham wrote: > That's a pre-existing bug: https://bugs.kde.org/show_bug.cgi?id=401507 That's not the full truth though. The cursor theme KCM will affect the default theme of the whole session

D17187: Set the default cursor theme to breeze_cursors

wbauer added a comment. In D17187#367366 , @fvogt wrote: > > The same happens already if one uses the GTK KCM though, as it will always write a cursor theme entry too. > > Yes, that can be unexpected - even by not changing the cursor theme e

  1   2   >