Re: Travel to Sprint tomorrow

2012-06-10 Thread Vishesh Handa
Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-25 Thread Vishesh Handa
//r/105329/#scomment50> Shouldn't this text be centered? I think it should be similar to that of Categories. Same thing for "Get new widgets", "Activities", and "Add Widgets" - Vishesh Handa On June 2

Re: [Nepomuk] porting stuff to Nepomuk2

2012-07-11 Thread Vishesh Handa
.9 cause there are some problems with the current rcgen which I would like to fix at some point. Btw, I don't really understand the NepomukAddOntologyClasses.cmake, so I hope it works :) > Cheers, > Marco Martin > > ___ > Nepomuk mailing list > nepo..

Re: [Nepomuk] porting stuff to Nepomuk2

2012-07-11 Thread Vishesh Handa
On Wed, Jul 11, 2012 at 7:35 PM, Marco Martin wrote: > On Wednesday 11 July 2012, Vishesh Handa wrote: > > On Tue, Jul 10, 2012 at 3:25 PM, Marco Martin wrote: > > > Yo all, > > > I tried to port some stuff to Nepomuk2, namely kactivities and > > > plasma-mo

Re: [Nepomuk] porting stuff to Nepomuk2

2012-07-11 Thread Vishesh Handa
On Wed, Jul 11, 2012 at 10:20 PM, Marco Martin wrote: > On Wednesday 11 July 2012, Vishesh Handa wrote: > > > > > > I'm not sure what is the policy of cmake files, if they should be > > > scattered together their framework or if they are still wanted in a >

Re: [Nepomuk] porting stuff to Nepomuk2

2012-07-18 Thread Vishesh Handa
On Thu, Jul 12, 2012 at 10:37 PM, Marco Martin wrote: > On Wednesday 11 July 2012, Vishesh Handa wrote: > > > > uses nepomuk2_rcgen. Cause I don't think the packagers would like us > > > > > > having > > > > > > > 2 pacakges (nepomuk-c

Review Request: Make the Nepomuk runner forward all the nie:urls

2012-07-26 Thread Vishesh Handa
/generic/runners/nepomuksearch/nepomuksearchrunner.cpp 0ea308d Diff: http://git.reviewboard.kde.org/r/105738/diff/ Testing --- Yup. Emails open up with KMail. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request: Make the Nepomuk runner forward all the nie:urls

2012-07-27 Thread Vishesh Handa
view16511 --- On July 26, 2012, 5:25 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewb

Re: Review Request: Make the Nepomuk runner forward all the nie:urls

2012-07-30 Thread Vishesh Handa
we can ignore this. It can go in 4.9.1. - Vishesh --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105738/#review16520 -------

Review Request: NepomukRunner: Port to NepomukCore

2012-08-22 Thread Vishesh Handa
/nepomuksearch/queryclientwrapper.h 48c1eaa plasma/generic/runners/nepomuksearch/queryclientwrapper.cpp 0b828b0 Diff: http://git.reviewboard.kde.org/r/106117/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel

Review Request: Nepomuk Runner: Port to Query::ResultIterator

2012-10-01 Thread Vishesh Handa
/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: NepomukRunner: Redirect the 'nepomuk:/res/uuid' urls before opening them

2013-01-09 Thread Vishesh Handa
t this is something that will have to be fixed. This addresses bug 287259. http://bugs.kde.org/show_bug.cgi?id=287259 Diffs - plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp 8075a6b Diff: http://git.reviewboard.kde.org/r/108305/diff/ Testing --

Re: Review Request: Show album art in krunner results.

2013-01-10 Thread Vishesh Handa
ttp://git.reviewboard.kde.org/r/108316/#comment19254> How about using 'toUrl().toLocalFile()' instead? That will remove the file prefix. - Vishesh Handa On Jan. 10, 2013, 5:35 a.m., Emil Sedgh wrote: > > --- >

Re: reflecting on 4.10

2013-01-11 Thread Vishesh Handa
. It might be better to allocate different people to different parts of Plasma & Kwin. Preferably based on their configuration. We could even make up a page of who uses what kind of configuration (generally), and accordingly see what isn't being covered. >

Re: [RFC] Invite Razor-Qt to next Workspaces Sprint

2013-02-17 Thread Vishesh Handa
> Even though there are joins at every turn, I haven't found that to be a problem with virtuoso. Though I have been dreaming about "maybe" implementing something like this [1] on top of QtSql. While it has its benefits, I'm not sure it would be a good idea. We should f

Review Request 110467: Plasma Wallpaper BackgroundListModel: Avoid using KFileMetaInfo

2013-05-16 Thread Vishesh Handa
image/backgroundlistmodel.cpp c4093a7 Diff: http://git.reviewboard.kde.org/r/110467/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 110465: Plasma Wallpaper BackgroundListModel: Remember to clear the caches

2013-05-16 Thread Vishesh Handa
clear m_packages, clear the m_sizeCache and m_previews as well Diffs - plasma/generic/wallpapers/image/backgroundlistmodel.cpp c4093a7 Diff: http://git.reviewboard.kde.org/r/110465/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel ma

Activities - Storing ResourceScoreCache in Nepomuk

2013-05-20 Thread Vishesh Handa
now is a good time to get rid of it if it actually not required. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Activities - Storing ResourceScoreCache in Nepomuk

2013-05-22 Thread Vishesh Handa
1/06/06/randa-and-ontologies-and-whatnot/ ? Considering that none of the others parts of this have been implement and there seems to be no roadmap to implement them - I do not think we should be adding unnecessary stuff. > Cheerio, > Ivan > > > > On 20 May 2013 21:38, Mar

Re: Activities - Storing ResourceScoreCache in Nepomuk

2013-05-22 Thread Vishesh Handa
> -- > A program that has not been tested does not work. > -- Bjarne Stroustrup > > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > -- Vishesh Handa __

Re: Activities - Storing ResourceScoreCache in Nepomuk

2013-05-22 Thread Vishesh Handa
ves... > -- Monty Python's Flying Circus > > _______ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Activities - Storing ResourceScoreCache in Nepomuk

2013-05-22 Thread Vishesh Handa
r 4.11 > > Cheerio, > Ivan > > -- > Money can't buy happiness, but neither can poverty. > -- Leo Rosten > > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-

Re: Activities - Storing ResourceScoreCache in Nepomuk

2013-05-28 Thread Vishesh Handa
uld be needed to > implement a > new "queryprovider" that does it > (in plasma-mobile/components/metadatamodel/library/queryproviders/) > > i would be interested to try it to see wether is possible to make it fast > enough for regular use > > -- > Marco Marti

Re: Activities - Storing ResourceScoreCache in Nepomuk

2013-05-28 Thread Vishesh Handa
t; Ivan > > > -- > Money can't buy happiness, but neither can poverty. > -- Leo Rosten > > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > > -- Vishesh

Re: [RFC] Moving Wishlist Items to Brainstorm

2013-05-28 Thread Vishesh Handa
reports in Nepomuk and use the template described. As a developer, I never look at the feature requests. Also, most of them are useless. > Cheers > Martin > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Introducing Milou

2013-09-04 Thread Vishesh Handa
arativeItem which does so. I'm still working out this concept of previews, and how I'm going to implement it. - A dedicated application for searching which can be connected to this plasmoid for showing more search results, and to allow the user to filter them better. Any comments

Re: Introducing Milou

2013-09-05 Thread Vishesh Handa
. It goes without saying that these features should go into the Plasma Runner API. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Nepomuk in 4.13 and beyond

2013-12-12 Thread Vishesh Handa
at it is a step in the right direction. I'd recommend using Milou [3] for searching. -- Vishesh Handa [1] https://projects.kde.org/projects/playground/base/baloo [2] http://techbase.kde.org/Projects/Baloo [3] https://projects.kde.org/projects/playground/base/milou _

Re: Review Request 114429: use of time data engine -> less code

2013-12-13 Thread Vishesh Handa
ome/HomeScreenText.qml <http://git.reviewboard.kde.org/r/114429/#comment32595> If this is not required then please remove it. - Vishesh Handa On Dec. 13, 2013, 7:07 a.m., Heena Mahour wrote: > > --- > This is an aut

Notes from "KRunner Breakout"

2014-01-16 Thread Vishesh Handa
o, comments and opinions are welcome. -- Vishesh Handa [1] https://projects.kde.org/projects/playground/base/milou [2] http://vhanda.in/milou.png ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Notes from "KRunner Breakout"

2014-01-17 Thread Vishesh Handa
On Friday 17 January 2014 16:32:18 Eike Hein wrote: > On Thursday 16 January 2014 21:15:02 Vishesh Handa wrote: > > * Runner Library needs a certain amount of work > > - Add item type capabilities to the results > > - Add preview capabilities > > - Refactor so that a

Re: [Kde-pim] Baloo based Qml API for (Active) Mail + Plasma

2014-01-23 Thread Vishesh Handa
> Cheers > > Mike > > > > [1] http://mail.kde.org/pipermail/plasma-devel/2013-November/027148.html > [2] > https://drive.google.com/file/d/0B2wLkUtvD4v_MG80amViR2pZZ1k/edit?usp=sharin > g ___ > KDE PIM mailing list kde-...@kde.org > https://mail.kde.org/mailman/listinfo/kde-pim > KDE PIM home page at http://pim.kde.org/ -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Animation durations

2014-02-02 Thread Vishesh Handa
animations. > if due to that central configuration units will report 0 as those lengths, > that's ok I like the fact that I can still have animations, but that they aren't very slow and annoying. To quote Obi-Wan Kenobi - "Only a Sith

Moving Milou to Extragear

2014-02-11 Thread Vishesh Handa
features will be added to the krunner framework. I could really use a review for the QML code, hence the plasma-devel cc. -- Vishesh Handa [1] http://vhanda.in/milou.png ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Moving Milou to Extragear

2014-02-12 Thread Vishesh Handa
On Tuesday, February 11, 2014 11:48:44 PM Albert Astals Cid wrote: > > Repo name? Oops. It's called milou. Clone it via the standard - kde:milou -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailm

Re: Moving Milou to Extragear

2014-02-13 Thread Vishesh Handa
On Wednesday, February 12, 2014 11:56:27 PM Albert Astals Cid wrote: > El Dimarts, 11 de febrer de 2014, a les 11:55:01, Vishesh Handa va escriure: > > Hello people > > > > I've been developing Milou for quite some time now and I think it would be > > best to

Re: Moving Milou to Extragear

2014-02-13 Thread Vishesh Handa
On Wednesday, February 12, 2014 11:57:56 PM Albert Astals Cid wrote: > > Also you can optimize > qDeleteAll(m_mapping.values()); > to > qDeleteAll(m_mapping); > Thanks. Fixed -- Vishesh Handa ___ Plasma-devel mailing list Pl

Re: Review Request 116577: Call malloc_trim() when deleting a dialog

2014-03-12 Thread Vishesh Handa
> On March 3, 2014, 8:51 p.m., Martin Gräßlin wrote: > > recommendation: look at kwin/main.cpp kdemain() > > David Edmundson wrote: > Thanks. > > Copy and pasted for lazy: > > #ifdef M_TRIM_THRESHOLD > // Prevent fragmentation of the heap by malloc (glibc). >

Re: Polishing sprint in May: dates?

2014-03-20 Thread Vishesh Handa
not take part in this sprint, > given my exams, GSoC 2014 and probably I will increase sprint budget > (around 700 EUR, my ticket cost).. :P > Please don't worry about the sprint budget. Add your dates to the sprint, and we can accordingly pick a date. It'll be goo

Re: Problems found by the CI system

2014-03-24 Thread Vishesh Handa
ements are used in the CMake logic. > I've pushed a commit. That should hopefully fix it. Could you perhaps add some hook to email me about these failures? We don't have a dedicated mailing list for Baloo and I'm not sure if notifying kde- devel would b

Review Request 117374: Add a kded module for ksysguard

2014-04-04 Thread Vishesh Handa
17374/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117374: Add a kded module for ksysguard

2014-04-07 Thread Vishesh Handa
d on Ctrl + Escape - Vishesh --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117374/#review55023 --- On April 4, 2014,

Review Request 117447: Runner - QueryMatch: Allow each match to give a category

2014-04-09 Thread Vishesh Handa
--- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117447: Runner - QueryMatch: Allow each match to give a category

2014-04-09 Thread Vishesh Handa
videos files in your filesystem. We need to give some distinction between local videos and external videos. - Vishesh --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117447/#review55

Review Request 117449: KRunner: No need to reimplement tab/backspace/etc

2014-04-09 Thread Vishesh Handa
Description --- We can just forward our keys to the Milou.ResultsView and that handles all of these. With this the arrow keys also work. Diffs - Diff: https://git.reviewboard.kde.org/r/117449/diff/ Testing --- Thanks, Vishesh Handa

Review Request 117450: Add Milou to the default panel layout

2014-04-09 Thread Vishesh Handa
://git.reviewboard.kde.org/r/117450/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117449: KRunner: No need to reimplement tab/backspace/etc

2014-04-10 Thread Vishesh Handa
Diffs (updated) - lookandfeel/contents/runcommand/RunCommand.qml d8d7874 Diff: https://git.reviewboard.kde.org/r/117449/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/lis

Re: Review Request 117450: Add Milou to the default panel layout

2014-04-10 Thread Vishesh Handa
erently than how Milou displays stuff, it would look quite strange. - Vishesh --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117450/#review55333 ------

Re: Review Request 117447: Runner - QueryMatch: Allow each match to give a category

2014-04-10 Thread Vishesh Handa
n wrote: > uhm, i can easily think about different runners returning website urls, > or resutls of type "video" regardless if is a search on the filesystem or > from a youtube runner.. > > Vishesh Handa wrote: > * I like the idea of having a sensible default. A Misc sec

Re: Review Request 117447: Runner - QueryMatch: Allow each match to give a category

2014-04-10 Thread Vishesh Handa
n wrote: > uhm, i can easily think about different runners returning website urls, > or resutls of type "video" regardless if is a search on the filesystem or > from a youtube runner.. > > Vishesh Handa wrote: > * I like the idea of having a sensible default. A Misc sec

Re: Review Request 117449: KRunner: No need to reimplement tab/backspace/etc

2014-04-10 Thread Vishesh Handa
/RunCommand.qml d8d7874 Diff: https://git.reviewboard.kde.org/r/117449/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117447: Runner - QueryMatch: Allow each match to give a category

2014-04-10 Thread Vishesh Handa
n wrote: > uhm, i can easily think about different runners returning website urls, > or resutls of type "video" regardless if is a search on the filesystem or > from a youtube runner.. > > Vishesh Handa wrote: > * I like the idea of having a sensible default. A Misc sec

Re: Review Request 117481: Remove "Open Wallpaper Image" entry on the menu

2014-04-10 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117481/#review55394 --- Ship it! Ship It! - Vishesh Handa On April 10, 2014, 2:23

Re: Review Request 117450: Add Milou to the default panel layout

2014-04-12 Thread Vishesh Handa
generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117450/#review55488 ----------- On April 9, 2014, 3:22 p.m., Vishesh Handa wrote: > > --- > This

Re: Review Request 117450: Add Milou to the default panel layout

2014-04-12 Thread Vishesh Handa
lly correct" by arguing that they do launch applications. In that sense, yes they do and so do other search results. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117450: Add Milou to the default panel layout

2014-04-12 Thread Vishesh Handa
uot; in osx is perfectly fine where spotlight > is because they don't have a menu with another search field just at the > other side of the panel. A search field which is mostly hidden and does NOT provide the same ease of use as KRunner/Milou. But if we don't care about ea

Re: Review Request 117450: Add Milou to the default panel layout

2014-04-12 Thread Vishesh Handa
nt" if they do the same thing, which they clearly do not. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117450: Add Milou to the default panel layout

2014-04-12 Thread Vishesh Handa
ool to have from a technical showcase point of view but in reality > it's just not used that way. If people even know it's there to begin > with. you have no data to back that up claim up. This statement can be made both ways - I know people who love the calculator and the oth

Re: Review Request 117450: Add Milou to the default panel layout

2014-04-12 Thread Vishesh Handa
ke to take a decision now. We can then decide from a quality assurance point of view if adding such a feature is worth the risks for this release. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listi

Re: Review Request 117447: Runner - QueryMatch: Allow each match to give a category

2014-04-13 Thread Vishesh Handa
src/querymatch.cpp 83888f7 Diff: https://git.reviewboard.kde.org/r/117447/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117450: Add Milou to the default panel layout

2014-04-15 Thread Vishesh Handa
because of KRunner. Diffs - desktoppackage/contents/layout.js 303e7af Diff: https://git.reviewboard.kde.org/r/117450/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Continued: milou/kickoff/whatever menu

2014-04-17 Thread Vishesh Handa
g more consistent, it also shows a good feedback to > "you narrowed the search" , you "zoomed in" > > comments? ;) It's doesn't look bad, but it is inconsistent. How about we take a step back and re-evaluate all of this after this initial release? We ha

Re: Polishing sprint in May: dates?

2014-04-24 Thread Vishesh Handa
should get moving I think? I didn't realize I had to ask the board, and now we don't have enough time. We're supposed to ask 1 month in advance. Given that this is just supposed to be a *bug fixing* sprint. Is it really required? Cause that is what everyone working on Plasma

Re: Review Request 117800: Move tests inside libs/mediacenter and make them compile with the library sources instead of linking to libplasmamediacenter

2014-04-29 Thread Vishesh Handa
u may want to generate the diff via --find-copies-harder - Vishesh Handa On April 29, 2014, 9:39 a.m., Shantanu Tushar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 117915: Fetch photo-taken Date/Time for Images and file created Date/Time for other files

2014-05-02 Thread Vishesh Handa
gins/baloosearch/searchresulthandler.cpp <https://git.reviewboard.kde.org/r/117915/#comment39794> Please keep in mind that this is sync, and you'll be blocking. You want to put it another thread via the Runnable if you want it to be async. - Vishesh Handa On May 1, 2014, 6:06

Re: RFC: Change Krunner's default key shortcut for Next

2014-05-12 Thread Vishesh Handa
So if there are no objections, I'll change the primary shortcut to > Alt+space while keeping Alt+F2 as a secondary one. > Do it. Currently the secondary shortcut is set to Alt + Shift + F2. I don't think any of us will miss this. -- Vishesh Handa ___

Review Request 118148: KRunner: Add the concept of disabled categories

2014-05-15 Thread Vishesh Handa
75fb9ef Diff: https://git.reviewboard.kde.org/r/118148/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118148: KRunner: Add the concept of disabled categories

2014-05-15 Thread Vishesh Handa
sh --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118148/#review58008 ------- On May 15, 2014, 2:37 p.m., Vishesh Handa wrote: >

Re: plasma packages in kde-workspace

2014-05-21 Thread Vishesh Handa
o become a framework at some point. > > Jonathan > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma packages in kde-workspace

2014-05-21 Thread Vishesh Handa
On Wed, May 21, 2014 at 4:59 PM, Marco Martin wrote: > > That should be fine, if as in kde-workspace times, if the policy is kept to > workspace can contain libraries, but won't guarantee compatibility until > moved > in frameworks > Okay. No objections from me th

Re: Review Request 117374: Add a kded module for ksysguard

2014-05-22 Thread Vishesh Handa
ksysguard/ksystemactivitydialog.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117374/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118148: KRunner: Add the concept of disabled categories

2014-05-22 Thread Vishesh Handa
/abstractrunner.cpp c64c510 src/runnercontext.h 0fe0038 src/runnercontext.cpp f58bab6 src/runnermanager.h 94d0454 src/runnermanager.cpp 75fb9ef Diff: https://git.reviewboard.kde.org/r/118148/diff/ Testing --- Thanks, Vishesh Handa

Review Request 118469: KRunner: Stop using the dialog class

2014-06-02 Thread Vishesh Handa
er of repaints/resizes are much less. Tested by comparing frames via apitrace. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118469: KRunner: Stop using the dialog class

2014-06-02 Thread Vishesh Handa
14/06/02/3b64d656-f080-437b-be5e-8d8e0a3e10ee__krunner-dialog.png KRunner without dialog https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/84f19377-f984-4c17-887e-b661fb5ec9b1__krunner-nodialog.png Thanks, Vishesh Handa ___ Plasma-

Re: Review Request 118386: Give milou proper version

2014-06-10 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118386/#review59681 --- Ship it! - Vishesh Handa On May 28, 2014, 7:07 p.m

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

2014-06-10 Thread Vishesh Handa
point of view, I would like to avoid it. - Vishesh Handa On June 4, 2014, 6:28 a.m., Matthew Dawson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 118148: KRunner: Add the concept of disabled categories

2014-06-10 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118148/#review59712 --- ping - Vishesh Handa On May 22, 2014, 2:59 p.m., Vishesh

Re: Review Request 118469: KRunner: Stop using the dialog class

2014-06-10 Thread Vishesh Handa
-437b-be5e-8d8e0a3e10ee__krunner-dialog.png KRunner without dialog https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/84f19377-f984-4c17-887e-b661fb5ec9b1__krunner-nodialog.png Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

2014-06-11 Thread Vishesh Handa
KF5KFileMetaDataConfig.cmake instead? This way there will be no conflicts, and it will be consistent with the rest of the frameworks as well? - Vishesh Handa On June 4, 2014, 6:28 a.m., Matthew Dawson wrote: > > --- > This is an automatically generat

Moving Parts of Baloo into the Workspace

2014-06-11 Thread Vishesh Handa
will obviously result in Baloo being a compile time dependency for plasma-workspace. If anyone has any objections please speak up. I'll do the move on Monday. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.o

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

2014-06-11 Thread Vishesh Handa
> On June 11, 2014, 11 a.m., Vishesh Handa wrote: > > How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead? > > This way there will be no conflicts, and it will be consistent with the > > rest of the frameworks as well? > > Aleix Pol Gonzale

Re: Moving Parts of Baloo into the Workspace

2014-06-11 Thread Vishesh Handa
non-kde point of view. If you want a file indexer, you probably don't want to drag in KCMUtils. Additionally, it would be nice to combine the (hypothetical) runners kcms with the baloo one. For now, lets leave the kcm in Baloo. -- Vishesh Handa ___ Pl

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

2014-06-11 Thread Vishesh Handa
s an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118512/ > --- > > (Updated June 4, 2014, 6:28 a.m.) > > > Review request for Plasma, Jonathan Riddell and Vishesh Handa. > > &g

Re: Review Request 118148: KRunner: Add the concept of disabled categories

2014-06-11 Thread Vishesh Handa
0fe0038 src/runnercontext.cpp f58bab6 src/runnermanager.h 94d0454 src/runnermanager.cpp 75fb9ef Diff: https://git.reviewboard.kde.org/r/118148/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

2014-06-11 Thread Vishesh Handa
> On June 11, 2014, 11 a.m., Vishesh Handa wrote: > > How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead? > > This way there will be no conflicts, and it will be consistent with the > > rest of the frameworks as well? > > Aleix Pol Gonzale

Re: Review Request 118357: Disable the agenda part of the calendar

2014-06-12 Thread Vishesh Handa
have been showcasing our calendar widget a LOT. It was the only thing that was shown during FOSDEM. Do we want to change that? - Vishesh Handa On June 2, 2014, 12:44 p.m., Martin Klapetek wrote: > > --- > This is an automatically g

Re: Review Request 118357: Disable the agenda part of the calendar

2014-06-13 Thread Vishesh Handa
> On June 12, 2014, 10:25 a.m., Vishesh Handa wrote: > > I seem to have missed this change. > > > > The rationale behind this change is that there is no PIM support and > > therefore we should remove it. I'm sure you guys would have thought about > &g

Review Request 118731: AbstractRunner: Add an iconForCategory virtual function

2014-06-13 Thread Vishesh Handa
://git.reviewboard.kde.org/r/118731/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118779: [krunner] Add Qt::Key_Search as a global shortcut

2014-06-16 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118779/#review60188 --- Ship it! Ship It! - Vishesh Handa On June 16, 2014, 11:45

Re: Review Request 118512: Turn KFileMetaData into a Framework.

2014-06-16 Thread Vishesh Handa
is not you - https://git.reviewboard.kde.org/r/118670/ Would you mind dropping this? His patch is ready to be shipped. - Vishesh Handa On June 14, 2014, 10:40 p.m., Matthew Dawson wrote: > > --- > This is an automatically generat

Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

2014-06-17 Thread Vishesh Handa
l/contents/runcommand/RunCommand.qml 7a0503d Diff: https://git.reviewboard.kde.org/r/118791/diff/ Testing --- File Attachments Krunner in its full view https://git.reviewboard.kde.org/media/uploaded/files/2014/06/17/a5743542-405a-4346-aa26-ac915821__krunner.png Thanks

Review Request 118792: PowerDevil: Show the brightness OSD on pressing the brightness key

2014-06-17 Thread Vishesh Handa
: powerdevil Description --- See title Diffs - daemon/actions/bundled/brightnesscontrol.cpp 59bbbcc Diff: https://git.reviewboard.kde.org/r/118792/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

2014-06-17 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118791/#review60230 ------- On June 17, 2014, 11:07 a.m., Vishesh Handa wrote: > > ---

Re: Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

2014-06-17 Thread Vishesh Handa
y sure that the results will fit the > > screen. I think you can leave the scroll area, but try to expand it as > > needed, even until it goes to touch the bottom margin of the screen (or > > near to it) and the scrollarea would almost never show a scrollbar, except > > c

Re: Review Request 118792: PowerDevil: Show the brightness OSD on pressing the brightness key

2014-06-17 Thread Vishesh Handa
marked as submitted. Review request for Plasma, Solid and Àlex Fiestas. Repository: powerdevil Description --- See title Diffs - daemon/actions/bundled/brightnesscontrol.cpp 59bbbcc Diff: https://git.reviewboard.kde.org/r/118792/diff/ Testing --- Thanks, Vishesh Handa

Re: Review Request 118797: Port webshortcuts runner

2014-06-17 Thread Vishesh Handa
. runners/webshortcuts/CMakeLists.txt <https://git.reviewboard.kde.org/r/118797/#comment42034> Is DBus being used? runners/webshortcuts/CMakeLists.txt <https://git.reviewboard.kde.org/r/118797/#comment42035> Ditto - Vishesh Handa On June 17, 2014, 2:53 p.m., Roha

Re: Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

2014-06-17 Thread Vishesh Handa
w https://git.reviewboard.kde.org/media/uploaded/files/2014/06/17/a5743542-405a-4346-aa26-ac915821__krunner.png Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

2014-06-19 Thread Vishesh Handa
y sure that the results will fit the > > screen. I think you can leave the scroll area, but try to expand it as > > needed, even until it goes to touch the bottom margin of the screen (or > > near to it) and the scrollarea would almost never show a scrollbar, except > > c

Re: Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

2014-06-19 Thread Vishesh Handa
rd.kde.org/media/uploaded/files/2014/06/17/a5743542-405a-4346-aa26-ac915821__krunner.png Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118731: AbstractRunner: Add an iconForCategory virtual function

2014-06-20 Thread Vishesh Handa
KCM. Diffs - src/abstractrunner.h 0958a28 src/abstractrunner.cpp a48fd0c Diff: https://git.reviewboard.kde.org/r/118731/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

  1   2   3   4   >