Review Request: adding default colors format for kolourpicker and support for latex colors.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1669/ --- Review request for Plasma. Summary --- remvoes the default menu that appear

Re: Review Request: adding default colors format for kolourpicker and support for latex colors.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1669/ --- (Updated 2009-09-21 13:01:00.808581) Review request for Plasma. Changes --

Re: Review Request: adding default colors format for kolourpicker and support for latex colors.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1669/ --- (Updated 2009-09-21 13:11:09.327288) Review request for Plasma. Changes --

Review Request: added support for collors and size on fifteenpuzzle.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1706/ --- Review request for Plasma. Summary --- colors are now configurable, and num

Re: Review Request: added support for collors and size on fifteenpuzzle.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1706/ --- (Updated 2009-09-24 15:01:36.918350) Review request for Plasma. Changes --

Re: Review Request: added support for collors and size on fifteenpuzzle.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1706/ --- (Updated 2009-09-24 15:05:37.627922) Review request for Plasma. Changes --

Review Request: support for latex colours in kolorpicker.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1747/ --- Review request for Plasma and Pino Toscano. Summary --- adds support for la

Review Request: fileWatcher - removed depreceated method.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2267/ --- Review request for Plasma. Summary --- Removed a depreceated method, change

Re: Review Request: support for latex colours in kolorpicker.

ress on this patch? > > > - Beat > > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1747/#review2812 > --------

Re: KDE architecture diagram

an scientist after all, but you will not see a thing about paleobathymetry or stratigraphy in anything that I write if the focus is people outside of my area of knowledge. Best Regards, Ana Cristina" And I agree with her, she has a very good point.

Re: Where can I define my widget's preference?

On Thu, Jun 28, 2012 at 6:49 AM, gaoxiang wrote: > I think I'm having trouble with documentions.  These documentations gives > little information.  I have not find any tutorials or documentations on where > and how my widget's preference should be defined so I have to ask here. > Please give some

Re: How Can I change wallpaper from CLI?

2012/9/5 Weng Xuetian : > On Wed, Sep 5, 2012 at 9:48 AM, kevinzhow wrote: >> hello~ >> >> Sorry to brother,I don not know which channel should i send this mail >> exactly , so i send this mail to kde, kde-devel and ode-core-devel, but i >> really need this help, please This looks like the KDE

Re: Re: Introducing Homerun

>From my side ( since I can relate to nuno's ), what I have currently open on my desktop is: Qt Designer, Qt Assistant, KDevelop ( I know that there's an integrated doc view, but I don't like it to be always attached ), Firefox/Chrome ( one of both, zillions of tabs opened ), Bangarang, Dolphin, G

Re: Re: Re: Introducing Homerun

never actually did see that option before, never paid attention, since I write 'dol' and quicly hit enter after that. ) 2012/11/13 Tomaz Canabrava > So krunner is broken and I should step in to fix that :) > just tried here ( alt+f2, dolphin, repeat 6 times ) and I got a looo

Re: Introducing Homerun

Platform Version 4.9.3 , latest stable - arch build. 2012/11/13 Marco Martin > On Tuesday 13 November 2012, Tomaz Canabrava wrote: > > So krunner is broken and I should step in to fix that :) > > just tried here ( alt+f2, dolphin, repeat 6 times ) and I got a looot of >

Re: Re: Introducing Homerun

ay 13 November 2012 12:00:08 Tomaz Canabrava wrote: >> >>> Platform Version 4.9.3 , latest stable - arch build. >>> >> Lol, here works like in Tomaz... Something seems broken then. >> > is the windows runner activated? > >

Re: kdeobservatory seems to be missing a qwt min version check

It used to work on the SVN, needs to be ported to Git. /me downloading it to see if I can revive it. On Tue, Jun 4, 2013 at 2:22 PM, Albert Astals Cid wrote: > El Dilluns, 3 de juny de 2013, a les 21:22:42, Sandro Andrade va escriure: > > Hi there, > > > > That's actually intended to be moved t

Re: Plasma Addons

On Sat, May 24, 2014 at 10:32 AM, Marco Martin wrote: > On Saturday, May 24, 2014, Martin Graesslin wrote: >> I support David on this one. I think we have better ways to spend our >> development resources than to pick up some dead code and port it to QML. > > I think the best thing is to list the

Re: modifying the drawer menus

On Wed, Jan 6, 2016 at 6:29 PM, Marco Martin wrote: > On Wednesday 06 January 2016, Dirk Hohndel wrote: > > I'm sure this email will mostly just expose my ignorance - but I'm OK > with > > that :-) -- I asked on IRC but I think no one was around who knew. > > > > I want to be able to change t

Re: modifying the drawer menus

On Wed, Jan 6, 2016 at 6:39 PM, Marco Martin wrote: > On Wednesday 06 January 2016, Tomaz Canabrava wrote: > > We need a menu that will change its contents based on whats being > displayed > > on the main part of the application. > > > > Somethi

GSoC on Porting Plasmoids to QML

Hy All, A bunch of you already know me, and I do plan to apply for the Porting Plasmoids to QML. I already worked a bit with plasmoids ( trying some Widgets using plasma and have a lot of code in the fifteen puzzle plasmoid & other some hacks that were not accepted ). I do have a solid knowledge

Re: GSoC on Porting Plasmoids to QML

011, Tomaz Canabrava wrote: >> Hy All, >> >> A bunch of you already know me, and I do plan to apply for the Porting >> Plasmoids to QML. I already worked a bit with plasmoids ( trying some >> Widgets using plasma and have a lot of code in the fifteen puzzle >> pla

Re: GSoC on Porting Plasmoids to QML

On Tue, Feb 22, 2011 at 4:18 PM, Marco Martin wrote: > On Tuesday 22 February 2011, Tomaz Canabrava wrote: >> Not gonna happen here, Already started talking about the project in the ML. >> Also already started learning QML, and seeing what can be done for the >> plasmoids.

Re: GSoC on Porting Plasmoids to QML

Already downloaded the Plasmoids from SVN and studying QML. if anything that I should know beforehand, please state them. On Tue, Feb 22, 2011 at 5:42 PM, Marco Martin wrote: > On Tuesday 22 February 2011, Artur de Souza wrote: >> Quoting Tomaz Canabrava : >> > Not gonna v

Re: GSOC 2011 QMLify widgets or something

Travis, we can talk about the qmlfying plasmoids, I want to get a SoC with QML on it, so it's one more thing to learn, one thing I was thinking, the Kopete interface could be all qmlfyed ( the nick list ). On Wed, Feb 23, 2011 at 5:10 PM, Marco Martin wrote: > On Wednesday 23 February 2011, Travi

Re: The future of virtual desktops

Kun Zhang, actually windows are managed by virtual desktops in kde 4.6 On Fri, Feb 25, 2011 at 3:18 AM, Martin Gräßlin wrote: > > - Ursprüngliche Mitteilung - >> Hi all, >> > snip >> What I want to know is the following: Are there any plans or outlines >> regarding how to proceed with vir

Re: GSoC: QMLify Plasmoids

libplasma2 only exists in the developers heads. On Mon, Feb 28, 2011 at 9:47 AM, Viranch Mehta wrote: > Hi, > I know it has been a long while I haven't turned up with any work. I'm kind > of caught up with my semester very badly (not an excuse, I know). Anyhow, I > had some very basic questions r

Re: Combining the 4 notes plasmoids into 1

On Fri, Aug 12, 2011 at 7:47 PM, Rohan Garg wrote: > Hey! > I discussed this idea with the KDE PIM team in the PIM BoF today at DS, and > later on with Marco, and i think we have too many notes plasmoids and we > could do better by just combining all of them into one plasmoid, Marco even > suggest

Review Request: Changed the wallpaper virus config. dialog so it looks like the 'image' configuration.

Diff: http://git.reviewboard.kde.org/r/102930/diff/diff Testing --- Screenshots --- http://git.reviewboard.kde.org/r/102930/s/313/ Thanks, Tomaz Canabrava ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listi

Re: Switching activities and keeping applications

On Tue, Nov 8, 2011 at 1:41 PM, Sebastian Kügler wrote: > On Tuesday, November 08, 2011 11:26:11 Fabian Riethmayer wrote: >> I was just talking to sebas on IRC about switching activities and "take" >> all  my applications with me. He said, it was not (easily) possible at the >> moment to switch be

Re: Plasma Widgets in Qt-designer

On Tue, Nov 22, 2011 at 8:09 AM, David Baron wrote: > On Monday 24 Heshvan 5772 23:02:13 Aaron J. Seigo wrote: >> On Monday, November 21, 2011 16:38:22 Luiz =?ISO-8859-1?Q?Rom=E1rio?= >> Santana >> >> Rios wrote: >> > I think it's because Plasma widgets are not QWidgets, but >> > QGraphicsWidgets.

Re: Plasma Widgets in Qt-designer

On Tue, Nov 22, 2011 at 9:31 AM, Aaron J. Seigo wrote: > On Tuesday, November 22, 2011 08:13:44 Tomaz Canabrava wrote: > >> If you want to use plasma widgets in your app, it's possible, you can > >> use a Plasma::Corona and the set of plasma classes for it, like Amarok &

Re: Help us finding the new name for Laptop window decoration

On Fri, Mar 16, 2012 at 5:06 AM, Aaron J. Seigo wrote: > On Thursday, March 15, 2012 14:59:17 Martin Gräßlin wrote: >> http://www.doodle.com/e9se6zuz8ufepxke > > for those who voted for "simple": in what way is it "simple"? No gradients, no shades, plain colors, flat. Simple <3. > -- > Aaron J.

Re: Re: Help us finding the new name for Laptop window decoration

On Fri, Mar 16, 2012 at 5:16 AM, Martin Gräßlin wrote: > On Friday 16 March 2012 05:13:56 Tomaz Canabrava wrote: >> On Fri, Mar 16, 2012 at 5:06 AM, Aaron J. Seigo wrote: >> > On Thursday, March 15, 2012 14:59:17 Martin Gräßlin wrote: >> >> http://www.doodle.com/

Re: cmake does not work

Devanshu, I know it's frustrating to begin in a very complex and huge software as KDE and Plasma, belive me - this happened to me 6 years ago. It's very important to try to understand the errors that you have before asking for help, really. Holding hands is cool but not the most efficient way to l

Re: cmake does not work

"/home/devanshu/Documents/PMC/plasma-mediacenter/build/-fPIC" does not > exist. What? no no no, You must add -fPIC as the CXX_COMPILER_FLAGS, how's your CMakeLists.txt? It seems that you are adding -fPIC at the wrong location. > > On Thu, Jul 10, 2014 at 8:41 PM, Tomaz Canabrava w

Re: cmake does not work

LAGS "${CMAKE_CXX_FLAGS} -std=c++0x") > else() > message(STATUS "The compiler ${CMAKE_CXX_COMPILER} has no C++11 > support. Please use a different C++ compiler.") > endif() > > *----- > > How should I add fPIC

Re: cmake does not work

On Thu, Jul 10, 2014 at 12:45 PM, Shantanu Tushar Jha wrote: > Cool, though I had asked "how" have you installed Qt ;) Because I've never > encountered this error. > > Anyway, you can even add the fPIC flag like this - > > cmake .. -DCMAKE_CXX_FLAGS=-fPIC -DCMAKE_INSTALL_PREFIX=`kde4-config > --pr

Re: [kde-community] Jitsi Meet installation for KDE?

Seems to me a lovely idea. On Fri, Jul 18, 2014 at 10:36 AM, Thomas Pfeiffer wrote: > On Sunday 06 July 2014 00:08:38 Michael Bohlender wrote: >> Hi everyone, >> video conferencing seems to gain more and more importance within KDE. The >> Plasma team has their weekly "Monday Hangout", the VDG reg

Re: Plasma 5 - thank you

Em 21/08/2014 10:59, "Carl Symons" escreveu: > > For a few days, I've been using Plasma 5 when I'm out and about. Generally, not production work. And on a real computer, not a VM (as a co-worker suggested). > > It is outstanding, and now I'm seriously considering upgrading the main machine. It's a

Review Request 123142: Fixes plasma-desktop compilation with boost 1.56

/resultset_iterator.cpp 664b399 Diff: https://git.reviewboard.kde.org/r/123142/diff/ Testing --- compiles. Thanks, Tomaz Canabrava ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123142: Fixes plasma-desktop compilation with boost 1.57

::optional conversion to bool must be explicit, thus a static_cast is needed. Diffs - lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp 664b399 Diff: https://git.reviewboard.kde.org/r/123142/diff/ Testing --- compiles. Thanks, Tomaz Canabrava

Re: Review Request 123142: Fixes plasma-desktop compilation with boost 1.57

explicit, thus a static_cast is needed. Diffs - lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp 664b399 Diff: https://git.reviewboard.kde.org/r/123142/diff/ Testing --- compiles. Thanks, Tomaz Canabrava ___ Plasma-devel mailing

Re: Kirigami patches

Subsue Em 16 de ago de 2016 04:43, "Marco Martin" escreveu: > > On Tuesday 16 August 2016, Martin Gysel wrote: > > Am 16.08.2016 um 01:55 schrieb Dirk Hohndel: > > > It's pretty clear that no one ever tested the kirigami.pro qmake file. > > > The second patch I'm not 100% sure about, but it seems

Re: Please cleanup your scratch and clone repositories

Done. On Sun, Nov 27, 2016 at 9:39 AM, Ben Cooksley wrote: > On Sat, Nov 26, 2016 at 7:53 AM, Ben Cooksley wrote: > > Hi all, > > Hi all, > > > > > To help Sysadmin assess how these types of repositories would be used > > under Phabricator, it would be appreciated if everyone could please > > c

Kirigami2 issues on static libraries.

Hello good people, I started to port Subsurface to kirigami2 and I found some issues that are interesting. If I try to run subsurface while plasma is not running, it works, if I try to run subsurface while plasma is running, it doesnt. It seems that we hit a issue by using kirigami as a Static l

Re: Kirigami2 issues on static libraries.

On Tue, Dec 27, 2016 at 6:45 PM, Marco Martin wrote: > On Tuesday 27 December 2016, Tomaz Canabrava wrote: > > Hello good people, > > > > I started to port Subsurface to kirigami2 and I found some issues that > are > > interesting. > > > > If I try to

D29028: feat(wayland): add Wrapland plugin

tcanabrava added a comment. I understand David's point: Wrapland project has one developer and we don't know how successful it will be, while the other backends have developers. What would happen if you suddenly quit / disappear and the project dies? Then kscreen will have a folder of dead c

Re: Plasma Firewall

Lots of nitpicks fixed, still missing some, I'll finish the rest today. On Fri, May 22, 2020 at 6:10 PM Ivan Čukić wrote: > Hi Kai, > > > This is something that Plasma has been missing for a long time. Thanks to > everyone involved! > > > A few comments from a quick run-through over kcm/core: >

D25375: Start of the accessibility KCM

tcanabrava abandoned this revision. tcanabrava added inline comments. INLINE COMMENTS > broulik wrote in kcmaccess.cpp:141 > Are you sure this shouldn't be something like > > modifiers & (ScrollMask | LockMask | NumMask) good catch. > broulik wrote in kcmaccess.desktop:9 > What about this? W

Re: Plasma Firewall

People, I have spend a great deal of time fine tuning the Firewall, I hope it's ready for a release. On Wed, Jun 3, 2020 at 6:33 PM Tomaz Canabrava wrote: > Lots of nitpicks fixed, still missing some, I'll finish the rest today. > > > On Fri, May 22, 2020 at 6:10 PM Ivan

D13591: Set complete vectors instead of creting them at runtime

tcanabrava added a comment. second ping. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13591 To: tcanabrava, #breeze, #plasma Cc: ngraham, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13591: Set complete vectors instead of creting them at runtime

tcanabrava abandoned this revision. tcanabrava added a comment. Seems there's nobody to review. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13591 To: tcanabrava, #breeze, #plasma Cc: ngraham, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, je

D13591: Set complete vectors instead of creting them at runtime

This revision was automatically updated to reflect the committed changes. Closed by commit R31:c671ea190645: Set complete vectors instead of creting them at runtime (authored by tcanabrava). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13591?vs=36515&id=40562

D18575: Remove warning before hidding the MenuBar

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY No other KDE app does this, while also allowing to show / hide the menubar. This actualy seemed quite extreme as there's no

D18576: Simpe C updates to ksysguardd code

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Use C 11, it has better defaults Simplify if - chain Reduce variable scope Don't check before free REPOSITORY R106 KS

D18578: Reduce string objects

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY QStringLiteral cannot deal with duplicates, so each invokation in the same file with the same string will create a different

D18579: Rework Sensor Browser

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Move public classes to Internal Structs Make sure we are not accessing something wrong No need to clear on destruction S

D18580: Accept commas to separate processes on the Search Edit

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REPOSITORY R111 KSysguard Library BRANCH acceptCommasSearch REVISION DETAIL https://phabricator.kde.org/D18580 AFFECTED FILES processu

D18580: Accept commas to separate processes on the Search Edit

tcanabrava updated this revision to Diff 50463. tcanabrava added a comment. - Accept commas for PID REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18580?vs=50426&id=50463 BRANCH acceptCommasSearch REVISION DETAIL https://phabricator.kde.org/

D18580: Accept commas to separate processes on the Search Edit

This revision was automatically updated to reflect the committed changes. Closed by commit R111:f5dcd02c52fd: Accept commas to separate processes on the Search Edit (authored by tcanabrava). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18580?vs=504

D18579: Rework Sensor Browser

tcanabrava added inline comments. INLINE COMMENTS > argonel wrote in SensorBrowser.cpp:51 > This one caused me to notice the style issues. The rule is "For pointers or > references, use a single space before '*' or '&', but not after" ups. that was a typo. > argonel wrote in SensorBrowser.cpp:

D18578: Reduce string objects

tcanabrava added a comment. In D18578#401842 , @apol wrote: > Looks okay from a theoretical point of view, I can expect the practical impact of this be about 0~ :P What I really like about math is that sum of changes with zero impact i

D18801: CMakeLists: Fix bfd.h include path on windows

tcanabrava accepted this revision. tcanabrava added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:71 > +find_path(BFD_INCLUDE_DIR bfd.h) > +include_directories("${BFD_INCLUDE_DIR}") > endif() you don't need the quotes here. REPOSITOR

D18859: cdb: First working version

tcanabrava requested changes to this revision. tcanabrava added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > backtraceparsercdb.h:31 > +protected Q_SLOTS: > +virtual void newLine(const QString &lineStr); > + remove virtual, override. > backtraceparsercdb

D18859: cdb: First working version

tcanabrava added inline comments. INLINE COMMENTS > tcanabrava wrote in backtraceparsercdb.h:31 > remove virtual, override. still missing the override. > tcanabrava wrote in backtraceparsercdb.h:34 > remove virtual, override. still missing the override. REPOSITORY R871 DrKonqi REVISION DET

D18575: Remove warning before hidding the MenuBar

tcanabrava added a comment. In D18575#401418 , @ngraham wrote: > > No other KDE app does this > > That's not true. Kate and Gwenview do this too, and for good reason: without this warning, there's no way to know how to get the menu bar back a

D18578: Reduce string objects

This revision was automatically updated to reflect the committed changes. Closed by commit R106:91b1f7115bf3: Reduce string objects (authored by tcanabrava). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18578?vs=50421&id=51653 REVISION DETAIL https://ph

D18576: Simpe C updates to ksysguardd code

This revision was automatically updated to reflect the committed changes. Closed by commit R106:b4bde28dc7af: Simpe C updates to ksysguardd code (authored by tcanabrava). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18576?vs=50419&id=51654 REVISION DETAIL

D18579: Rework Sensor Browser

tcanabrava updated this revision to Diff 51655. tcanabrava added a comment. - Fix code style - re-add assert - Fix code style REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18579?vs=50423&id=51655 BRANCH CleanSensorBrowser REVISION DETAIL https:

D19656: Comparisson has a typo, === and not = ==.

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH fixMouseHandlerLoading REVISION DETAIL https://phabricator.kde.org/D19656 AFFECTED FILES applets

D24374: WIP: Initial port of the Date and Time KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY This is mostly the c++ part, missing the Qml - however this one should be easy to do - with the exception of the visual cloc

D24374: WIP: Initial port of the Date and Time KCM

tcanabrava updated this revision to Diff 67223. tcanabrava added a comment. - Fix KAuth usage REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24374?vs=67219&id=67223 BRANCH kcm_dateandtime REVISION DETAIL https://phabricator.kde.org/D24374 AFFE

D24374: WIP: Initial port of the Date and Time KCM

tcanabrava updated this revision to Diff 67277. tcanabrava added a comment. wq - Restore colors metatada, and correctly set the datetime metadata - s/kcmclock/kcm_clock - Fix author - kcm_name break kauth, it needs kcmname =/ - Fix missing property, Add a Qml Clock (from the Qt Demo

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67563. tcanabrava added a comment. - Fix metadata installation - Fix model loading on Qml - Base work on the Qml - Name fixes - Move ui/main to contents - Fix wrong types in Qml - Plug the controllers - Link to the save button - Fix borde

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67567. tcanabrava marked 7 inline comments as done. tcanabrava added a comment. - Simplify Checkboxes - Fix previouslyEnabled logic - Tell Qml that we have the values - Move code around - Fix QSet math - Qml gives us a Url, we want the Local fi

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67568. tcanabrava added a comment. - fix Comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=67567&id=67568 BRANCH kcm_baloo_qml REVISION DETAIL https://phabricator.kde.org/D23718 AFFECTED F

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava marked 2 inline comments as done. tcanabrava added a comment. I still need to play a bit with the folder save / load. the code from the old kcm is quite strange. it saves "included folders", but there's nothing using that. perhaps it's safer if we just remove everything that's not

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 67571. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDAT

D24224: Start of the accessibility KCM

tcanabrava added a comment. this now depends on https://phabricator.kde.org/D23835 - There's an issue with saving (the save is not activated for some reason, I need to investigate. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24224 To: tcanabrava Cc: mart,

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67572. tcanabrava added a comment. - Fix Strings - Fix margins REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=67568&id=67572 BRANCH kcm_baloo_qml REVISION DETAIL https://phabricator.kde.org/D2

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d66bd8f3e9af: WIP: Beginning of the Baloo/Search KCM Rewrite (authored by tcanabrava). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=67572&id=67701

D24224: Start of the accessibility KCM

tcanabrava added a comment. In D24224#545013 , @broulik wrote: > Can you please follow KDE Frameworks coding style Sorry, it was by mistake. I'll fix the style. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.o

D24224: Start of the accessibility KCM

tcanabrava added inline comments. INLINE COMMENTS > bport wrote in kcmaccess.h:32-67 > Using KConfigXT will remove lots of boilerplate code (tons of property > declaration + associated methods and easiest, load, save and defaults method). > And with the work done by @ervin on KConfigXT and KQui

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 68019. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout - A much much better layout than tabs - Beginning of KC

D24224: Start of the accessibility KCM

tcanabrava added a comment. F7605185: kcm_access.png Now it uses a Vertical List, providing a better navigation mode, The Settings where also rewritten using KConfigXT so I don't need to deal with all the possible properties. This actually hit a hard l

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 69650. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout - A much much better layout than tabs - Beginning of KC

D24224: Start of the accessibility KCM

tcanabrava added a comment. F7759258: image.png INLINE COMMENTS > bport wrote in CMakeLists.txt:24 > Not sure why we have this change in this code review, seems unrelated completely unrelated, thanks for spotting. REPOSITORY R119 Plasma Desktop REVI

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 69651. tcanabrava added a comment. - Fix Layout REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24224?vs=69650&id=69651 BRANCH kcm_acess REVISION DETAIL https://phabricator.kde.org/D24224 AFFECTED FILES

D24224: Start of the accessibility KCM

tcanabrava added a comment. In D24224#561693 , @ngraham wrote: > It doesn't compile: > > /home/nate/kde/usr/include/KF5/KNewStuff3/KNS3/DownloadDialog:1:10: fatal error: kns3/downloaddialog.h: No such file or directory > 1 | #includ

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 69945. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout - A much much better layout than tabs - Beginning of KC

D25375: Start of the accessibility KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY This rewrites the Accessibility KCM to use Qml and the new Managed Config classes. REPOSITORY R119 Plasma Desktop BRANCH

D24224: Start of the accessibility KCM

tcanabrava added a comment. After squashing the commits to remove the broken history, arc diff opened a new revision. https://phabricator.kde.org/D25375 INLINE COMMENTS > ervin wrote in kcmaccessibilitymouse.kcfg:34 > Wouldn't an Enum be more suited here? This i a spinBox with a range fro

D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Before we port this to Qml we need to simplify the code it's currently monolithycal, and need to be split into at least tw

D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM

tcanabrava updated this revision to Diff 70018. tcanabrava added a comment. - Fix speed of the models - Simplify Logic - Speed up emoticon loading - Re-Enable updateBtn - Re-enable remove theme - Move more data to the Models - Re-enable the rest of the functions - Remove ui file

D25280: [Baloo KCM] Purge index when disabling indexing

tcanabrava added a comment. I gree with david's questioning, sometimes I disable indexing when I'm about to do something heavy, to re-enable it later. I don't want to lose all my data. perhaps there should be a box `purge database data` instead of purging on disable? INLINE COMMENTS > ma

D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM

tcanabrava added a comment. In D25379#565509 , @davidedmundson wrote: > I was under the impression we were killing this KCM in the very near future. > > The relevant workboard entry: https://phabricator.kde.org/T7292 While the KCM doe

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 70103. tcanabrava added a comment. - Fixes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25375?vs=69947&id=70103 BRANCH kcm_acess REVISION DETAIL https://phabricator.kde.org/D25375 AFFECTED FILES kcm

D25449: Start of the new Formats KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Detangle the code, implement models and start the Qml REPOSITORY R119 Plasma Desktop BRANCH kcm_formats REVISION DETAIL

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 70749. tcanabrava added a comment. - Fixes - Fixes texts and UI - Simplify Algorithm - Fix Enable / Disable status REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25375?vs=70103&id=70749 BRANCH kcm_ace

  1   2   >