Am Monday 20 July 2009 schrieb Marco Martin:
> adding (another) new type could also solve my issue with the netbook shell,
> where kwin thinks that window is fullscreen just because has the full size
> but not the fullscreen flag
afaik that's a workaround for old apps that are not NETWM compliant,
://git.reviewboard.kde.org/r/105382/diff/
Testing
---
yes, dashboard still triggers the effect, renamed xterm no longer
Thanks,
Thomas Lübking
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
On June 28, 2012, 7:42 p.m., Thomas Lübking wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105382/
> --
> On Sept. 6, 2012, 12:29 p.m., David Faure wrote:
> > A number of comments on the implementation, but also a more general
> > comment: does it even make sense to use a Speller in multiple threads, and
> > to change the language from one thread while another one is using the
> > speller for s
> parsing strings. So I couldn't see a way to do this except to call
> Sonnet::Speller::setLanguage() in Plasma::AbstractRunner::match,
> which meant that for it to work I had to make match thread-safe.
>
> Sorry. I'm open to suggestions if you have a be
> parsing strings. So I couldn't see a way to do this except to call
> Sonnet::Speller::setLanguage() in Plasma::AbstractRunner::match,
> which meant that for it to work I had to make match thread-safe.
>
> Sorry. I'm open to suggestions if you have a be
> On Sept. 11, 2012, 7:39 p.m., Zack Rusin wrote:
> > That's pretty bonkers. This class was never meant to be used like that.
> > Holding an object in two threads is not going to work unless you make the
> > entire communication synchronous effectively reducing all the
> > multi-threading aspe
x27;t look into details) for quite sure
trigger bug reports ("can't switch desktops", "present windows no longer works
with fullscreen "), so here's a warning about that ;-)
If some client wants to ensure unobscured input it can grab the pointer, what
would also wo
> On Oct. 4, 2012, 1:13 p.m., Thomas Lübking wrote:
> > Special case solution?
> >
> > This will (by assumed behavior, didn't look into details) for quite sure
> > trigger bug reports ("can't switch desktops", "present windows no longer
>
> On March 30, 2012, 8:18 p.m., Thomas Lübking wrote:
> > service/jobs/nepomuk/Move.cpp, line 352
> > <http://git.reviewboard.kde.org/r/104417/diff/5/?file=55320#file55320line352>
> >
> > "!QUrl::isLocalFile()"?
>
> Lamarque Vieira Souza wrot
On Montag, 24. Dezember 2012 23:12:22 CEST, Weng Xuetian wrote:
> Hi Plasma world,
> As new shadow lands in KDE 4.10 RC1, some unintentional mess is introduced.
>
> https://bugs.kde.org/show_bug.cgi?id=311502
> https://bugs.kde.org/show_bug.cgi?id=311995
I doubt those have much relation, notably #
#312168.
Wild guess from your patch: don't remove the shadows before, but *after* the
hiding (eventually "later", ie. in the deconstructor or on the destroyed
signal) to avoid confusations between the deleted window size and the "dirty"
area.
- Thomas Lübking
On
kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1
Diff: http://git.reviewboard.kde.org/r/107983/diff/
Testing
---
see summary
Thanks,
Thomas Lübking
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
cpp f9b3cc1
Diff: http://git.reviewboard.kde.org/r/107983/diff/
Testing
---
see summary
Thanks,
Thomas Lübking
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
ncountering bug #179042.
- Thomas
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/#review24713
---
On Jan. 5, 20
ewboard.kde.org/r/107983/#review24751
---
On Jan. 5, 2013, 2:38 p.m., Thomas Lübking wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
s.kde.org/show_bug.cgi?id=179042
Diffs (updated)
-
kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1
Diff: http://git.reviewboard.kde.org/r/107983/diff/
Testing
---
see summary
Thanks,
Thomas Lübking
___
Plasma-devel mailing list
Plasma-de
> On Jan. 5, 2013, 3:13 p.m., Fredrik Höglund wrote:
> > Because the XFixesSelectSelectionInput() call specifies that the event
> > should be delivered to winId(). KSelectionOwner does not send XFixes
> > events; they are generated by the X server.
> >
>
&g
> On Jan. 5, 2013, 3:13 p.m., Fredrik Höglund wrote:
> > Because the XFixesSelectSelectionInput() call specifies that the event
> > should be delivered to winId(). KSelectionOwner does not send XFixes
> > events; they are generated by the X server.
> >
>
&g
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote:
> > I don't like having a link dependency on plasmagenericshell. If that is
> > supposed to be used, then it needs to go to the workspaces libs.
> >
> > I also think that this approach just doesn't scale. We use Plasma styled
> > dialogs for
t; So kwin will directly use Plasma::Svg for tabbox shadow?.. I can't see a
> clear way for doing this right so I just take a easiest way for this. (And to
> call attention for right people on this, on purpose :P)
>
> Thomas Lübking wrote:
> KWin needs a (tmp proprietary
is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/#review25012
---
On Jan. 5, 2013, 5:08 p.m., Thomas Lübking wrote:
>
> --
o kwin), and I
> > notice some strange plasma theme change caused by this.
> >
> > Trying to find you why..
>
> Thomas Lübking wrote:
> The XFixesSelectionNotify event fires one every selection owner event,
> usually it'll be the cnp system (when you eg. mark
--
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/#review25025
---
On Jan. 9, 2013, 12:52 a.m., Thomas Lübking wrote:
>
> ---
> On Jan. 10, 2013, 6:42 a.m., Martin Gräßlin wrote:
> > the big question is whether the code has been like that for historic
> > reasons or whether there are problems with some window managers. I am for
> > 99 % sure that it's for historic reasons, but the remaining 1 % tells me
> > that it's
iff: http://git.reviewboard.kde.org/r/107983/diff/
Testing
---
see summary
Thanks,
Thomas Lübking
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
the KWindowSystem issue remains.
This addresses bug 179042.
http://bugs.kde.org/show_bug.cgi?id=179042
Diffs (updated)
-
kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1
Diff: http://git.reviewboard.kde.org/r/107983/diff/
Testing
---
see summary
2c263
ksmserver/screenlocker/greeter/greeterapp.cpp a35c8ae
ksmserver/screenlocker/greeter/screensaverwindow.cpp adb2587
Diff: http://git.reviewboard.kde.org/r/108375/diff/
Testing
---
"Screensaver" - Emulation ;-)
m_showScreenSaver = true;
// screensaverWindow->setBackground(b
m a
turned off, ie. black screen.
This addresses bug 313020.
http://bugs.kde.org/show_bug.cgi?id=313020
Diffs
-
ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/main.qml
0e78fdd
Diff: http://git.reviewboard.kde.org/r/108377/diff/
Testing
---
ttp://git.reviewboard.kde.org/r/108375/#comment19351>
all changes in greeter.cpp are wrong and relics and i've reset the file
locally - sorry for having it in the patch
- Thomas Lübking
On Jan. 13, 2013, 11:22 a.m., Thomas Lü
** please keep me in CC **
While stepping across the ksmserver/screenlocker/greeter/* code i noticed that there's
(intended) support to show the screensaver on pressing esc, but no equivalent to
re/activate dmps (DPMSForceLevel, "xdpms force off")
I've failed to find resp. API in powerdevil (a
locker/greeter/greeterapp.cpp a35c8ae
ksmserver/screenlocker/greeter/screensaverwindow.cpp adb2587
Diff: http://git.reviewboard.kde.org/r/108375/diff/
Testing
---
"Screensaver" - Emulation ;-)
m_showScreenSaver = true;
// screensaverWindow->setBackground(backgroundPix
tically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108375/#review25397
---
On Jan. 13, 2013, 9:32 p.m., Thomas Lübking wrote:
>
> ---
> This is an automat
On Sonntag, 13. Januar 2013 19:22:09 CEST, Aaron J. Seigo wrote:
On Sunday, January 13, 2013 13:55:54 Thomas Lübking wrote:
** please keep me in CC **
While stepping across the ksmserver/screenlocker/greeter/* code i noticed
that there's (intended) support to show the screensaver on pressing e
> On Jan. 14, 2013, 7:59 a.m., Thomas Lübking wrote:
> > my 2c only:
> >
> > if air has an unnotable *highlight* frame this should be fixed in the theme.
> > if it is not fixable in the theme because the focus is on a mostly light
> > and "airy" appea
de.org/r/108417/diff/
Testing
---
Yes, reliably toggles the screen even after press-holding the escape key (then
wait for the actual screen state and then controlled toggling it)
Thanks,
Thomas Lübking
___
Plasma-devel mailing list
Plasma
not have to perform the dbus trip anyway...)
- Thomas
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108417/#review25531
-------
On Jan. 14, 2013, 9:12 p.m., Thomas Lübking wrote:
>
> -
the interface? I can
> > picture a case where powerdevil is inactive. I guess in that case asyncCall
> > would simply silently fail, but better safe than sorry.
>
> Thomas Lübking wrote:
> It'll silently fail whereas the query for the interface is a synchronous
>
> On Jan. 14, 2013, 7:59 a.m., Thomas Lübking wrote:
> > my 2c only:
> >
> > if air has an unnotable *highlight* frame this should be fixed in the theme.
> > if it is not fixable in the theme because the focus is on a mostly light
> > and "airy" appea
> On Jan. 15, 2013, 3:06 p.m., Aaron J. Seigo wrote:
> > yes, looks proper.
> >
> > on a broader note, it's probably hard/impossible to make the viewitem svg
> > work for this use case and the general use case of QML views .. so +1 from
> > me.
I'd rather say if theme can not provide this, th
the interface? I can
> > picture a case where powerdevil is inactive. I guess in that case asyncCall
> > would simply silently fail, but better safe than sorry.
>
> Thomas Lübking wrote:
> It'll silently fail whereas the query for the interface is a synchronous
>
107983/#review25307
---
On Jan. 9, 2013, 2 a.m., Thomas Lübking wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://g
Testing
---
Yes, also no dangerous asserts included (turned out i've debug compiling only
fake enabled for kwin ;-)
Thanks,
Thomas Lübking
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
because of eg. the
requirement to mask the window (no idea whether that works at all) and doesn't
catch plasma dialogs etc. - yet (aside the margin issue) better that what is
there and the fix in the shadow frame is pretty much required.
- Thomas Lübking
On Jan. 16, 2013, 1:57 p.m., M
rd.kde.org/r/108417/#review25663
---
On Jan. 14, 2013, 9:12 p.m., Thomas Lübking wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://
that an approach that works for all varieties of locker?
>
> Thomas Lübking wrote:
> The unlock dialog cannot be dismissed, it's what protects the screen
> against content exposure - it /is/ the screenlocker by the new architecture
> and afaiu.
> The "screensaver"
> On Jan. 16, 2013, 5:58 p.m., Sebastian Kügler wrote:
> > This patch brings a big improvement on the contrast, works better even than
> > I expected. :)
> >
> > On KDE/4.10 I'm getting the following build error:
> >
> > /home/sebas/kdesvn/src/kde-workspace/kwin/tabbox/../workspace.h: In
> >
tomatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108375/#review25695
-------
On Jan. 13, 2013, 9:32 p.m., Thomas Lübking wrote:
>
> ---
> This i
seen was that the TabBox became too small -
> thumbnails were placed outside the box.
>
> I will look into it tomorrow again - maybe Aaron found a solution for
> KWin tells libplasma that we use compositing ;-)
>
> Thomas Lübking wrote:
> Does https://git.revie
at i could have simply xrandr'd the geometry from VT1 as
well - "blast!")
everything is nicely black (with compositing)
Thanks,
Thomas Lübking
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108585/#review26205
-------
On Jan. 25, 2013, 11:04 p.m., Thomas Lübking wrote:
>
> ---
> This is
> On Jan. 26, 2013, 2:03 p.m., Oliver Henshaw wrote:
> > I don't have multiple monitors to test with, but can you test with the the
> > LockWindow set to some colour other than black? Just so that any bizarre
> > side effects are more obvious.
>
> Thomas Lü
-
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108585/#review26301
---
On Jan. 25, 2013, 11:04 p.m., Thomas Lübking wrote:
>
> --
might be required on top (if the lockerwindow moved
itself above the greeter) - at least activateWindow will not raise the window.
- Thomas Lübking
On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote:
>
> ---
> This is an automat
the Qt::transparent.
This also requires it to be 32bit, ie. ARGB - is that lockerwindow constructed
out of sth. else here (eg. plasma-desktop) or do you eventually run into this
with the oxygen-transparent style or the resp. settings of QtCurve or Bespin?
- Thomas Lübking
On Jan. 28, 2013, 2:38
> On Jan. 28, 2013, 3:27 p.m., Thomas Lübking wrote:
> > ksmserver/screenlocker/greeter/greeterapp.cpp, line 210
> > <http://git.reviewboard.kde.org/r/108643/diff/1/?file=109632#file109632line210>
> >
> > This is pointless because the greeter view is not ma
> On Jan. 28, 2013, 3:30 p.m., Thomas Lübking wrote:
> > What kinda strucks me is that the window is translucent for the
> > Qt::transparent.
> > This also requires it to be 32bit, ie. ARGB - is that lockerwindow
> > constructed out of sth. else here (eg. plasma-de
32bit drawable here (or this is maybe an
issue in the driver)
- Thomas Lübking
On Jan. 28, 2013, 2:38 p.m., Aaron J. Seigo wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
ox/declarative.cpp
<http://git.reviewboard.kde.org/r/108438/#comment20104>
No idea how expensive this is (eg. whether there's an I/O) but it could be
cached (since iirc we connect the themeChange signal anyway)
- Thomas Lübking
On Jan. 30, 2013, 7:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108438/#review26419
---
Ship it!
Ship It!
- Thomas Lübking
On Jan. 30, 2013, 1:28
513/#comment20329>
F***
I ran into that yesterday and wanted to mention it.
You forgot to bump the ABI (leading to *very* ominous crash reports here ;-)
- Thomas Lübking
On Feb. 4, 2013, 8:50 a.m., Martin Gräßlin
> On Feb. 7, 2013, 9:25 p.m., Albert Astals Cid wrote:
> > I see this has a ship it but marked as uncommited. Was it commited and you
> > forgot to close the request or is still uncommited?
>
> Aaron J. Seigo wrote:
> plastik is gone, but b2 and laptop are still there.
>
> Albert Astals Ci
and updates the property.
yeah.)
I frankly have no concept for the above ready (esp: "who'd forgets information
in the root case") but am not convinced about the bamf approach.
It looks like some of my hack solutions in this regard, not anything like a
proper solution.
- Th
trigger dock type
(thus managed) would more or less get you what you want (below -active-
fullscreen windows, above everything else) - however they'd be below kwin
screenedges (corners or to switch VD w/o moving a window) then (while currently
above those)
- Thomas Lübking
On Aug. 22, 2012,
On Freitag, 15. März 2013 14:38:45 CEST, Martin Gräßlin wrote:
Since [1] KWin has the internal KDecorationBridge as a public part of the
KDecoration API to allow Compiz to implement it. This is rather
unfortunate as
it makes our life more difficult as we cannot extend our
internal API without
> On March 20, 2013, 2 p.m., Aaron J. Seigo wrote:
> > have you tested the following two use cases:
> >
> > * panel hides, a window becomes full screen at that point .. does the panel
> > still unhide now?
> > * window becomes full screen, panel hides (and with the patch no unhide
> > trigger
m_clients and m_ids as hash/map or at least a pair
(implicitly documenting "this is assigned and has to be in sync")
Most on terminology, but think about grouping m_ids and m_clients
The last "ClientGroup" lost the connection quite some times ... =)
- Thomas Lübking
On March
2
Diffs
-
kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1
Diff: http://git.reviewboard.kde.org/r/107983/diff/
Testing
---
see summary
File Attachments
testcase
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp
> On March 21, 2013, 9:06 p.m., Thomas Lübking wrote:
> > kwin/scripting/scripting_model.cpp, line 190
> > <http://git.reviewboard.kde.org/r/109604/diff/1/?file=120515#file120515line190>
> >
> > considered to keep m_clients and m_ids as hash/map or
anyway ;-)
- Thomas Lübking
On April 2, 2013, 3:41 p.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
me
> > screen -> don't interfere.
>
> Thomas Lübking wrote:
> a fullscreen window can cover more than one screen (@Martin: there's even
> a netwm hint on that for xinerama ;-)
> What you wanted to check is whether the panel and the window intersect.
&
t uses this will use background.svg
instead.
There's (unfortunately) no explicit requirement on that either this is
translucent or exists at all (what will get us the regular "solid" background)
For the beginning, i'd strongly recommend to elevate the to-be-tiled window
ov
> On April 25, 2013, 9:10 a.m., Marco Martin wrote:
> > seems a nice idea.
> > since the shadow for that item is huge, does take it into account when it
> > resizes the frame? )you would want the frame border, not the shadow more or
> > less aligned with the window size)
>
> Martin Gräßlin wro
> On April 25, 2013, 12:29 p.m., Thomas Lübking wrote:
> > It's a definitively visual improvement with many themes (including and esp.
> > air), but eg. (old) oxygen and several others still get me a black overlay
> > that does not much look like a frame or windo
tl;dr - No.
1st off i recall somebody more or less saying not letting any distro (and one
in particular) determine his (or her, hey ;-) actions.
I agree with that.
Furthermore, it's not much fair towards "other users" - and loosing high-quality
reports (eg. from gentoo) because is less than i
even with opaque themes and a
clear improvement over the status quo in about all cases.
- Thomas Lübking
On April 26, 2013, 6 a.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
176/#comment23735>
though not sure about this - personally liked the other variant better
(also, what if there's a transparent panel on either edge?)
- Thomas Lübking
On April 26, 2013, 6 a.m., Martin Gräßlin wrote:
>
> ---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/#review31963
-------
On March 23, 2013, 8:06 p.m., Thomas Lübking wrote:
>
> --
/main.qml
<http://git.reviewboard.kde.org/r/112236/#comment28473>
... ;-)
- Thomas Lübking
On Aug. 24, 2013, 9:52 a.m., Harald Hvaal wrote:
>
> ---
> This is an automatically generated e-mail. To reply
> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote:
> > Hm, on the face of it, this patch doesn't really make sense ... launcher
> > items don't have an associated task, so the function should already return
> > early and the extra condition should be redundant. Unless there's a race
> > condition
pe when I get home
> tonight I'll finally get around to setting up a 32 bit VM, and I'm hoping
> it'll crash there so I can throw all the gdb/valgrind/asan at it we got :).
>
> Thomas Lübking wrote:
> What bug and is "WId" involved?
>
> Bhush
el
appears), subsequent indication remains unaffected.
Thanks,
Thomas Lübking
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
de is not indicated (but the panel
appears), subsequent indication remains unaffected.
Thanks,
Thomas Lübking
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112727/#review40664
-----------
On Sept. 14, 2013, 2:36 p.m., Thomas Lübking wrote:
>
> ---
> Thi
> On Oct. 24, 2013, 3:35 p.m., Ivan Čukić wrote:
> > Actually, this is something that I wanted to do ever since I saw it on a
> > different screen to the one I had when I made it.
> >
> > If you want to try it with a radial gradient, mind that around the logo,
> > the background needs to be pi
33945
Diff: http://git.reviewboard.kde.org/r/113971/diff/
Testing
---
Thanks,
Thomas Lübking
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
is is obviously very important.
If we enter a recursion here, the user will not be able to enter a password
on a multiscreen context
- Thomas Lübking
On Nov. 20, 2013, 4:52 p.m., Thomas Lübking wrote:
>
> --
erver/screenlocker/greeter/greeterapp.h 951b1e3
ksmserver/screenlocker/greeter/greeterapp.cpp bf33945
Diff: http://git.reviewboard.kde.org/r/113971/diff/
Testing
---
Thanks,
Thomas Lübking
___
Plasma-devel mailing list
Plasma-devel@kde.org
only cause a full parent
repaint when adding/removing an (fdo) icon?
- Thomas Lübking
On Jan. 8, 2014, 8:59 a.m., Dmitry Ivanov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.revi
On Samstag, 18. Januar 2014 13:34:49 CEST, Martin Graesslin wrote:
Show it on all screens. That is create one OSD per screen. If that's not
wanted I'd say we use what KWin considers the "active" screen. And we could
take care of moving it there. (Active screen is depending on
config option the
On Sonntag, 19. Januar 2014 14:17:15 CEST, Martin Graesslin wrote:
The idea is to reuse the desktop windows, hide the
wallpaper (on compositing) and restack it on top of all other windows.
That would imply to dump the "dashboard" as some additional plasmoid container,
correct?
Thus if the show
On Montag, 20. Januar 2014 17:29:18 CEST, Martin Klapetek wrote:
How would the positioning work inside kwin and where?
kwin/placement.cpp
You may want to take a look at https://git.reviewboard.kde.org/r/110918/ in
addition.
Btw does it also handle when you click a youtube link you got from s
> On Sept. 24, 2013, 10:31 a.m., Martin Gräßlin wrote:
> > > no idea whether that's acceptable
> > shouldn't be much of an issue. KWindowSystem is emitting a signal, isn't
> > it? activeWindowChanged()
>
> Thomas Lübking wrote:
> There&#
> On Feb. 18, 2014, 6:37 a.m., Martin Gräßlin wrote:
> > I'm sorry, but you are fixing symptoms and not the problem. Calling the
> > repaint is correct, otherwise we might end with artefacts. The problem must
> > be that another effect is still holding a reference to the window and thus
> > it
nce to the window and thus
> > it's being shown again. Try disabling the fade effect or any other closing
> > animation effect you might be using.
>
> Thomas Lübking wrote:
> Depending on the flicker it could also be cached blurring (bug #307112)
> Otherwise in the
tps://git.reviewboard.kde.org/r/115859/#comment35252>
what about setting and removing this with setting the "slide" flag and
catch windowAdded() while slide is true for that matter?
- Thomas Lübking
On Feb. 18, 2014, 1:58 p.m., Sebast
ning
kwin/effects/slide/slide.cpp
<https://git.reviewboard.kde.org/r/115859/#comment35258>
three hash lookups for one (use QHash::iterator)
kwin/effects/slidingpopups/slidingpopups.cpp
<https://git.reviewboard.kde.org/r/115859/#comment35257>
unrelated?
- Thomas Lübkin
> On Feb. 18, 2014, 2:15 p.m., Thomas Lübking wrote:
> > kwin/effects/slide/slide.cpp, line 72
> > <https://git.reviewboard.kde.org/r/115859/diff/3/?file=244774#file244774line72>
> >
> > what about setting and removing this with setting the "slide&qu
> On Feb. 18, 2014, 2:15 p.m., Thomas Lübking wrote:
> > kwin/effects/slide/slide.cpp, line 72
> > <https://git.reviewboard.kde.org/r/115859/diff/3/?file=244774#file244774line72>
> >
> > what about setting and removing this with setting the "slide&qu
> On Feb. 19, 2014, 1:10 p.m., Commit Hook wrote:
> > This review has been submitted with commit
> > 848dd8c25b3511d89527ff8bd7b7e9125290385e by Sebastian Kügler to branch
> > master.
Just for the records, the commit is https://git.reviewboard.kde.org/r/115859/ -
this review was not submitted
1 - 100 of 396 matches
Mail list logo
