Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

nterface.h a1e2cd7 src/scriptengines/qml/plasmoid/appletinterface.cpp 1cd6934 Diff: https://git.reviewboard.kde.org/r/129204/diff/ Testing --- Thanks, Roman Gilg

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

Testing --- Thanks, Roman Gilg

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

Testing --- Thanks, Roman Gilg

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

d Martin's comment. The question is: Are there possibly any other applets than the launchers, which rely on the activationAction to only trigger their activation, but not their deactivation? - Roman --- This is an automatically generated e-ma

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

--- src/plasmaquick/appletquickitem.h 943e227 src/plasmaquick/appletquickitem.cpp 2f100b8 src/plasmaquick/private/appletquickitem_p.h 1436935 src/scriptengines/qml/plasmoid/appletinterface.cpp 1cd6934 Diff: https://git.reviewboard.kde.org/r/129204/diff/ Testing --- Thanks, Roman Gilg

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

ewboard.kde.org/r/129204/#review100072 --- On Okt. 17, 2016, 8:40 nachm., Roman Gilg wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

6935 src/scriptengines/qml/plasmoid/appletinterface.cpp 1cd6934 Diff: https://git.reviewboard.kde.org/r/129204/diff/ Testing --- Thanks, Roman Gilg

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

marked as submitted. Review request for Plasma and Martin Gräßlin. Changes --- Submitted with commit 65706d3878d556c7a1eac18984ec41b1a1d96d56 by Roman Gilg to branch master. Bugs: 367685 http://bugs.kde.org/show_bug.cgi?id=367685 Repository: plasma-framework Description

[Differential] [Accepted] D4038: [Task Manager] Only match application name if we never managed to match PID

subdiff accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4038 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, hein, subdiff, #plasma Cc: plasma-d

[Differential] [Commented On] D4040: [Icon Item] Round size we want to load a pixmap in

subdiff added a comment. Just tested and this solves pixelated launcher icons, i.e. https://bugs.kde.org/show_bug.cgi?id=374707 REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4040 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Commented On] D4040: [Icon Item] Round size we want to load a pixmap in

subdiff added a comment. It seems there have been problems with this before the new aspect-ratio aware IconItem aswell. See https://bugs.kde.org/show_bug.cgi?id=365326 Could your patch also solve this issue? Then we need to backport it to 5.8. REPOSITORY R242 Plasma Frameworks REVISIO

[Differential] [Request, 8 lines] D4041: [task manager] No subtext audio indicator in tooltip

subdiff created this revision. subdiff added reviewers: Plasma, broulik. subdiff set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise breaks the design goal

[Differential] [Closed] D4041: [task manager] No subtext audio indicator in tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e9bdca996091: [Task Manager] No audio indicator message in tooltip subtext (authored by subdiff). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4041?vs=9906

[Differential] [Commented On] D4050: add a "by KDE" sign in the splash

subdiff added a comment. Logo integrated into text? F1976427: splash.png F1976429: bykde.svgz REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4050 EMAIL PREFERENCES htt

[Differential] [Commented On] D4050: add a "by KDE" sign in the splash

subdiff added a comment. Still not like the "KDE" plus logo. Maybe only "made by" and then the logo? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4050 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc:

[Differential] [Closed] D3617: [Touchpad KCM] New KWin Wayland version

This revision was automatically updated to reflect the committed changes. subdiff marked an inline comment as done. Closed by commit R119:3db456588d0d: [Touchpad KCM] New KWin Wayland version (authored by subdiff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3617?vs=9495&id=10034#toc

[Differential] [Request, 73 lines] D4081: [libinput] Connection object in main thread for DBus connection

subdiff created this revision. subdiff added a reviewer: KWin. subdiff set the repository for this revision to R108 KWin. subdiff added projects: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The last patch https://phabricator.kde.org/D40

[Differential] [Commented On] D4081: [libinput] Connection object in main thread for DBus connection

subdiff added a comment. Note, that the Wayland Touchpad KCM won't work without this patch. So it's rather important. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4081 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #kw

[Differential] [Closed] D4081: [libinput] Connection object in main thread for DBus connection

This revision was automatically updated to reflect the committed changes. Closed by commit R108:ffa60dfef1c0: [libinput] Connection helper class for DBus connection (authored by subdiff). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4081?vs=10035&id=10086 REVI

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

subdiff added a comment. Log or squareroot? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, jensreuterberg Cc: subdiff, mart, hein, broulik, plasma-devel,

[Differential] [Accepted] D4168: Move X11 specific KGlobalAccel handling into the x11-standalone platform

subdiff accepted this revision. subdiff added a reviewer: subdiff. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH action-kglobalaccel-to-x11 REVISION DETAIL https://phabricator.kde.org/D4168 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Changed Subscribers] D4165: Drop KWin's internal global shortcut handling

subdiff added inline comments. INLINE COMMENTS > globalshortcuts.cpp:173 > -{ > -QKeySequence s = getShortcutForAction(KWIN_NAME, action->objectName(), > shortcut); > -if (s.isEmpty()) { `getShortcutForAction` was only called here, so you could remove this function aswell? REPOSITORY

[Differential] [Updated] D4171: [Task Manager] Remove arbitrary sizes from tooltip

subdiff added a comment. Before you commit give me a few minutes time please. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4171 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, hein, su

[Differential] [Changed Subscribers] D4171: [Task Manager] Remove arbitrary sizes from tooltip

subdiff added a subscriber: Fuchs. subdiff added a comment. F2082185: edit.png The gap between the app name and the top of the tooltip is increased. Is it possible to reduce it? Otherwise the tooltip in total gets bigger again and the close button t

[Differential] [Accepted] D4165: Drop KWin's internal global shortcut handling

subdiff accepted this revision. subdiff added a reviewer: subdiff. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH drop-internal-global-shortcuts REVISION DETAIL https://phabricator.kde.org/D4165 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Updated] D4202: use proper packagestructures

subdiff added a reviewer: subdiff. REPOSITORY R108 KWin BRANCH phab/packageplugins REVISION DETAIL https://phabricator.kde.org/D4202 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, graesslin, subdiff Cc: graesslin, plasma-devel, kwin, #

[Differential] [Updated] D4202: use proper packagestructures

subdiff added a comment. Just for keeping record: The only issue I noticed is that the config button in scripts isn't displayed. Besides works very nice! REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4202 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel

[Differential] [Commented On] D4293: [Task Manager] Show "Mark applications that play audio" option only if plasma-pa is available

subdiff added a comment. Set enable property instead of visible (and always uncheck in case Plasma-pa not avail)? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4293 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brouli

[Differential] [Request, 21 lines] D4301: [System Tray] SNI fallback to context menu on failing Activate

subdiff created this revision. subdiff added reviewers: Plasma, davidedmundson. subdiff set the repository for this revision to R120 Plasma Workspace. subdiff added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch primarily is aimed at appli

[Differential] [Updated] D4301: [System Tray] SNI fallback to context menu on failing Activate

subdiff marked an inline comment as done. subdiff added inline comments. INLINE COMMENTS > broulik wrote in statusnotifieritemsource.cpp:472 > This spins its own event loop which is dangerous when dealing with QML > This spins its own event loop which is dangerous when dealing with QML Since th

[Differential] [Updated, 27 lines] D4301: [System Tray] SNI fallback to context menu on failing Activate

subdiff updated this revision to Diff 10649. subdiff added a comment. One more try with guarding against dangling pointers. Just trying out stuff here. So in case this is utter bullshit please tell me if and why it doesn't work. My thinking was the following: - Guard code execution

[Differential] [Updated, 36 lines] D4301: [System Tray] SNI fallback to context menu on failing Activate

subdiff updated this revision to Diff 10713. subdiff added a comment. Use QDBusPendingCallWatcher. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4301?vs=10649&id=10713 REVISION DETAIL https://phabricator.kde.org/D4301 AFFECTED FILES applets/

[Differential] [Request, 334 lines] D4358: [cursors] Add 36px (1.5 scaling) size for Breeze and Breeze Snow Cursors

subdiff created this revision. subdiff added a reviewer: Plasma. subdiff set the repository for this revision to R31 Breeze. subdiff added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I use 1.5 scaling factor on my PC and the cursor sizes 24 (facto

[Differential] [Commented On] D4358: [cursors] Add 36px (1.5 scaling) size for Breeze and Breeze Snow Cursors

subdiff added a comment. In https://phabricator.kde.org/D4358#81742, @broulik wrote: > Can you make sure you don't have any duplicate files and symlink them as needed? Could you give me an example? I just ran the build script, which automatically should only symlink files, instea

[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)

https://bugs.kde.org/show_bug.cgi?id=363147 Roman Gilg changed: What|Removed |Added CC||subd...@gmail.com --- Comment #2 from Roman Gilg

[Differential] [Updated] D4366: WIP: Add screen recorder interface

subdiff added a comment. Could this also made possible without using the effects pipeline (and GL)? In https://phabricator.kde.org/T4426 we want to explicitly bypass it on fullscreen apps. Since one of the more prominent examples for such is gaming and Twitch is a thing we would need context

[Differential] [Closed] D4301: [System Tray] SNI fallback to context menu on failing Activate

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5d5518455d10: [System Tray] SNI fallback to context menu on failing Activate (authored by subdiff). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4301?vs=

[Differential] [Commented On] D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme

subdiff added a comment. FYI there has been a regression according to Rog131 commenting in this bug report . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2983 EMAIL PREFERENCES https://phabricator.kde.org/se

[Differential] [Request, 2 lines] D4473: [ScrollViewStyle] Evaluate frameVisible property

subdiff created this revision. subdiff added reviewers: Plasma, mart, hein. subdiff added a subscriber: hein. subdiff set the repository for this revision to R242 Plasma Framework (Library). subdiff added a project: Plasma. Restricted Application added subscribers: Frameworks, plasma-devel. Restric

[Differential] [Commented On] D4473: [ScrollViewStyle] Evaluate frameVisible property

subdiff added a comment. Note: This patch changes the default. Since until now the frameVisible property wasn't evaluated the frames were always shown. But since QtQuickControls ScrollView (i.e. Plasma Extra Components ScrollArea aswell) has set frameVisible to false by default, they are

[Differential] [Commented On] D4473: [ScrollViewStyle] Evaluate frameVisible property

subdiff added a comment. You mean in Plasma's ScrollArea? Would be ok for me. It's a rather random deviation from upstream's ScrollView though. Is this ok for anyone else aswell? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4473 EMAIL PREF

[Differential] [Updated, 3 lines] D4473: [ScrollViewStyle] Evaluate frameVisible property

subdiff updated this revision to Diff 11003. subdiff added a comment. Set ScrollArea's frameVisible default to true additional in order to not change current implementations. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4473?vs=10997&i

[Differential] [Commented On] D4473: [ScrollViewStyle] Evaluate frameVisible property

subdiff added a comment. The scroll indicators **are** the frame component in the Breeze style. So they get replaced in any other style by the frame specified there. If you take a look at ScrollViewStyle.qml, the indicators are inside the frame component and the frame sides just change their

[Differential] [Commented On] D4473: [ScrollViewStyle] Evaluate frameVisible property

subdiff added a comment. In https://phabricator.kde.org/D4473#83779, @hein wrote: > Aye. I think that's weird I agree. > Does defaulting the frames to on mean the bottom flash is back too or is that still fixed? Still fixed. > Can't comment on the ramifications of d

[Differential] [Closed] D4473: [ScrollViewStyle] Evaluate frameVisible property

This revision was automatically updated to reflect the committed changes. Closed by commit R242:eb39b3514130: [ScrollViewStyle] Evaluate frameVisible property (authored by subdiff). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4473?vs=1100

[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

subdiff added a comment. Can you add screenshots on your 13.3 screen with and without this patch? I know at the moment the code on master is not perfect. But we have to find a solution, which doesn't change the current look of the text lines completely. The Heading class to my taste has

[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

subdiff added a comment. In https://phabricator.kde.org/D4491#84110, @broulik wrote: > It doesn't *completely* change the look, it makes it consistent with literally everywhere else ... Then we have to ask ourselves if "everywhere else" is flawed aswell in some way. For example I

[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

subdiff added a comment. In https://phabricator.kde.org/D4491#84112, @anthonyfieroni wrote: > In work i'm on 5.8 :) I don't know what you want to see in screenshot when we talk to pixel density i.e. it depends on diagonal inches. I will update patch with heading levels instead of labels

[Differential] [Accepted] D4578: Split modifier only handling into a dedicated InputEventSpy

subdiff accepted this revision. subdiff added a reviewer: subdiff. subdiff added a comment. This revision is now accepted and ready to land. Didn't find any obvious issues in code plus tested it on X and Wayland. INLINE COMMENTS > keyboard_input.cpp:686 > m_input->processSpies(std::bind(

[Differential] [Updated, 338 lines] D4358: [cursors] Add 36px (1.5 scaling) size for Breeze and Breeze Snow Cursors

subdiff updated this revision to Diff 11333. subdiff added a comment. - Now doesn't reverts changes of https://phabricator.kde.org/D3459 anymore (and supports it in build script instead of adding the symlink directly). - Doesn't change mode for build scripts anymore. REPOSITORY R31 Breeze

[Differential] [Updated] D4358: [cursors] Add 36px (1.5 scaling) size for Breeze and Breeze Snow Cursors

subdiff updated the summary for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D4358 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, ab

[Breeze] [Bug 348603] Small mouse size (24 size too small, 48 too big)

https://bugs.kde.org/show_bug.cgi?id=348603 Roman Gilg changed: What|Removed |Added CC||subd...@gmail.com --- Comment #2 from Roman Gilg

[Maniphest] [Created] T5412: Improve Plasma PA usability

subdiff created this task. subdiff added projects: Plasma, VDG. TASK DESCRIPTION There have been huge improvements to Plasma's audio handling in the past thanks to @drosca. But there is still room for more. Currently I see the following issues, which in some cases might be easy to fix, in othe

[Differential] [Commented On] D3738: [Task Manager] Tooltips redesign

subdiff added a comment. In https://phabricator.kde.org/D3738#87601, @markg wrote: > ... There has already been a commit to master tackling this issue: https://phabricator.kde.org/D4491 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3738 EMAIL P

[Differential] [Closed] D3738: [Task Manager] Tooltips redesign

subdiff closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3738 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #vdg, hein, #plasma Cc: markg, broulik, anthonyfieroni, hein, colomar, plasma-devel, p

[Maniphest] [Commented On] T5412: Improve Plasma PA usability

subdiff added a comment. > This needs to go in, I forgot about it: https://phabricator.kde.org/D2314 Looks good! As Thomas said in the review though, I'm also in favor of offering at least the "Default" setting directly in the applet or add a button next to every stream to show this cont

[Differential] [Request, 58 lines] D4724: [KCM] Show notification stream at end of list

subdiff created this revision. subdiff added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The notification stream is not as important to the user than other app streams. Show it therefore at the end of the list. Rearranging the separator also

[Differential] [Updated] D4724: [KCM] Show notification stream at end of list

subdiff edited the summary of this revision. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4724 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma, drosca Cc: plasma-devel, progwolff, lesliezhai, al

[Differential] [Commented On] D4724: [KCM] Show notification stream at end of list

subdiff added a comment. Thanks. Didn't know about the design similarity to pavucontrol. But in this case it doesn't make much sense to me how pavucontrol is handling this. Something which is always there and is only for system internals, doesn't need to be presented at top position. What I

[Differential] [Commented On] D4724: [KCM] Show notification stream at end of list

subdiff added a comment. In https://phabricator.kde.org/D4724#88718, @drosca wrote: > > Regarding the size: When you look at the separator lines in the following screenshot, you can see that the spacing between the top and the first one is smaller than the one between the first and the s

[Differential] [Request, 533 lines] D4732: [KCM] Rework design and structure

subdiff created this revision. subdiff added projects: Plasma, VDG. REVISION SUMMARY This patch changes no functional stuff, only the arrangement and headings of the controls. In the end the KCM: - wastes less space - resembles more the applet - is less cumbersome to use because w

[Differential] [Commented On] D4732: [KCM] Rework design and structure

subdiff added a comment. Thank you! This Qt bug seems kinda weird. Maybe we should move away from using Tabs here? I thought about this, but haven't quite found the way to go instead. Maybe the same nice looking buttons you use in the applet (with the blue line below)? Anyway, this woul

[Differential] [Changed Subscribers] D4736: Port: Expose port availability to QML

subdiff added inline comments. INLINE COMMENTS > port.cpp:39 > +return m_availability; > } > Better put the definition of this getter in the header. > port.h:66 > } > } > Better put the definition of this long method in the cpp file. REPOSITORY R115 Plasma Audio Volum

[Differential] [Updated] D4732: [KCM] Rework design and structure

subdiff added a comment. > Then it will look out of place, all other KCMs use tabs. Also you can't use the tabbar from applet, as that is Plasma component (you can of course implement the same thing with QtQuickControls, but then again it will look out of place). There will be a redesig

[Differential] [Closed] D4732: [KCM] Rework design and structure

This revision was automatically updated to reflect the committed changes. Closed by commit R115:daeafed202f5: [KCM] Rework design and structure (authored by subdiff). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4732?vs=11650&id=11672 REV

[Differential] [Accepted] D4736: Port: Expose port availability to QML

subdiff accepted this revision. subdiff added a comment. This revision is now accepted and ready to land. Tested it and it works fine. Only problem was that I couldn't use "Port.Available", but probably only because I didn't define it somewhere in the QML file. What worked in DeviceListItem.q

[Maniphest] [Edited] T5412: Improve Plasma PA usability

subdiff edited the task description. TASK DETAIL https://phabricator.kde.org/T5412 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff Cc: broulik, #vdg, plasma-devel, #plasma, subdiff, drosca, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts

[Differential] [Request, 110 lines] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff created this revision. subdiff added a project: Plasma. REVISION SUMMARY Based on https://phabricator.kde.org/D2314. Additionally adds a button to open context menu and always shows ports in the menu (greyed out if only one available). F282: Screenshot_20170223_204846.png

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff added a comment. In https://phabricator.kde.org/D4751#89222, @Zren wrote: > Looks like the icon is really small in plasmoidviewer? Using scaling factor 2 on 4K. Have no idea why it looks this way for you. > Just wondering why you used a IconItem+MouseArea pattern for t

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff added inline comments. INLINE COMMENTS > drosca wrote in ListItemBase.qml:135 > As @Zren pointed out, please change it to ToolButton. This is actually a > button, so there is no reason to make it IconItem + MouseArea. Also as it is > now, it breaks accessibility. How does it break acce

[Differential] [Accepted] D4491: Let make taskmanager tooltip readable again

subdiff accepted this revision. subdiff added inline comments. INLINE COMMENTS > ToolTipInstance.qml:108 > height: undefined > +maximumLineCount: 2 > elide: Text.ElideRight Because of this the tooltips aren't the same height when one of them has

[Differential] [Request, 32 lines] D4792: [Kicker] Property for hiding app categories in RootModel

subdiff created this revision. subdiff added a project: Plasma. REVISION SUMMARY With RootModel it is possible to represent pretty much any combination of other Kicker models. What's not yet possible is to show for example exclusively "All Applications" together with "Recent Applications", but

[Differential] [Request, 164 lines] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

subdiff created this revision. subdiff added a project: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The ToolButton has a rather odd looking style, which often conflicts with its placement and other lines in

[Differential] [Updated] D4800: [Task Manager] text elide doesn't work for Tooltips

subdiff added a comment. Removing the undefineds increases the margins between the lines again. @anthonyfieroni had another fix for the elide a few days ago by setting the maximumLineCount property. He hadn't yet pushed it though. I would go for his solution if it retains the margins. You co

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

subdiff added a comment. I see where you're coming from. You're right, that the rounded edges don't fit so well to other Plasma element. So I would try to find another design, because I still think the current ToolButton is ugly. Let me make it more clear, what I dislike about the current (f

[Differential] [Updated, 169 lines] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

subdiff updated this revision to Diff 11853. subdiff added a comment. Replicate the design of QToolButton (used for example in the tool bars of System Settings and Dolphin). F2617274: Spectacle.oB6068.png REPOSITORY R242 Plasma Framework (Library)

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

subdiff added a comment. In https://phabricator.kde.org/D4797#90126, @broulik wrote: > Design looks ok but still you can't change `ToolButtonStyle`, instead, the Breeze Plasma theme needs to be changed. Sorry, I didn't quite get it the last time you mentioned it. I think I unders

[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

subdiff added a comment. In https://phabricator.kde.org/D4491#90362, @anthonyfieroni wrote: > At least i plan to commit it from tomorrow release, so title 1 line or 2 lines ? After the pic

[Differential] [Commented On] D4792: [Kicker] Property for hiding app categories in RootModel

subdiff added a comment. In https://phabricator.kde.org/D4792#90384, @hein wrote: > I'm not sure I like it. Maybe it's better to expose more of the individual models in the plugin so you can instanciate them directly? Well, you can already use most of the indivdiual models, for ex

[Differential] [Abandoned] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

subdiff abandoned this revision. subdiff added a comment. Not anymore relevant thanks to https://phabricator.kde.org/D4827. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4797 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Updated, 95 lines] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff updated this revision to Diff 11914. subdiff marked 15 inline comments as done. subdiff added a comment. After https://phabricator.kde.org/D4827 has landed, I'm finally able to update this Diff without crying into my pillow every evening (Yeah, maybe I'm exaggerating, but the former T

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff added a comment. In https://phabricator.kde.org/D4751#89462, @Zren wrote: > ... Looks quite complicated in the end. I would like to avoid that. Can you test my current work around? It just uses the slider height for the ToolButton size. Works quite well on my system and m

[Differential] [Updated, 99 lines] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff updated this revision to Diff 11917. subdiff marked 2 inline comments as done. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4751?vs=11914&id=11917 REVISION DETAIL https://phabricator.kde.org/D4751 AFFECTED FILES applet/content

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff added a comment. In https://phabricator.kde.org/D4751#90677, @Zren wrote: > I mentioned earlier: > > > Using Layout.maximumHeight: parent.height on the ToolButton will make it 18px tall, but will also make the icon tiny by default (because it keeps the padding). We can bypass

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff added a comment. In https://phabricator.kde.org/D4751#90695, @Zren wrote: > Ah! Sorry bout that, `/usr/lib/x86_64-linux-gnu/qt5/qml/QtQuick/Controls/Styles/Plasma/ToolButtonStyle.qml` is different from what it shows in git. > > I copied the git source to that file, and while

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff added a comment. Since it looks ok for @drosca and me I'll commit it for now. Maybe we can fix your issue afterwards, or maybe you need to update something else to current master head (compiling via kdesrc-build is of course the most secure way of doing it). REPOSITORY R115 Plasma

[Maniphest] [Edited] T5412: Improve Plasma PA usability

subdiff edited the task description. TASK DETAIL https://phabricator.kde.org/T5412 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff Cc: Zren, broulik, #vdg, plasma-devel, #plasma, subdiff, drosca, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Closed] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

This revision was automatically updated to reflect the committed changes. Closed by commit R115:f063ff829928: [Applet] Context Menu per device/stream to offer additional functionality (authored by subdiff). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabrica

[Differential] [Accepted] D4837: Applet: Make volume indicator icon bigger

subdiff accepted this revision. subdiff added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ListItemBase.qml:123 > +roundToIconSize: false > +Layout.preferredWidth: Math.round(slider.height * > 0.95) > +

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff added a comment. Yes, today it's on my system too small as well (as @Zren described it already earlier). I'll investigate what's the reason and try to fix it in a new diff. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4751 EMAIL PREFERE

[Differential] [Updated] D4838: [Notifications] Add context menu for thumbnail

subdiff added subscribers: colomar, subdiff. subdiff added a comment. That's an awesome idea Kai! I normally only want to open the containing folder and not the screenshot directly, so I was really missing this functionality. Would it be a good idea to not make this as a right click context

[Differential] [Changed Subscribers] D4837: Applet: Make volume indicator icon bigger

subdiff added a subscriber: andreask. subdiff added inline comments. INLINE COMMENTS > drosca wrote in ListItemBase.qml:123 > Because `slider.height` is already too big (it's like half of the main > device/app icon size). > > We should change the microphone-sensitivity icons to look same as the

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

subdiff added a comment. I thought of something like this: F2668672: Screenshot_20170228_114914.png Is this in line with the HIG? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4838 EMAIL PREFERENCES https://phabr

[Differential] [Accepted] D4845: Fix context menu button's icon size when on default DPI

subdiff accepted this revision. subdiff added a comment. This revision is now accepted and ready to land. Tested it and works well. You can omit the `!parent.flat` condition as @drosca said, since it's always false. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabr

[Differential] [Request, 56 lines] D4867: [Menu] Improved available space correction for openRelative

subdiff created this revision. subdiff added a project: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY There was already some kind of detection and adjustment if there is not enough space for the popup availabl

[Differential] [Updated] D4867: [Menu] Improved available space correction for openRelative

subdiff edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4867 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma Cc: plasma-devel, #frameworks, progwolff, lesliezha

[Differential] [Request, 2 lines] D4868: [TaskManager] For contextMenuComponent placement use accurate enum on right edge

subdiff created this revision. subdiff added a project: Plasma. REVISION SUMMARY The contextMenuComponent uses currently `TopPosedLeftAlignedPopup` for its placement property if it is on the right edge. Until now this had no influence because of the flawed space correction in plasma-framework.

D4868: [TaskManager] For contextMenuComponent placement use accurate enum on right edge

This revision was automatically updated to reflect the committed changes.Closed by commit R119:67e490f48d2c: [TaskManager] For context menu placement use accurate enum on right edge (authored by subdiff). View RevisionREPOSITORYR119 Plasma DesktopCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org

D4867: [Menu] Improved available space correction for openRelative

This revision was automatically updated to reflect the committed changes.Closed by commit R242:daee27f0962d: [Menu] Improve available space correction for openRelative (authored by subdiff). View RevisionCHANGED PRIOR TO COMMIThttps://phabricator.kde.org/D4867?vs=12015&id=12094#tocREPOSITORYR242 Pl

D4904: [Applet] Open contextMenu relatively to visual parent contextMenuButton

subdiff created this revision.subdiff added a project: Plasma. View RevisionREVISION SUMMARYThis will open the context menu aligned to its button and will not hide the button if there is not enough space for it: F2675613: 1.png F2675614: 2.png Thanks to @broulik for the advice.REPOSITORYR115 Plas

  1   2   3   4   5   6   7   8   9   10   >