D28194: Fix loading button icons from qrc

2020-10-09 Thread Nicolas Fella
nicolasfella abandoned this revision. nicolasfella added a comment. Abandoning in favor of https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/35 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D28194 To: nicolasfella, #pl

[kwrited] [Bug 429652] [Feature Request] Notification applet should also save images

2020-11-25 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=429652 Nicolas Fella changed: What|Removed |Added Resolution|WAITINGFORINFO |NOT A BUG CC

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

2020-12-14 Thread Nicolas Fella
nicolasfella added a comment. @leinir it seems like this was merged so I guess this should be closed? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25961 To: leinir Cc: nicolasfella, apol, zachus, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jr

Re: theming questions

2020-12-23 Thread Nicolas Fella
On 23.12.20 20:05, Dirk Hohndel wrote: Hi there and happy holidays I'm trying to improve the theming of my Kirigami-based app. We started using Kirigami about 5 years ago (before the current Theme code was there) and have done a lot of rather brute force things along the way (mostly out of in

Consistent CMake requirements in Plasma

2021-02-09 Thread Nicolas Fella
Hi, while I was doing some cmake cleanup in Plasma I noticed that our stated minimum cmake versions are both somewhat inconsistent and super old. Most Plasma projects state that either 2.8 (released in 2009) or 3.0 (released in 2014) are the minimum. That's obviously unrealistic. Newer cmake ver

Fwd: Consistent CMake requirements in Plasma

2021-02-24 Thread Nicolas Fella
any distro that does not ship at least CMake 3.16 interested in shipping future Plasma releases? Cheers Nico Forwarded Message Subject:Consistent CMake requirements in Plasma Date: Tue, 9 Feb 2021 19:32:36 +0100 From: Nicolas Fella Reply-To: plasma-devel

Re: Consistent CMake requirements in Plasma

2021-03-01 Thread Nicolas Fella
Hi, so far I haven't received any negative feedback on this and got acknowledgements from Debian, Fedora and OpenSUSE. Unless someone objects within the next 24 hours I suggest that we proceed with this. Cheers Nico On 2/9/21 7:32 PM, Nicolas Fella wrote: Hi, while I was doing some

Re: Consistent CMake requirements in Plasma

2021-03-04 Thread Nicolas Fella
Hi, I have now bumped the requirement for all Plasma repos. There was one resulting build failure in kinfocenter that has been corrected. Let me know if you notice any other unusual behavior. Cheers Nico On 3/1/21 12:30 PM, Nicolas Fella wrote: Hi, so far I haven't received any neg

Re: KDE CI: Plasma » kinfocenter » kf5-qt5 SUSEQt5.15 - Build # 93 - Failure!

2021-03-11 Thread Nicolas Fella
See https://invent.kde.org/plasma/kinfocenter/-/merge_requests/24 On 3/4/21 12:25 PM, CI System wrote: *BUILD FAILURE* Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20SUSEQt5.15/93/

Re: Re-purposing KWaylandServer

2021-04-29 Thread Nicolas Fella
Hi, I noticed that the current split makes it very hard to perform git bisect on kwin given its close relation to kwayland-server. Therefore big +1 from me to incorporating kwaylandserver into the kwin repo. Cheers Nico On 4/29/21 3:14 PM, Vlad Zahorodnii wrote: On 4/28/21 4:27 PM, Aleix Pol

Re: Akademy Plasma Bof

2021-06-09 Thread Nicolas Fella
On 07/06/2021 10:42, Marco Martin wrote: Hi all, Do we want a plasma bof at akademy? often we do a full day one, which may or may not be useful, depending on what topic we do have. Personally i would like to make one about plasma 6 Any day/time preference? other topics? Hi, in terms of topics

Re: Maliit Keyboard and Plasma

2021-06-24 Thread Nicolas Fella
Hi, On 24/06/2021 20:17, Jonathan Riddell wrote: It's unclear to me if Plasma expects or needs Maliit to be installed. Technically speaking it does not expect Maliit, any keyboard implementing the required Wayland protocol will do. Maliit happens to be the one we tend to test and it's what we

Re: Maliit as Plasma's on-screen keyboard

2021-06-28 Thread Nicolas Fella
Hi, On 28.06.21 09:12, Tobias C. Berner wrote: Moin moin I'm a bit concerned about it seeming to be built on a stack of abandonware -- qtfeedback (no release), and presage (2015). mfg Tobias On Fri, 25 Jun 2021 at 16:38, Aleix Pol wrote: Dear distros, It's been pointed out to me that we ne

plasma_install_package vs plasma_install_bundled_package

2021-07-29 Thread Nicolas Fella
Hi, in https://invent.kde.org/frameworks/plasma-framework/-/blob/master/KF5PlasmaMacros.cmake#L12 we recommend using plasma_install_bundled_package over plasma_install_package. However in practice we always use the latter, except for plasma-pa and plasma-nm. I stumbled across this because the b

Re: plasma_install_package vs plasma_install_bundled_package

2021-07-29 Thread Nicolas Fella
initial patch description it was stated that it is experimental :) Regards Alex On Thursday, July 29, 2021 2:29:01 PM CEST Nicolas Fella wrote: > Hi, > > in > https://invent.kde.org/frameworks/plasma-framework/-/blob/master/KF5PlasmaMa > cros.cmake#L12 we recommen

Using C++20 in Plasma

2021-08-06 Thread Nicolas Fella
Hi, I would like to explore whether it would be feasible from a distribution POV to use C++20 in Plasma (and other non-Frameworks projects). In practical terms this would mean something like requiring gcc 10 or clang 10 (the exact version that supports a given standard is hard to define precisel

Re: KDE CI: Plasma » breeze » kf5-qt5 SUSEQt5.15 - Build # 267 - Still Failing!

2021-08-10 Thread Nicolas Fella
Should be fixed with https://invent.kde.org/frameworks/kwindowsystem/-/merge_requests/30 On 10.08.21 20:36, CI System wrote: *BUILD FAILURE* Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20SUSEQt5.15/267/

Re: polkit-kde-agent-1 build failure

2021-08-26 Thread Nicolas Fella
Hi, Should be fixed with https://invent.kde.org/libraries/polkit-qt-1/-/merge_requests/18 On 26/08/2021 13:19, Jonathan Riddell wrote: I wonder if anyone has ideas on a build failure I'm getting in polkit-kde-agent-1 https://build.neon.kde.org/job/focal_stable_kde_polkit-kde-agent-1_bin_amd64

Re: Gitlab CI - Inbound

2021-09-05 Thread Nicolas Fella
On 05.09.21 08:13, Ben Cooksley wrote: Hi all, This morning after much work i'm happy to announce that the new generation CI scripts intended for use with Gitlab CI successfully completed their first build (of ECM, and then subsequently of KCoreAddons). This begins our first steps towards trans

[plasmashell] [Bug 447389] Notifications widget in the system tray shows items that are not clickable

2021-12-22 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=447389 Nicolas Fella changed: What|Removed |Added Component|general |Notifications Product|kwrited

Re: Next Plasma LTS?

2022-01-10 Thread Nicolas Fella
On 1/10/22 12:51, David Edmundson wrote: The last 5.X release definitely needs to be an LTS. That's unmovable. We can't have two active LTSs, it'd be a backporting nightmare and at best it would be a lie to claim we're actively supporting both. An LTS now effectively means we can't start Plasm

Plasma 6 Kickoff sprint

2022-01-13 Thread Nicolas Fella
Hi, recently there was some discussion on Plasma 6 branching/timeline. At the KF6 meeting we figured it would help finding a timeline if we had some discussion on what kind of (architectural) changes we want to make. I know that Marco has some ideas in particular around plasma-framework and appl

[Powerdevil] [Bug 359142] powerdevil ignores "even when external monitor connected" option

2022-02-15 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=359142 Nicolas Fella changed: What|Removed |Added CC||nicolas.fe...@gmx.de Resolution

Monday Meeting Notes for 28/3/2022

2022-03-28 Thread Nicolas Fella
Marco: Wayland: Merged realtime screen edges support touch friendly changes for Overview Breeze: More tablet mode friendlyness for breeze qstyle, change on the fly and enlarge many controls https://invent.kde.org/plasma/kwin/-/merge_requests/2168 https://invent.kde.org/plasma/breeze/-/merge_req

Re: [GSoC Draft proposal] Redesign system settings modules by porting them to QtQuick

2022-04-02 Thread Nicolas Fella
Hi, On 3/31/22 19:04, Smit Patil wrote: Hello all, I'm looking for potentials mentors for GSoC 2022 to review/comment my draft proposal for this task:- https://community.kde.org/GSoC/2022/Ideas#Plasma_modernise_system_settings_modules I think for the Font Management KCM there was a conclusion

Parent windows for system dialogs

2022-06-28 Thread Nicolas Fella
Hi, we have several places where we have "system" dialogs that don't have a "real" parent window. Examples would be stuff like KWallet, network management, or anything spawned by kded where there's no corresponding app window. Currently, at least on Wayland, they are placed semi-randomly on the s

Re: Parent windows for system dialogs

2022-06-29 Thread Nicolas Fella
On 6/29/22 09:10, Vlad Zahorodnii wrote: On 6/29/22 01:35, Nicolas Fella wrote: Hi, we have several places where we have "system" dialogs that don't have a "real" parent window. Examples would be stuff like KWallet, network management, or anything spawned by kded where

C++/library requirements for Plasma 5.26

2022-07-07 Thread Nicolas Fella
Hi, for Plasma 5.26 I would like to make use of some C++20 features, in particular coroutines. In terms of compiler requirements this should translate to requiring GCC 10 or Clang 11. In addition we would like to require the qcoro library (https://github.com/danvratil/qcoro). As per https://git

Re: C++/library requirements for Plasma 5.26

2022-07-29 Thread Nicolas Fella
On 07/07/2022 19:24, Ivan Čukić wrote: You might very well not be reading this correctly, as it's phrased very ambiguously: Very likely. It is just that the ambiguous wording with the conclusion didn't give me the confidence of the quality of implementation. However, C++20 also brought dozens

Re: C++/library requirements for Plasma 5.26

2022-07-29 Thread Nicolas Fella
On 07/07/2022 14:08, Nicolas Fella wrote: Hi, for Plasma 5.26 I would like to make use of some C++20 features, in particular coroutines. In terms of compiler requirements this should translate to requiring GCC 10 or Clang 11. In addition we would like to require the qcoro library (https

Re: Latte Dock Farewell

2022-07-30 Thread Nicolas Fella
On 7/27/22 13:14, Aleix Pol wrote: On Wed, Jul 27, 2022 at 12:15 PM Jonathan Riddell wrote: Michail has announced he's not going to be developing Latte Dock in future https://psifidotos.blogspot.com/2022/07/latte-dock-farewell.html Thanks for all your work Michail! As far as we can tell Latte

Re: testing UIs and improving a11y all at once!

2022-08-10 Thread Nicolas Fella
Am 10.08.22 um 12:29 schrieb Harald Sitter: Servus, A while ago I prototyped a "new" approach to UI testing and I'm wondering if there's general interest in doing more Plasma testing using it. I'm able to invest time in polishing the experience for us. Very rough prototype: https://invent.kde.o

New bugfix release for plasma-workspace

2022-09-17 Thread Nicolas Fella
Hi, Plasma 5.25 has no planned releases any more, but the Plasma/5.25 branch in plasma-workspace has accumulated two fixes for somewhat important bugs (https://bugs.kde.org/show_bug.cgi?id=458829 and https://bugs.kde.org/show_bug.cgi?id=458865). The former is a regression introduced in 5.25.5. In

Monday meeting notes for 07/11/2022

2022-11-07 Thread Nicolas Fella
David E: nothing Arjen: so I'm looking into some kwin performance related things, currently focusing on activation lag when activating the window view effect from the taskbar which has lead me to a deep dive into framesvg and related things in plasma as qml profiling showed that creating PC3 butt

Splitting KGlobalAccel interface and runtime

2023-02-13 Thread Nicolas Fella
Hi, the kglobalaccel framework currently contains two pieces: kglobalacceld, the runtime component that manages global shortcuts, and an application-side library to interact with it. The two communicate with each other via DBus. On X11 there is a standalone kglobalacceld5 process providing the i

Plasma master switches to Qt6

2023-02-27 Thread Nicolas Fella
Hi, The master branch for Plasma repos will be made Qt6-only tomorrow, 28.02.2023. There will be disruption because of this. While we aim for getting a basic workspace running as soon as possible non-essential functionality might be broken for a while. Existing kdesrc-build setups will be switc

Plasma repositories sprint cleaning

2023-03-03 Thread Nicolas Fella
Hi, while porting Plasma repos to Qt6 I've come across several repos in the plasma/ namespace on invent that I found questionable: - khotkeys: consensus seems to be to abandon it, because maintaining two global shortcut systems is no joy: https://phabricator.kde.org/T2050. It's still released wi

Re: Plasma repositories spring cleaning

2023-03-03 Thread Nicolas Fella
Am 03.03.23 um 13:45 schrieb Nicolas Fella: Hi, while porting Plasma repos to Qt6 I've come across several repos in the plasma/ namespace on invent that I found questionable: - khotkeys: consensus seems to be to abandon it, because maintaining two global shortcut systems is no joy:

Plasma Sprint 2023

2023-03-16 Thread Nicolas Fella
Hi, I guess we can all agree that it's high time for another Plasma Sprint. We are in contact with Tuxedo, who kindly agreed to host us in their office in Augsburg, Germany. To find a suitable date I've created a poll, ranging from May to early June. Please add yourself there so we can plan acc

Re: Plasma repositories sprint cleaning

2023-03-18 Thread Nicolas Fella
Hi, ksysguard, kwayland-server, plasma-active-window-control, plasma-redshift-control, and plasma-tests are now archived. On Fri, Mar 3, 2023 at 1:45 PM Nicolas Fella wrote: - khotkeys: consensus seems to be to abandon it, because maintaining two global shortcut systems is no joy: https

Ping: Plasma Sprint 2023

2023-03-22 Thread Nicolas Fella
On 3/16/23 17:38, Nicolas Fella wrote: Hi, I guess we can all agree that it's high time for another Plasma Sprint. We are in contact with Tuxedo, who kindly agreed to host us in their office in Augsburg, Germany. To find a suitable date I've created a poll, ranging from May to

Re: kpipewire and sddm theme in plasma6

2023-03-25 Thread Nicolas Fella
Am 25.03.23 um 19:47 schrieb Harald Sitter: and breeze widget style that will need to be available for qt5 :( On Fri, Mar 24, 2023 at 10:29 AM Harald Sitter wrote: Ciao It occurred to me that we have some compatibility problems coming up. Notably the sddm login theme (which is used by sddm -

Re: Plasma Sprint 2023

2023-03-29 Thread Nicolas Fella
Am 16.03.23 um 17:38 schrieb Nicolas Fella: Hi, I guess we can all agree that it's high time for another Plasma Sprint. We are in contact with Tuxedo, who kindly agreed to host us in their office in Augsburg, Germany. To find a suitable date I've created a poll, ranging from May to

Re: Plasma Sprint 2023

2023-04-02 Thread Nicolas Fella
Am 29.03.23 um 15:15 schrieb Nicolas Fella: Am 16.03.23 um 17:38 schrieb Nicolas Fella: Hi, I guess we can all agree that it's high time for another Plasma Sprint. We are in contact with Tuxedo, who kindly agreed to host us in their office in Augsburg, Germany. To find a suitable date

Re: Plasma Sprint 2023

2023-04-07 Thread Nicolas Fella
Am 02.04.23 um 17:09 schrieb Nicolas Fella: Am 29.03.23 um 15:15 schrieb Nicolas Fella: Am 16.03.23 um 17:38 schrieb Nicolas Fella: Hi, I guess we can all agree that it's high time for another Plasma Sprint. We are in contact with Tuxedo, who kindly agreed to host us in their offi

Plasma Sprint Topics

2023-04-08 Thread Nicolas Fella
Hi, with the sprint all in order it's time to collect some topics. Of course we don't want to pre-plan the whole week, and there will be lots of time for free-form discussion and hacking, but having some topics known from the start could help structure the whole thing a bit. This is particularl

Moving print-manager and wacomtablet to Plasma

2023-06-24 Thread Nicolas Fella
Hi, print-manager and wacomtablet are in a somewhat odd place currently. They provide integration of (printers|tablets) into Plasma via KCMs, kded modules, plasmoids etc, to the point where they are not that useful outside of Plasma (technically they should mostly work outside of Plasma, but it d

Remaining plasma-framework KF6 tasks

2023-07-09 Thread Nicolas Fella
Hi, on the KF6 workboard there's a number of plasma-framework related tasks that are still open. Some of them are actionable, others probably not or need discussion. I would appreciate if someone could go over the open tasks and triage them, i.e. determine whether we consider them done, whether

Re: Remaining plasma-framework KF6 tasks

2023-07-09 Thread Nicolas Fella
Am 09.07.23 um 12:56 schrieb Nicolas Fella: Hi, on the KF6 workboard there's a number of plasma-framework related tasks that are still open. Some of them are actionable, others probably not or need discussion. I would appreciate if someone could go over the open tasks and triage them

Porting aid place for Plasma stuff?

2023-08-02 Thread Nicolas Fella
Hi, on several occasions we found API in Frameworks that we would like to remove, but is still used in more than one place in Plasma and it may not be feasible to port all of these usages in time for (Frameworks) 6.0. There's a few things that fall in this category that come to my mind: - KWayl

KF6/Plasma 6 packaging notes

2023-08-11 Thread Nicolas Fella
Hi, I'm happy that more and more distros are looking into packaging an experimental KF6/Plasma 6 session. Since there are some non-obvious things to keep in mind while doing that I started collecting some packaging notes/information in https://community.kde.org/Plasma/Plasma_6#Packaging_notes. I

Monday meeting notes for 25/09/2023

2023-09-25 Thread Nicolas Fella
redstrate: I did some accessibility-related work, some of which is already merged: I fixed a kaccess bug causing some options to become out of sync (https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1736). Redone the appearance of the accessibility KCM, so it looks a bit nicer. (http

Monday meeting notes for 09/10/2023

2023-10-09 Thread Nicolas Fella
Meven: I am written the kcm wallpaper, it is progressing, it updates the any screen wallpaper and display the screen layout A bunch of things are left to do, hopefully will have a draft later this week And I will be merging the dbus backend redstrate: not much, just a leftover from last week: h

Renaming Plasma's applications.menu file

2023-10-19 Thread Nicolas Fella
Hi, In KF5 KService ships /etc/xdg/menus/applications.menu, our menu definition according to https://specifications.freedesktop.org/menu-spec/menu-spec-1.0.html Since this will cause a conflict between KF5 and KF6 (and potentially other desktop environments) for Plasma 6 I'm planning to: - Move

[Powerdevil] [Bug 365100] Pressing the physical power button is ignored with certain hardware

2023-10-23 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=365100 Nicolas Fella changed: What|Removed |Added CC||nicolas.fe...@gmx.de --- Comment #12 from

Re: Plasma 6 alpha modules list

2023-10-28 Thread Nicolas Fella
In https://mail.kde.org/pipermail/release-team/2023-June/013081.html I proposed to move print-manager and wacomtablet from Gear to Plasma. Nobody objected so I guess we can move forward with this? On 10/27/23 17:39, Jonathan Riddell wrote: 12 days to go until the first alpha release, it's time t

Re: print-manager and wacomtablet to Plasma

2023-10-31 Thread Nicolas Fella
On 10/31/23 23:23, Albert Astals Cid wrote: El dimarts, 31 d’octubre de 2023, a les 20:43:47 (CET), Jonathan Riddell va escriure: As discuccsed in Plasma meeting and just now with KDE gear release spods, Plasma would like to take over releases of print-manager and wacomtablet. This means renumbe

Re: print-manager and wacomtablet to Plasma

2023-10-31 Thread Nicolas Fella
On 11/1/23 00:28, Nicolas Fella wrote: On 10/31/23 23:23, Albert Astals Cid wrote: El dimarts, 31 d’octubre de 2023, a les 20:43:47 (CET), Jonathan Riddell va escriure: As discuccsed in Plasma meeting and just now with KDE gear release spods, Plasma would like to take over releases of print

Applet config dialog changes

2023-11-04 Thread Nicolas Fella
Hi, I have an open MR that changes how applet's config UI integrates with the container UI: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1675 See https://invent.kde.org/plasma/plasma-desktop/-/issues/99 for some context. The benefits would not only be somewhat cleaner internals

Re: plasma-framework

2023-11-07 Thread Nicolas Fella
On 11/7/23 12:22, Jonathan Esk-Riddell wrote: On Sun, Nov 05, 2023 at 12:59:28PM +0100, Friedrich W. H. Kossebau wrote: kactivities and kactivities-stats: please consider proper de-KF-ication now Hi, with plasma-framework, kactivities and kactivities entering the Plasma product bundle, I assum

Re: QML: a packagers nightmare. Assistance please.

2023-11-08 Thread Nicolas Fella
On 11/8/23 17:11, Scarlett Moore wrote: While I have everyone's attention. The part that is getting me ( and our linters ) is qml installation paths seem all over the place For example plasma-framework we have org.kde.plasma.plasmoids which I read in the docs is "identified" qml which states it

Re: more betas / shorter windows?

2023-12-18 Thread Nicolas Fella
On 12/18/23 18:42, Harald Sitter wrote: With the second p6 beta sneaking up on us I've been pondering the beta experience... I can't help but think that the windows we've chosen were too long. At least from a crash tracking POV most of the crash reports we get from !neon are either of unreasonab

Monday meeting notes for 15/01/2024

2024-01-15 Thread Nicolas Fella
Marco: fixed wheel to switch desktop action in folderview looking at why long touchscreen tap on the desktop crashes plasma, still no clue made an upstream merge request for layer shell to reserve edges also for corner-aligned panels refactored kirigami.Page to have global toolbars outside of it

Plasm 6.1 Kickoff Meeting notes

2024-03-11 Thread Nicolas Fella
# Plasma 6.1 kickoff meeting notes ## 6.0 retrospective Generally well received# Plasma 6.1 kickoff meeting notes ## 6.0 retrospective Generally well received Problems: - Neon's rollout was/still is bumpy. Needs retrospective from Neon developers on what happend - Nvidia:     - Missing config

Re: QtWayland 6.7.2 packaging recommendation

2024-08-06 Thread Nicolas Fella
On 09.07.24 11:14, Vlad Zahorodnii wrote: Hello, QtWayland 6.7.2 contains a regression with regards to initializing the popup parent, which can result in the plasmashell process getting killed in some circumstances (e.g. https://bugs.kde.org/show_bug.cgi?id=489259). The regression has been fixed

Re: Move Plasma Dialer and Spacebar to Plasma release

2024-08-22 Thread Nicolas Fella
On 22.08.24 13:29, Jonathan Riddell wrote: Plasma Dialer depends on KWin and Plasma Wayland Protocols, Spacebar (SMS messaging app) similarly depends on libplasma, so it would seem sensible to have these as part of Plasma releases. Where does Spacebar depend on libplasma? Repo freeze is in

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

2020-02-25 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > kdeplatformdependent.cpp:165 > +// directly requests the accounts kcm to start adding a new account if > it's not there, maybe even pre-fills the fields...) > +KService::List services = > KServiceTypeTrader::self()->query(QStringLite

D27781: [Language KCM] Wrap the label text

2020-03-02 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b2df03a51f97: [Language KCM] Wrap the label text (authored by PureTryOut, committed by nicolasfella). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27781?

D27786: [notifications] Read appname from desktop file if no appname set

2020-03-02 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Some applications, e.g. pamac, don't send an app_name, which is legal acco

D27786: [notifications] Read appname from desktop file if no appname set

2020-03-02 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in notification.cpp:333 > How about adjusting this condition instead? That codepath assumes we have a notifyrc REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27786 To: nicolasfella, #plasma,

D27786: [notifications] Read appname from desktop file if no appname set

2020-03-02 Thread Nicolas Fella
nicolasfella updated this revision to Diff 76783. nicolasfella added a comment. - Combine codepaths REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27786?vs=76780&id=76783 BRANCH notiappname REVISION DETAIL https://phabricator.kde.org/D27786

D27786: [notifications] Read appname from desktop file if no appname set

2020-03-02 Thread Nicolas Fella
nicolasfella marked 2 inline comments as done. nicolasfella added inline comments. INLINE COMMENTS > nicolasfella wrote in notification.cpp:333 > That codepath assumes we have a notifyrc nvm REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27786 To: nicolasfel

D27563: [mobile/wifi] Use ScrollViewKCM

2020-03-08 Thread Nicolas Fella
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R116:83ce03a41117: [mobile/wifi] Use ScrollViewKCM (authored by nicolasfella). REPOSITORY R116 Plasma Network Management

D27996: Fix undefined check in global drawer menu mode

2020-03-11 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Kamoso uses Overlaydrawer instead of GlobalDrawer, which has no isMenu pr

D27996: Fix undefined check in global drawer menu mode

2020-03-11 Thread Nicolas Fella
nicolasfella updated this revision to Diff 77465. nicolasfella added a comment. - use 'in' REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27996?vs=77458&id=77465 BRANCH fixkamoso REVISION DETAIL https://phabricator.kde.org/D27996 AFFECTED FILES sr

D27996: Fix undefined check in global drawer menu mode

2020-03-11 Thread Nicolas Fella
nicolasfella marked an inline comment as done. nicolasfella added inline comments. INLINE COMMENTS > apol wrote in PageRowGlobalToolBarUI.qml:49 > Wouldn't it be easier to do: > > visible: !Kirigami.Settings.isMobile && applicationWindow().globalDrawer && > applicationWindow().globalDrawer.is

D27574: Remove bold formatting of device name

2020-03-12 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R97:c190802e1e0a: Remove bold formatting of device name (authored by nicolasfella). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27574?vs=76178&id=77527 REVISION DET

D27572: [kcm] Drop 'Enable bluetooth integration' setting

2020-03-12 Thread Nicolas Fella
nicolasfella added a comment. In D27572#626285 , @drosca wrote: > What happens if someone have it disabled and updates Plasma with this change? Nothing immediately happens, but the module can be reenabled via the KDED KCM REPOSITORY R9

D27572: [kcm] Drop 'Enable bluetooth integration' setting

2020-03-14 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R97:2d92acae05f4: [kcm] Drop 'Enable bluetooth integration' setting (authored by nicolasfella). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27572?vs=76167&id=77629

D27996: Fix undefined check in global drawer menu mode

2020-03-14 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R169:4d84d3f1d93f: Fix undefined check in global drawer menu mode (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27996?vs=77465&id=77630 RE

D28065: Add missing types to qrc

2020-03-15 Thread Nicolas Fella
nicolasfella created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R169 Kirigami BRANCH types REVISION DETAIL https://phabricator.kde.org/D28065 AFFECTED FILES kirigami.qrc kirigami.

D28065: Add missing types to qrc

2020-03-16 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R169:f1ac443fefff: Add missing types to qrc (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28065?vs=77690&id=77707 REVISION DETAIL https:

D28068: Cleanup file resolving

2020-03-16 Thread Nicolas Fella
nicolasfella created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The current code is ... a mess. resolveFileUrl and resolveFilePath do very similar things, except that one returns a pa

D28077: [applet] Add tooltip to enable bluetooth checkbox

2020-03-16 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Plasma, VDG, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Thoroughly inspired by what plasma-nm does REPOSITORY R97 Bluedevil

D28077: [applet] Add tooltip to enable bluetooth checkbox

2020-03-16 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R97:a0bc4ed75f46: [applet] Add tooltip to enable bluetooth checkbox (authored by nicolasfella). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28077?vs=77735&id=77736

D28154: Add users KCM

2020-03-20 Thread Nicolas Fella
nicolasfella added a comment. > I seem to recall seeing that on a rough early version of @nicolasfella's version. That's the most urgently needed feature. I'm pretty sure I did no such thing and I also think it's not super important REPOSITORY R119 Plasma Desktop REVISION DETAIL htt

D28154: Add users KCM

2020-03-20 Thread Nicolas Fella
nicolasfella added a comment. Couple of nitpicks, mostly coding style and most of that probably comes from me. Can't say much otherwise since I wrote quite a bit of it INLINE COMMENTS > main.qml:100 > +Component.onCompleted: () => { > +print("compl") > +

D28194: [WIP] Fix loading button icons from qrc

2020-03-21 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Allow to use `icon.source: "qrc:/testicon.png"` in buttons. WIP as there

D28194: [WIP] Fix loading button icons from qrc

2020-03-21 Thread Nicolas Fella
nicolasfella added a comment. For more context see https://github.com/nextcloud/desktop/issues/1746 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D28194 To: nicolasfella, #plasma, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry

2020-03-26 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Else the entry is still in cfg_shownItems/cfg_hiddenItems and the config UI will d

D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry

2020-03-26 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R120:fede85a3d0ea: [applets/systemtray] Clear item from shown/hidden list when disabling entry (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28311?vs=78561&id=78563#toc

D28428: [screenlocker] listen to notifications from the notification server

2020-03-30 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > interface.cpp:213 > > +void Interface::Notify(const QString& app_name, uint replaces_id, const > QString& app_icon, > + const QString& summary, const QString& body, const > QStringList& actions, conding style: & afte

D28427: [libnotificationmanager] forward notifications to lockscreen

2020-03-30 Thread Nicolas Fella
nicolasfella added a comment. So notifications are only forwarded if x-kde-show-on-lockscreen is set? I wonder if opt-out (x-kde-dont-show-on-lockscreen) would be better with regard to third-party apps. From a privacy POV I think a global dont-show-notis-on-lockscreen thing would make more s

D25549: [kcms/keyboard] Port away from KToolInvokation

2020-04-02 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R119:13358835296e: [kcms/keyboard] Port away from KToolInvokation (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25549?vs=70360&id=791

D28526: [notifications] Hide close/configure buttons on mobile

2020-04-02 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The close button is not really needed since the notification can just be swiped aw

D28526: [notifications] Hide close/configure buttons on mobile

2020-04-05 Thread Nicolas Fella
nicolasfella added a comment. In D28526#640431 , @broulik wrote: > I think we also want to stop the animation/circle thing, too? Maybe shove all of it in a loader? Isn't that done automatically since the circle thing is a child of the clo

D28625: [WIP] Use ShadowedRectangle for Card backgrounds

2020-04-06 Thread Nicolas Fella
nicolasfella added a comment. This fixes https://bugs.kde.org/show_bug.cgi?id=415526 REPOSITORY R169 Kirigami BRANCH card_shadowrect REVISION DETAIL https://phabricator.kde.org/D28625 To: ahiemstra, #kirigami, #vdg, cblack Cc: nicolasfella, cblack, plasma-devel, fbampaloukas, GB_2, do

Virtual Plasma Mobile mini-sprint

2020-04-07 Thread Nicolas Fella
Hi, in our latest blog post[0] we announced a virtual Plasma Mobile mini-sprint. The purpose of this is multifold: - Discussions to drive Plasma Mobile forward - Help onboard new contributors that were not able to attend the physical sprint - Explore this kind of interaction as a replaceme

D28685: Use ListSectionHeader in ListView example

2020-04-08 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Kirigami. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R1014 Kirigami Gallery BRANCH sectionheader REVISION DETAIL https://phab

D28685: Use ListSectionHeader in ListView example

2020-04-08 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R1014:ae736f9febcd: Use ListSectionHeader in ListView example (authored by nicolasfella). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28685?vs=79661&id=7966

  1   2   3   4   5   6   >