Re: Raising windows on Wayland

2018-07-03 Thread Martin Flöser
Am 2018-07-03 14:45, schrieb Aleix Pol: Dear kwiners, Would it be possible to find a way to do so? I know we don't want windows to be positioning themselves willy-nilly on the window stack, but we certainly need to figure out his use-case. What would need to happen to do this? If you need to,

Re: Raising windows on Wayland

2018-07-03 Thread Martin Flöser
Am 2018-07-03 18:05, schrieb Aleix Pol: On Tue, Jul 3, 2018 at 6:02 PM Martin Flöser wrote: Am 2018-07-03 14:45, schrieb Aleix Pol: > Dear kwiners, > Would it be possible to find a way to do so? > > I know we don't want windows to be positioning themselves willy-nilly >

Re: Raising windows on Wayland

2018-07-03 Thread Martin Flöser
Am 2018-07-03 18:41, schrieb Aleix Pol: On Tue, Jul 3, 2018 at 6:32 PM Martin Flöser wrote: Am 2018-07-03 18:05, schrieb Aleix Pol: > On Tue, Jul 3, 2018 at 6:02 PM Martin Flöser > wrote: >> >> Am 2018-07-03 14:45, schrieb Aleix Pol: >> > Dear kwiners, >> >

Re: Raising windows on Wayland

2018-07-03 Thread Martin Flöser
Am 2018-07-03 18:58, schrieb David Edmundson: Ideally this needs to be standardized so that it does not only work with our applications but with any. Even within just KDE apps, we have code like QDesktopServices spawning links in code we can't manipulate. Anything non standard, simply isn't

Re: Discussion for Virtual Desktops and Activities future

2018-07-15 Thread Martin Flöser
Hi all, just chiming in to give some KWin perspective. Activities are weird and we (Thomas and I) never knew what they are and how we should integrate them in KWin. The existing code is just a bad copy of virtual desktops (bad because it copied the code 1:1 without understanding what it does

D14264: Disconnect decoration button requestHover tooltip on decoration destuction

2018-07-21 Thread Martin Flöser
graesslin added a comment. The hovered state cannot change if there is no decoration. Hover is from an event handler from Decoration. I doubt that this change here can fix the crash. Also that's the explanation for the update slot not checking: no hover change if there's no decoration.

D14264: Disconnect decoration button requestHover tooltip on decoration destuction

2018-07-21 Thread Martin Flöser
graesslin added a comment. What's really strange is that requestShowTooltip comes from the event loop. But nothing in kdecoration or in KWin goes through a queued event to KWin::Decoration::DecoratedClientImpl::requestShowToolTip. Could it be a decoration plugin causing this? REPOSITORY

Re: KDE Connect clipboard integration doesn't work on Wayland

2018-08-01 Thread Martin Flöser
Am 2018-08-01 17:43, schrieb Aleix Pol: Hey, One of the most useful features in KDE Connect is the clipboard integration, this is not working currently. I'm guessing it's a privileges issue, I was wondering if it would maybe be possible to fix it by doing something like we're doing for fake input

Re: Akademy BOF Topics

2018-08-01 Thread Martin Flöser
Am 2018-08-01 17:01, schrieb David Edmundson: We currently have a bunch of slots booked as general "Plasma". We should split them up into relevant topics people actually want to discuss so people know when to turn up to what. In case there is something you want me to remote participate: I can

Re: KWin tests on FreeBSD all timing out

2018-08-03 Thread Martin Flöser
Am 2018-08-03 12:04, schrieb Ben Cooksley: Hi all, Sometime recently there was a change in the KWin / FreeBSD world which means all KWin tests now fail on FreeBSD, and instead of exiting nicely simply fail with a timeout on the CI system. As a consequence this means KWin builds now tie up build

D14923: Supress paste in screen locker

2018-08-18 Thread Martin Flöser
graesslin added a comment. I like this solution. As a matter of fact the default options of Klipper are also fine. Only if the not default prevent empty clipboard option is used this breaks. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D14923 To: davidedmun

D14924: Prevent paste in screen locker (alternative approach)

2018-08-18 Thread Martin Flöser
graesslin added a comment. I like the other solution better as it doesn't depend on Klipper specific behavior. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D14924 To: davidedmundson, #plasma Cc: graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, a

D14923: Supress paste in screen locker

2018-08-21 Thread Martin Flöser
graesslin added a comment. In D14923#311845 , @davidedmundson wrote: > > . As a matter of fact the default options of Klipper are also fine. Only if the not default prevent empty clipboard option is used this breaks. > > Code says otherwise.

D15410: Handle clients which change window metadata during early startup

2018-09-10 Thread Martin Flöser
graesslin added a comment. I just want to point out that such applications are not ICCCM compliant: This property must be present when the window leaves the Withdrawn state and may be changed only while the window is in the Withdrawn state. Window managers may examine the property only when

D14949: Add option for whether to show the volume change OSD

2018-10-01 Thread Martin Flöser
graesslin added a comment. Please don't introduce options based on what's unpopular on Reddit. REVISION DETAIL https://phabricator.kde.org/D14949 To: anonym, #vdg Cc: graesslin, svenmauch, ngraham, romangg, mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jens

Re: My ksmserver plans

2018-10-01 Thread Martin Flöser
Sounds good! Cheers Martin Am 1. Oktober 2018 13:46:56 MESZ schrieb David Edmundson : >I was making a few ksmserver patches, I thought I should document what >my >long term plans are so the patches make sense. > >https://phabricator.kde.org/T9779 > >It's not an urgent task, so might spread over

D14949: Add option for whether to show the volume change OSD

2018-10-02 Thread Martin Flöser
graesslin added a comment. It's not about that there are only complaints on Reddit. It's about the user group: do we want to deaign so that the small Reddit community is happy or do we want to design for the rest? Do we want to make the product more complicated (yes that's the result of a co

D16425: Added new Suspend then Hibernate option

2018-10-26 Thread Martin Flöser
graesslin added a comment. I would suggest to turn "suspend then hibernate" into the new suspend. And one just can specify in the ui how long it takes till hibernate (which could also be endless). REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D16425 To: avaldes

D12997: Add new api to support window tabs

2018-11-06 Thread Martin Flöser
graesslin added a comment. In D12997#354190 , @zzag wrote: > Ping? The code doesn't work yet, the API is still lacking some functionality REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D12997 T

D15512: [startplasmacompositor] Add Wayland socket argument

2018-11-13 Thread Martin Flöser
graesslin added a comment. KWin does not have functionality to generate the socket. KWin doesn't need this functionality and shouldn't have this functionality and it would be difficult to implement. Given that I fully support this change. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D15512: [startplasmacompositor] Add Wayland socket argument

2018-11-14 Thread Martin Flöser
graesslin added a comment. In D15512#359253 , @fvogt wrote: > > KWin doesn't need this functionality and shouldn't have this functionality and it would be difficult to implement. > > Why? That goes entirely against what I and probably many ot

D16897: Allow windows to be closed from the window switchers

2018-11-15 Thread Martin Flöser
graesslin added a comment. I agree with David: please don't hardcode the key. Please don't use "W" - it has no meaning in a window manager, it's just the shortcut in some applications, others use Ctrl+Q and localized it could be something completely different. I suggest to implement thi

D16897: Allow windows to be closed from the window switchers

2018-11-15 Thread Martin Flöser
graesslin added a comment. In D16897#359900 , @ngraham wrote: > Good point, guys. I'll start with `StandardKey.Close` for now and see about making the KWin changes later (I'll admit I'm a bit intimidated by KWin's codebase!). I would pre

D16897: Allow windows to be closed from the window switchers

2018-11-16 Thread Martin Flöser
graesslin added a comment. In D16897#359912 , @ngraham wrote: > In D16897#359911 , @graesslin wrote: > > > In D16897#359900 , @ngraham wrote: > > > > >

D16943: Disable kcrash in greeter in same way as in KWin

2018-11-17 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY When running KWin's lock screen test I saw: KCrash: crashing... crashRecursionCoun

D16945: Fix fallback to built-in ui

2018-11-17 Thread Martin Flöser
graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY If the lock screen package is not available m_mainQmlPath is an empty URL. Thus view->setS

D16945: Fix fallback to built-in ui

2018-11-18 Thread Martin Flöser
graesslin updated this revision to Diff 45744. graesslin added a comment. Adjust in the way David suggested. REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16945?vs=45633&id=45744 BRANCH fix-fallback REVISION DETAIL https://phabricator.kde.org/D

D17217: Implement free memory notifier

2018-11-28 Thread Martin Flöser
graesslin added a comment. I don't think that this is useful - sorry. I run out of memory about once every five years, so polling every five seconds is way too often and a waste of resources. On the other hand the time when it happens polling 5 sec is way too low as then we are already dead.

D17659: Set parent window for dialogs

2018-12-19 Thread Martin Flöser
graesslin added a comment. In D17659#379007 , @apol wrote: > LGTM, I also missed this! > > Maybe it would make sense to add a TODO about implementing it for Wayland? Even better would be to just implement it for Wayland. https://api.k

D17758: Disable KDE ServerDecoration on Qt > 5.12

2018-12-23 Thread Martin Flöser
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. I still have Qt 5.11, so I'll try to compile the change and give it a try. INLINE COMMENTS > kwaylandintegration.cpp:127 > + > +if (QLibraryInfo::version() >= QVersionNumber(5, 12

D17659: Set parent window for dialogs

2018-12-26 Thread Martin Flöser
graesslin added a comment. In D17659#379912 , @volkov wrote: > Is it possible to implement support for foreign windows in KWin QPA plugin? There is no such thing as a KWin QPA. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop

D17706: Fix lock screen focus

2019-01-09 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > greeterapp.cpp:460 > // w->setFocus(Qt::OtherFocusReason); // FIXME > +w->setFlags(w->flags() | Qt::X11BypassWindowManagerHint); > } David already said it: we cannot do this. Changing the X11BypassWindowManagerHint flag after the wind

D17659: Set parent window for dialogs

2019-01-09 Thread Martin Flöser
graesslin added a comment. In D17659#389728 , @volkov wrote: > I mean this plugin: https://cgit.kde.org/kwin.git/tree/plugins/qpa That is KWin's own plugin. No binary except KWin can use it. REPOSITORY R838 Flatpak Support: KDE Portal f

D16943: Disable kcrash in greeter in same way as in KWin

2019-01-12 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R133:552932c8baab: Disable kcrash in greeter in same way as in KWin (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16943?vs=45629&id=49329

D16945: Fix fallback to built-in ui

2019-01-12 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R133:dfd02160746b: Fix fallback to built-in ui (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16945?vs=45744&id=49330 REVISION DETAIL h

D18564: Remove support for KWin's QPA plugin for KWindowSystem

2019-01-27 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY KWin added a plugin for itself, thus it's no longer needed. See: 02a0561016c22be90

Re: Proposal: passing user idle time to systemd-logind

2019-05-26 Thread Martin Flöser
Am 2019-05-24 21:51, schrieb Aleix Pol: On Wed, May 22, 2019 at 6:13 PM Germano Massullo wrote: Hello, I am writing to you to propose the following reasoning, hoping that it can help making easier (just a bit) third parties development work on Linux. I am currently developing BOINC client user

Re: RFC: Running clang-format across all Plasma (and more?) repos

2019-07-11 Thread Martin Flöser
Am 2019-07-11 16:18, schrieb David Edmundson: One topic discussed at the recent Plasma sprint was that we should run a code formatting tool (clang-format) over all our repos to ease all future review comments about whitespace. All new contributions simply have to run the same tool and we get con

D22418: wayland: make automatic backend selection truly automatic

2019-07-12 Thread Martin Flöser
graesslin added a comment. Is there a real world situation where KWin is getting compiled twice with different settings? When adding the ifdefs this was based on feedback from distributions REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D22418 To: alexeymin, romangg,

D22418: WIP [wayland] make automatic backend selection truly automatic

2019-07-20 Thread Martin Flöser
graesslin added a comment. I'm not convinced that removing the ifdef is the solution to the problem. What you basically want is being able to do an out-of-tree build of a backend. Ideally you would want to install all the variants next to each other and be able to pick the correct one.

D9599: Create interface for passing server decoration palettes

2018-01-02 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D9599 To: davidedmundson, #plasma, graessl

D9608: [KScreen Effect] Fade opacity only for transparent windows

2018-01-02 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9608#184871, @luebking wrote: > Should the lock screen not be guarded by a black layer in the compositor? On Wayland that's the case. On X11 there is a bla

D9608: [KScreen Effect] Fade opacity only for transparent windows

2018-01-02 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9608#184901, @broulik wrote: > > As of the effect, maybe this should rather fade in a black layer than fade out everything else? > > I suppose. Do you have a

D9597: Move calls depending on $DISPLAY from startplasmacompositor to startplasma

2018-01-02 Thread Martin Flöser
graesslin added a comment. Looks good to me. Personally I would split it into two commits. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9597 To: fvogt, #plasma, davidedmundson Cc: graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, a

D9618: Don't send keyboard events to QWindows which have outputOnly property set

2018-01-02 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application edited projects, added Plasma; removed KWin. REVISION SUMMARY PlasmaCore.Dialog has a prope

D9625: Require Qt 5.7

2018-01-02 Thread Martin Flöser
graesslin added a comment. Please do this change in master and not in the bug fix branch. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9625 To: volkov, #plasma Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moham

D9625: Require Qt 5.9

2018-01-03 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D9625 To: volkov, #plasma, graesslin Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesl

D9638: [effects] add 'Slide Desktops' effect

2018-01-03 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Overall code looks good for me and the video looks really promising. I fear it's too late for 5.12, which is a pity. INLINE COMMENTS > slidedesktops.cpp:144 > +QRegion clipRegion = buildClipReg

D9638: [effects] add 'Slide Desktops' effect

2018-01-03 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Just putting it as an idea: maybe we should just drop the "old" slide desktop effect and replace it with this one? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zz

D9618: Don't send keyboard events to QWindows which have outputOnly property set

2018-01-03 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:f5f1f6ceb49d: Don't send keyboard events to QWindows which have outputOnly property set (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KW

D9647: Ignore outputOnly QWindows for pointer and touch events

2018-01-03 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application edited projects, added Plasma; removed KWin. REVISION SUMMARY The idea is to be output only

D9647: Ignore outputOnly QWindows for pointer and touch events

2018-01-03 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:6ab625ed9770: Ignore outputOnly QWindows for pointer and touch events (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE

D9516: [libinput] Add support for switch devices and events

2018-01-03 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9516 To: graesslin, #kwin, #plasma Cc: ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreut

D9656: Fix naming inconsistency

2018-01-04 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D9656 To: davidedmundson, #plasma, graessl

D9516: [libinput] Add support for switch devices and events

2018-01-04 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:ac2f41c86d3b: [libinput] Add support for switch devices and events (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin CHANGES SINCE LAS

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

2018-01-04 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. I'm not sure whether you understood the feature request correctly. I understood it as for the application mode it should not be changed, but for the AllWindowsCurrentApplication the show desktop sho

D9660: Add explicit protocol for colour scheme management

2018-01-04 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9660 To: davidedmundson, #plasma, graesslin Cc: plasma-dev

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

2018-01-04 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9661#186102, @broulik wrote: > From what I and Nate understood it makes no sense to have the Desktop window in a list of windows from the same application which t

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

2018-01-04 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9661#186122, @broulik wrote: > Right, the enum names were confusing. I was young ;-) REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org

D9601: Make media controls configurable

2018-01-04 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.cpp:136 > This won't work. > > Kpacakges don't inherit metadata, so I think if you changed to breeze-dark > you'd get the controls but lose the ability to turn them off. > You can't assume that authors should copy me

Re: detecting tablet mode

2018-01-04 Thread Martin Flöser
I want to provide a dbus service in KWin to export the state. Apps cannot use libinput directly, one needs root for that. Cheers Martin Am 4. Januar 2018 23:22:43 MEZ schrieb Marco Martin : >Hi all, >one thing i wanted to look into, is to detect when a trasformable >laptop goes >in tablet mode

Re: detecting tablet mode

2018-01-05 Thread Martin Flöser
artin On Fri, Jan 5, 2018 at 6:23 AM, Martin Flöser wrote: I want to provide a dbus service in KWin to export the state. Apps cannot use libinput directly, one needs root for that. Cheers Martin Am 4. Januar 2018 23:22:43 MEZ schrieb Marco Martin : Hi all, one thing i wanted to look into, is

Re: detecting tablet mode

2018-01-05 Thread Martin Flöser
sers to help there. Cheers Martin On Fri, Jan 5, 2018 at 6:23 AM, Martin Flöser wrote: I want to provide a dbus service in KWin to export the state. Apps cannot use libinput directly, one needs root for that. Cheers Martin Am 4. Januar 2018 23:22:43 MEZ schrieb Marco Martin : Hi all, one

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

2018-01-05 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9661 To: broulik, #plasma, #vdg, graesslin Cc: graesslin, plasma-devel, kwi

D9658: Use explicit palette interface

2018-01-05 Thread Martin Flöser
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Soon my kdevelop will be black again! REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D9658 To: davidedmund

D9601: Make media controls configurable

2018-01-05 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D9601#186415, @davidedmundson wrote: > > maybe we need a lnf specific config module? It's not the first feature where I would say that this actually doesn't belong into kscreenlocker kcm as it's specific to the theme. > > I li

D9684: Load config specified by the LnF theme

2018-01-05 Thread Martin Flöser
graesslin added a comment. I like it! REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D9684 To: davidedmundson, #plasma Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9699: Keep fullscreen windows in active layer based on transients not the group

2018-01-06 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REV

D9699: Keep fullscreen windows in active layer based on transients not the group

2018-01-06 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9699#186940, @romangg wrote: > Are there maybe other cases of clients in X, which share the same group, are not transient, but need to have `isActiveFullScreen` r

D9699: Keep fullscreen windows in active layer based on transients not the group

2018-01-06 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. git blame result: The group check was introduced with https://phabricator.kde.org/R108:476ca65295bfb3f0d90f535d9930250a13a8b323 - before it was a check for transient, but the group check was there a

D9699: Keep fullscreen windows in active layer based on transients not the group

2018-01-06 Thread Martin Flöser
graesslin added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > romangg wrote in abstract_client.cpp:1155 > Just a question for understanding unrelated to this patch: why should > `isActiveFullScreen` return true, if `ac->screen() != screen(

D9699: Keep fullscreen windows in active layer based on transients not the group

2018-01-06 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9699#186972, @graesslin wrote: > git blame result: The group check was introduced with https://phabricator.kde.org/R108:476ca65295bfb3f0d90f535d9930250a13a8b323 -

D9699: Keep fullscreen windows in active layer based on transients not the group

2018-01-07 Thread Martin Flöser
graesslin updated this revision to Diff 24870. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Check transients recursively by looking at the transients main windows REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D9713: Add script to unlock a broken session via ConsoleKit.

2018-01-08 Thread Martin Flöser
graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > abstractlocker.cpp:53 > +#if HAVE_CONSOLEKIT > +auto text = ki18n("The screen locker is broken and unlocking is not > possible anymore.\n" > +

D9521: Pass SwitchEvent from LibInput through KWin and add to DebugConsole

2018-01-09 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:d2a9232ad34f: Pass SwitchEvent from LibInput through KWin and add to DebugConsole (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CH

D9764: [WIP] a basic TabletModeManager

2018-01-09 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9764#188268, @mart wrote: > one thing i'm wondering, is how to manage dependencies, as ideally we want most of our apps to make use of this, but can't ask for sur

D9764: [WIP] a basic TabletModeManager

2018-01-09 Thread Martin Flöser
graesslin added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > tabletmodemanager.cpp:75 > +{ > +m_spy = new TabletModeInputEventSpy(this); > +input()->installInputEventSpy(m_spy); please put into initializer. Also the spy leaks. >

Re: detecting tablet mode

2018-01-09 Thread Martin Flöser
Am 2018-01-09 13:27, schrieb Marco Martin: On Fri, Jan 5, 2018 at 6:21 PM, Martin Flöser wrote: So I would do something like a small class class TabletModeManager : public QObject, public InputEventSpy { }; I'm starting on this direction now, another thing: libinput has the event fo

D9713: Add script to unlock a broken session via ConsoleKit.

2018-01-09 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > tcberner wrote in abstractlocker.cpp:53 > So something ala > > - if logingd-runing then logindmessage > - if consolekit-running then consolekitmessage > - else falback message That would be the ultimate solution ;-) REPOSITORY R133 KScreenLo

Re: detecting tablet mode

2018-01-09 Thread Martin Flöser
Am 2018-01-08 11:13, schrieb Marco Martin: On Fri, Jan 5, 2018 at 6:24 PM, Martin Flöser wrote: Am 2018-01-05 16:11, schrieb Marco Martin: debugging a bit what happens currently on my machine, i don't seem to have any event device which libinput_device_switch_has_switch, however, when i

D9776: Fix Plastik bottom and right border

2018-01-09 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9776 To: davidedmundson, #plasma, graesslin Cc: plasma-dev

D9764: [WIP] a basic TabletModeManager

2018-01-10 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9764#188862, @mart wrote: > In https://phabricator.kde.org/D9764#188354, @graesslin wrote: > > > In https://phabricator.kde.org/D9764#188268, @mart wrote: >

D9555: Simulate user activity on fake input events

2018-01-10 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:b002b2790321: Simulate user activity on fake input events (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. CHANGED PRIOR TO COMMIT https://phabricator.kde.

D9699: Keep fullscreen windows in active layer based on transients not the group

2018-01-10 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:b7ad4bcf881c: Keep fullscreen windows in active layer based on transients not the group (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KW

D9764: [WIP] a basic TabletModeManager

2018-01-10 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH mart/tabletMode REVISION DETAIL https://phabricator.kde.org/D9764 To: mart, #plasma, #kwin, graesslin Cc: grae

D7246: Tooltips

2018-01-10 Thread Martin Flöser
graesslin accepted this revision. graesslin added subscribers: jriddell, davidedmundson. graesslin added a comment. This revision is now accepted and ready to land. We are close to release and this might create hassles for distributions. Should we include it or wait for master being open again

Re: 5.12 announce

2018-01-11 Thread Martin Flöser
Am 2018-01-11 19:02, schrieb Jonathan Riddell: I've made https://www.kde.org/announcements/plasma-5.12.0.php I don't suppose anyone has done figures or nice bar graphs for the speedups? 'Output resolution can be set through KScreen' I used this for the screenshot for Wayland section but it do

Re: 5.12 announce

2018-01-12 Thread Martin Flöser
Jonathan On 11 January 2018 at 19:05, Martin Flöser wrote: Am 2018-01-11 19:02, schrieb Jonathan Riddell: I've made https://www.kde.org/announcements/plasma-5.12.0.php I don't suppose anyone has done figures or nice bar graphs for the speedups? 'Output resolution can be set thr

D9638: [effects] add 'Slide Desktops' effect

2018-01-12 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. as we had quite positive feedback on the replacement idea: could you please rework the patch to replace the old effect? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 T

Re: keyboard indicator

2018-01-12 Thread Martin Flöser
Am 2018-01-12 17:06, schrieb Jonathan Riddell: Chatting with the Slimbook devs we noticed they wanted a programme called keyboard-indicator installed. Slimbook laptops don't have an LED on caps lock/num lock etc like some other laptops do so there's no visual indicator that you have caps lock tu

Re: 5.12 announce

2018-01-12 Thread Martin Flöser
Am 2018-01-12 19:13, schrieb Jonathan Riddell: On Fri, Jan 12, 2018 at 06:41:31PM +0100, Martin Flöser wrote: Am 2018-01-11 20:16, schrieb Jonathan Riddell: >Could someone take a screenshot which does work of KScreen under >Wayland? I could do a screenshot, but what do you want to see? T

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

2018-01-13 Thread Martin Flöser
graesslin resigned from this revision. graesslin added subscribers: fredrik, davidedmundson, mart. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. I would like to see this reviewed by @fredrik, @mart , @davidedmundson and in general the https://ph

D9859: Fix crash when destroying tabletmodemanager

2018-01-13 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma, mart. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin

[kwin] /: Disable KActivities integration on Wayland

2018-01-13 Thread Martin Flöser
Git commit b8f43618478437e52b5e4f7f5cc50d1c689e6b1c by Martin Flöser. Committed on 13/01/2018 at 15:58. Pushed by graesslin into branch 'master'. Disable KActivities integration on Wayland Once again KActivities causes a delay in the startup of KWin. This is not the first time it hap

D9865: Do not call into NETWinInfo in AbstractClient::setSkipPager

2018-01-13 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REV

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

2018-01-13 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REV

D9865: Do not call into NETWinInfo in AbstractClient::setSkipPager

2018-01-13 Thread Martin Flöser
graesslin added a dependent revision: D9866: Add support for initial apply rules for skip (taskbar|pager|switcher). REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9865 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jens

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

2018-01-13 Thread Martin Flöser
graesslin added a dependency: D9865: Do not call into NETWinInfo in AbstractClient::setSkipPager. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9866 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin,

D9638: [effects] replace old slide effect with a new one

2018-01-13 Thread Martin Flöser
graesslin added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > slide.cpp:62 > > -const auto d = animationTime( > -SlideConfig::duration() != 0 ? SlideConfig::duration() : 250); > -mTimeLine.setDuration(d); > +m_timeline

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

2018-01-14 Thread Martin Flöser
graesslin added a dependent revision: D9870: Add support for apply initial keep above/below window rules. REPOSITORY R108 KWin BRANCH shell-client-skip-rules REVISION DETAIL https://phabricator.kde.org/D9866 To: graesslin, #kwin, #plasma, hein Cc: plasma-devel, kwin, ZrenBot, progwolff,

  1   2   3   4   5   6   7   8   9   10   >