Review Request 128400: Configuration option for System Tray's icon size

ontents/ui/ConfigIcons.qml PRE-CREATION applets/systemtray/package/contents/ui/main.qml a66ea69 Diff: https://git.reviewboard.kde.org/r/128400/diff/ Testing --- Tested in KDE Neon Developer Stable (as of July 7, 2016) Thanks, John Salatas ___ Pl

Review Request 128402: Kickoff: Add option to hide Favorites tab

per Stable (as of July 7, 2016) Thanks, John Salatas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

e lower which I prefer is units.iconSizes.smallMedium - John --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/#review97184 --- On July 8, 2016

Re: Review Request 128400: Configuration option for System Tray's icon size

Developer Stable (as of July 7, 2016) Thanks, John Salatas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

ng a fixed value :\ - John --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/#review97186 --- On July 8, 2016, 8:41 a.m., John Salat

Re: Review Request 128400: Configuration option for System Tray's icon size

finitely. Perhaps add the "usability" group to have them decide. > > > > Also, I don't think this single option deserves a separage page, it would > > fit just fine at the top of the "General" page imho. > > John Salatas wrote: > Thanks for y

Re: Review Request 128400: Configuration option for System Tray's icon size

finitely. Perhaps add the "usability" group to have them decide. > > > > Also, I don't think this single option deserves a separage page, it would > > fit just fine at the top of the "General" page imho. > > John Salatas wrote: > Thanks for y

Re: Review Request 128402: Kickoff: Add option to hide Favorites tab

--- On July 8, 2016, 6:35 a.m., John Salatas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128402/ > ---

Re: Review Request 128400: Configuration option for System Tray's icon size

s://git.reviewboard.kde.org/r/128400/#review97202 ------- On July 8, 2016, 8:56 a.m., John Salatas wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 128400: Configuration option for System Tray's icon size

git.reviewboard.kde.org/r/128400/#review97212 ------- On July 8, 2016, 8:56 a.m., John Salatas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128400/ > --

Re: Review Request 128402: Kickoff: Add option to hide Favorites tab

0c598-745d-41d5-9b5c-34191cc85b04__kickoff.png Thanks, John Salatas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128402: Kickoff: Add option to hide Favorites tab

> On July 8, 2016, 9:35 a.m., Kai Uwe Broulik wrote: > > -1 > > > > What I would instead like is the ability to re-arrange and hide individual > > tabs, see Bug 361210, but not a corner-case solution for just the favorites. > > John Salatas wrote: > Yes

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 8, 2016, 11:21 a.m., Thomas Pfeiffer wrote: > > Visual aspects should stay under the theme's control. Therefore, from the > > usability perspective, there should be no user option, instead the look & > > feel theme should be able to control the icon

Re: Review Request 128400: Configuration option for System Tray's icon size

view97305 --- On July 8, 2016, 8:56 a.m., John Salatas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 128400: Configuration option for System Tray's icon size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/#review97308 --- Ship it! Ship It! - John Salatas On July 8, 2016, 8:56

Re: Review Request 128400: Configuration option for System Tray's icon size

/main.xml 65a7029 applets/systemtray/package/contents/ui/main.qml a66ea69 Diff: https://git.reviewboard.kde.org/r/128400/diff/ Testing --- Tested in KDE Neon Developer Stable (as of July 7, 2016) Thanks, John Salatas ___ Plasma-devel mailing li

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 12, 2016, 7:46 a.m., Marco Martin wrote: > > > > John Salatas wrote: > done I just realized that I cannot commit to git and (obviously) marking it as submitted it doesn't submit it :) Can someone submit it for

Re: Review Request 128400: Configuration option for System Tray's icon size

view97313 --- On July 12, 2016, 8:29 a.m., John Salatas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

4/419ec52a-04db-4cc5-b15a-7b237f0ad084__kickoff.png Thanks, John Salatas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

ide would work in the same way, and the > > "Visible Tabs" box would always exactly represent reality. Updated as per your suggestions. - John --- This is an automatically generated e-mail. To reply, visit: ht

Re: Review Request 128400: Configuration option for System Tray's icon size

it myself. - John --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/#review97384 --- On July 12, 2016, 8:29 a.m.,

Re: Review Request 128400: Configuration option for System Tray's icon size

le (as of July 7, 2016) Thanks, John Salatas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

d) > > > > "Hidden Tabs" > > [ ] [ ] > > > > Drag tabs between the boxes to show/hide them, or reorder the visible tabs > > by dragging. > > > > --- > > That way reaordering and show/hide would work in the same way, and the

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2016/07/14/419ec52a-04db-4cc5-b15a-7b237f0ad084__kickoff.png Thanks, John Salatas

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

- John Salatas On Sept. 18, 2016, 2:48 p.m., John Salatas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

aded/files/2016/07/14/419ec52a-04db-4cc5-b15a-7b237f0ad084__kickoff.png Thanks, John Salatas

Widget's Configuration Icon Colors

t-here-kde) and the Menu Buttons appear as white. Is there any way to change the SVG's icon color (not the button's) to dark (possibly text color or something dark)? Thanks! [Screenshot 1]: http://jsalatas.ictpro.gr/01.png [Screenshot 2]: http://jsalatas.ictpro.gr/02.png John Sa

Widget's Configuration Icon Colors

t-here-kde) and the Menu Buttons appear as white. Is there any way to change the SVG's icon color (not the button's) to dark (possibly text color or something dark)? Thanks! [Screenshot 1]: http://jsalatas.ictpro.gr/01.png [Screenshot 2]: http://jsalatas.ictpro.gr/02.png John

[Breeze] [Bug 375005] New scrollbars for Plasma 4.9: slow scrolling is no longer intuitive

https://bugs.kde.org/show_bug.cgi?id=375005 John Salatas changed: What|Removed |Added CC||jsala...@gmail.com --- Comment #5 from John

[Differential] [Request, 2 lines] D4153: Network manager configuration model is unreadable

jsalatas created this revision. jsalatas added reviewers: Plasma, Plasma: Design, jgrulich. jsalatas set the repository for this revision to R116 Plasma Network Management Applet. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUM

[Differential] [Updated, 4 lines] D4153: Network manager configuration model is unreadable

jsalatas updated this revision to Diff 10204. jsalatas added a comment. Previous diff was incomplete. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4153?vs=10203&id=10204 REVISION DETAIL https://phabricator.kde.org/D4153 AFFECT

[Differential] [Commented On] D4153: Network manager configuration model is unreadable

jsalatas added a comment. In https://phabricator.kde.org/D4153#77525, @jgrulich wrote: > I'm trying to get rid of Plasma QML components so it uses same colors which are used by the rest of application. I guess that would be a better approach as it seems that plasma and applicatio

[Differential] [Commented On] D4153: Network manager configuration model is unreadable

jsalatas added a comment. In https://phabricator.kde.org/D4153#77549, @jgrulich wrote: > Icons problem solved F2049814: kcm.patch . Can you please test this patch? Perfect :) REPOSITORY R116 Plasma Network Management Applet REVISION DE

[Differential] [Commented On] D4153: Network manager configuration model is unreadable

jsalatas added a comment. BTW: I don't know how I did it but while testing it, at some point configuration didn't open at all and plasma produced the following error "kcmshell5 with modules ' "org.kde.kcmshell_kcm_networkmanagement.desktop" ' is already running." I cannot reproduce

[Differential] [Abandoned] D4153: Network manager configuration model is unreadable

jsalatas abandoned this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D4153 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jsalatas, #plasma, #plasma:_design, jgrulich Cc: plasma-devel, lesliezhai

[Differential] [Request, 14 lines] D4181: Sonnet: segfault in trigrams generation

jsalatas created this revision. jsalatas added a reviewer: Plasma. jsalatas set the repository for this revision to R246 Sonnet. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This patch fixes a Segm

[Differential] [Closed] D4181: Sonnet: segfault in trigrams generation

This revision was automatically updated to reflect the committed changes. Closed by commit R246:c7f0b1453720: Fix segfault in trigrams generation and expose MAXGRAMS constant in the header (authored by jsalatas). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4

[Differential] [Commented On] D4197: Delete KCModule before deleting QApplication

jsalatas added a comment. Seems to work. It also fixes another (maybe related) issue in network mananager: 1. Right Click the nm applet and choose "Configure Network Connections" 2. Click "Add new connection" 3. Having the "Choose a connection type" window open, click "Cancel"

[Differential] [Request, 6 lines] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

jsalatas created this revision. jsalatas added reviewers: Frameworks, Plasma. jsalatas set the repository for this revision to R39 KTextEditor. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: kwrite-devel, plasma-devel. REVISION SUMMARY This p

[Differential] [Updated] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

jsalatas updated the summary for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4538 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jsalatas, #frameworks, #plasma Cc: plasma-devel, kwrite-devel, lesliezhai, ali-mo

[Differential] [Updated] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

jsalatas added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4538 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jsalatas, #frameworks, #plasma, #ktexteditor Cc: plasma-devel, kwrite-devel, lesliezhai,

[Differential] [Updated, 26 lines] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

jsalatas updated this revision to Diff 11494. jsalatas added a comment. 1. I abandoned the 3rd issue I mention in the summary about the line `scrollPos(max, max.column(), calledExternally);` as I could neither verify nor disprove if this was intended or not. 2. In `cursorToCoordinate()`

[Differential] [Closed] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

This revision was automatically updated to reflect the committed changes. Closed by commit R39:1858d6fafb58: Consistent conversion from/to cursor to/from coordinates (authored by jsalatas). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4538?vs=11494&id=115

[Differential] [Request, 3 lines] D4800: [Task Manager] text elide doesn't work for Tooltips

jsalatas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Seems that `height: undefined` cause the elide not to work in the Tooltip headings TEST PLAN Before F2611512: before.png

[Differential] [Commented On] D4800: [Task Manager] text elide doesn't work for Tooltips

jsalatas added a comment. If you agree, I believe this should be committed to 5.9 branch and not wait until 5.10. Please confirm. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4800 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Commented On] D4800: [Task Manager] text elide doesn't work for Tooltips

jsalatas added a comment. In https://phabricator.kde.org/D4800#89954, @subdiff wrote: > Removing the undefineds increases the margins between the lines again. @anthonyfieroni had another fix for the elide a few days ago by setting the maximumLineCount property. He hadn't yet pushed it th

[Differential] [Abandoned] D4800: [Task Manager] text elide doesn't work for Tooltips

jsalatas abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4800 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jsalatas, #plasma, #vdg, anthonyfieroni, subdiff Cc: plasma-devel, progwolff, lesliezhai, a

[Differential] [Changed Subscribers] D4491: Let make taskmanager tooltip readable again

jsalatas added inline comments. INLINE COMMENTS > ToolTipInstance.qml:108 > height: undefined > +maximumLineCount: 2 > elide: Text.ElideRight Is it possible to have it always fixed to 2 lines and not just max to 2? Otherwise having either 1 or 2

[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

jsalatas added a comment. In https://phabricator.kde.org/D4491#89982, @anthonyfieroni wrote: > ElideMiddle on basic regex match for path I like the idea but ElideMiddle doesn't seem to work for me: Seems that it just keeps the left part of the text that it can fit and ignores anyt

D17249: Preserve screen colour doesn't work as expected

jsalatas created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jsalatas requested review of this revision. REVISION SUMMARY If you are using a custom icc profile, this should be restored during day time. see also https://github.com/kotelnik/pla

D17249: Preserve screen colour doesn't work as expected

jsalatas added a comment. ping? :) REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D17249 To: jsalatas, #plasma, martinkostolny Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17249: Preserve screen colour doesn't work as expected

This revision was automatically updated to reflect the committed changes. Closed by commit R885:1e2a920633d7: Preserve screen colour doesn't work as expected (authored by jsalatas). REPOSITORY R885 Redshift Control for Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17249?vs=46

Night Color Widget (adapt Redshift Control Widget to kwin's Night Color functionality)

I'm one of the maintainers of Redshift Control Widget) :\ Thank you in advance! John Salatas References [1] https://phabricator.kde.org/source/plasma-redshift-control/browse/master/package/contents/ui/main.qml$123 [2] https://phabricator.kde.org/source/kwin/browse/ma

Night Color Widget (Redshift Control Widget adapt to kwin's Night Color)

I'm one of the maintainers of Redshift Control Widget) :\ Thank you in advance! John Salatas References [1] https://phabricator.kde.org/source/plasma-redshift-control/browse/master/package/contents/ui/main.qml$123 [2] https://phabricator.kde.org/source/kwin/browse/ma

[Differential] [Request, 57 lines] D2900: [Kickoff] Draw FrameSvgItem behind kickoff configuration buttons

jsalatas created this revision. jsalatas added a reviewer: Plasma. jsalatas set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This ensures we don't end u

[Differential] [Updated] D2900: [Kickoff] Draw FrameSvgItem behind kickoff configuration buttons

jsalatas added a reviewer: Plasma: Design. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2900 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jsalatas, #plasma, #plasma:_design Cc: plasma-devel, lesliezhai, ali-moh

[Differential] [Updated, 55 lines] D2900: [Kickoff] Draw FrameSvgItem behind kickoff configuration buttons

jsalatas removed rPLASMADESKTOP Plasma Desktop as the repository for this revision. jsalatas updated this revision to Diff 7013. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2900?vs=7012&id=7013 REVISION DETAIL https://phabricator.kde.org/D2900 AFFECTED FILES applets/kickoff/pac

[Differential] [Accepted] D2901: Constrain kickoff config button label size

jsalatas accepted this revision. jsalatas added a reviewer: jsalatas. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2901 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/em

[Differential] [Request, 8 lines] D2913: Make the background of the logout screen darker

jsalatas created this revision. jsalatas added reviewers: Plasma, Plasma: Design. jsalatas added a subscriber: apol. jsalatas set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma

[Differential] [Commented On] D2913: Make the background of the logout screen darker

jsalatas added a comment. There is no blur effect (I'm running it in a Virtual Machine with no 3D acceleration). Here is the output of the qdbus org.kde.KWin /KWin supportInformation command # qdbus org.kde.KWin /KWin supportInformation KWin Support Information: The followi

[Differential] [Updated, 2 lines] D2913: Make the background of the logout screen darker

jsalatas updated the test plan for this revision. jsalatas updated this revision to Diff 7058. jsalatas added a comment. According to mart's suggestion there is already a rectangle, so there is no need to add a new one (the "after" screenshot is also updated to reflect this) REPOSITORY rPLA

[Differential] [Abandoned] D2913: Make the background of the logout screen darker

jsalatas abandoned this revision. jsalatas added a comment. I just tested it in a normal PC (ie not Virtual Machine) with 3D acceleration and the background is indeed blurred as davidedmundson said. So I'm abandoning this, as it seems a very minor issue. REPOSITORY rPLASMAWORKSPACE Pla

[Differential] [Request, 4 lines] D3847: SWT/Eclipse toolbar fix

jsalatas created this revision. jsalatas added a reviewer: Breeze. jsalatas set the repository for this revision to R98 Breeze for Gtk. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In eclipse running with SWT gtk2 the

[Differential] [Closed] D3847: SWT/Eclipse toolbar fix

This revision was automatically updated to reflect the committed changes. Closed by commit R98:85fd0772a125: SWT/Eclipse toolbar fix (authored by jsalatas). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3847?vs=9436&id=9482 REVISION DETAIL https://ph