Re: Review Request 108525: Make plasma widgets respect plasma theme's button color

01/21/after.png Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 108525: Make plasma widgets respect plasma theme's button color

2013/01/21/before.png With patch http://git.reviewboard.kde.org/media/uploaded/files/2013/01/21/after.png Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108969: Visual cleanup, slight design changes(more margins) and auto sizing of text in now playing widget.

gigantic here. Otherwise, great improvement :-) - Hrvoje Senjan On Feb. 15, 2013, 3:23 p.m., Tjaart Blignaut wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 108969: Visual cleanup, slight design changes(more margins) and auto sizing of text in now playing widget.

> On Feb. 16, 2013, 8:36 p.m., Hrvoje Senjan wrote: > > Maybe to slightly reduce controls size? This made controls gigantic here. > > Otherwise, great improvement :-) > > Tjaart Blignaut wrote: > Could you post a screen shot. I changed the icon sizing policy but in

Re: Review Request 108969: Visual cleanup, slight design changes(more margins) and auto sizing of text in now playing widget.

> On Feb. 16, 2013, 8:36 p.m., Hrvoje Senjan wrote: > > Maybe to slightly reduce controls size? This made controls gigantic here. > > Otherwise, great improvement :-) > > Tjaart Blignaut wrote: > Could you post a screen shot. I changed the icon sizing policy but in

Re: Review Request 108969: Visual cleanup, slight design changes(more margins) and auto sizing of text in now playing widget.

> On Feb. 16, 2013, 8:36 p.m., Hrvoje Senjan wrote: > > Maybe to slightly reduce controls size? This made controls gigantic here. > > Otherwise, great improvement :-) > > Tjaart Blignaut wrote: > Could you post a screen shot. I changed the icon sizing policy but in

Review Request 109606: Use nocover svg from plasma theme

/r/109606/diff/ Testing --- Using any theme that doesn't have the svg, makes the plasmoid uses the default one. Changed theme that *does* have another nocover, it changes correctly to that one. Thanks, Hrvoje Senjan ___ Plasma-devel ma

Re: Review Request 109606: Use nocover svg from plasma theme

p://git.reviewboard.kde.org/r/109606/#review29550 ----------- On March 20, 2013, 1:03 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 109606: Use nocover svg from plasma theme

hanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 110135: Adjust Kickoff actions to latest Powerdevil changes

://git.reviewboard.kde.org/r/110135/diff/ Testing --- Compiled, actions work now. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust Kickoff actions to latest Powerdevil changes

t FDO's). - Hrvoje --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110135/#review31459 --- On April 23, 2013, 5:28

Re: Review Request 110135: Adjust to new suspend session handling

://git.reviewboard.kde.org/r/110135/diff/ Testing --- Compiled, actions work now. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

6f90006 plasma/generic/dataengines/time/timeengine.cpp 2f69e8f plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d Diff: http://git.reviewboard.kde.org/r/110135/diff/ Testing --- Compiled, actions work now. Thanks, Hrvoje Senjan

Re: Review Request 110135: Adjust to new suspend session handling

--- Compiled, actions work now. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

plasma/generic/dataengines/time/CMakeLists.txt 007a60a plasma/generic/dataengines/time/timeengine.cpp 2f69e8f plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d Diff: http://git.reviewboard.kde.org/r/110135/diff/ Testing --- Compiled, actions work now. Thanks, Hrvoje

Review Request 110160: Switch to Solid::PowerManagement instead of using DBus interface

- libs/lancelot-datamodels/SystemActions.cpp 7b9df63 Diff: http://git.reviewboard.kde.org/r/110160/diff/ Testing --- Compiled, works. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Review Request 110350: Use smooth filtering for screenlocker background

Current look http://git.reviewboard.kde.org/media/uploaded/files/2013/05/07/current.png patched http://git.reviewboard.kde.org/media/uploaded/files/2013/05/07/smoothened.png Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 110350: Use smooth filtering for screenlocker background

nks - Hrvoje --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110350/#review32216 --- On May 7, 2013, 7:48 p.m., Hrvoj

Re: Review Request 110160: Switch to Solid::PowerManagement instead of using DBus interface

rvoje Senjan On April 24, 2013, 6:44 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Review Request 110783: Fix non-Air icontasks tooltips

last three are currently broken, and the patch resolves the problem. Now Air uses shadow as it was before, and other themes are also rendered properly. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Review Request 110786: Use dialog svg instead of tooltip for popupview

pp 75db43e Diff: http://git.reviewboard.kde.org/r/110786/diff/ Testing --- Tested all combos, works now. I guess it's also more of a dialog really than a tooltip, no? Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde

Review Request 110917: Remove usage of (fake) Amarok-Mockup theme

Diff: http://git.reviewboard.kde.org/r/110917/diff/ Testing --- Compiled, no crash, no (yet at least) side-effects. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110783: Fix non-Air icontasks tooltips

y, visit: http://git.reviewboard.kde.org/r/110783/#review33686 --- On June 2, 2013, 4:11 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail.

Review Request 112069: Call KPluginInfo::KPluginInfo with the resource argument

d 322446. http://bugs.kde.org/show_bug.cgi?id=320855 http://bugs.kde.org/show_bug.cgi?id=322446 Diffs - plasma/theme.cpp 4554de7 Diff: http://git.reviewboard.kde.org/r/112069/diff/ Testing --- Tried the above example with the patch, plasma doesn't crash Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 112073: Partially revert commit 83d3018

Diffs - plasma/desktop/shell/data/plasma-desktop.desktop f37dc57 Diff: http://git.reviewboard.kde.org/r/112073/diff/ Testing --- Yes... starts "normally" as previously/ksplash isn't interupted Thanks, Hrvoje Senjan ___ Plasm

Re: Review Request 112069: Call KPluginInfo::KPluginInfo with the resource argument

adding [Theme] name=fake-non-existant-theme in plasmarc) This addresses bugs 320855 and 322446. http://bugs.kde.org/show_bug.cgi?id=320855 http://bugs.kde.org/show_bug.cgi?id=322446 Diffs - plasma/theme.cpp 4554de7 Diff: http://git.reviewboard.kde.org/r/112069/diff/ Testing -

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Review Request 115605: Rename plasmapkg

. Repository: plasma-framework Description --- ...so it can be co-installed in the same prefix as kde-runtime(4) Diffs - src/plasmapkg/CMakeLists.txt a9e186f Diff: https://git.reviewboard.kde.org/r/115605/diff/ Testing --- Builds Thanks, Hrvoje Senjan

Re: Review Request 115605: Rename plasmapkg

/115605/diff/ Testing --- Builds Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115605: Rename plasmapkg

/r/115605/diff/ Testing --- Builds Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 115871: Use QStandardPaths for finding plasma shells instead of hardcoding to install prefix

asma runs with plasma-framework installed to /usr, and kde-workspace to /opt. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115871: Use QStandardPaths for finding plasma shells instead of hardcoding to install prefix

1188b48 Diff: https://git.reviewboard.kde.org/r/115871/diff/ Testing --- builds & plasma runs with plasma-framework installed to /usr, and kde-workspace to /opt. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org h

Re: Review Request 116085: welcome back the javascript interactive console

g/r/116085/#comment35769> This would mean: a) propagate KTextEditor to part of the KF5 releases (that was not the case with TP1 & alpha1) b) move the console or shell altogether to a different repo c) rewrite it without this framework - Hrvoje Senjan On Feb. 26, 2014

Re: Review Request 116085: welcome back the javascript interactive console

> On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote: > > src/shell/CMakeLists.txt, line 20 > > <https://git.reviewboard.kde.org/r/116085/diff/2/?file=246330#file246330line20> > > > > This would mean: > > a) propagate KTextEditor to part of the KF5 re

Re: Review Request 116625: Oxygen as default font

625/#comment37007> Why not just change the defaults in frameworkintegration instead of writing directly into users settings? - Hrvoje Senjan On March 6, 2014, 1:08 a.m., Sebastian Kügler wrote: > > --- > This is an automatica

Re: Review Request 116633: Change default font settings to Oxygen font

633/#comment37030> you can just mark it as a runtime dependancy (so the build doesn't fail w/o oxygen font. src/platformtheme/kfontsettingsdata.cpp <https://git.reviewboard.kde.org/r/116633/#comment37031> r116625 got also monospace variant changed, right? - Hrvoje Senjan

Re: Review Request 116625: Oxygen as default font

> On March 19, 2014, 1:16 a.m., Commit Hook wrote: > > This review has been submitted with commit > > c504562c4dc37828790a51ff33a895a962d9b891 by Sebastian Kügler to branch > > master. i was under the impression that consensus was to go with (only) r116633. at least kdeglobals injection *shoul

Review Request 117312: Disable PackageKit integration

n was added, no definition w/ patch Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117312: Disable PackageKit integration

sting --- builds. before the patch -DPLASMA_ENABLE_PACKAGEKIT_SUPPORT=1 definition was added, no definition w/ patch Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117448: Port startkde script to KF5

g/r/117448/#comment38496> just a question, why this change? qtpaths comes from qttools (same as qdbus), and kf5-config from kdelibs4support, so this looks like a step backwards, and makes it harder later to move on from using kde4support... (same for qt_plugin_path change) - Hrvoje

Review Request 117463: kinfocenter: minor dependencies cleanup

improvements Diffs - CMakeLists.txt 869e65a Diff: https://git.reviewboard.kde.org/r/117463/diff/ Testing --- Built successfully with CMake 3.0.0-rc3 & Frameworks HEAD. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-d

Re: Review Request 117463: kinfocenter: minor dependencies cleanup

them 3) DocTools are needed for doc dir 4) Zlib and XCB:: are not needed 5) Minor description improvements Diffs - CMakeLists.txt 869e65a Diff: https://git.reviewboard.kde.org/r/117463/diff/ Testing --- Built successfully with CMake 3.0.0-rc3 & Frameworks HEAD. Thanks, Hr

Review Request 117530: Port & build KSMServer KCM

& keys are correctly read/written Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117393: Make building tests optional

> On April 16, 2014, 4:48 p.m., Martin Gräßlin wrote: > > as all unit tests use ecm_mark_as_test the tests should not be built even > > if they are included in the CMakeLists.txt. Given that I think that change > > is not needed at all. If there are tests which do not use ecm_mark_as_test > >

Re: Review Request 117530: Port & build KSMServer KCM

ui df2bef5 Diff: https://git.reviewboard.kde.org/r/117530/diff/ Testing --- builds & keys are correctly read/written Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability

g/r/117876/#comment39694> i guess also org.kde.kuiserver.service would need adjusting ... - Hrvoje Senjan On April 29, 2014, 5:29 p.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability

> On April 30, 2014, 12:56 a.m., Hrvoje Senjan wrote: > > kuiserver/CMakeLists.txt, line 73 > > <https://git.reviewboard.kde.org/r/117876/diff/2/?file=269233#file269233line73> > > > > i guess also org.kde.kuiserver.service would need adjusting ... > >

Re: Review Request 117859: rename kioslave files for co-installability

libmolletnetwork devel symlink, and interface file be installed at all? in 4.x world they come from kde-runtime, which is not used for development purposes... - Hrvoje Senjan On April 30, 2014, 11:36 a.m., Jonathan Riddell wrote: > > --- > T

Re: Review Request 116024: Port IconItem to native QSGTexture

> On May 13, 2014, 2:47 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/CMakeLists.txt, line 39 > > > > > > why do you link against Qt5::OpenGL and find it? OpenGL is part of Gui > > David Edmundson w

Re: Review Request 118169: Rename pkgconfig file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118169/#review58110 --- maybe to adjust Libs: and Name: in pc file also? - Hrvoje

Re: Review Request 116633: Change default font settings to Oxygen font

tps://git.reviewboard.kde.org/r/116633/#comment40461> in the end, this line wasn't committed... - Hrvoje Senjan On March 19, 2014, 12:52 a.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 118257: explicit dependency on kpty as needed by kdesu

> On May 22, 2014, 1:40 p.m., Michael Palimaka wrote: > > Where is the kpty usage located? > > Jonathan Riddell wrote: > When compiling without kpty installed: > > In file included from /usr/include/KF5/KDESu/kdesu/stubprocess.h:13:0, > from /usr/include/KF5/KDE

Review Request 118386: Give milou proper version

Description --- sideeffect - coexists with 4.x version. as there's no development files, added LIBRARY NAMELINK_SKIP directive. Diffs - CMakeLists.txt 4bf25ae lib/CMakeLists.txt 657e9dc Diff: https://git.reviewboard.kde.org/r/118386/diff/ Testing --- builds Thanks, H

Review Request 118387: Bump systemsettingsview SOVERSION to 5

Description --- otherwise if KF5's is in LD_LIBRARY_PATH, there's no way to start 4.x version Diffs - core/CMakeLists.txt 9752ad7 Diff: https://git.reviewboard.kde.org/r/118387/diff/ Testing --- Thanks, Hrvoje Senjan

Review Request 118388: rename systemsettings binary to systemsettings5

--- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118388: rename systemsettings binary to systemsettings5

tically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118388/#review58690 ------- On May 28, 2014, 9:32 p.m., Hrvoje Senjan wrote: > > --- > This is an

Review Request 118482: Adjust ksmserver for renamed KWin binary

days, noticed no regression. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118482: Adjust ksmserver for renamed KWin binary

-ksmserver.h.cmake 939632c ksmserver/server.cpp 644013b ksmserver/startup.cpp 6f5d502 Diff: https://git.reviewboard.kde.org/r/118482/diff/ Testing --- using it for some ~10 days, noticed no regression. Thanks, Hrvoje Senjan ___ Plasma

Re: Review Request 118482: Adjust ksmserver for renamed KWin binary

org/r/118482/#review59121 --- On June 3, 2014, 3:22 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: Review Request 118516: Load the networkmanager applet on demand

> On June 4, 2014, 1:02 p.m., Lukáš Tinkl wrote: > > How would you connect to a VPN in that case? > > Marco Martin wrote: > Is networkmanager used to connect a VPN? > (and more generally, are there any features in the plasmoid that can be > used without networkmanager running?) > > Luk

Re: Review Request 118516: Load the networkmanager applet on demand

e. > > The approach to load it on-demand seems fine to me. > > Jan Grulich wrote: > You can use VPN connections without NetworkManager and I think that this > patch makes sense, because plasma-nm is useless when NetworkManager is > running. > > Marco Mart

Re: Review Request 118482: Adjust ksmserver for renamed KWin binary

> On June 4, 2014, 9:04 a.m., Martin Gräßlin wrote: > > looks good to me. Where is the KCM living where one can select the window > > manager? > > Hrvoje Senjan wrote: > it is in plasma-desktop repo. but i did not want to add a patch for > something that does

Review Request 118574: Adjust componentchooser for renamed KWin binary

ault one writes in kwin_x11 in ksmserverrc, upon restarting kwin_x11 is invoked. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118388: rename systemsettings binary to systemsettings5

d system settings will still be > > able to set configuration details relevant for KDE 4 applications. > > Hrvoje Senjan wrote: > >Ideally the KF5 based system settings will still be able to set > configuration details relevant for KDE 4 applications. > > that

Re: Review Request 118388: rename systemsettings binary to systemsettings5

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118388/#review59612 --- On May 28, 2014, 9:32 p.m., Hrvoje Senjan wrote: > > --

Re: Review Request 118386: Give milou proper version

Diff: https://git.reviewboard.kde.org/r/118386/diff/ Testing --- builds Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118388: rename systemsettings binary to systemsettings5

r118387 =) - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118388/#review59811 --- On May 28, 2014, 9:32 p.m., Hrvoje Senjan wrote: > > ---

Re: Review Request 118729: add xsession file for Plasma Desktop

g/r/118729/#comment41761> i guess adding DesktopNames key would also be good =) (see https://git.reviewboard.kde.org/r/117400/) - Hrvoje Senjan On June 13, 2014, 2:45 p.m., Jonathan Riddell wrote: > > --- > This is a

Re: Review Request 118732: Add xsession file for Plasma

g/r/118732/#comment41777> should be KDE instead of Plasma - Hrvoje Senjan On June 13, 2014, 3:39 p.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

tps://git.reviewboard.kde.org/r/118730/#comment41829> it was my understanding that KF5_LIBEXEC_INSTALL_DIR is 'reserved' for KF5, and rest of depending software would use libexec_install_dir. iow, this is only executable in kf5/ subdir, that doesn't come from a Framework - Hrvoje Senj

Re: Review Request 118482: Adjust ksmserver for renamed KWin binary

-ksmserver.h.cmake 939632c ksmserver/server.cpp 644013b ksmserver/startup.cpp 6f5d502 Diff: https://git.reviewboard.kde.org/r/118482/diff/ Testing --- using it for some ~10 days, noticed no regression. Thanks, Hrvoje Senjan ___ Plasma-devel mailing

Re: Review Request 118574: Adjust componentchooser for renamed KWin binary

Diff: https://git.reviewboard.kde.org/r/118574/diff/ Testing --- builds, reseting to default one writes in kwin_x11 in ksmserverrc, upon restarting kwin_x11 is invoked. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org h

Re: Review Request 118387: Bump systemsettingsview SOVERSION to 5

--- On May 28, 2014, 9:26 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118387/ > -

Re: Review Request 118636: Reinstate login & logout sounds

amount of time (bug 336396). local revert resolved those problems completely here. note, i have sound notifications off, and haven't enabled plasma_workspace notifications - Hrvoje Senjan On June 13, 2014, 5:42 p.m., Martin

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

nd will need to link to libksld. but here you skip the symlink? - Hrvoje Senjan On Oct. 28, 2015, 12:07 p.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

tps://git.reviewboard.kde.org/r/125838/#comment60155> you also didn't set the SOVERSION - Hrvoje Senjan On Oct. 29, 2015, 12:12 p.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 125811: detect gtk engine

tps://git.reviewboard.kde.org/r/125811/#comment60331> KDE_INSTALL_FULL_LIBDIR rather? - Hrvoje Senjan On Oct. 27, 2015, 10:22 a.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

her don't assume this ;-) at least send a mail to kde-distro-packagers about the sideeffects if those 3 are pushed asynchronously - Hrvoje Senjan On Nov. 16, 2015, 6:06 p.m., Boudhayan Gupta wrote: > > --- > This is an automati

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

icult to differentiate minimized from normal window (i.e. not focused)... i know it's a one man opinion but maybe this can be discussed further. - Hrvoje Senjan On Nov. 18, 2015, 11:51 p.m., Gregor Mi wrote: > > --- > This

Re: Review Request 126234: Fix build with Qt 5.6

:D - Hrvoje Senjan On Dec. 3, 2015, 6:37 p.m., Jan Kundrát wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126234: Fix build with Qt 5.6

? - Hrvoje Senjan On Dec. 4, 2015, 10:23 a.m., Jan Kundrát wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126250: knetattach: Changing host port does not enable connect button

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126250/#review89150 --- Andrea, did this build for you? - Hrvoje Senjan On Dec. 5

Re: Review Request 126248: change icons in breeze plasma theme

-> http://i.imgur.com/aY1igIu.jpg - Hrvoje Senjan On Dec. 5, 2015, 8:26 a.m., andreas kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.k

Re: Review Request 126248: change icons in breeze plasma theme

> On Dec. 5, 2015, 5:56 p.m., Hrvoje Senjan wrote: > > Andreas, battery is almost invisible with breeze dark -> > > http://i.imgur.com/aY1igIu.jpg > > andreas kainz wrote: > you have right the problem is also the old one from master doesn't work > in

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

> On Dec. 8, 2015, 7:51 a.m., Martin Gräßlin wrote: > > -2 for another reason: the display system should not be a user facing part. > > That's a technical detail which will go away in a year or two. Do you want > > to rename it back to Plasma then? If at all we should change the X11 > > sessio

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

panel would be shown). this patch fixes the problem here. - Hrvoje Senjan On Dec. 11, 2015, 7:48 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126381: kwayland backend for libkscreen

tps://git.reviewboard.kde.org/r/126381/#comment61717> Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should be marked as required in top CMakeLists.tyt - Hrvoje Senjan On Dec. 22, 2015, 12:46 a.m., Sebastian Kügler wrote: > > -

Re: Review Request 126381: kwayland backend for libkscreen

> On Dec. 24, 2015, 9:23 p.m., Hrvoje Senjan wrote: > > backends/CMakeLists.txt, line 3 > > <https://git.reviewboard.kde.org/r/126381/diff/7/?file=424946#file424946line3> > > > > Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should

Re: Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126792/#review91390 --- so i lost kmail icon in tray after this it seems - Hrvoje

Re: Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

> On Jan. 20, 2016, 11:26 p.m., Hrvoje Senjan wrote: > > so i lost kmail icon in tray after this it seems > > Marco Martin wrote: > do you have an empty space or no icon at all? empty space. - Hrvoje --- This i

Re: Review Request 127086: Raise the required CMake version to 3.4.0

odule that only indicates RUNTIME requirement? Another way is to check for ISOcodes only with cmake 3.4. - Hrvoje Senjan On Feb. 16, 2016, 12:13 p.m., Elias Probst wrote: > > --- > This is an automatically generated e-mail. T

Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag

diff/ Testing --- Now builds. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

people that have systemsettings.desktop as favourite in launchers? - Hrvoje Senjan On March 8, 2016, 4:18 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

> On March 8, 2016, 6:20 p.m., Hrvoje Senjan wrote: > > Do we want a kconf_update script with that for all hte people that have > > systemsettings.desktop as favourite in launchers? > > Martin Gräßlin wrote: > I don't think it's needed. The important part

Re: Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag

marked as submitted. Review request for Plasma and Harald Sitter. Changes --- Submitted with commit 73b5509bd45719e8cbbee95142d25d373172bfe1 by Hrvoje Senjan to branch Plasma/5.6. Repository: breeze-plymouth Description --- KDECompilerSettings aren't included so this wasn'

Re: Review Request 127346: Infrastructure for Plasmoid integration testing

> On March 16, 2016, 5:31 p.m., Hrvoje Senjan wrote: > > shell/testcorona.cpp, line 22 > > <https://git.reviewboard.kde.org/r/127346/diff/4/?file=449839#file449839line22> > > > > PlasmaQuick doesn't have any headers installed, so the build fails. >

Re: Review Request 127346: Infrastructure for Plasmoid integration testing

tps://git.reviewboard.kde.org/r/127346/#comment63836> PlasmaQuick doesn't have any headers installed, so the build fails. - Hrvoje Senjan On March 16, 2016, 12:46 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically genera

Re: Review Request 127346: Infrastructure for Plasmoid integration testing

> On March 16, 2016, 5:31 p.m., Hrvoje Senjan wrote: > > shell/testcorona.cpp, line 22 > > <https://git.reviewboard.kde.org/r/127346/diff/4/?file=449839#file449839line22> > > > > PlasmaQuick doesn't have any headers installed, so the build fails. >

Review Request 119166: [plasma-desktop]: use correct libexec directory

/FontInstInterface.cpp a9b1845 kcms/kfontinst/viewpart/FontViewPart.cpp a7de921 Diff: https://git.reviewboard.kde.org/r/119166/diff/ Testing --- builds. in theory is correct way™/more correct compared to current solution. Thanks, Hrvoje Senjan

Re: Review Request 119166: [plasma-desktop]: use correct libexec directory

: https://git.reviewboard.kde.org/r/119166/diff/ Testing --- builds. in theory is correct way™/more correct compared to current solution. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

  1   2   3   >