Akonadi Calendar Dataengine

Hi all, I just noticed that now - with KDE SC 4.4, I have a working Akonadi Calendar. Which by itself is pretty awesome of course. But wouldn't it be even ++aweseome if that was connected to my plasma-clock-foldout-calendar? So I set down and poked our pimsters and got all the info I need in or

Re: Akonadi Calendar Dataengine

Marco Martin wrote: > On Monday 05 April 2010, Frederik Gladhorn wrote: >> Hi all, >> >> I just noticed that now - with KDE SC 4.4, I have a working Akonadi >> Calendar. Which by itself is pretty awesome of course. But wouldn't it be >> even ++aweseome if th

Re: Akonadi Calendar Dataengine

due to things like recurrence making it not easy to correctly filter in some cases. I'd be happy if anyone would write a quick calendar list plasmoid as example, it could simply show a list of dates and the corresponding event. Greetings, Frederik Aaron J. Seigo wrote: > On

Re: Akonadi Calendar Dataengine

Aaron J. Seigo wrote: > On April 6, 2010, Frederik Gladhorn wrote: >> Requests to it have to have the form: "calendar:-mm-dd:-mm-dd" >> where the two dates are a range. > > could we replace calendar: with events:? sounds good to me (done) > > an

Re: Akonadi Calendar Dataengine

Hi, Aaron J. Seigo wrote: > On April 6, 2010, Frederik Gladhorn wrote: >> So would "eventsInMonth:2010-04-01" sound OK? I don't have strong >> feelings about this. > > yes, that'd be cool as well, and keep it consistent with holidays. > > events:2

Re: Review Request 119163: Add basic accessibility properties

/ModelContextMenu.qml 74d81d1 Diff: https://git.reviewboard.kde.org/r/119163/diff/ Testing --- http://blogs.fsfe.org/gladhorn/2014/07/07/plasma-next-accessibility/ Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 119163: Add basic accessibility properties

and decrement functions, good catch. Otherwise the same as for the ProgressBar applies. - Frederik --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119163/#review61844 ----

Re: Review Request 119163: Add basic accessibility properties

/plasmacomponents/qml/Switch.qml 60f179d src/declarativeimports/plasmacomponents/qml/TabBar.qml 809318a Diff: https://git.reviewboard.kde.org/r/119163/diff/ Testing --- http://blogs.fsfe.org/gladhorn/2014/07/07/plasma-next-accessibility/ Thanks, Frederik Gladhorn

Plasma, Accessibility and Keyboard

Hello, I've run Plasma Next just a little bit in the last few days and I'm pleasantly surprised, great work everyone. I'm also happy to see that http://blogs.fsfe.org/gladhorn/2014/07/07/plasma-next-accessibility/ got a little attention. I guess it's a good idea to give some more background a

Re: Review Request 119163: Add basic accessibility properties

60f179d src/declarativeimports/plasmacomponents/qml/TabBar.qml 809318a Diff: https://git.reviewboard.kde.org/r/119163/diff/ Testing --- http://blogs.fsfe.org/gladhorn/2014/07/07/plasma-next-accessibility/ Thanks, Frederik Gladhorn ___ Plasma

Re: Plasma, Accessibility and Keyboard

Tirsdag 8. juli 2014 15.48.19 skrev David Edmundson: > Do you consider accelerator keys (the pressing alt + the underlined > letter) to be a useful accessibility feature? I think it's a generally useful feature, that makes it into a useful accessibility feature too - and generally shortcuts are v

Re: Plasma, Accessibility and Keyboard

Just a quick follow-up: kickoff the default app launcher doesn't currently work with screen readers, even after spending some time on it. The reason is that it keeps the focus on some root item (I didn't check where it actually is). For accessibility I currently rely on getting focus changes to

Review Request 119301: Basic accessibility for kicker

(once it has keyboard focus), before it's completely silent. The problem of getting the focus onto the applet when opening it via keyboard shortcut is still there. Which branch should this go? Thanks, Frederik Gladhorn ___ Plasma-devel mailing

Re: Review Request 119301: Basic accessibility for kicker

hanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119379: Lockscreen accessibility

--- Tested with Orca. Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

ToolButtons and focus

Hello, I just looked at the screen locker from an accessibility point of view (it's kinda' buggersome when there's no way to get back into a session after it has been locked) and with a bit of nudging (see review request) I can use it nicely. Not perfect, but good enough to get back to work. N

Re: Review Request 119379: Lockscreen accessibility

utomatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119379/#review62741 --- On July 20, 2014, 4:05 p.m., Frederik Gladhorn wrote: > > -

Re: Review Request 119379: Lockscreen accessibility

/UserDelegate.qml 2221368 Diff: https://git.reviewboard.kde.org/r/119379/diff/ Testing --- Tested with Orca. Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119870: Make TabGroup a focus scope

/ Testing --- Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119872: AppletInterface::init should set focus not forceActiveFocus

handling work in KickOff. Patches for KickOff still need cleanup. Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119874: Make Kicker's root item a FocusScope

ocus moves to the line edit since that one has focus: true. Diffs - applets/kicker/package/contents/ui/FullRepresentation.qml 1a1e845 Diff: https://git.reviewboard.kde.org/r/119874/diff/ Testing --- Thanks, Frederik Gladhorn ___ Pl

Re: Review Request 119874: Make Kicker's root item a FocusScope

that when it receives focus the focus moves to the line edit since that one has focus: true. Diffs - applets/kicker/package/contents/ui/FullRepresentation.qml 1a1e845 Diff: https://git.reviewboard.kde.org/r/119874/diff/ Testing --- Thanks, Frederi

Re: Review Request 119874: Make Kicker's root item a FocusScope

Testing --- Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119870: Make TabGroup a focus scope

/plasmacomponents/qml/TabGroup.qml 8cad25f Diff: https://git.reviewboard.kde.org/r/119870/diff/ Testing --- Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119872: AppletInterface::init should set focus not forceActiveFocus

Diff: https://git.reviewboard.kde.org/r/119872/diff/ Testing --- Made accessibility focus handling work in KickOff. Patches for KickOff still need cleanup. Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 120352: Remove keyboard click volume setting

board sounds. For virtual keybords this would certainly make sense, but this is about the hardware keyboard. If the feature never worked, then just remove it, it can always be added back and fixed when someone requests it. - Frederik Gladhorn On Sept. 28, 2014, 1:33 p.m., David Edmundson

Review Request 122464: Remove bell kcm

Diff: https://git.reviewboard.kde.org/r/122464/diff/ Testing --- Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122464: Remove bell kcm

bell/bell.cpp 1c4f552 kcms/bell/bell.desktop f1cd552 kcms/bell/bell.h fda09b5 Diff: https://git.reviewboard.kde.org/r/122464/diff/ Testing --- Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kd

Review Request 122533: Port accessibility kcm somewhat to xcb xkb

e101de4 kcms/access/kaccess.cpp 2419efb Diff: https://git.reviewboard.kde.org/r/122533/diff/ Testing --- After this change sticky keys and some of the other features seem to work again. Thanks, Frederik Gladhorn ___ Plasma-devel mailing li

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

t seems to have been rotting for a while. Diffs (updated) - kcms/access/kaccess.h e101de4 kcms/access/kaccess.cpp 2419efb Diff: https://git.reviewboard.kde.org/r/122533/diff/ Testing --- After this change sticky keys and some of the other features seem to work again. Th

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

again. Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122540: Add screen reader to Accessibility KCM

ccess/accessibility.ui 2e0db83 kcms/access/kaccess.h e101de4 kcms/access/kaccess.cpp 2419efb kcms/access/kcmaccess.cpp 7e0217d Diff: https://git.reviewboard.kde.org/r/122540/diff/ Testing --- This allows me to start and stop Orca using meta-alt-s or the kcm. Thanks, Frederik Gla

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

---- On Feb. 11, 2015, 9:25 p.m., Frederik Gladhorn wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122533/ >

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

Diffs (updated) - kcms/access/kaccess.h e101de4 kcms/access/kaccess.cpp 2419efb Diff: https://git.reviewboard.kde.org/r/122533/diff/ Testing --- After this change sticky keys and some of the other features seem to work again. Thanks, Fr

Re: Review Request 122540: Add screen reader to Accessibility KCM

t and stop Orca using meta-alt-s or the kcm. Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122540: Add screen reader to Accessibility KCM

To reply, visit: https://git.reviewboard.kde.org/r/122540/#review75930 --- On Feb. 12, 2015, 5:01 p.m., Frederik Gladhorn wrote: > > --- > This is an automatical

Re: Review Request 122540: Add screen reader to Accessibility KCM

-s or the kcm. Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122540: Add screen reader to Accessibility KCM

This allows me to start and stop Orca using meta-alt-s or the kcm. Thanks, Frederik Gladhorn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

ld code was, it seems to have been rotting for a while. Diffs - kcms/access/kaccess.h e101de4 kcms/access/kaccess.cpp 2419efb Diff: https://git.reviewboard.kde.org/r/122533/diff/ Testing --- After this change sticky keys and some of the other features seem to work again. Th

Re: [PATCH] Review request for plasma marble wallpaper (playground)

Hi Sascha, thanks for looking at the marble wallpaper - that's much appreciated from my side :) I have had no time to look at the patch at all yet, will do so on the weekend. On Monday 15 December 2008 21:41:16 Sascha Peilicke wrote: > For Frederic Gladhorn and FYI. > > > This patch adds/changes

extenderitem layout problems

Hi all, as you probably noticed, the NetworkManager Plasma applet has some layout problems. They are caused by the following setup: -we add a widget into the ExtenderItem -QGraphicsGridLayout is added to the widget -whenever for example a wireless network appears, some widget is added to the layo

suspend/hibernate and lock-logout

Hi, since lately suspend and hibernate work quite well for me, I added buttons for them to the lock/lockout plasma widget. I decided to follow the current scheme and add a checkbox for each button in the config. So far choosing any two out of four buttons works perfectly, but having more than tw

Review Request: Sleep/Hibernate in Lock/Log out plasma applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1031/ --- Review request for Plasma. Summary --- Display Sleep and Hibernate buttons

Re: Review Request: Sleep/Hibernate in Lock/Log out plasma applet

-- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1031/#review1613 --- On 2009-07-14 21:56:47, Frederik Gladhorn wrote: > > --- > This

D14023: Make Primary Combo a regular QComboBox

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY This will make it easier to re-design the UI. Also it centralizes all updates, before a bunch of

D14024: Move KCM to UI file

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY This fixes the size policy, the only element we want expanding is the preview area on top, every

D14025: Move scale and unify button to the top, next to primary combo

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen BRANCH gladhorn/ui REVISION DETAIL https://phabricator.kde.org/D14025 AFFECTED FILES

D14025: Move scale and unify button to the top, next to primary combo

gladhorn added a comment. The diff is confusing. It actually moves the buttons into the other layout :) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D14025: Move scale and unify button to the top, next to primary combo

gladhorn added a comment. before: F6067872: kscreen_kcm_before.png REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D14025: Move scale and unify button to the top, next to primary combo

gladhorn added a comment. after: F6067891: kscreen_kcm_after.png REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, ab

D14025: Move scale and unify button to the top, next to primary combo

gladhorn added a comment. This is at least a first step in making the UI a bit nicer. And imho it's a low-hanging fruit. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14024: Move KCM to UI file

gladhorn added a comment. depends on https://phabricator.kde.org/D14023 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14024 To: gladhorn, #plasma, sebas Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14025: Move scale and unify button to the top, next to primary combo

gladhorn added a comment. depends on https://phabricator.kde.org/D14024 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn, #vdg, #plasma, sebas Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seba

D14023: Make Primary Combo a regular QComboBox

gladhorn added a comment. Need to remove debug statements. INLINE COMMENTS > widget.cpp:171 > + > +qDebug() << Q_FUNC_INFO; > +Q_FOREACH (const KScreen::OutputPtr &output, mConfig->outputs()) { Left over debug statement. Remove. > widget.cpp:508 > +{ > +qDebug() << Q_FUNC_INFO <

D14024: Move KCM to UI file

gladhorn updated this revision to Diff 37501. gladhorn added a comment. Fixed stretch for unified outputs REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14024?vs=37496&id=37501 BRANCH gladhorn/ui REVISION DETAIL https://phabricator.kde.org/D14024 AFF

D14023: Make Primary Combo a regular QComboBox

gladhorn updated this revision to Diff 37502. gladhorn added a comment. Removed left over debug statements REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14023?vs=37495&id=37502 REVISION DETAIL https://phabricator.kde.org/D14023 AFFECTED FILES kcm/src

D14024: Move KCM to UI file

gladhorn added a comment. Sure, but let's get there step by step. In general this needs some un-tangling of functionality and UI first. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14024 To: gladhorn, #plasma, sebas Cc: ngraham, plasma-devel, ragreen, Pitel, Zren

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

gladhorn added a comment. I've been running with QT_SCREEN_SCALE_FACTORS set manually for at least half a year and it works for me. Except for suspending, so that seems to be a wide spread issue, maybe even in Qt. I'm strongly in favor of this, it is the only thing that works sensibly on xor

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

gladhorn added inline comments. INLINE COMMENTS > outputconfig.cpp:145 > +connect(scaleDialogButton, &QPushButton::released, [this] { > +QPointer dialog = new ScalingConfig(mOutput, > this); > +dialog->exec(); Why not use QScopedPointer here? REPOSITORY R104 K

D14031: Move ECM & Co. macro includes before finding Qt & KF

gladhorn added a comment. Seems OK to me. REPOSITORY R104 KScreen BRANCH movemoduleincludestofront REVISION DETAIL https://phabricator.kde.org/D14031 To: kossebau, gladhorn, sebas, romangg, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abett

D14023: Make Primary Combo a regular QComboBox

gladhorn updated this revision to Diff 37530. gladhorn added a comment. Make diff slightly smaller (newlines) and remove a qDebug that was stil left over. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14023?vs=37502&id=37530 BRANCH master REVISION DET

D14023: Make Primary Combo a regular QComboBox

This revision was automatically updated to reflect the committed changes. Closed by commit R104:77ee98211895: Make Primary Combo a regular QComboBox (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14023?vs=37530&id=37554 REVISION DETAIL

D14044: Simplify getting edid in xrandr backend

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY XRandR::outputEdid is used in only one place, let it return a byte array directly. REPOSITORY

D14044: Simplify getting edid in xrandr backend

gladhorn added inline comments. INLINE COMMENTS > zzag wrote in xrandr.cpp:273 > reinterpret_cast(result) I agree, but there are more places with c-style casts, let's clean them all up in one go. This is just moving things. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL

D14044: Simplify getting edid in xrandr backend

This revision was automatically updated to reflect the committed changes. Closed by commit R110:e4236e02b814: Simplify getting edid in xrandr backend (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14044?vs=37555&id=37557 REVISI

D14048: Fix fake parser copy and paste error

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY all other cases remove the key they were looking for, this seems to be a copy and paste error.

D14024: Move KCM to UI file

This revision was automatically updated to reflect the committed changes. Closed by commit R104:ce68ee44e099: Move KCM to UI file (authored by gladhorn). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14024?vs=37501&id=37594#toc REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https

D14025: Move scale and unify button to the top, next to primary combo

gladhorn closed this revision. gladhorn added a comment. Pushed, sadly without the phabricator tag, since I'm struggling to manage > 1 patch with phabricator. b01b567296b70b9b593eaa438d86dffe7b663afa REPOSITORY R

D14058: Give connect to lambda a context object

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY This is cleaner since it will track the life-time. REPOSITORY R110 KScreen Library BRANCH ma

D14058: Give connect to lambda a context object

gladhorn added a comment. Yes, this is partially to shut up clazy. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14058 To: gladhorn, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14058: Give connect to lambda a context object

This revision was automatically updated to reflect the committed changes. Closed by commit R110:bd4fa7d318e8: Give connect to lambda a context object (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14058?vs=37596&id=37598 REVISI

D14060: Clean up string casts

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Compile without casting to/from ascii to avoid typical mistakes due to implicit conversions. Fix

D14060: Clean up string casts

gladhorn marked 3 inline comments as done. gladhorn added inline comments. INLINE COMMENTS > broulik wrote in testkwaylandbackend.cpp:88 > Why `true`? Indeed, that makes no sense. > broulik wrote in testlog.cpp:52 > I thought when concatenating the advantage of `QStringLiteral` don't cut it >

D14060: Clean up string casts

gladhorn updated this revision to Diff 37616. gladhorn marked 2 inline comments as done. gladhorn added a comment. Fixed some of Kai's comments, some minor things are still to do. REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14060?vs=37599&id=3761

D14060: Clean up string casts

gladhorn added inline comments. INLINE COMMENTS > davidedmundson wrote in waylandtestserver.cpp:39 > shouldn't that be a QStringLiteral? Concatenation is still faster with latin1string. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D14060 To:

D14065: Be strict about implicit string casts

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Use QT_NO_CAST_FROM_ASCII and friends. There are a bunch of places where QString should really b

D14048: Fix fake parser copy and paste error

This revision was automatically updated to reflect the committed changes. Closed by commit R110:967f21ac54f2: Fix fake parser copy and paste error (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14048?vs=37565&id=37620 REVISION

D14060: Clean up string casts

gladhorn added a comment. I think micro-optimizing the tests further is simply not worth anyone's time. I'd propose taking this in (and if you spot more things, do them on top of this change). REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D14060: Clean up string casts

This revision was automatically updated to reflect the committed changes. Closed by commit R110:973bef8349d2: Clean up string casts (authored by gladhorn). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14060?vs=37616&id=37628#toc REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPD

D14065: Be strict about implicit string casts

This revision was automatically updated to reflect the committed changes. Closed by commit R104:e9cca953e8bc: Be strict about implicit string casts (authored by gladhorn). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14065?vs=37619&id=37630#toc REPOSITORY R104 KScreen CHANGES SINCE

D14073: Improve wording in comment

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14073 A

D14074: Use context argument in lambda connect

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen BRANCH x REVISION DETAIL https://phabricator.kde.org/D14074 AFFECTED FILES kded/da

D14075: In function returning void, use plain return

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen BRANCH x REVISION DETAIL https://phabricator.kde.o

D14076: Use QStringLiteral when a conversion to QString will happen

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY In this case we would allocate to create a QString instance sin

D14078: Simplify string comparison

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library BRANCH stringcomp REVISION DETAIL https://

D14078: Simplify string comparison

This revision was automatically updated to reflect the committed changes. Closed by commit R110:9694b4a511e4: Simplify string comparison (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14078?vs=37643&id=37645 REVISION DETAIL h

D14073: Improve wording in comment

This revision was automatically updated to reflect the committed changes. Closed by commit R104:94d19d7e335f: Improve wording in comment (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14073?vs=37635&id=37647 REVISION DETAIL https://p

D14074: Use context argument in lambda connect

This revision was automatically updated to reflect the committed changes. Closed by commit R104:439feca241e8: Use context argument in lambda connect (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14074?vs=37636&id=37648 REVISION DETAIL

D14075: In function returning void, use plain return

This revision was automatically updated to reflect the committed changes. Closed by commit R104:f62f316ab207: In function returning void, use plain return (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14075?vs=37637&id=37649 REVISION

D14074: Use context argument in lambda connect

gladhorn added inline comments. INLINE COMMENTS > broulik wrote in daemon.cpp:94 > You could also connect it to the method directly > > connect(action, &QAction::triggered, this, &KScreenDaemon::displayButton); Of course, that was pretty blind of me. REPOSITORY R104 KScreen REVISION DETAI

D14076: Use QStringLiteral when a conversion to QString will happen

This revision was automatically updated to reflect the committed changes. Closed by commit R104:ccbee3e89925: Use QStringLiteral when a conversion to QString will happen (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14076?vs=37640&id=3

D14081: Fix types, improve readability

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY These changes don't matter in the big picture but hopefully mak

D14081: Fix types, improve readability

gladhorn updated this revision to Diff 37724. gladhorn added a comment. Added * to auto pointers REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14081?vs=37663&id=37724 BRANCH arcpatch-D14081 REVISION DETAIL https://phabricator.kde.org/D14081

D14081: Fix types, improve readability

gladhorn updated this revision to Diff 37736. gladhorn added a comment. Fixed placement of * REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14081?vs=37724&id=37736 BRANCH arcpatch-D14081 REVISION DETAIL https://phabricator.kde.org/D14081 AFFE

D14143: Make the action selector OSD independent of the other OSDs

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY This OSD should handle keyboard input and behave different, so

D14144: Make the action selector OSD independent of the other OSDs

gladhorn created this revision. gladhorn added a reviewer: Plasma. gladhorn added a project: Plasma. gladhorn requested review of this revision. REVISION SUMMARY This OSD should handle keyboard input and behave different, so make it work on its own. In follow up changes, the keyboard handling

D14144: Make the action selector OSD independent of the other OSDs

gladhorn added a comment. arc squashed https://phabricator.kde.org/D14143 into this :( Tool failure. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14144 To: gladhorn, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abett

D14081: Fix types, improve readability

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:20c88fd906dd: Fix types, improve readability (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE

D14143: Make the action selector OSD independent of the other OSDs

gladhorn added inline comments. INLINE COMMENTS > zzag wrote in osd.cpp:120 > s/expansion/extension/ Good point. I copied this from the original instantiation, will fix both. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14143 To: gladhorn, #plasma Cc: zzag, plasma-

D14143: Make the action selector OSD independent of the other OSDs

gladhorn updated this revision to Diff 37850. gladhorn added a comment. Remove string ref in return. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14143?vs=37826&id=37850 BRANCH arcpatch-D14143 REVISION DETAIL https://phabricator.kde.org/D14143 AFFE

  1   2   3   >