Review Request 128682: Fix typo in icon name

--- Introduced in commit 9e236ec5d4d28d7498dfcc830a95590dececcf02 Diffs - src/declarative/pkupdates.cpp 324387f Diff: https://git.reviewboard.kde.org/r/128682/diff/ Testing --- Built and run, icon appears fine. Thanks, Fabian Vogt

Re: Review Request 128682: Fix typo in icon name

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 9662b9c5d83ad0188803830d7cf9a96a2db0d114 by David Edmundson on behalf of Fabian Vogt to branch master. Repository: plasma-pk-updates Description --- Introduced in commit

Re: Review Request 128815: Fix themes list with SDDM 0.14

hardcoded at configure time: "@DATA_INSTALL_DIR@/themes". - Fabian Vogt On Sept. 2, 2016, 5:51 nachm., Antonio Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 129404: [AppletInterface] Never pull focus away from fullRepresentation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129404/#review100841 --- Ship it! Tested, works fine! - Fabian Vogt On Nov. 14

[Differential] [Request, 3 lines] D4464: Add missing include in sortedactivitiesmodel to fix build with GCC 7I did not build-test this, but it's fairly obvious.

fvogt created this revision. fvogt added a reviewer: Plasma. fvogt added a subscriber: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes "error: 'placeholders' is not a namespace-name" REPOSITORY R119 Plasma

[Differential] [Closed] D4464: Add missing include in sortedactivitiesmodel to fix build with GCC 7I did not build-test this, but it's fairly obvious.

fvogt closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4464 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fvogt, #plasma, davidedmundson Cc: plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg

[Differential] [Request, 2 lines] D4579: Do not treat filename in selection as URL

fvogt created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KFileWidget::setSelection(QString &) accepts either absolute URLs or relative paths. If the filename contains a :, it gets treated as a URL a

[Differential] [Updated] D4579: Do not treat filename in selection as URL

fvogt added a reviewer: Plasma. fvogt added a comment. https://bugs.kde.org/show_bug.cgi?id=376365 contains reproducer, with this change it works. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D4579 EMAIL PREFERENCES https://phab

[Differential] [Closed] D4579: Do not treat filename in selection as URL

This revision was automatically updated to reflect the committed changes. Closed by commit R135:e70f8134a2bc: Do not treat filename in selection as URL (authored by fvogt). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4579?v

[Differential] [Accepted] D4654: Port to QMultiHash.

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. If all cases of insert(key,value) are validated to behave correctly (same as insertMulti now!), this looks good to me. Easier to understand and fewer code lines! REPOSITORY R120 Plasma

[Differential] [Request, 4 lines] D4794: Fix default fixed font in fonts kcm

fvogt created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Now it is the same as used by plasma-integration. Also adjust the file name in the comment, which was apparently forgotten. TEST PLAN I didn

[Differential] [Updated] D4794: Fix default fixed font in fonts kcm

fvogt added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4794 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fvogt, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

[Differential] [Updated] D4794: Fix default fixed font in fonts kcm

fvogt edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4794 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fvogt, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuter

[Differential] [Closed] D4794: Fix default fixed font in fonts kcm

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d02de0db36a3: Fix default fixed font in fonts kcm (authored by fvogt). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4794?vs=11826&id=11841 REVISION DETAIL

[Differential] [Request, 24 lines] D4821: Implement manual focus on click

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Currently only the first created screenlock window gets focus. On clicks, no focus events are sent, which makes it impossible to input passwords. This patch now makes it possible to focus to a diffe

[Differential] [Commented On] D4821: Implement manual focus on click

fvogt added a comment. This is weird: While the fix works absolutely fine (and reliably) for me on my primary user account, it does not have any effect for a different user around and @broulik Even weirder: I cannot reproduce the original bug in any of my VMs using multihead QXL...

[Differential] [Commented On] D4821: Implement manual focus on click

fvogt added a comment. In https://phabricator.kde.org/D4821#90657, @graesslin wrote: > Just as an fyi: in the build tree there is a test app which does the complete locking without the need for restart the session. Would that really work for changes in x11locker.cpp as well? it's

[Differential] [Updated, 28 lines] D4821: Implement manual focus on click

fvogt updated this revision to Diff 11916. fvogt added a comment. Handle the case better when the currently focused window vanishes REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4821?vs=11898&id=11916 BRANCH Plasma/5.8 REVISION DETAIL https://p

[Differential] [Commented On] D4821: Implement manual focus on click

fvogt added a comment. I finally figured the issue out. Newly appearing windows try to steal focus, which makes m_focusedLockWindow actually wrong. That explains why it works only for some and only for some setups... I'll try to fix that by adding setAttribute(Qt::WA_ShowWithoutAc

[Differential] [Updated, 29 lines] D4821: Implement manual focus on click

fvogt updated this revision to Diff 11941. fvogt added a comment. Newly created windows do not steal focus anymore Needs a quick test that it does not break wayland (e.g. no focus at all) REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4821?vs=119

[Differential] [Requested Review] D4821: Implement manual focus on click

fvogt requested review of this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4821 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fvogt, broulik, #plasma, graesslin Cc: plasma-devel, progwolff, lesliezhai, ali-moham

[Differential] [Commented On] D4821: Implement manual focus on click

fvogt added a comment. In https://phabricator.kde.org/D4821#91393, @hein wrote: > > On Wayland screen locker is initially focused but clicking on different screens doesn't focus them. > > If this is outstanding, maybe add a FIXME TODO so we don't forget ...? Yes, but that can

[Differential] [Closed] D4821: Implement manual focus on click

This revision was automatically updated to reflect the committed changes. Closed by commit R133:f8043de10b5d: Implement manual focus on click (authored by fvogt). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4821?vs=11941&id=12030 REVISION DETAIL ht

D4955: [QDBusMenuBar] Connect to popupRequested signal

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. Can't apply to Plasma/5.9 with arc patch as your diff is missing the workaround code for Qt 5.7.0. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL htt

D4955: [QDBusMenuBar] Connect to popupRequested signal

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Tested this with Qt 5.6.2 + backports, the signal gets triggered fine. So far it only seems to work with a few select apps (dolphin), some (e.g. konsole) do not assign shortcuts at all and ot

D5025: Do not use fixed steps when scrolling on battery icon

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY This makes it possible to have some more fine-grained control over the screen brightness with scroll devices that support it, like touchpads or trackpoints. TEST PLAN Tested with touchpad, trackp

D5025: Do not use fixed steps when scrolling on battery icon

fvogt added a comment. Arc seems to have selected my local branch as target branch for some reason, it should be "master" instead, obviously REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5025 To: fvogt, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali

D5025: Do not use fixed steps when scrolling on battery icon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:82a44a3f264c: Do not use fixed steps when scrolling on battery icon (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5025?vs=12405&id=12

D5227: Add a configuration option to hide the show password button

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY The show password button only makes sense with a virtual keyboard on touchscreens. On desktop PCs it's not only not useful, but it can also be used to show (partially) typed in passwords. It also

D5227: Add a configuration option to hide the show password button

fvogt updated this revision to Diff 12933. fvogt added a comment. Add a comment in greeterapp.cpp and also add a tooltip to the configuration option label. REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5227?vs=12932&id=12933 BRANCH master REVISI

D5227: Add a configuration option to hide the show password button

fvogt planned changes to this revision. fvogt added a comment. I would fix the clipboard content issue with klipper (although I find that approach wrong as it's too complicated as a seemingly unrelated component needs to support the screenlocker), but I do not have enough experience in that a

D5227: Add a configuration option to hide the show password button

fvogt added a comment. In https://phabricator.kde.org/D5227#98542, @broulik wrote: > For show password button there's a kiosk restriction available: **lineedit_reveal_password** (see https://userbase.kde.org/KDE_System_Administration/Kiosk/Keys) Indeed, that works! Now if just th

D5227: Add a configuration option to hide the show password button

fvogt added a comment. In https://phabricator.kde.org/D5227#98555, @graesslin wrote: > I'm against adding this option as the greeter does not have any influence over the lnf package. It works with our default but as soon as users change the theme we do not know. I'm against adding new op

D5351: kcm_baloofile: Add option to disable file content indexing

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Baloo supports "only basic indexing" since version 5.15, which causes it to only store file names into the database: https://community.kde.org/Baloo/Configuration TEST PLAN Ran "balooctl config s

D5351: kcm_baloofile: Add option to disable file content indexing

fvogt updated this revision to Diff 13233. fvogt added a comment. Obviously for master only. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5351?vs=13232&id=13233 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5351 AFFECTED FILES

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. In D12405#676733 , @memeplex wrote: > So I set QT_SCREEN_SCALE_FACTORS='eDP-1=2;DP-2=1.7;'. But consider: > > 1. QT_AUTO_SCREEN_SCALE_FACTOR=1 QT_SCREEN_SCALE_FACTORS='eDP-1=2;DP-2=1.7;' konsole > 2. QT_AUTO_SCREEN_SC

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added a comment. I just tried that here and it works fine (Qt 5.15.1). Maybe there's something else in the environment which breaks it? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: memeplex, anthonyfieroni, luxus, snugghash, gla

Re: Relicensing Plasma Browser Integration Host to GPLv3+

e following people (and myself) touched that folder: > > David Edmundson > Fabian Vogt > Laurent Montel > Friedrich W. H. Kossebau > Matthijs Tijink > > Are you fine with this, or have any other comments? I'm fine with GPL-3.0-or-later, yes. Cheers, Fabian > Cheers > Kai Uwe > > (Should probably do some REUSE porting as part of this, too ;)

Re: Fwd: Consistent CMake requirements in Plasma

Moin, Am Mittwoch, 24. Februar 2021, 14:40:08 CET schrieb Nicolas Fella: > Hi packagers, > > I recently proposed to formalize that Plasma depends on CMake 3.16. The > reasoning is to 1) make the requirements consistent across Plasma repos > and 2) enable the use of modern CMake features. If accpe

Re: Critical Denial of Service bugs in Discover

Hi, Am Samstag, 5. Februar 2022, 22:16:28 CET schrieb Ben Cooksley: > Hi all, > > Over the past week or so Sysadmin has been dealing with an extremely high > volume of traffic directed towards both download.kde.org and > distribute.kde.org. > > This traffic volume is curious in so far that it is

Re: Critical Denial of Service bugs in Discover

Moin, Am Sonntag, 6. Februar 2022, 19:27:11 CET schrieb Ben Cooksley: > On Sun, Feb 6, 2022 at 1:07 PM Fabian Vogt wrote: > > The first URL is used by kfontinst.knsrc from plasma-workspace: > > ProvidersUrl=https://distribute.kde.org/khotnewstuff/fonts-providers.xml > >

[plasma/plasma-workspace/Plasma/5.24] kcms/kfontinst/kcmfontinst: Use the correct endpoint for this - hosted by a CDN and therefore capable of handling much greater volumes of traffic.

Git commit fb5656eaf2e021e6a9288edd00573c14afe6e115 by Fabian Vogt, on behalf of Ben Cooksley. Committed on 07/02/2022 at 11:09. Pushed by fvogt into branch 'Plasma/5.24'. Use the correct endpoint for this - hosted by a CDN and therefore capable of handling much greater volumes

Re: Critical Denial of Service bugs in Discover

Moin, Am Sonntag, 6. Februar 2022, 21:54:13 CET schrieb Fabian Vogt: > Am Sonntag, 6. Februar 2022, 19:27:11 CET schrieb Ben Cooksley: > > On Sun, Feb 6, 2022 at 1:07 PM Fabian Vogt wrote: > > > The first URL is used by kfontinst.knsrc from plasma-workspace: > &

Re: Plasma 5.24.2

Moin, Am Dienstag, 22. Februar 2022, 14:56:11 CET schrieb Jonathan Riddell: > Plasma 5.24.2 is now released https://kde.org/announcements/plasma/5/5.24.2 It appears like plasma-mobile-5.24.2.tar.xz is missing translations, like with 5.24.1 already. Cheers, Fabian

Re: Plasma 5.26.3: Breeze is broken

Hi, Am Dienstag, 8. November 2022, 15:28:54 CET schrieb Jonathan Riddell: > Plasma 5.26.3 is now released https://kde.org/announcements/plasma/5/5.26.3 At least breeze has the wrong version in its CMakeLists.txt: set(PROJECT_VERSION "5.26.2") This means that plasma-workspace will silently ignor

Re: Plasma 6.0.1

Hi, Am Mittwoch, 6. März 2024, 00:38:54 CET schrieb Jonathan Riddell: > Plasma 6.0.1 is out now for packaging and distributing > https://kde.org/announcements/plasma/6.0.1/ URL is broken, it's https://kde.org/announcements/plasma/6/6.0.1/. Also, kpipewire fails to build because there's a syntax

D27643: FileChooser: download remote files to a cache location to open them through the portal

fvogt added a comment. In D27643#618125 , @jgrulich wrote: > I have never used fuse. I see you can use kio-fuse over dbus to mount a file, but you still have to unmount it, which will be a problem, because from the portal I don't know whether th

D27643: FileChooser: download remote files to a cache location to open them through the portal

fvogt added a comment. In D27643#618310 , @jgrulich wrote: > In D27643#618132 , @fvogt wrote: > > > In D27643#618125 , @jgrulich wrote: > > > > > I have

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

fvogt planned changes to this revision. fvogt added a comment. I need some input on how to express `HAVE_QTWEBENGINEWIDGETS` with this. Currently it would fail to build if `Qt5WebEngineWidgets` is installed but `Qt5WebChannel` isn't. REPOSITORY R111 KSysguard Library REVISION DETAIL htt

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

fvogt added a comment. Currently `processui/scripting.cpp` has this: #if HAVE_QTWEBENGINEWIDGETS #include ... #endif So `Qt5WebEngineWidgets` without `Qt5WebChannel` will fail to build and `Qt5WebChannel` without `Qt5WebEngineWidgets` leads to scripting support gettin

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

fvogt updated this revision to Diff 76750. fvogt added a comment. This revision is now accepted and ready to land. Treat scripting as a feature instead REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27347?vs=75550&id=76750 BRANCH Plasma/5.18 R

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

fvogt marked an inline comment as done. fvogt added inline comments. INLINE COMMENTS > lbeltrame wrote in CMakeLists.txt:86 > Should you add a message in case one of the two is not found? In that case `WEBENGINE_SCRIPTING_ENABLED` is `FALSE` and it'll print that `Scripting plugin support` is no

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

This revision was automatically updated to reflect the committed changes. fvogt marked an inline comment as done. Closed by commit R111:ba7f78716af6: Only link to Qt5WebChannel if Qt5WebEngineWidgets available (authored by fvogt). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE h

D28134: Add ColorUtils

fvogt added inline comments. INLINE COMMENTS > colorutils.cpp:90 > +}); > +} > + If item is neither of those three, it would never call `pending->setValue` at all > colorutils.cpp:103 > + > +if (pending->value().isValid()) { > + pending->setValue(luma(result->value().va

D28614: Add better player tab crash handling

fvogt added a comment. If there is a false positive in the detection, how would those be handled? AFAICT the players would never appear in mpris again? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28614 To: broulik, #plasma, fvogt, cblack Cc: p

D28614: Add better player tab crash handling

fvogt added a comment. In D28614#642630 , @broulik wrote: > > If there is a false positive in the detection, how would those be handled? AFAICT the players would never appear in mpris again? > > I believe whenever a player starts playing agai

D28614: Add better player tab crash handling

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. For false positives the player would get added again by the `playing` event, which is not ideal, but as it doesn't require a reload it's IMO close enough. REPOSITORY R856 Plasma Browser Int

D26185: Also disable automatic scaling on Qt >= 5.14

fvogt added a comment. That sounds like a Qt bug, which fails to use the `QT_SCREEN_SCALE_FACTORS` value for pixmaps for some reason. Is it a multi-monitor setup? Can you open a new issue with details and a screenshot? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator

D28705: Don't consider player gone when it only got temporarily added by us

fvogt added a comment. So was the case handled by line 805 completely broken? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28705 To: broulik, #plasma, fvogt, ognarb Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28705: Don't consider player gone when it only got temporarily added by us

fvogt added a comment. In D28705#644982 , @broulik wrote: > It worked on Chrome, and the properties can be accessed from the same context. > It's just that the mutation.removedNodes loop above which is in content script cannot access those JS

D28706: Restore old Audio prototype after exportFunction

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. I can't find a better way to do this either... Some notes: - `window.eval` works as expected so if not entirely unlucky (old firefox?) this can be replaced by using `executeScript` c

D28709: Implement executeScript for Firefox

fvogt created this revision. fvogt added reviewers: Plasma, broulik. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY window.eval is exactly what we need, so we can drop the Firefox specific replacements like calls to exportFunction. TEST PLAN Restar

D28709: Implement executeScript for Firefox

fvogt updated this revision to Diff 79729. fvogt added a comment. Use full URL in comment REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28709?vs=79728&id=79729 BRANCH ffeval REVISION DETAIL https://phabricator.kde.org/D28709 AFFEC

D28709: Implement executeScript for Firefox

fvogt added a comment. Note: Remains to be tested on non-firefox and old firefox ESR. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28706: Restore old Audio prototype after exportFunction

fvogt added a comment. D28709 conflicts/supersedes this now. `window.Audio.prototype != Audio` is a separate issue though, which might still need fixing. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28706

D28709: Implement executeScript for Firefox

fvogt added a comment. I'm not sure about the `// Firefox enforces Content-Security-Policy also for scripts injected by the content-script` part, but I'm not sure how to test it. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #pl

D28709: Implement executeScript for Firefox

fvogt added a comment. I just tried this with google translate on FF ESR 68(.1.0 IIRC) and it worked, but there was an error about the content security policy having blocked an eval. The error is gone if the extension is disabled. So this needs a test with spotify/nextcloud. Do you have any

D28709: Implement executeScript for Firefox

fvogt abandoned this revision. fvogt added a comment. https://bugzilla.mozilla.org/show_bug.cgi?id=1591983 :-( I guess spotify had `unsave-eval`, but not `unsafe-inline`, so this method just breaks different pages... Apparently it's possible to add a `script` element with ´src="moz-

D28705: Don't consider player gone when it only got temporarily added by us

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. In D28705#645038 , @broulik wrote: > Yeah, wondering the same... maybe it didn't. Anyway this also fixes Spotify's previous/next buttons not wor

D28719: [Purpose Plugin] Detect cancelling the prompt more reliable

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Looks fragile, but I don't have a better idea either. https://bugreports.qt.io/browse/QTBUG-56761 sigh REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.

D28709: Implement executeScript for Firefox

fvogt added a comment. In D28709#645296 , @broulik wrote: > I've originally injected breeze scroll bar CSS as style with src in the extension but that also cause other issues where websites weren't allowed to access the different origin of the s

D28791: Manually merge stored and default settings

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Just have to make sure not to add anything to `DEFAULT_EXTENSION_SETTINGS.mpris.websiteSettings` now. Previously that would've been ignored. INLINE COMMENTS > utils.js:39 > +

D28791: Manually merge stored and default settings

fvogt accepted this revision. fvogt added inline comments. INLINE COMMENTS > fvogt wrote in utils.js:39 > Why not if/else? I'd invert the condition REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28791 To: broulik, #plasma, fvogt Cc: plasma-devel, O

D28893: Detect Vivaldi based on binary name

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Tested, works. I didn't even notice that it broke... Will probably have to be refactored later to look at `environmentDescriptions` or `environmentNames` though. > Should be good for

D28853: krunner: Prevent regression

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Proper fix with refactoring will take too long, let's take this for now. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28853 To: apol, #p

D28853: krunner: Prevent regression

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a28e110cbb15: krunner: Prevent regression (authored by apol, committed by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28853?vs=80192&id=80371 R

D28939: Don't offer sending non-http(s) links and sources via KDE Connect

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. > Repository R120 Plasma Workspace How did that happen? > Should we include "ftp"? I'd say yes, together with `ftps`

D28658: [krdb] Drop GTK2 colour exporting

fvogt added a comment. > FIXED-IN: 5.19.0 (or should we consider this a bugfix and land it on the stable branch?) At least in openSUSE we'll backport it to Plasma 5.18, but it might not be the kind of behaviour change desired in 5.18 at this point in time... REPOSITORY R119 Plasma Des

D28936: Use a Proxy object to detect changes within the MediaMetadata

fvogt added a comment. AFAICT (take with a grain of salt, I'm a JS n00b) this doesn't catch something like this: let a = {}; navigator.mediaSession.metadata = a; a["foo"] = "bar"; And behaves weirdly if you do: let a = navigator.mediaSession.metadata; navigator.m

D28936: Use a Proxy object to detect changes within the MediaMetadata

fvogt added a comment. In D28936#656422 , @broulik wrote: > > this doesn't catch something like this > > Yeah it doesn't. I thought I could "monitor" an Object but the caller actually has to //use// the Proxy for it to detect anything :/ >

D28926: Signal player gone in "pagehide" not "beforeunload"

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Didn't test myself, but apparently you did, so LGTM. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28926 To: broulik, #plasma, fvogt, ognarb Cc:

D29533: [Reminder] Also advert Chromie store for Vivaldi

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. "Chromie"? :D For some reason I can't get the reminder to trigger. `dbus-monitor` shows method call time=1588952594.025913 sender=:1.16 -> destination=org.kde.Activi

D9875: Extend parsing ssh prompt

fvogt added a comment. In D9875#675101 , @mkoller wrote: > This patch breaks usage for git (and probably others): > git first asks for a "Username for 'https:" which leads to ksshaskpass open the input dialog but the typed-in user > is n

D9875: Extend parsing ssh prompt

fvogt added a comment. In D9875#675107 , @mkoller wrote: > They did not overwrite each other since the entry for the Username holds an URL _without_ user but the password entry did. That's pretty fragile, but would need to be kept for comp

D9875: Extend parsing ssh prompt

fvogt closed this revision. fvogt added a comment. FTR: https://invent.kde.org/plasma/ksshaskpass/-/merge_requests/2 REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9875 To: fvogt, pali, lbeltrame Cc: mkoller, lbeltrame, ngraham, fvogt, plasma-devel,

D13776: Move the salt file existence check into the unprivileged process

fvogt created this revision. fvogt added reviewers: Plasma, aacid. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. fvogt requested review of this revision. REVISION SUMMARY Otherwise the salt is always recreated on with ~ on NFS with root_

D13776: Move the salt file existence check into the unprivileged process

fvogt updated this revision to Diff 36826. fvogt added a comment. Rebase on master - this only makes sense with the user privileges salt file reading. REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13776?vs=36815&id=36826 BRANCH master

D13776: Move remaining salt file operations into unprivileged processes

fvogt updated this revision to Diff 36827. fvogt added a comment. Fix rebase error REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13776?vs=36826&id=36827 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13776 AFFECTED FILES

D13776: Move remaining salt file operations into unprivileged processes

fvogt added a comment. > Are you saying that there are files that root can't read but the user can? Exactly. REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D13776 To: fvogt, #plasma, aacid Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, al

D13776: Move remaining salt file operations into unprivileged processes

fvogt added a comment. In D13776#289669 , @aacid wrote: > In D13776#289490 , @fvogt wrote: > > > > Are you saying that there are files that root can't read but the user can? > > > > Exactly. >

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

fvogt added inline comments. INLINE COMMENTS > gladhorn wrote in outputconfig.cpp:145 > Why not use QScopedPointer here? I just moved the code from kcm/src/widget.cpp. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: gladhorn, mart, hein, n

D14209: Listen for player "emptied" signal

fvogt added a comment. If the extension translates "emptied" to "stopped", wouldn't it be compatible with older hosts? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D14209 To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel, ragreen, Pit

D14209: Listen for player "emptied" signal

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Didn't test myself, but LGTM REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D14209 To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel, r

D13776: Move remaining salt file operations into unprivileged processes

This revision was automatically updated to reflect the committed changes. Closed by commit R107:c78e8ade9e2b: Move remaining salt file operations into unprivileged processes (authored by fvogt). REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13

D14599: Rename libbreezecommon to libbreezecommon5 and don't install .so links

fvogt created this revision. fvogt added reviewers: Breeze, zzag. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. fvogt requested review of this revision. REVISION SUMMARY libbreezecommon is not meant to be used outside of breeze (it can't

D14599: Rename libbreezecommon to libbreezecommon5 and don't install .so links

fvogt updated this revision to Diff 39062. fvogt added a comment. BUG: 397145 REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14599?vs=39061&id=39062 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14599 AFFECTED FILES kdecoration/CMakeList

D14599: Rename libbreezecommon to libbreezecommon5 and don't install .so links

This revision was automatically updated to reflect the committed changes. Closed by commit R31:763ec6d33541: Rename libbreezecommon to libbreezecommon5 and don't install .so links (authored by fvogt). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14599?vs=39062

D14822: Use QJSValue as method parameter type for the scripting interface

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY If a slot or Q_INVOKABLE has a QVariant as parameter and gets called from a QJSEngine's script, it receives a QJSValue wrapped as QVariant. T

D14822: Use QJSValue as method parameter type for the scripting interface

fvogt added inline comments. INLINE COMMENTS > anthonyfieroni wrote in applet.cpp:139 > So writeEntry gets QJSValue& now why you call again toVariant(), here > everywhere else. KConfigGroup != ConfigGroup. d->configGroup is from kconfig and does not take QJSValue. That's the core of the bugfix

D14822: Use QJSValue as method parameter type for the scripting interface

fvogt added a comment. A different approach of fixing this is to do something like if(value.userType() == qMetaTypeId()) value = value.value().toVariant(); in every function for every QVariant parameter. Advantages are that it's more obvious and the function's interface doe

  1   2   3   4   5   6   7   >