Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

2012-06-02 Thread David Edmundson
te m_installer, you pass this as the parent. publisher/remoteinstaller/remoteinstallerdialog.cpp <http://git.reviewboard.kde.org/r/105032/#comment11351> for single characters use ' ' rather than " ". That way Qt knows to search for a character (rather than

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

2012-06-03 Thread David Edmundson
> On June 2, 2012, 3:14 p.m., David Edmundson wrote: > > publisher/remoteinstaller/remoteinstallerdialog.cpp, line 53 > > <http://git.reviewboard.kde.org/r/105032/diff/3/?file=66057#file66057line53> > > > > This looks like it leaks. > > >

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

2012-06-03 Thread David Edmundson
::RemoteInstaller(const QString& username, const QString& hostname,const QString& source, QWidget* parent): QObject(parent), m_widget(parent) { ... } . - David Edmundson On June 3,

Re: Review Request: JJ bug 224062 - add switch user check to kickoff leave model

2012-06-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104879/#review14405 --- Ship it! Ship It! - David Edmundson On May 16, 2012, 3:05

Re: Bugsplashing

2012-06-04 Thread David Edmundson
ome bugs need to be fixed before 4.9 is out: for example the Weather > Station applet does not display anything anymore (API changes from ions I > suppose) so it'll be either fixed or removed as we cannot seriously ship > things that are really bro

Re: Plasmoid-TreeView problem

2012-06-04 Thread David Edmundson
On Mon, Jun 4, 2012 at 1:37 PM, Akos Toth wrote: > Hi > > I created a plasmoid, that shows my BZFlag friends (people I liked to play > with). > > When I place the plasmoid on the workspace, after I added some of my > "friends", I'm trying scoll on treeview, the content is not changing, unless > I

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

2012-06-05 Thread David Edmundson
) give you a ship it. - David Edmundson On June 4, 2012, 4:54 p.m., Giorgos Tsiapaliwkas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Review Request: Misc fixes in widget explorer tooltip including missing i18n

2012-06-07 Thread David Edmundson
.qml ea0606a Diff: http://git.reviewboard.kde.org/r/105177/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Mouse wheel on Slider QML component

2012-06-07 Thread David Edmundson
On Thu, Jun 7, 2012 at 9:51 PM, Viranch Mehta wrote: > Hi, > > I wanted to know if the Slider (from QML components) can be moved > using the mouse wheels. If not, is it possible to implement it atm? > Qt 4.x does not have a wheel event on MouseArea therefore it's not possible to fix Slider in Comp

Re: Review Request: Fix text colors on TabButton and ToolButton

2012-06-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105163/#review14504 --- Ship it! Ship It! - David Edmundson On June 6, 2012, 2:28

Re: Workspace Next Sprint Organization

2012-06-08 Thread David Edmundson
On Fri, Jun 8, 2012 at 6:39 PM, Kevin Ottens wrote: > On Friday 08 June 2012 18:22:51 Alex Fiestas wrote: >> On Friday, June 08, 2012 05:41:25 PM Kevin Ottens wrote: >> >  - A dozen white boxes (ideally roughly the cereal box size, can be >> >  slightly >> > >> > bigger >> >> I doub't we can find

Re: Travel to Sprint tomorrow

2012-06-10 Thread David Edmundson
I'm arriving at 5pm. Marco, we can meet if you want. Otherwise head on without me. I'll wear my KDE T-shirt to make identification easier. My phone number is +447593244223 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/li

Review Request: Fix value not being updated when dragging slider, also fix animation when using keys.

2012-06-13 Thread David Edmundson
battery plasmoid. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix the minimum size of some applets

2012-06-13 Thread David Edmundson
It gets set again. - David Edmundson On June 12, 2012, 8:43 p.m., Maarten De Meyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git

Re: Review Request: Fix the minimum size of some applets

2012-06-13 Thread David Edmundson
"deleted" the other patches. (if you just show revision 3, you'll only see this) applets/pastebin/pastebin.cpp <http://git.reviewboard.kde.org/r/105234/#comment11597> Where did you get the number 33 from? - David Edmundson On June 13, 2012, 3:42 p.m., M

Re: Quality Team: LCD weather station and calendar (in panel) are really broken

2012-06-14 Thread David Edmundson
ngs happens is because Plasma does not have an attitude of everyone doing reviews. Everyone will just follow the example set by everyone else. It's the perfect way of increasing communication between everyone so we all know what's going on. Especially once we've entered such a beta phas

Re: Quality Team: LCD weather station and calendar (in panel) are really broken

2012-06-14 Thread David Edmundson
On Thu, Jun 14, 2012 at 7:31 PM, Aaron J. Seigo wrote: > On Thursday, June 14, 2012 16:58:55 David Edmundson wrote: >> so much resistance. Reviews are slow, > > often they happen the same day, sometimes they don't. i would like them to be > faster as well. when i keep on

Re: No "remaining time" option in battery monitor?

2012-06-14 Thread David Edmundson
On Thu, Jun 14, 2012 at 11:54 PM, Viranch Mehta wrote: > Hi, > > I just noticed there is no option of "remaining time" in the latest stable > released > version of the c++ battery applet (4.8.4). Have we discarded it? I want to > know this > so I can know whether I should keep this in the qml vers

Re: Review Request: Make sure vertical slider's handle have the same shadow as the horizontal one

2012-06-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105269/#review14777 --- Ship it! Ship It! - David Edmundson On June 16, 2012, 12

Re: Review Request: Make sure the views don't get overscrolled when clicking the scrollbar arrows

2012-06-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105268/#review14778 --- Ship it! Ship It! - David Edmundson On June 15, 2012, 11

Review Request: Add a keyboard shortcut to stop the current activity

2012-06-16 Thread David Edmundson
) --- Pressed shortcut, tested current activity closed, and that I could not close the last activity. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Support for multiple batteries in battery monitor applet

2012-06-17 Thread David Edmundson
> On June 16, 2012, 6:40 p.m., Marco Martin wrote: > > i think the change is on the right path, but should wait for the unfreeze, > > since is not a "trivial" fix Given this patch is untested (due to Viranch having only one battery) and that we will have a lot of angry users complaining that t

Review Request: Use common plasma components Tooltip in battery monitor

2012-06-17 Thread David Edmundson
ma/generic/applets/batterymonitor/contents/ui/IconButton.qml d4454c6 plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab72a Diff: http://git.reviewboard.kde.org/r/105283/diff/ Testing --- Checked applet looked ok. Thanks, David

Re: blogs from the sprint?

2012-06-19 Thread David Edmundson
Other items from the sprint. Clarification on terminology. http://community.kde.org/Plasma/Terminology This is the list of processed tasks that we decided were important for moving workspaces forward. http://community.kde.org/Plasma/Workspace_Sprint/Kanban Some parts, such as the review of the P

Re: Review Request: Use common plasma components Tooltip in battery monitor

2012-06-20 Thread David Edmundson
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105283/#review14839 --- On June 17, 2012, 7:52 p.m., David Edmundson wrote: > > ---

Re: Team meeting today

2012-06-21 Thread David Edmundson
riate. If you really hate editing mediawiki tables (who doesn't ) email me directly with changes and I'll do it. After a week (end of June) I will fill any gaps as "unmaintained". List of components are based on bugzilla component entries. Feel free to add more here, but it proba

Re: Team meeting today

2012-06-21 Thread David Edmundson
Can I ask for some clarification on why my message now have to go through moderation? I'm sure that's new. As far as I'm aware I've been generally courteous and constructive despite all the arguing around. If no-one tells me what I've done wrong I can't improve. If it's an overall change on every

Re: Team meeting today

2012-06-21 Thread David Edmundson
On Thu, Jun 21, 2012 at 1:47 PM, Aaron J. Seigo wrote: > On Thursday, June 21, 2012 13:23:02 David Edmundson wrote: >> I made a similar form for Plasma is available here: >> http://community.kde.org/Plasma/Maintainership please fill-in as >> appropriate. > > there ar

Re: Review Request: DBus-interface for changing wallpapers

2012-06-22 Thread David Edmundson
en add ${KACTIVITIES_LIBRARY} to your target_link_libraries in CMakeLists.txt - David Edmundson On June 22, 2012, 2:07 a.m., Varun Herale wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.rev

Re: Plasma Bug Workflow BOF

2012-06-22 Thread David Edmundson
On Fri, Jun 22, 2012 at 3:49 PM, Myriam Schweingruber wrote: > Hi Mark, > > On Fri, Jun 22, 2012 at 4:26 PM, Mark wrote: >> On Fri, Jun 22, 2012 at 3:11 PM, Myriam Schweingruber wrote: >>> Hi Thijs, >>> >>> On Fri, Jun 22, 2012 at 10:22 AM, Thijs Heus >>> wrote: Hi Martin, >>> ... >>>

Re: Review Request: Add missing email addresses back into add widget tooltip.

2012-06-23 Thread David Edmundson
label links do nothing but emit a signal when clicked in the label add: onLinkActivated: { plasmoid.openUrl(link); } libs/plasmagenericshell/widgetsexplorer/plasmaappletitemmodel_p.h <http://git.reviewboard.kde.org/r/105312/#comment11836> Good spot! - David Edm

Re: Review Request: DBus-interface for changing wallpapers

2012-06-23 Thread David Edmundson
p/shell/plasmaapp.cpp <http://git.reviewboard.kde.org/r/105319/#comment11839> second setting of currentContainment->setWallpaper - David Edmundson On June 22, 2012, 2:36 p.m., Varun Herale wrote: > > --- > This is an aut

Re: Review Request: DBus-interface for changing wallpapers

2012-06-24 Thread David Edmundson
> On June 24, 2012, 1:41 a.m., David Edmundson wrote: > > I think you've overcomplicated this: > > > > Everything after currentContainment could be replaced with simply: > > > > --- > > currentContainment->setW

Re: Plasma applets inside QML applet

2012-06-24 Thread David Edmundson
On Sun, Jun 24, 2012 at 11:05 AM, Marco Martin wrote: > On Saturday 23 June 2012, Dmitry wrote: >> Hello! >> >> I'm developing an applet in QML. I need to load an external applet and >> to place it into my applet like  containment applet, like panel or >> system tray. But at the same time my apple

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/#review15058 --- Ship it! - David Edmundson On June 22, 2012, 10:04 p.m

Re: Review Request: fixed widget explorer or activity manager not closed when clicking desktop area above panel

2012-06-24 Thread David Edmundson
x27;ve processed everything the event queue (the 'later') so as I see this it does the same thing twice. If there is a reason, document it! - David Edmundson On June 24, 2012, 1:45 p.m., Reza Shah wrote: > > ---

Re: Review Request: DBus-interface for changing wallpapers

2012-06-24 Thread David Edmundson
don't ship it till after the feature freeze ends for 4.9. (unless someone else gives you permission) - David Edmundson On June 24, 2012, 3:47 p.m., Varun Herale wrote: > > --- > This is an automatically generated e-mail. To r

Re: Where I can find api documents of qml?

2012-06-27 Thread David Edmundson
On Wed, Jun 27, 2012 at 12:53 PM, qasdfgtyuiop wrote: > I want to insert some icon in my qml widget, and using javascript to > access calendar.  But I can not find the document related to this. > Where can I find a document of plasma qml? > > I have seen these pages but find nothing helpful, these

Re: Where I can find api documents of qml?

2012-06-27 Thread David Edmundson
On Wed, Jun 27, 2012 at 1:26 PM, David Edmundson wrote: > On Wed, Jun 27, 2012 at 12:53 PM, qasdfgtyuiop wrote: >> I want to insert some icon in my qml widget, and using javascript to >> access calendar.  But I can not find the document related to this. >> Where can I find

Re: Where I can find api documents of qml?

2012-06-28 Thread David Edmundson
On Thu, Jun 28, 2012 at 8:42 AM, qasdfgtyuiop wrote: > The problem has been solved.  Thank you. It's not really resolved the original problem of any missing docs. qasdfgtyuiop, if you encounter issues like this where you can't find the documentation and someone helps you please could you update

Re: Where I can find api documents of qml?

2012-06-28 Thread David Edmundson
On Thu, Jun 28, 2012 at 10:30 AM, gaoxiang wrote: > Ok, after I finish my program, I will look at the problem I met and write > something Awesome Thanks. > On Thursday 28 June 2012 10:09:19 David Edmundson wrote: >> On Thu, Jun 28, 2012 at 8:42 AM, qasdfgtyuiop > wrote: &g

Re: Re: Plasma Bug Workflow BOF

2012-06-28 Thread David Edmundson
On Mon, Jun 25, 2012 at 8:18 AM, Sebastian Kügler wrote: > On Friday, June 22, 2012 15:11:42 Myriam Schweingruber wrote: >> What needs to be understood is that all code can have bugs, that is >> only natural and nobody will deny that. But that also means that we >> should thrive to make the code b

Re: Review Request: Improve ProgressBar display

2012-08-15 Thread David Edmundson
/ProgressBar.qml <http://git.reviewboard.kde.org/r/105966/#comment13690> You've kept the trigger for width changing, but not height. That doesn't sound right. - David Edmundson On Aug. 10, 2012, 4:12 p.m., Aleix Po

Re: Back to basics

2012-08-17 Thread David Edmundson
Some of the stuff discussed here overlaps with the "Extra Mile" project being run by Aurelien, myself and KDE Quality team. The idea is we make a big list of very minor small annoying bugs, and encourage people to help file these, and in the meantime we blog trying to encourage developers not to j

[RFC] Merging LightDM into KDE Workspaces

2012-08-20 Thread David Edmundson
harpley.org.uk/blog/lightdm-0_3 , http://http://www.sharpley.org.uk/blog/lightdm-0_2, http://www.sharpley.org.uk/lightdm-google-authentication, http://www.sharpley.org.uk/blog/an-update-on-lightdm-kde [4] http://static.davidedmundson.co.uk/lightdm_design_rationale.html Regards David Edmundson __

Re: [RFC] Merging LightDM into KDE Workspaces

2012-08-22 Thread David Edmundson
Sure makes sense. Forwarded. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: [RFC] Merging LightDM into KDE Workspaces

2012-08-22 Thread David Edmundson
On Wed, Aug 22, 2012 at 2:06 PM, Daniel Nicoletti wrote: > Though I have nothing against this move, I'd like to ask a dumb > question (well maybe not that dumb): > Since lightDM-kde greeter is (AFAIK) pretty much just an interface > for lightDM, and since I myself find the user interface much more

Re: Review Request: Activities KCM

2012-08-22 Thread David Edmundson
al) src/workspace/settings/BlacklistedApplicationsModel.cpp <http://git.reviewboard.kde.org/r/106130/#comment14120> const & src/workspace/settings/CMakeLists.txt <http://git.reviewboard.kde.org/r/106130/#comment14121> capital letter in class

Re: Review Request: Weather Forecast QML port

2012-08-26 Thread David Edmundson
Updated from dataUpdated. applets/weather/weatherapplet.h <http://git.reviewboard.kde.org/r/106225/#comment14300> You don't need this. In your QML you can call plasmoid.openUrl() - David Edmundson On Aug. 26, 2012, 7:59 p.m., Luis Gabriel Lima wrote: > >

Re: Review Request: Dictionary Runner

2012-08-28 Thread David Edmundson
re perhaps) currently if a translator translates it differently in one of the 3 places, it breaks. - David Edmundson On Aug. 18, 2012, 3:57 a.m., Jason A. Donenfeld wrote: > > --- > This is an automatical

Re: Review Request: Weather Forecast QML port

2012-08-29 Thread David Edmundson
> On Aug. 26, 2012, 9:36 p.m., David Edmundson wrote: > > applets/weather/package/contents/ui/FiveDaysView.qml, line 70 > > <http://git.reviewboard.kde.org/r/106225/diff/1/?file=81340#file81340line70> > > > > you don't need this.. just use > >

Re: Ordering items in QML Column

2012-09-07 Thread David Edmundson
On Fri, Sep 7, 2012 at 4:36 PM, Michał 'rysiek' Woźniak wrote: > Hi there, > > Is there a way to re-order items in QML Column element? I can, of > course, remove all items and add them in a new order, but that seems a > very inelegant solution. > > In the docs there is no info on any ordering meth

Re: Review Request: Weather Forecast QML port

2012-09-07 Thread David Edmundson
> On Aug. 26, 2012, 9:36 p.m., David Edmundson wrote: > > applets/weather/package/contents/ui/Notice.qml, line 27 > > <http://git.reviewboard.kde.org/r/106225/diff/1/?file=81341#file81341line27> > > > > Unless there's a good reason, use PlasmaComponents.

Re: Review Request: Weather Forecast QML port

2012-09-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18666 --- Ship it! Fine with me. - David Edmundson On Aug. 30, 2012

Re: Changes to Plasma Weather - Git revision 5a09cd815edd7723800c0ba43a8be9f67d28e011

2012-09-11 Thread David Edmundson
On Tue, Sep 11, 2012 at 1:05 PM, Shawn Starr wrote: > On Tuesday, September 11, 2012 08:30:50 AM Luís Gabriel wrote: >> You can see some screenshots here: >> https://git.reviewboard.kde.org/r/106225/ >> There was no changes in the UI, it was just rewritten in QML. >> >> Cheers, >> -- >> Luís Gabri

Re: Poll - Rethinking "battery remaining time" option

2012-09-12 Thread David Edmundson
On Wed, Sep 12, 2012 at 1:41 PM, Sebastian Kügler wrote: > On Wednesday, September 12, 2012 14:30:08 Marco Martin wrote: >> I'm for keeping the config option as "least possible damage", i think it >> has been discussed to death (including why user polls for features don't >> work) > > +1 > > I do

Re: Re: Status of QML Porting

2012-09-15 Thread David Edmundson
Alex, I noticed you just assigned timer to yourself. I remember reading that David Bettio had updating that (and Calendar) as his GSOC project: http://blog.uninstall.it/2012/06/24/my-gsoc-project-port-plasma-calendar-and-other-widgets-to-qml/ I think he passed GSOC so both of those should be some

Re: Re: Status of QML Porting

2012-09-15 Thread David Edmundson
Checking against what I have on my system, that list is also missing: bball battery binary clock blackboard bubbemon calculator charselect comic (I stopped at this point) Is this list a deliberate subset? If so what is the criteria? and I'll add anything missing.

Re: Status of QML Porting

2012-09-16 Thread David Edmundson
On Sat, Sep 15, 2012 at 11:16 AM, Marco Martin wrote: > On Saturday 15 September 2012, David Edmundson wrote: >> Checking against what I have on my system, that list is also missing: >> >> bball >> battery >> binary clock >> blackboard >> bubbemon >

Review Request: smooth scroll by mousewheel in SystemSettings

2012-09-21 Thread David Edmundson
/icons/CategorizedView.h f2b064f systemsettings/icons/CategorizedView.cpp 1a2a1d9 Diff: http://git.reviewboard.kde.org/r/106523/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request: smooth scroll by mousewheel in SystemSettings

2012-09-22 Thread David Edmundson
ed e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106523/#review19265 ------- On Sept. 21, 2012, 11:26 a.m., David Edmundson wrote: > > --- > This is an automatically

Re: Review Request: reuse knewstuff's itemsview class to provide smooth scrolling in wallpaper configuration screen

2012-09-22 Thread David Edmundson
iff. Also if you work round a bug you should explicitly state what bug you are working around. That way people know when it is ok to remove it. - David Edmundson On Sept. 23, 2012, 12:37 a.m., Reza Shah wrote: > > --- > This

Re: Fit Grid elements in Item

2012-09-24 Thread David Edmundson
On Mon, Sep 24, 2012 at 4:05 AM, Luiz Romário Santana Rios wrote: > Hello. > > I'm trying to port the Calculator plasmoid to QML, but I'm stuck > trying to make the buttons fit their parent item. I'm doing this: > > Item { > anchors { > top: resultArea.bottom > bottom: parent.b

Re: Fit Grid elements in Item

2012-09-24 Thread David Edmundson
On Mon, Sep 24, 2012 at 1:16 PM, Sebastian Kügler wrote: > On Monday, September 24, 2012 11:45:22 David Edmundson wrote: >> Although you've told the grid to anchor on the right hand side, you've >> also (implicitly) told it it needs to be 4 buttons wide, and each >&g

Re: Behavior on systray icon clicking

2012-09-25 Thread David Edmundson
Back to the topic of the KTp plasmoid. The original goals of that plasmoid was not to be a silly shortcut to the contact list anyway. It's purpose /was/ to provide access to change your online-ness. I'd like to see it go back to what it was designed to do, rather than it's current state and the d

Re: share-like-connect in 4.10

2012-10-03 Thread David Edmundson
On Wed, Oct 3, 2012 at 4:22 PM, Marco Martin wrote: > On Wednesday 03 October 2012, Alex Fiestas wrote: >> On Wednesday 03 October 2012 13:49:28 Marco Martin wrote: >> > > 4. more plugins >> > >> > yep, those are the two most relevant points (many plugins btw will depend >> > from the web accounts

Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

2012-10-03 Thread David Edmundson
6717/diff/ Testing --- Edited Widget gallery to have "width: minimumWidth" on a button. It looked ok. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: share-like-connect in 4.10

2012-10-03 Thread David Edmundson
On Wed, Oct 3, 2012 at 11:25 PM, Aaron J. Seigo wrote: > On Wednesday, October 3, 2012 19:24:56 David Edmundson wrote: >> On Wed, Oct 3, 2012 at 4:22 PM, Marco Martin wrote: >> - blog about it > > already done. several times. we need to do it more. > >> - make

Re: Re: un-NIH-ing accounts?

2012-10-07 Thread David Edmundson
On Mon, Oct 8, 2012 at 1:50 AM, Alex Fiestas wrote: > On Monday 08 October 2012 01:46:40 Aaron J. Seigo wrote: >> On Sunday, October 7, 2012 23:10:47 Mark wrote: >> > This page has a bit more info then the google code link (and the >> > packages): >> > http://gitorious.org/accounts-sso/pages/Home

Re: Review Request: Translate strings in Global Keyboard Shortcuts component KDE Keyboard Layout Switcher

2012-10-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106424/#review20131 --- Ship it! Ship It! - David Edmundson On Sept. 11, 2012, 1

Re: Review Request: miscelaneous things for kdelibs/plasma

2012-10-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106782/#review20150 --- Ship it! Looks good to me. - David Edmundson On Oct. 10

Review Request: Fix padding to the left and right of text in a textField

2012-10-11 Thread David Edmundson
-- Before http://git.reviewboard.kde.org/r/106797/s/766/ After http://git.reviewboard.kde.org/r/106797/s/767/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix Inconsistencies and Bugs in Activity Bar's Size Hinting

2012-10-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106978/#review20642 --- There does not seem to be a diff attached. - David Edmundson

Re: slc repo as dependency

2012-10-23 Thread David Edmundson
It would need to be moved from playground if kde-workspace was to depend on it. The procedure I've had to go through is: - open a sysadmin request to move repo to kdereview stating you want to move to review, and the intended final destination - post to kde-devel to inform people about the move,

Re: kickoff qml

2012-10-23 Thread David Edmundson
On Mon, Oct 22, 2012 at 10:16 AM, Marco Martin wrote: > Hi all, > one thing i would like to have merged for 4.10 is the qml port of kickoff. > i have been looking at it past few days, and it seems to have most of the > features, even tough is still quite rough, i'm not 100% sure it may be ready >

Re: kickoff qml

2012-10-24 Thread David Edmundson
Using bugzilla to track something not in master is not a good idea. It makes it impossible to identify what bugs are actually present in the product being shipped. Which is why I asked :) David ___ Plasma-devel mailing list Plasma-devel@kde.org https://

Review Request: Kickoff-qml fixes

2012-10-24 Thread David Edmundson
6e972a3510 plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 9d468b2e596410eae18aba357bd6307b70758e33 Diff: http://git.reviewboard.kde.org/r/107026/diff/ Testing --- Screenshots --- After http://git.reviewboard.kde.org/r/107026/s/799/ Than

Re: Review Request: Kickoff-qml fixes

2012-10-24 Thread David Edmundson
enerated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/#review20823 --- On Oct. 24, 2012, 6:20 p.m., David Edmundson wrote: > > --- > This is an automati

Re: Review Request: Kickoff-qml fixes

2012-10-24 Thread David Edmundson
> On Oct. 24, 2012, 9:16 p.m., Sebastian Kügler wrote: > > plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml, line 109 > > <http://git.reviewboard.kde.org/r/107026/diff/1/?file=92249#file92249line109> > > > > Why remove this fade in anim

Re: Review Request: Fix bold text in battery-monitor tooltip

2012-11-02 Thread David Edmundson
Ship it from me too (with Sebas's comment fixed of course) - David Edmundson On Nov. 1, 2012, 10:26 p.m., Michele Gastaldo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Review Request: Fix bold text in battery-monitor tooltip

2012-11-04 Thread David Edmundson
sh on your behalf. - David Edmundson On Nov. 3, 2012, 5:23 p.m., Michele Gastaldo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread David Edmundson
on if (content.value("Mime Type").toString() == "text/x-html") should be == QLatin1String("text/x-html"); (this is in many places) -- David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Release Testing for 4.10

2012-11-21 Thread David Edmundson
As you may know the KDE Quality team was set up with the aim of conducting organised testing of KDE just before a release. One of the things we do is to have a specific targeted lists of things to check. This will be from a team of people who have been "trained" (forced to read a wiki page) on how

Re: Switch and Checkbox items

2012-12-14 Thread David Edmundson
Relevant bug report to the discussion: https://bugs.kde.org/show_bug.cgi?id=302067 I am in favour of any of the proposed solutions. I think even if we went for option 2, it still makes a lot of sense to change the existing code for desktop components, just so it's easier to read. This also allows

Re: RSS Launcher plasmoid

2012-12-18 Thread David Edmundson
On Tue, Dec 18, 2012 at 4:33 PM, Lionel Chauvin wrote: > Hi, > > I wrote another RSS plasmoid based on the qml "news" plasmoid. > > Here a screenshot: http://wstaw.org/m/2012/12/18/rss-launcher.png > The plasmoid can be downloaded from: > http://megabigbug.dyndns.org/rss-launcher.plasmoid > > Thi

Re: Review Request: Expose default Plasma theme to QML based KSplash

2012-12-19 Thread David Edmundson
I guess it never got anywhere. I have a copy of it. If Nuno doesn't reply to my emails, I'll post it to RB myself. Description --- This patch modifies KSplashQML allowing it to exposes the default Plasma theme to QML splash screens. The idea was taken from the work done by David Ed

Re: KDEREVIEW: share like connect and plasmate

2013-01-06 Thread David Edmundson
, and need to know how to use it. Especially when the return type of executeAction is so complicated. Also I personally don't think this is release ready until error reporting is included, or at least has a solid plan of action. David Edmundson > we have it working properly on desktop as w

Re: some thoughts on screensavers in Plasma Workspaces 2

2013-01-13 Thread David Edmundson
On Sun, Jan 13, 2013 at 7:25 PM, Martin Graesslin wrote: > On Sunday 13 January 2013 19:48:48 Aaron J. Seigo wrote: >> hi .. >> >> side note 1: i've taken to refering to "future releases of Plasma Worskpaces >> that will use Frameworks 5 with libplasma2, Qt 5.1+ and QtQuick2" as Plasma >> Workspac

Re: Thoughts about a better Quality Management process for Plasma

2013-01-14 Thread David Edmundson
all the work, _all_ the active devs help out, which is why it works so well. We got to this state because lead devs, including the ones before me, actively participate and encourage all the developers including new guys to do the same. Most devs are quickly given a components[1] that they ca

Re: Thoughts about a better Quality Management process for Plasma

2013-01-17 Thread David Edmundson
On Sun, Jan 13, 2013 at 2:50 PM, Martin Gräßlin wrote: > Hi all, > > *warning* long mail! Please take time reading it. Given how long I am now > writing on it: schedule half an hour or so ;-) > > I will try to formulate some thoughts on what I think might help to improve > the Quality Management i

Review Request 108935: Add a DBus method to plasma-desktop to provide support information for easier bug triaging

2013-02-13 Thread David Edmundson
02/13/plasma_support_information.txt Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Thoughts about a better Quality Management process for Plasma

2013-02-18 Thread David Edmundson
On Thu, Jan 17, 2013 at 11:51 AM, Martin Gräßlin wrote: > On Thursday 17 January 2013 11:22:04 David Edmundson wrote: > > This morning I spent an hour going through the list of "general", I > > found a few problems. > > > > There were several bugs I l

Re: Review Request 109124: qml port currentappcontrol

2013-02-24 Thread David Edmundson
ructure. Make the replacement below. - $XGETTEXT *.cpp -o $podir/plasma_applet_currentappcontrol.pot + $XGETTEXT `find . -name \*.qml` -o $podir/plasma_applet_currentappcontrol.pot - David Edmundson On Feb. 24, 2013, 11:10 a.m., Greg T wrote: > > -

Re: KDED module and DBus signals

2013-03-08 Thread David Edmundson
On Fri, Mar 8, 2013 at 5:33 PM, Michail Vourlakos wrote: > Yes, kded-appmenu do this: >> >> $ qdbus org.kde.kded /modules/appmenu|grep signal|wc -l >> 6 >> >> regards, >> > Perfect that worked... > > Do you know what is the best way to debug a KDEDModule? > > You can use : http://quickgit.kde.org/

Re: Review Request 109492: Allow Rich Text in QML notifications plasmoid

2013-03-17 Thread David Edmundson
ted notifications which were known to trigger the bug. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [Nepomuk] Nepomukcontroller rewritten in QML

2013-03-19 Thread David Edmundson
On Tue, Mar 19, 2013 at 6:34 PM, Jörg Ehrichs wrote: > 2013/3/19 Ignacio Serantes : >> Hi, >> >> Installed and is an amazing improvement. Only for contribute with minor >> thing: >> >> A method to call a manual backup or a restore. >> A start/stop/restart nepomuk method. >> > > Start/Stop for any

Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

2013-03-21 Thread David Edmundson
would be incredibly useful. Given the proximity to the deadline and your testing I can't see this breaking anything, so ship it if you're confident with it. - David Edmundson On March 21, 2013, 5:37 p.m., Aleix Pol Gonzalez wrote: > >

Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

2013-03-22 Thread David Edmundson
> On March 21, 2013, 6:54 p.m., David Edmundson wrote: > > I'm very much against shipping any patches if we don't know why it fixes > > it. From what I can see from declarative/declarativeitemcontainer.cpp it > > just sets the minimumWidth to it... which I

Re: [Nepomuk] Nepomukcontroller rewritten in QML

2013-03-27 Thread David Edmundson
Awesome, Is it ready to give it another review? David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [Nepomuk] Nepomukcontroller rewritten in QML

2013-03-27 Thread David Edmundson
Nicely done, a few minor comments still, but a "ship it!" from me. Applet: Missing Messages.sh file This is needed to tell the translation mechanism to extract the messages in the i18n functions Copy this from another existing applet. Make sure you copy a version from an applet that already u

  1   2   3   4   5   6   7   8   9   10   >