Re: Drop kwin's fullscreen hack

2009-08-30 Thread Christoph Feck
Hm, if it is full screen, but applications should appear above it, wouldn't that qualify for a "desktop" window type? And are you saying the netbook shell does not use netwm? Am Sunday 30 August 2009 19:06:34 schrieb Marco Martin: > On 8/30/09, Martin Gräßlin wrote: > > Attached is a patch to r

Re: Drop kwin's fullscreen hack

2009-08-30 Thread Christoph Feck
Am Sunday 30 August 2009 22:27:59 schrieb Marco Martin: > On 8/30/09, Christoph Feck wrote: > > And are you saying the netbook shell does not use netwm? > > it does, what would be broken are applications that does not use it, > but do they still exist and are relevant? Then I

Please review/report usage of standard Font and Icon roles in Plasma

2009-09-01 Thread Christoph Feck
ld like to know if Plasma: - still "uses" (respects) those choices and intends to do so in the future, - does not respect those choices, - already has or intends to provide its own configuration. If they are no longer needed, I would like to remove them

Review Request: Use window() as KNotificationItem::associatedWidget() to avoid native widgets

2009-09-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1707/ --- Review request for kdelibs and Plasma. Summary --- Use the window() of the

Re: Review Request: Use window() as KNotificationItem::associatedWidget() to avoid native widgets

2009-09-24 Thread Christoph Feck
eview2457 --- On 2009-09-24 03:20:31, Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1707/ > -

Re: Review Request: Use window() as KNotificationItem::associatedWidget() to avoid native widgets

2009-10-07 Thread Christoph Feck
ve widgets internally. I have yet to find out why. - Christoph --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1707/#review2465 -----

Re: Grouping Desktop moved to kdereview

2010-07-23 Thread Christoph Feck
On Friday 23 July 2010 00:51:49 Giulio Camuffo wrote: > Probably the best target for this is kdeplasma-addons, event if I don't > hide that I'd like to see it in kdebase. :) I am not able to build it outside kdebase because it uses kephal. /local/svn/kde/trunk/kdereview/plasma/containments/groupi

Re: When should a bug be considered as a regression or a release_blocker?

2012-06-20 Thread Christoph Feck
it is a release blocker) (CCing kde-testing) Christoph Feck (kdepepo) KDE Quality Team ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Please, if you port something to QML, make it at the very least exactly the same as the C++ version!

2012-07-08 Thread Christoph Feck
he QML rewrite in the current form. And if you would follow the discussion in the review request, you would notice that it wasn't "just" accepted. -- Christoph Feck http://kdepepo.wordpress.com/ KDE Quality Team ___ Plasma-devel mailin

Re: Review Request: Fix misplaced panel (especially when more than one monitor is involved)

2012-07-24 Thread Christoph Feck
and bug 281029 are likely duplicates. Cannot comment if the patch is correct, though. - Christoph Feck On July 16, 2012, 4:34 p.m., Rolf Eike Beer wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request: change default config of taskmanager

2012-07-26 Thread Christoph Feck
in this request? Branch is actually in freeze, the bug fix says "Fixed in 4.9.1", but the change will be in 4.9.0 unless it is reverted in branch. Additionally, I thought plasma uses kdelibs coding style. If that's the case, there need to be braces even in single-statement if/els

Re: Review Request: Adding notify signals to FrameSvgItem

2012-08-12 Thread Christoph Feck
the object changes the value _itself_ (e.g. in response to user interaction), as opposed to where the application changed the value. In that light, an imagePathChanged() would not make sense, because the path cannot change, except if the application changes it. What am I missing? - Christoph

Re: Review Request: Make autohide panel do not intercept events in fullscreen app

2012-08-21 Thread Christoph Feck
a related note, I also find it odd that the auto-hide panel does not go above "Keep Above Others" windows, but that may be intended. An auto-hide panel is a temporary window like a menu, so it should not be covered by anything except other such menus. - Christoph Feck On Aug.

Re: Review Request: Make autohide panel do not intercept events in fullscreen app

2012-08-21 Thread Christoph Feck
> On Aug. 21, 2012, 10:24 a.m., Christoph Feck wrote: > > If this "feature" is going to be implemented, it should be configurable. If > > you are only using a mouse (or stylus on a Tablet PC), then you would have > > no way to reach the panel in full-screen mod

Re: Review Request: Adding notify signals to FrameSvgItem

2012-08-21 Thread Christoph Feck
> On Aug. 12, 2012, 10:41 a.m., Christoph Feck wrote: > > As I understand it, the notify system is for attributes, where the object > > changes the value _itself_ (e.g. in response to user interaction), as > > opposed to where the application changed the value. >

Re: Activities KCM

2012-08-23 Thread Christoph Feck
ide user interface elements, but in this case hiding was the least evil. So definitely "disabling" in your case. -- Christoph Feck http://kdepepo.wordpress.com/ KDE Quality Team ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: How Can I change wallpaper from CLI?

2012-09-05 Thread Christoph Feck
On Wednesday 05 September 2012 20:10:53 Alexander Neundorf wrote: > In KDE3 it was possible to set the wallpaper via dcop in kdesktop. > So we can't do this anymore ? It's still being worked on, see bug 217950 and linked review request. ___ Plasma-devel

Review Request: Fix wrong selection background rendering (visible e.g. with Plastique)

2012-09-23 Thread Christoph Feck
, Plastique, Skulpture. Thanks, Christoph Feck ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Display Configuration KCM design review

2012-10-04 Thread Christoph Feck
moving it 3 pixels to the left > won't cause anything. Having two monitors placed side-by-side, you want to be able to correctly vertically align them. There could be an "Advanced" mode, where you can set pixel positions, refresh rates, etc. Christoph Feck (kdepepo) KDE Quality

Re: Display Configuration KCM design review

2012-10-04 Thread Christoph Feck
On Thursday 04 October 2012 14:45:14 Aaron J. Seigo wrote: > On Thursday, October 4, 2012 13:38:06 Christoph Feck wrote: > > Having two monitors placed side-by-side, you want to be able > > to correctly vertically align them. > > can you define "correctly vertical

Re: Display Configuration KCM design review

2012-10-04 Thread Christoph Feck
is possible to move them freely. Hm, thinking about it, maybe it should be possible to move them freely in one direction, but keeping them glued together in the orthogonal direction. So you could freely move one of two screens placed side by side up and down, without introducing a gap or an

Re: using device targets in qml plasmoids

2012-10-24 Thread Christoph Feck
multiple buttons), but still requires an on-screen keyboard as a text input panel. Christoph Feck (kdepepo) KDE Quality Team ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix battery applet screen power management

2012-11-01 Thread Christoph Feck
> On Nov. 1, 2012, 3:18 p.m., Commit Hook wrote: > > This review has been submitted with commit > > e1bf8805b3d0c8ddf22805f334faec8bd678742e by Oliver Henshaw to branch > > push/4.9. "push/4.9" is not a valid branch name for kde-workspace. If these commits should be part of KDE 4.9.3 release,

Re: Bug component for lockscreen?

2012-11-24 Thread Christoph Feck
about the old X screen savers. > > On the same topic: with ksmserver/ui I assume the lock-out screen > is meant, which should probably have Lamarque as default assignee? > > Cheers > Martin > > [1] https://bugs.kde.org/show_bug.cgi?id=310611 Product "

Re: Review Request: Show album art in krunner results.

2013-01-11 Thread Christoph Feck
icon engine somewhere in the contacts runner, which uses passes QImage data around. QImage can be used outside the UI thread. - Christoph Feck On Jan. 11, 2013, 7:01 a.m., Emil Sedgh wrote: > > --- > This is an automatically generat

Re: reflecting on 4.10

2013-01-11 Thread Christoph Feck
o mature, and this direction should not change for 4.11. Christoph Feck (kdepepo) KDE Quality Team ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108662: Fix build with OAuth present and QJson missing

2013-02-25 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108662/#review28087 --- Ship it! Ship It! - Christoph Feck On Feb. 25, 2013, 1:45

Re: [RFC] Disable DrKonqi for KWin in stable releases

2013-04-30 Thread Christoph Feck
act reason for the crashes only appearing on Ubuntu? Are the Ubuntu developers aware of the crashes? They could provide patches through their update repositories. Christoph Feck (kdepepo) KDE Quality Team ___ Plasma-devel mailing list Plasma-devel@kd

Re: Review Request 111087: widget-taskbar: vertical text layout

2013-06-18 Thread Christoph Feck
alignment should be done using the font's natural box (fm.height()), not the bounding boxes of certain characters. - Christoph Feck On June 18, 2013, 11:44 a.m., Greg T wrote: > > --- > This is an automatically generated e-

Re: Bounding rect question

2013-07-08 Thread Christoph Feck
not a QSize, so the function somehow needs to know the position. Additionally, you can use 'flags' to request centering, and thus it needs to know the box where to center in. -- Christoph Feck http://kdepepo.wordpress.com/ KDE Quality Team ___

Review Request 111621: Increase size of label pixmap to account for margins and shadows

2013-07-20 Thread Christoph Feck
?id=314879 Diffs - plasma/desktop/applets/tasks/support/textlabel.cpp 9fbc12d Diff: http://git.reviewboard.kde.org/r/111621/diff/ Testing --- Thanks, Christoph Feck ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Questions about models in NotificationDelegate.qml

2013-08-27 Thread Christoph Feck
r item has been added or removed in the meantime, is the index updated accordingly? Or worse, if the item has been removed for other reasons, is the timer/animation automatically cancelled so that remove() is not called again? Christoph Fec

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Christoph Feck
> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: > > I respectfully disagree with the change. > > > > If I understand the descripion right, the only thing that matters for > > QtQuick is to change the default returned value (if all else fail) from 1 > > to FRAME_FRAMEWIDTH. Correct

Re: Questions about models in NotificationDelegate.qml

2013-09-03 Thread Christoph Feck
On Tuesday 27 August 2013 13:57:00 Christoph Feck wrote: > Hi, > > Looking at the NotificationDelegate.qml file, I see several lines > that say "notificationsModel.remove(index)", fired from timers, > running animations etc. > > Do QML models automatically make su

Re: Questions about models in NotificationDelegate.qml

2013-09-04 Thread Christoph Feck
On Wednesday 04 September 2013 00:17:37 Marco Martin wrote: > On Tuesday 27 August 2013, Christoph Feck wrote: > > Hi, > > > > Looking at the NotificationDelegate.qml file, I see several lines > > that say "notificationsModel.remove(index)", fired fr

Re: kde-workspace master becomes Qt5-based

2013-10-01 Thread Christoph Feck
On Tuesday 01 October 2013 15:25:27 Sebastian Kügler wrote: > On Tuesday, October 01, 2013 15:11:51 Stephen Kelly wrote: > > > We're planning to merge the frameworks-scratch branch of > > > kde-workspace into master next Monday. > > > > I tried building the branch. It requires qimageblitz, which I

Review Request 113368: Fix crash with slide show wallpaper

2013-10-21 Thread Christoph Feck
://git.reviewboard.kde.org/r/113368/diff/ Testing --- Thanks, Christoph Feck ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113368: Fix crash with slide show wallpaper

2013-10-21 Thread Christoph Feck
. Diffs - plasma/generic/wallpapers/image/image.cpp 15e0e3f Diff: http://git.reviewboard.kde.org/r/113368/diff/ Testing --- Thanks, Christoph Feck ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Christoph Feck
4.11.3. Someone else must approve. - Christoph Feck On Oct. 27, 2013, 10:36 a.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Christoph Feck
> On Oct. 27, 2013, 11:05 a.m., Christoph Feck wrote: > > Ah, that makes sense, thanks for your investigation! > > > > What could be done to improve it, is to let the timer fire again sometimes > > later, until the item could actually be removed. I am not sure, thoug

Review Request 113504: Fix krunner calculator letter check

2013-10-29 Thread Christoph Feck
pport functions in the case the user had omitted the '=' Diffs - plasma/generic/runners/calculator/calculatorrunner.cpp 0d52301 Diff: http://git.reviewboard.kde.org/r/113504/diff/ Testing --- Thanks, Christoph Feck ___ Pl

Re: Review Request 113504: Fix krunner calculator letter check

2013-10-30 Thread Christoph Feck
7;=', restoring 4.10 behavior. If I understand the letter check correctly, it is very hard to support functions in the case the user had omitted the '=' Diffs - plasma/generic/runners/calculator/calculatorrunner.cpp 0d52301 Diff: http://git.reviewboard.kde.org/r/113504

Review Request 113535: Fix build with latest ThreadWeaver

2013-11-01 Thread Christoph Feck
e in the wrong place. Diffs - src/plasma/runnermanager.cpp ee4851f Diff: http://git.reviewboard.kde.org/r/113535/diff/ Testing --- Compiles, no further testing. Thanks, Christoph Feck ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 113535: Fix build with latest ThreadWeaver

2013-11-01 Thread Christoph Feck
, no further testing. Thanks, Christoph Feck ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113535: Fix build with latest ThreadWeaver

2013-11-01 Thread Christoph Feck
, no further testing. Thanks, Christoph Feck ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.

2013-11-06 Thread Christoph Feck
> On Nov. 7, 2013, 12:19 a.m., Teemu Rytilahti wrote: > > I'm not actually sure whether is okay to force focus after any key is being > > released... Bug 319935 is probably the same issue, and also contains a patch at comment #1 for the "onReleased" function, so it seems there is no other way

Re: Moving KScreen and libkscreen to extragear

2013-11-13 Thread Christoph Feck
y it (including Plasma-NM components, etc.). Christoph Feck (kdepepo) KDE Quality Team ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-13 Thread Christoph Feck
> On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch > > frameworks. Locally, I get this error: AUTOMOC: error: process for /local/build/kf5/runtime/ktimezoned/ktimezoned.moc

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-15 Thread Christoph Feck
> On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch > > frameworks. > > Christoph Feck wrote: > Locally, I get this error: >

Re: Next Plasma bug day or bug week(?)

2013-11-16 Thread Christoph Feck
Additionally, do I understand you right, that Plasma 2 is in a state for bug triagers to test it? I know there is progress, but I am not sure we are there yet. -- Christoph Feck http://kdepepo.wordpress.com/ KDE Quality Team ___ Plasma-devel mailing l

Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.

2013-11-18 Thread Christoph Feck
> On Nov. 7, 2013, 12:19 a.m., Teemu Rytilahti wrote: > > I'm not actually sure whether is okay to force focus after any key is being > > released... > > Christoph Feck wrote: > Bug 319935 is probably the same issue, and also contains a patch at > comment

Re: Review Request 113971: improve screenlocker multiscreen handling

2013-11-20 Thread Christoph Feck
code. - Christoph Feck On Nov. 20, 2013, 4:52 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Review Request 114059: [Pager] Avoid crashes when no windows

2013-11-23 Thread Christoph Feck
the first place. Diffs - plasma/desktop/applets/pager/model.cpp 4424e3c plasma/desktop/applets/pager/pager.cpp eb8c63c Diff: http://git.reviewboard.kde.org/r/114059/diff/ Testing --- Thanks, Christoph Feck ___ Plasma-devel mailing

Re: Review Request 114059: [Pager] Avoid crashes when no windows

2013-11-23 Thread Christoph Feck
, Christoph Feck ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114059: [Pager] Avoid crashes when no windows

2013-11-23 Thread Christoph Feck
://git.reviewboard.kde.org/r/114059/#review44289 --- On Nov. 24, 2013, 12:02 a.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 114059: [Pager] Avoid crashes when no windows

2013-11-26 Thread Christoph Feck
--- Thanks, Christoph Feck ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114059: [Pager] Avoid crashes when no windows

2013-11-26 Thread Christoph Feck
--- Thanks, Christoph Feck ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.

2013-11-26 Thread Christoph Feck
> On Nov. 7, 2013, 12:19 a.m., Teemu Rytilahti wrote: > > I'm not actually sure whether is okay to force focus after any key is being > > released... > > Christoph Feck wrote: > Bug 319935 is probably the same issue, and also contains a patch at > comment

Setting a Notification's urgency

2013-11-26 Thread Christoph Feck
th the QML notifications rewrite, and if yes, how do applications set this urgency? For the reference, I would like to resolve kdialog bug 328099 by allowing the user to optionally specify such an urgency attribute. The code in kdialog uses a D-Bus call to create the notification. Thanks, Christoph Feck (kd

Fails to build against Qt 5.3 dev snapshot

2013-11-28 Thread Christoph Feck
/packageurlinterceptor.cpp:20:0: /local/git/playground/libs/plasma- framework/src/plasmaquick/packageurlinterceptor.h:23:38: fatal error: QQmlAbstractUrlInterceptor: No such file or directory Christoph Feck (kdepepo) ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Fails to build against Qt 5.3 dev snapshot

2013-11-28 Thread Christoph Feck
On Friday 29 November 2013 02:53:22 Christoph Feck wrote: > Hi, > > compiling plasma-framework I get this error. Might be caused by a > removed include or symbol in Qt. If this was a public symbol, > please report it to https://bugreports.qt-project.org/ > > In file inc

Re: Digital Clock widget

2013-12-11 Thread Christoph Feck
uot;Select" column) on the same tab. See also bug 300094. Additionally, please do not use this list to report bugs. We use a bug tracker for a reason. Christoph Feck (kdepepo) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 114746: [calculator runner] Replace regexp with explicit character category check

2013-12-30 Thread Christoph Feck
c/runners/calculator/calculatorrunner.cpp 8d00449 Diff: https://git.reviewboard.kde.org/r/114746/diff/ Testing --- Thanks, Christoph Feck ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114746: [calculator runner] Replace regexp with explicit character category check

2013-12-30 Thread Christoph Feck
-- plasma/generic/runners/calculator/calculatorrunner.h 3a031e0 plasma/generic/runners/calculator/calculatorrunner.cpp 8d00449 Diff: https://git.reviewboard.kde.org/r/114746/diff/ Testing --- Thanks, Christoph Feck ___ Plasma-devel maili

Re: Review Request 114746: [calculator runner] Replace regexp with explicit character category check

2014-01-01 Thread Christoph Feck
or whatever. Diffs - plasma/generic/runners/calculator/calculatorrunner.h 3a031e0 plasma/generic/runners/calculator/calculatorrunner.cpp 8d00449 Diff: https://git.reviewboard.kde.org/r/114746/diff/ Testing --- Thanks, Christoph Feck ___ Plasm

Re: Review Request 112727: Shrink (fancy) unhide trigger when entered while FS window is active

2014-02-09 Thread Christoph Feck
> On Sept. 24, 2013, 10:31 a.m., Martin Gräßlin wrote: > > > no idea whether that's acceptable > > shouldn't be much of an issue. KWindowSystem is emitting a signal, isn't > > it? activeWindowChanged() > > Thomas Lübking wrote: > There's been concerns about waking up when windows were moved

Re: Review Request 115409: Workaround battery detection at runtime

2014-03-07 Thread Christoph Feck
7 is still fixed. - Christoph Feck On Feb. 15, 2014, 10:19 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.

Re: Review Request 115409: Workaround battery detection at runtime

2014-03-07 Thread Christoph Feck
> On March 7, 2014, 12:19 p.m., Christoph Feck wrote: > > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line > > 75 > > <https://git.reviewboard.kde.org/r/115409/diff/1/?file=241087#file241087line75> > > > > Removal of this c

Re: What to test for 4.13?

2014-03-07 Thread Christoph Feck
and invite users to report thing that still might need to be addressed. Thanks, Christoph Feck (kdepepo) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[plasma-shell] [Bug 327683] Crash at login (no activities found?)

2014-03-10 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=327683 --- Comment #8 from Christoph Feck --- Ivan, you already fixed that with e15fc07bdb4bf2379098d048fd2f8dc9024e2ffd :) -- You are receiving this mail because: You are on the CC list for the bug. ___ Plasma

Re: Review Request 115409: Workaround battery detection at runtime

2014-03-10 Thread Christoph Feck
> On March 7, 2014, 12:19 p.m., Christoph Feck wrote: > > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line > > 75 > > <https://git.reviewboard.kde.org/r/115409/diff/1/?file=241087#file241087line75> > > > > Removal of this c

Re: Review Request 116703: Improve section heading

2014-03-11 Thread Christoph Feck
> On March 11, 2014, 8:28 a.m., Thomas Pfeiffer wrote: > > Fine from the UI side, I can't say anything about the code itself It feels a bit odd that the space between the two text lines within each item is larger than the space between two text lines from adjacent items. - Christoph ---

Re: Notifications in Next

2014-03-20 Thread Christoph Feck
+ the > > ability to scroll using mouse wheel on it. Thoughts? > > +1 for scrolling rather than auto resize ;) Scrolling is fine, but please plan for users without a wheel, i.e. either add a scroll bar, or simply use drag scrolling. Christoph Feck (kdepepo) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117533: Fix batterymonitor popup closing when batter full, AC plugged in, and touching brightness slider

2014-04-19 Thread Christoph Feck
regressions. - Christoph Feck On April 13, 2014, 9:27 a.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker

2014-04-20 Thread Christoph Feck
review this, or suggest someone who could review it? - Christoph Feck On April 11, 2014, 10:23 a.m., Felix Geyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker

2014-04-20 Thread Christoph Feck
> On April 20, 2014, 7:18 p.m., Christoph Feck wrote: > > Can someone more familiar with the screen locker please review this, or > > suggest someone who could review it? Felix, could you please add Wolfgang Bauer (wbauer) and maybe Thomas Lübking (luebking) to the reviewers

Re: Notification bloat (4.xx)

2014-05-22 Thread Christoph Feck
this way. If you want more opinions, please also read the bugzilla entries for plasma/notifications. Users there generally agree that the current notifications are not without annoyances. Christoph Feck (kdepepo) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Notification bloat (4.xx)

2014-05-23 Thread Christoph Feck
On Friday 23 May 2014 22:58:21 Mark Gaiser wrote: > On Thu, May 22, 2014 at 8:41 PM, Christoph Feck wrote: > > On Thursday 22 May 2014 20:23:00 Mark Gaiser wrote: > >> Hi, > >> > >> First of all, i have no solution for this. I've just observed an >

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Christoph Feck
rmats/formats.desktop <https://git.reviewboard.kde.org/r/118290/#comment40660> Missing comma before the "and". kcms/kfontinst/kcmfontinst/fontinst.desktop <https://git.reviewboard.kde.org/r/118290/#comment40661> Missing comma. You could ask i18n team for shipit, bec

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Christoph Feck
tps://git.reviewboard.kde.org/r/118290/#comment40737> & - Christoph Feck On May 26, 2014, 10:52 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-27 Thread Christoph Feck
> On May 27, 2014, 4:12 p.m., Andrew Lake wrote: > > Ship It! > > Andrew Lake wrote: > In case anyone is wondering why this arbitrary fellow said "Ship It!", I > just wanted to provide an explicit thumbs up that this matches the 4px > spacing basis grid recommended in the HIG > (http://te

Review Request 118869: Use QElapsedTimer for data engines

2014-06-22 Thread Christoph Feck
/datacontainer_p.h a3e1f00 plasma/private/dataengine_p.h 74a61e2 Diff: https://git.reviewboard.kde.org/r/118869/diff/ Testing --- Thanks, Christoph Feck ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

2015-10-26 Thread Christoph Feck
> On Oct. 25, 2015, 10:05 p.m., Thomas Pfeiffer wrote: > > As always: If you want design or usability input, please provide a > > screenshot. We cannot read the code. Thanks. > > Eike Hein wrote: > Thomas, all this does is not grey out the text in Task Manager button > labels when a window

Re: Review Request 127405: Make sure PlasmaQuick export file is properly found

2016-03-19 Thread Christoph Feck
. - Christoph Feck On March 17, 2016, 12:16 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request: new kwin effect: roundedcorners - make corners of the desktop rounded

2010-09-21 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5225/#review7712 --- Some UI suggestions: - change "Width" in UI to either "Radius" or

Review Request: Fix PaintUtils::shadowText() placement

2010-09-30 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5504/ --- Review request for Plasma. Summary --- I used Plasma::PaintUtils::shado

Re: The KWin Coding Style Situation

2010-11-28 Thread Christoph Feck
be new kdelibs style, because that is where future contributions and fixes will land. Other than that, I agree that the current style is annoying and you should not force contributors to use it. Christoph Feck (kdepepo) ___ Plasma-devel mailing list

Re: Review Request: Fix plasma locale problems with multihead

2011-04-16 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101133/#review2676 --- Compilation fails with this error: kde-workspace/plasma/desktop

Re: Review Request: Fix plasma locale problems with multihead

2011-04-16 Thread Christoph Feck
> On April 16, 2011, 10:06 a.m., Christoph Feck wrote: > > Compilation fails with this error: > > > > kde-workspace/plasma/desktop/shell/plasmaapp.cpp:119:59: error: taking > > address of temporary > > Alberto Mattea wrote: > Weird, it works without

plasma_engine_metadata.so

2011-04-18 Thread Christoph Feck
Hi, both KDE/base/kde-workspace, as well as playground/base/plasma-mobile install the file "lib/kde4/plasma_engine_metadata.so". I am not sure if both packages are intended to be installed together, but if they are, one of the files needs to be renamed. Christoph Fec

nepomukstorage.notifyrc / plasma-applet-notifications.desktop

2011-05-05 Thread Christoph Feck
a file is installed. Thanks for looking at it, Christoph Feck (kdepepo) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Deprecate KLineEdit::clickMessage

2011-05-14 Thread Christoph Feck
> On May 14, 2011, 4:01 a.m., Shaun Reich wrote: > > Are you sure the behaviour for the Qt method 100% equivalent to the > > current? I ask this because now that the deprecated method forwards to it, > > naturally it's quite important to make sure nothing gets fscked up. > > Nicolas Alvarez wr

Review Request: Fix possible memory and D-Bus connection leak in KStatusNotifierItem

2011-06-06 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101527/ --- Review request for kdelibs, Plasma and Marco Martin. Summary --- Acco

Review Request: Use underscore instead of hyphen in .so name

2011-06-28 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101801/ --- Review request for Plasma. Summary --- Every other applet uses "plasm

Re: RFC: Remove Opacity from Alt+F3 menu

2011-08-19 Thread Christoph Feck
ich avoids the need to switch between them constantly. Christoph Feck (kdepepo) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: KControl/randr: Make changes to the absolute X/Y coordinates of a display call setConfigDirty

2011-09-21 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102631/#review6693 --- - Christoph On Sept. 16, 2011, 2:10 p.m., Thomas Gahr wrote: >

Re: Review Request: KControl/randr: Make changes to the absolute X/Y coordinates of a display call setConfigDirty

2011-09-21 Thread Christoph Feck
> On Sept. 21, 2011, 12:31 p.m., Christoph Feck wrote: > > If you commit this, could you check if it fixes the issues from bug 273102 ? - Christoph --- This is an automatically generated e-mail. To reply, vi

Re: Review Request: Fix ordinal suffix in plasmaclock configuration page for TTS

2011-10-16 Thread Christoph Feck
e last two digits, so that it becomes 312th, not 312nd. Maybe it should be added to KLocale? Some languages might have completely different requirements depending on the number, so the we have a central place to add code to handle them. - Christoph Feck On Oct. 15, 2011, 10:38 p.m., Trever Fis

Re: Review Request: Standard Actions KCM: Hide global column, and fix group name

2011-10-19 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102709/#review7502 --- Ship it! Ship It! - Christoph Feck On Sept. 26, 2011, 3:50

Re: Review Request: Standard Actions KCM: Hide global column, and fix group name

2011-10-19 Thread Christoph Feck
> On Oct. 19, 2011, 9:50 p.m., Christoph Feck wrote: > > Ship It! Erm, forgot the comment... Please commit to KDE/4.7, then git cherry-pick -x to master. - Christoph --- This is an automatically generated e-mail. To reply, vi

  1   2   3   4   5   6   >