Re: RFC: Use Grid as default for KWin's Presnt windows effect

2015-01-09 Thread Andres Betts
to name each window. --  Andres Betts On January 9, 2015 at 9:17:39 AM, Martin Klapetek (martin.klape...@gmail.com) wrote: Hey there, so I've been thinking about the Present Windows effect of KWin. The default setting for laying the windows out is currently "Natural", but to

Re: RFC: Use Grid as default for KWin's Presnt windows effect

2015-01-09 Thread Andres Betts
if you wanted extra input. --  Andres Betts On January 9, 2015 at 9:32:55 AM, Martin Klapetek (martin.klape...@gmail.com) wrote: On Fri, Jan 9, 2015 at 5:24 PM, Andres Betts wrote: My only objection to that is that the grid will end up making the each window generally smaller until it could

Re: Selecting a Plasma logo

2016-08-08 Thread Andres Betts
r (se...@kde.org) wrote: > Hi Andres, > > Sorry it took a few days to reply. > > On dinsdag 2 augustus 2016 07:45:10 CEST Andres Betts wrote: > > Let me explain the reasons about changing the logo and what stage this is > at. In my personal view, after working for some time

Re: Selecting a Plasma logo

2016-08-08 Thread Andres Betts
Hey Sebastian, Let me explain the reasons about changing the logo and what stage this is at. In my personal view, after working for some time on coming up with a new logo proposal, we received a few comments and changes to it that, to me, had no backing. One idea was shared that others wanted my p

D28461: In sidebar mode show if a module is in default state or not

2020-03-31 Thread Andres Betts
abetts added a comment. If I am understanding correctly, this patch adds icons in the kcm list to indicate changes you can revert by going to the kcm. Basically, default settings have changed and now you have the possibility to see that changes have been made. I am not sure that I like the i

D29057: Introduce PlaceholderMessage component

2020-04-21 Thread Andres Betts
abetts added a comment. Look cool! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29057 To: ngraham, #vdg, #kirigami, mart Cc: abetts, broulik, cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Andres Betts
abetts added a comment. I love this idea. I would request to keep the drag behavior and follow up with a second ticket to propose a change in the drag behavior for the panel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29535 To: ngraham, abetts, #vdg, #pl

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Andres Betts
abetts added a comment. +1 from me! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29535 To: ngraham, abetts, #vdg, #plasma Cc: ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, hi

D29570: Fix some alignments

2020-05-09 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29570 To: niccolove, #vdg, #plasma Cc: abetts, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezh

D11198: [libbreezecommon] Add box shadow helper

2018-06-30 Thread Andres Betts
abetts added a comment. I thought this was accepted and ready to go. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11198 To: zzag, #breeze, #vdg, hpereiradacosta Cc: ngraham, broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuter

D13745: Implement support for virtual desktops on Wayland

2018-07-03 Thread Andres Betts
abetts added a comment. The dev team has been in talks with the VDG about this change. We are OK with the change. We understand that before we make any visual changes, we need to, at least, provide the same functionality that we have in X11 to what we want to have in Wayland. The VDG is curr

D10083: [Look and Feel] Reverse the button order

2018-07-11 Thread Andres Betts
abetts added a comment. Not sure it is redundant but it should follow what the mockups in pholio are saying. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10083 To: safaalfulaij, #plasma, davidedmundson Cc: abetts, davidedmundson, plasma-devel, ragreen, Pit

D14145: Show a vertical menu for the panel widget options pop-up

2018-07-16 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14145 To: ngraham, #plasma Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14238: Polish Notifier Plasmoid's UI

2018-07-19 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14238 To: ngraham, apol, #discover_software_store, #vdg Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14105: Use a broom-style icon for clearing clipboard and notification history

2018-07-23 Thread Andres Betts
abetts added a comment. Can you share the svg file for this icon please? I would like to edit it a little bit REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14105 To: ngraham, broulik, Fuchs, #plasma, davidedmundson Cc: abetts, Zren, plasma-devel, ragreen,

D14105: Use a broom-style icon for clearing clipboard and notification history

2018-07-23 Thread Andres Betts
abetts added a comment. In D14105#296525 , @ngraham wrote: > It's the `edit-clear-history` icon in the `breeze-icons` repo. Can you help me find that repo please? I have no clue how to get there. REPOSITORY R120 Plasma Workspace REVISI

D14325: Remove Advanced section from screen config

2018-07-24 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14325 To: gladhorn, #plasma, #vdg, ngraham Cc: abetts, ngraham, andreaska, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14326: Fix layout of resolution selection

2018-07-24 Thread Andres Betts
abetts added a comment. +1 on the visual changes! REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14326 To: gladhorn, #plasma, #vdg Cc: abetts, ngraham, broulik, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14326: Fix layout of resolution selection

2018-07-24 Thread Andres Betts
abetts added a comment. In D14326#296853 , @gladhorn wrote: > F6134401: kcm_res_bef.png F6134403: kcm_res_aft.png F6134417: kcm_resolution_before.png

D14326: Fix layout of resolution selection

2018-07-24 Thread Andres Betts
abetts added a comment. In D14326#297020 , @gladhorn wrote: > In D14326#297016 , @abetts wrote: > > > In D14326#296853 , @gladhorn wrote: > > > > > F613

D14339: Remove confusing icons from rotation combobox

2018-07-24 Thread Andres Betts
abetts added a comment. In D14339#297211 , @ngraham wrote: > Hmm, instead of removing them, I'd prefer if we used better icons. Maybe like that little icon of a mountain and a sun within a frame that we already have--but rotated. > > With no

D14347: Fix blocky text on splash screen when using non-integer scale factor

2018-07-26 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14347 To: ngraham, #plasma, davidedmundson, broulik Cc: abetts, broulik, svenmauch, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14339: Change rotation icons to be a rotated preview icon

2018-07-26 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14339 To: gladhorn, #plasma, #vdg, ngraham, romangg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14581: support for multilevel kcms

2018-08-08 Thread Andres Betts
abetts added a comment. Looking great! REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D14581 To: mart, #plasma, #vdg Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14737: Move "update" button from the left side to the right side in NIC module

2018-08-11 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D14737 To: schampailler, ngraham Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14830: Add "Display Configuration" context menu entry on the desktop

2018-08-14 Thread Andres Betts
abetts added a comment. In D14830#308870 , @davidedmundson wrote: > > about how having this option is stupid and doesn't fit in here and bla bla that always emerges when this entry is proposed or talked about. > > Being off by default does n

D14830: Add "Display Configuration" context menu entry on the desktop

2018-08-14 Thread Andres Betts
abetts added a comment. In D14830#309263 , @davidedmundson wrote: > > This could be good whenever we have situations where the desktop locks > > If the desktop locks then the one thing you can't do is right click on the desktop Odd

D14855: Add applet with screen layouts and presentation mode

2018-08-15 Thread Andres Betts
abetts added a comment. On the first string I would change the wording: "Configurations become enabled when another screen is connected" The second string could read: "It will prevent the screen from turning off" (automatically = optional) REPOSITORY R104 KScreen REVISION DET

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-15 Thread Andres Betts
abetts added a comment. I like the way this looks, I would like to push it further for clarity and ask for window title at 13 and bold. I feel people stand to benefit from seeing a window title that is readable, especially when we have a dark color background default. REPOSITORY R119 Plas

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-15 Thread Andres Betts
abetts added a comment. In D14869#309824 , @ngraham wrote: > In D14869#309821 , @abetts wrote: > > > I like the way this looks, I would like to push it further for clarity and ask for window title at

D14857: Label job notifications with destination file name

2018-08-16 Thread Andres Betts
abetts accepted this revision. abetts added a comment. +1 REVISION DETAIL https://phabricator.kde.org/D14857 To: karthikp, #vdg, ngraham, abetts Cc: abetts, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14905: Warn on logout screen when another user is logged in

2018-08-20 Thread Andres Betts
abetts added a comment. This makes good sense in that admin world, more business style. I think they would appreciate it. I would probably look for a string that is a little shorter. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14905 To: broulik, #plasm

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-20 Thread Andres Betts
abetts added a comment. In D14869#312156 , @ngraham wrote: > Apparently people are passionate about font sizes. :) > > after reading everyone's comments here, it seems like this will probably not work on its own, but has usefully exposed a nu

D14855: Add applet with screen layouts and presentation mode

2018-08-20 Thread Andres Betts
abetts added a comment. In D14855#312321 , @ngraham wrote: > Instead of: > > Presentation mode > This will prevent your screen and computer from turning off automatically >[] Enable Presentation Mode > > > I would prefer to g

D14855: Add applet with screen layouts and presentation mode

2018-08-22 Thread Andres Betts
abetts added a comment. Love! Love! <3 Thanks for working on it. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14855 To: broulik, #plasma, #vdg, fischbach, harmathy Cc: anthonyfieroni, ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, Pitel, ZrenBot, le

D15011: [Kickoff] Make the search field always look like a search field

2018-08-22 Thread Andres Betts
abetts added a comment. I like this idea REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson Cc: abetts, davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterber

D15011: [Kickoff] Make the search field always look like a search field

2018-08-23 Thread Andres Betts
abetts accepted this revision. abetts added a comment. I like this idea, it is easier to discover. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: broulik, safaalfulaij, oysteins, anthonyfieroni, fil

D15024: Update icons kcm docbook to 5.13

2018-08-23 Thread Andres Betts
abetts added a comment. I am hoping there is also a way for people to be able to see more information about the theme in GHNS. Is there a visual way that we can do this? Maybe do the layout the same as it was before BUT where the preview image used to be, have the new gallery item look? REP

D15011: [Kickoff] Make the search field always look like a search field

2018-08-23 Thread Andres Betts
abetts added a comment. In D15011#314154 , @filipf wrote: > Yeah Nate, but if you look at your responses they're predominantly on a much higher level of abstraction (e.g "next step", "change is scary") than the issues raised. That's why for me t

D15011: [Kickoff] Make the search field always look like a search field

2018-08-23 Thread Andres Betts
abetts added a comment. In D15011#314181 , @davidedmundson wrote: > > @davidedmundson, does this look okay now? > > Code wise, yes. > > UI/Concept wide, I don't want to have an opinion either way Thanks Dave REPOSITORY R119 Pla

D15011: [Kickoff] Make the search field always look like a search field

2018-08-24 Thread Andres Betts
abetts added a comment. Maybe something I can explain, for us designers, is that we have a set of defined rules and guidelines for visual design on KDE and we should strive to first search for an option that is adapted or allowed by these guidelines. If that doesn't work, we could propose ot

D15011: [Kickoff] Make the search field always look like a search field

2018-08-26 Thread Andres Betts
abetts added a comment. I really like the last suggestion from Filip. It blends well with the theme. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: rooty, sharvey, romangg, broulik, safaalfulaij, oy

D15011: [Kickoff] Make the search field always look like a search field

2018-08-26 Thread Andres Betts
abetts added a comment. > However, regardless of what we choose, I would like to move towards unifying the interfaces in the above table, because inconsistency in something basic like this is not good. So if we decide to make search fields that have keyboard focus by default not visibly focu

D15011: [Kickoff] Make the search field always look like a search field

2018-08-26 Thread Andres Betts
abetts added a comment. In D15011#315863 , @ngraham wrote: > In D15011#315816 , @abetts wrote: > > > I agree that our HIG needs to explain focus better. It doesn't really have to be a long HIG about

D15011: [Kickoff] Make the search field always look like a search field

2018-08-27 Thread Andres Betts
abetts added a comment. Yay! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson, abetts Cc: fabianr, huftis, rooty, sharvey, romangg, broulik, safaalfulaij, oysteins, filipf, abetts, davidedmundson, michaeltunnell

D15101: [Widget Explorer] always show the search field

2018-08-27 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15101 To: ngraham, #plasma, sharvey, #vdg Cc: abetts, sharvey, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15101: [Widget Explorer] always show the search field

2018-08-27 Thread Andres Betts
abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. Approved depending on the code review. REPOSITORY R119 Plasma Desktop BRANCH widget-explorer-always-shows-search-field (branched from master) REVISION DETAIL https://phabricator.kde.

D15121: Kirigami ages are required for kcms

2018-08-28 Thread Andres Betts
abetts added a comment. I prefer "allows you to configure" REPOSITORY R115 Plasma Audio Volume Applet BRANCH mart/newkcm REVISION DETAIL https://phabricator.kde.org/D15121 To: mart, #plasma, davidedmundson Cc: abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, le

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Andres Betts
abetts added a comment. Could you please put a video or gif that shows the effect? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #plasma, #vdg, davidedmundson Cc: abetts, davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, les

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Andres Betts
abetts added a comment. In D14988#316633 , @phuongn wrote: > Hi, it's just the default desktop changing effect. Activated by scrolling with the cursor hovering on the pager. I haven't changed the effect, just added an option to toggle page wrapp

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Andres Betts
abetts added a comment. In D14988#316672 , @ngraham wrote: > I think the terminology "wraps around" is fine. Seems pretty clear to me. Cool, let's go with that. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.o

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

2018-08-29 Thread Andres Betts
abetts added a comment. Just a nitpick: Since we have a checkbox and then a label, can the label also have the word "Enable". We have transitioned into making actionable checkboxes to start their label with an active verb. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabric

D13481: Recommend window border size "None"

2018-08-29 Thread Andres Betts
abetts added a comment. I think we were able to identify the issues, even the ones pointed out in the discussions earlier in this ticket. I feel that we have a path forward. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13481 To: romangg, #plasma, #vdg Cc: pedrogome

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

2018-08-31 Thread Andres Betts
abetts added a comment. I like that string better. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14989 To: phuongn, #plasma Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15233: Add a tooltip for the appentry in the kicker

2018-09-04 Thread Andres Betts
abetts added a comment. What would this look like? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15233 To: underwit, #plasma Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15206: [Kickoff] Add a subtle separator line between the header and the content view

2018-09-04 Thread Andres Betts
abetts added a comment. In D15206#320116 , @mmustac wrote: > Personally I like it more without the separators but except of that the top-margin of the first element seems to be only 6px while the margin to the underneath elements is about 12px.

D15233: Add a tooltip for the appentry in the kicker

2018-09-05 Thread Andres Betts
abetts added a comment. In D15233#320616 , @underwit wrote: > Screenshot with tooltip > F6236529: Screenshot_20180905_105259.png > > For tooltip i use "comment", "genericname" or "name" from .desktop

D15423: System settings: make date/time format preview consistent

2018-09-11 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

2018-09-11 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

2018-09-13 Thread Andres Betts
abetts added a comment. In D15418#325340 , @acrouthamel wrote: > How about changing the volume icon for the non-playing application to `audio-volume-muted.svg`? Then, when it is playing audio, it reverts to low/high icons as usual, based on sli

D15418: Dim application icon when it is not playing anything

2018-09-13 Thread Andres Betts
abetts added a comment. In D15418#325344 , @broulik wrote: > All of that is reserved for being "Muted". Just because it doesn't play something doesn't mean it couldn't start producing sound any moment. > We shouldn't use anything that could be

D15514: [libbreezecommon] Use box blur instead of FFT approach

2018-09-14 Thread Andres Betts
abetts added a comment. Interesting, no big real differences visually IMHO REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15514 To: zzag, #kwin, #plasma Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15683: Add lock icon to desktop context menu

2018-09-21 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D15683 To: anemeth, ngraham, #vdg Cc: abetts, safaalfulaij, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15738: [Fonts KCM] remove filler words from anti-aliasing settings' labels

2018-09-25 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15738 To: ngraham, #vdg, #plasma Cc: abetts, svenmauch, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15785: [Slideshow] increase default interval from 10 seconds to 15 minutes

2018-09-26 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15785 To: ngraham, #plasma, broulik, mart, #vdg Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14542: WIP: Basic KCM using new virtual desktops DBus interface

2018-09-30 Thread Andres Betts
abetts added a comment. Suggestions from the VDG Channel - Make header "Row 1, Row 2, etc" grey - Add icons (up for review) to the right of each desktop label +1 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson Cc: abetts,

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

2018-10-02 Thread Andres Betts
abetts added a comment. Screenshot? REPOSITORY R119 Plasma Desktop BRANCH arc_folderview (branched from master) REVISION DETAIL https://phabricator.kde.org/D15823 To: thsurrel, #plasma, #vdg, hein Cc: abetts, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensr

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

2018-10-02 Thread Andres Betts
abetts added a comment. In D15823#335296 , @thsurrel wrote: > F6299154: screenshot.png > Showing the missing home button in the top left corner. The button would appear again if I would navigate one folde

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-05 Thread Andres Betts
abetts added a comment. Would this ensure that, at least, you can drag a window from the top area, like the toolbar, menu and the title bar empty areas? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15942 To: davidedmundson, #plasma, broulik, ngraham Cc: abetts, rik

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-05 Thread Andres Betts
abetts added a comment. In D15942#337137 , @broulik wrote: > No, not with a finger or pen. We should support this, yes, but not in the way it's currently done by synthesized mouse events. Sounds good! Thanks for the update! REPOSITORY

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-08 Thread Andres Betts
abetts added a comment. Is this patch also tweaking the shadows for the text or is it just concerned with the background for the icons? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16031 To: ngraham, #vdg, #plasma Cc: abetts, pstefan, broulik, rikmills,

D16035: [SDDM theme] Use grammatically correct string "Log In"

2018-10-09 Thread Andres Betts
abetts accepted this revision as: VDG, abetts. abetts added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16035 To: ngraham, #vdg, #plasma, abetts Cc: abetts, plasma-devel, rag

D15247: Show tooltips in krunner

2018-10-13 Thread Andres Betts
abetts added a comment. Love it! Thanks for the patch! REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D15247 To: McPain, #plasma, broulik, ngraham Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ma

D16219: [Lock Screen] Do not try to unlock when unvisible

2018-10-15 Thread Andres Betts
abetts added a comment. Could you please add a short video or gif showing this problem? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16219 To: thsurrel, #plasma, #vdg Cc: abetts, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jen

D16219: [Lock Screen] Do not try to unlock when unvisible

2018-10-15 Thread Andres Betts
abetts added a comment. In D16219#343507 , @davidedmundson wrote: > There's one in the bug report. If this is the bug referenced https://bugs.kde.org/show_bug.cgi?id=399835 There is no video there REPOSITORY R120 Plasma Works

D16219: [Lock Screen] Do not try to unlock when unvisible

2018-10-15 Thread Andres Betts
abetts added a comment. In D16219#343511 , @thsurrel wrote: > The bug is https://bugs.kde.org/show_bug.cgi?id=395671 Thank you guys REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16219 To: thsurrel, #p

D16241: [Folder View] Improve layout and formatting of Icons page

2018-10-16 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16241 To: ngraham, #plasma, #vdg, hein Cc: abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16219: [Lock Screen] Do not try to unlock when unvisible

2018-10-17 Thread Andres Betts
abetts added a comment. +1 for the idea! REPOSITORY R120 Plasma Workspace BRANCH arc_enterpressed (branched from master) REVISION DETAIL https://phabricator.kde.org/D16219 To: thsurrel, #plasma, #vdg, ngraham Cc: ngraham, davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel,

D16241: [Folder View] Improve layout and formatting of Icons page

2018-10-18 Thread Andres Betts
abetts added a comment. In D16241#345082 , @ngraham wrote: > Kirigami FormLayout is a really nice control to work with. I'm a big fan. This port was easy peasy and I can't wait to do more of these! > > The double `Kirigami.Separator` items ar

D15206: [Kickoff] Add a subtle separator line between the header and the content view

2018-10-23 Thread Andres Betts
abetts added a comment. Does the blue line from the selected content touch the divider line you are prosing? If it isn't, I would suggest no gap between those two lines. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15206 To: ngraham, #plasma, #vdg Cc: abet

D16504: [KCMs] Use consistent text for GHNS buttons

2018-10-28 Thread Andres Betts
abetts added a comment. I like the direction of the patch. My only thing is that we drop the use of the word "Scheme". I think we could use something different like "Pattern", "Swatch", "Theme", etc. If it is about colors, I think swatch would be really cool. REPOSITORY R119 Plasma De

D15206: [Kickoff] Add a subtle separator line between the header and the content view

2018-10-29 Thread Andres Betts
abetts added a comment. In D15206#348152 , @ngraham wrote: > No, the blue highlight doesn't touch, just like people requested. It looks just fine now. If we want to make the blue highlight touch the bounds of its whole view, that would be a sign

D16504: [KCMs] Use consistent text for GHNS buttons

2018-10-29 Thread Andres Betts
abetts added a comment. In D16504#350746 , @ngraham wrote: > In D16504#350245 , @abetts wrote: > > > I like the direction of the patch. > > > > My only thing is that we drop the use of the word "S

D16897: Allow windows to be closed from the window switchers

2018-11-15 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16897 To: ngraham, #plasma, #vdg Cc: abetts, Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16901: [Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless

2018-11-15 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16901 To: ngraham, #plasma, #vdg, hein Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

2018-11-19 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16988 To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson Cc: abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterber

D17050: Allow clicking of links in app descriptions

2018-11-20 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17050 To: leinir, #discover_software_store, apol Cc: abetts, plasma-devel, masilva, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17022: [Kickoff] Enable Esc to close Kickoff and Tab to switch to Search

2018-11-20 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17022 To: rooty, ngraham, romangg Cc: abetts, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

2018-11-21 Thread Andres Betts
abetts added a comment. Looks great. Thanks for the fix. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg Cc: abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D17073: Do not crop albumArt

2018-11-21 Thread Andres Betts
abetts added a comment. I know this patch doesn't deal with this, but I would suggest doing a background blur on the bottom bar that has the player buttons and the labels. It will improve readability REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To:

D16968: [Folder View] improve label contrast against challenging backgrounds

2018-11-24 Thread Andres Betts
abetts added a comment. Looking good guys! +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #vdg Cc: abetts, svenmauch, matheusm, filipf, emateli, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensre

D17073: Do not crop albumArt

2018-11-26 Thread Andres Betts
abetts added a comment. In D17073#366588 , @ngraham wrote: > Staring at these screenshots again, it occurs to me that the artist and title are unnecessarily repeated in the current UI: once right under the app name, and again towards the bottom,

D17217: Implement free memory notifier

2018-11-28 Thread Andres Betts
abetts added a comment. Is having this feature an optional feature? Can it be turned off? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17217 To: McPain, broulik, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, je

D17212: Port to QQC2 and FormLayout

2018-11-28 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17212 To: mart, #plasma, #vdg Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17192: use a Kirigami Heading for perfect consistency

2018-11-28 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17192 To: mart, #plasma, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17192: use a Kirigami Heading for perfect consistency

2018-11-28 Thread Andres Betts
abetts added a comment. I don't really have an issue with the font alignment. I think where I am conflicted is the part where we want this text to have too many purposes. The label is big so as to mean that it is a page title. However, when we place this on a phone, the header text is huge.

D17212: Port to QQC2 and FormLayout

2018-11-29 Thread Andres Betts
abetts added a comment. In D17212#368048 , @mart wrote: > F6446445: Screenshot_20181129_143041.png Wait! Isn't the header labels supposed to be on the right? They are also supposed to be aligned to

D17211: Port applet/containment configs to qqc2

2018-11-29 Thread Andres Betts
abetts added a comment. +1 on visuals REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik, ngraham Cc: abetts, ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart

D17211: Port applet/containment configs to qqc2

2018-11-29 Thread Andres Betts
abetts added a comment. In D17211#368161 , @ngraham wrote: > Thanks, the combobox open-on-click feature works perfectly! > > I still don't agree with making the wallpaper plugin GHNS button icons-only. That makes it inconsistent with all othe

D17192: use a Kirigami Heading for perfect consistency

2018-11-29 Thread Andres Betts
abetts added a comment. In D17192#368170 , @mart wrote: > well, to me part of the problem is that a title became a back button... even tough smaller target to hit, i would have preferred to have a toolbutton followed by a proper title that is ju

  1   2   3   4   >