Re: Review Request: Use the same text color as C++ Plasma::LineEdit

<http://git.reviewboard.kde.org/r/105159/#comment11398> Wouldn't textColor be better than buttonTextColor? The TextField doesn't have the a button background! - Aleix Pol Gonzalez On June 6, 2012, 10:55 a.m., Aurél

Re: Review Request: KRunner Bookmarks: implement Chrome/Chromium support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105673/#review16243 --- I don't see the patch...? - Aleix Pol Gonzalez On Ju

Re: Review Request: KRunner Bookmarks: implement Chrome/Chromium support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105673/#review16244 --- I don't see the patch...? - Aleix Pol Gonzalez On Ju

Review Request: Don't warn when using a page without toolbar

Testing --- Changed it and ran discover again, everything worked fine. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Polishing ScrollBar

Bar.qml 430de05 Diff: http://git.reviewboard.kde.org/r/105808/diff/ Testing --- Played around with http://proli.net/meu/kde/testcase.qml Also made sure it fixes my issue in ktp-text-ui Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing li

Re: Review Request: ScrollBar: fix update timer condition

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105817/#review16775 --- >.< my bad - Aleix Pol Gonzalez On Aug. 1, 2012, 4:

Re: Review Request: ScrollBar: fix update timer condition

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105817/#review16776 --- >.< my bad - Aleix Pol Gonzalez On Aug. 1, 2012, 4:

Review Request: Mouse hover effect on ListItem

acomponents/qml/ListItem.qml 8511a26 Diff: http://git.reviewboard.kde.org/r/105939/diff/ Testing --- played with muon discover a bit Screenshots --- a hovered item http://git.reviewboard.kde.org/r/105939/s/668/ Thanks, Ale

Re: Review Request: Mouse hover effect on ListItem

that. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105939/#review17153 --- On Aug. 9, 2012, 12:08 a.m., Aleix Pol Gonzalez wrote: > > -

Re: Review Request: Mouse hover effect on ListItem

ewboard.kde.org/r/105939/#review17154 --- On Aug. 9, 2012, 12:08 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request: Mouse hover effect on ListItem

generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105939/#review17158 --- On Aug. 9, 2012, 12:08 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatical

Re: Review Request: Mouse hover effect on ListItem

now a touch version without effect becomes necessary > > Aleix Pol Gonzalez wrote: > a) If ListItem.enabled is false, then the mouse area will be disabled. So > there will be not such effect. > b) why? the behavior should be the same, no? > > Marco Martin wrote: >

Review Request: Improve ProgressBar display

://git.reviewboard.kde.org/r/105966/s/669/ after http://git.reviewboard.kde.org/r/105966/s/670/ Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Improve ProgressBar display

/apol/kdeqmlviewer + http://proli.net/meu/kde/testprogress.qml Screenshots --- before http://git.reviewboard.kde.org/r/105966/s/669/ after http://git.reviewboard.kde.org/r/105966/s/670/ Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing

Re: Review Request: Improve ProgressBar display

+ http://proli.net/meu/kde/testprogress.qml Screenshots (updated) --- before http://git.reviewboard.kde.org/r/105966/s/669/ after http://git.reviewboard.kde.org/r/105966/s/671/ Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list

Re: Review Request: Improve ProgressBar display

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105966/#review17495 ------- On Aug. 10, 2012, 4:12 p.m., Aleix Pol Gonzalez wrote: > > ---

Review Request: Make it possible to have a QAbstractItemModel as a property

lasma/declarativeimports/core/datamodel.h cf82648 plasma/declarativeimports/core/datamodel.cpp 00108b1 Diff: http://git.reviewboard.kde.org/r/106267/diff/ Testing --- Plasma::SortFilterModel didn't stop working. Thanks, Aleix Pol Gonzalez

Review Request: Make it possible to use Tree models from QML

dy is interested I can provide it too. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make it possible to use Tree models from QML

tically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/#review18269 ------- On Aug. 30, 2012, 8:17 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an

Re: Review Request: Make it possible to use Tree models from QML

also tested it with a QML example I had with KPeople. If anybody is interested I can provide it too. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make it possible to use Tree models from QML

ith a QML example I had with KPeople. If anybody is interested I can provide it too. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make it possible to use Tree models from QML

> <http://git.reviewboard.kde.org/r/106272/diff/2/?file=82329#file82329line32> > > > > I see you're copy'n'pasting my precious unittest code :) ;) - Aleix --- This is an automatically generated e-ma

Re: Review Request: Make it possible to use Tree models from QML

know when the model when setting the index. I removed the warning. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/#review18325 ---------

Re: Review Request: Make it possible to use Tree models from QML

also tested it with a QML example I had with KPeople. If anybody is interested I can provide it too. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Make it possible to use Tree models from QML

has a good idea? SimplifierProxyModel? ListProxyModel? - Aleix Pol Gonzalez On Aug. 31, 2012, 3:45 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboa

Re: Review Request: Make it possible to use Tree models from QML

tin wrote: > +1 for ColumnProxyModel. > good also to put more emphasys on the columns rather than the possibility > to dive in the tree nodes, that is here only because visualdatamodel can't be > used in conjunction with other proxies, since doesn't inherit from qai

Re: Review Request: Make it possible to use Tree models from QML

-CREATION Diff: http://git.reviewboard.kde.org/r/106272/diff/ Testing --- There's a passing unit test, albeit limited. I also tested it with a QML example I had with KPeople. If anybody is interested I can provide it too. Thanks, Aleix Pol Gon

Review Request: Make it possible to configure a wallpaper from the viewer

wallpaperviewer/main.cpp ea3c5d4 plasma/generic/tools/wallpaperviewer/wallpaperwidget.h 0f387a5 Diff: http://git.reviewboard.kde.org/r/106495/diff/ Testing --- I ran it and seemed to work Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing li

Re: Review Request: add preview thumbnail at color wallpaper config dialog

ttp://git.reviewboard.kde.org/r/106626/#comment15723> Shouldn't the ItemsView be in some kind of common place? I probably should be using it in Animated Wallpapers as well... - Aleix Pol Gonzalez On Oct. 2, 2012, 11:48 a.m., Reza

Re: Review Request: add preview thumbnail at color wallpaper config dialog

> On Oct. 2, 2012, 2:20 p.m., Aleix Pol Gonzalez wrote: > > plasma/generic/wallpapers/color/itemsview.h, line 1 > > <http://git.reviewboard.kde.org/r/106626/diff/2/?file=88122#file88122line1> > > > > Shouldn't the ItemsView be in some kind of common pla

Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

ports/plasmacomponents/qml/Button.qml <http://git.reviewboard.kde.org/r/106717/#comment15779> unneeded change :) - Aleix Pol Gonzalez On Oct. 3, 2012, 10:01 p.m., David Edmundson wrote: > > --- > This is an automatically

Review Request: Humble attempt to improve the ScreenSaver KCM

de.org/r/106768/diff/ Testing --- just messed with it for a while. Screenshots --- result http://git.reviewboard.kde.org/r/106768/s/758/ Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mai

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

utomatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106768/#review20087 ----------- On Oct. 8, 2012, 3:43 p.m., Aleix Pol Gonzalez wrote: > > --- > This

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

than 50 % of > > the available screen estate. > > Marco Martin wrote: > another idea would be just show the screen saver part only when the > screensaver radio is selected (i kept it a bit that way before merging btw, > seemed a bit flashy..) > > Aleix Pol Gonzalez

Review Request: Add tooltips to the screensavers KCM

tip http://git.reviewboard.kde.org/r/106876/s/778/ Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: make qmlwallpaper thumbnail size similar to other plugins(image, color or pattern plugins)

t with those fixes :) - Aleix Pol Gonzalez On Oct. 17, 2012, 1 p.m., Reza Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revi

Re: Review Request: Plasmate: Port QDialog to KDialog

;t that exactly the opposite direction we want to go with KF5? - Aleix Pol Gonzalez On Nov. 6, 2012, 8:33 p.m., Antonis Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.r

Review Request: Reduce verbosity when running a QML-based plasmoid

top and I was flooded by those. Diffs - plasma/widgets/declarativewidget.cpp 3176073 Diff: http://git.reviewboard.kde.org/r/107261/diff/ Testing --- I ran org.kde.graphsplasmoid before patching and I got many warnings. After patching I didn't get those. Thanks, Ale

Review Request: Remove unneeded code

--- AFAIK, this code is not doing much, so it can be removed. Diffs - lib/bodega/installjobsmodel.h b5452d4 lib/bodega/installjobsmodel.cpp f69ba16 Diff: http://git.reviewboard.kde.org/r/107342/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Review Request: Reduce runtime warnings

r.cpp bd55c6a Diff: http://git.reviewboard.kde.org/r/107379/diff/ Testing --- Installed and ran again Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: adjust qml wallpaper setting dialog and make it's color button remember previous value

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107532/#review22819 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 30, 2012, 1

Re: Review Request: show notification summary for last popup notification

tions, since the sender is in there. I have no idea if it's the same case for other programs, though.. - Aleix Pol Gonzalez On Dec. 15, 2012, 9:17 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-ma

Re: Review Request: show notification summary for last popup notification

> On Dec. 16, 2012, 10:09 p.m., Kai Uwe Broulik wrote: > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml, > > line 181 > > > > > > Seems to have no effect here, and font shouldn't be bo

Review Request: Don't add qml elements twice to the scene, reduce warnings

works fine. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Fix initial size when --size is passed

saw that it works. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate: Replace QDialogButtonBox with QVBoxLayout

? setMaximum/MinimumSize shouldn't be used like that either... Have you considered using the designer to make the ui, instead? - Aleix Pol Gonzalez On Jan. 3, 2013, 2:15 p.m., Antonis Tsiapaliokas wrote: > > --- > This is an

Review Request: Translate \n into for error messages

ntime. Then ran a plasmoid that has an error message from the plasmoidviewer. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Use \n to split QML errors

32ee191 Diff: http://git.reviewboard.kde.org/r/108124/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate: Replace QDialogButtonBox with QVBoxLayout

t, no? Wow :) the code is looking much nicer now. Removing code feels right. ^^ Especially if you're not dropping functionality - Aleix Pol Gonzalez On Jan. 3, 2013, 8:13 p.m., Antonis Tsiapaliokas wrote: > > --- > This is an

Re: Review Request: Plasmate: Replace QDialogButtonBox with QVBoxLayout

parenthesis but I'd say it's good to have the label, since when there's some text you can't read the placeholder. I think the code is better now and it should get in, I'll mark as Ship It although I understand I don't have much of a say in this code. :) - Aleix Pol Gonzal

Re: Review Request: Show album art in krunner results.

> On Jan. 10, 2013, 10:12 p.m., Vishesh Handa wrote: > > runners/audioplayercontrol/audioplayercontrolrunner.cpp, line 510 > > > > > > How about using 'toUrl().toLocalFile()' instead? That will remove the > > fil

Re: Review Request: Show album art in krunner results.

lFile()' instead? That will remove the > > file prefix. > > Emil Sedgh wrote: > Done, thank you. > > Aleix Pol Gonzalez wrote: > In this case it's better to use pathOrUrl, in case it's actually a url. > > Or that can't

Review Request 108797: Small adjustments in KSMServer UI, fixed error that wouldn't reproduce in default plasma themes

smserver-default.png Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0

oblem. Diffs - plasma/declarativeimports/core/iconitem.cpp 765e7ed Diff: http://git.reviewboard.kde.org/r/108825/diff/ Testing --- After patching, ran discover again, without all the qWarnings. Thanks, Aleix Pol Gonzalez ___ Plasma-

Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0

't we just merge commits? - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108825/#review26828 --- On Feb. 7, 2013, 1:22 a

Re: Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0

> On Feb. 7, 2013, 9:39 a.m., Marco Martin wrote: > > Ship It! > > Marco Martin wrote: > ah, another thing. > from now on, patches done here should be applied also in the > corresponding file in the plasma-frameworks repository when applicable > > Aleix P

Review Request 108863: Consider an empty (0x0) IconItem a valid item

plasma/declarativeimports/core/iconitem.cpp a7e80e0 Diff: http://git.reviewboard.kde.org/r/108863/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108863: Consider an empty (0x0) IconItem a valid item

dated) - plasma/declarativeimports/core/iconitem.cpp a7e80e0 Diff: http://git.reviewboard.kde.org/r/108863/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/lis

Re: Review Request 108922: Fix off-by-one error in RunnerModel

you could run some interesting session with the ModelTest to catch this kind of issues ASAP, no? :) - Aleix Pol Gonzalez On Feb. 12, 2013, 3:10 p.m., Aurélien Gâteau wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 108992: Simple optimizations in SignalPlotter

a codebase improvement. Mostly otherwise. Also I'd like to know how you measured this 5% of improvement, which either way I'm unsure if it's worth it considering that this patch makes everything global, now. - Aleix Pol Gonzalez On Feb. 17, 2013, 12:57 p

Review Request 109641: Fix border detection in Plasma dialogs

fine. Diffs - plasma/dialog.cpp 038444c Diff: http://git.reviewboard.kde.org/r/109641/diff/ Testing --- Played with it, together with the ktp-chat plasmoid Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org

Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

e11269e Diff: http://git.reviewboard.kde.org/r/109648/diff/ Testing --- I was reproducing the problem regularly since a couple of days, then now I cannot reproduce anymore. There's no testing per se, though... Thanks, Aleix Pol Gonzalez ___ P

Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

s an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109648/#review29651 --- On March 21, 2013, 5:37 p.m., Aleix Pol Gonzalez wrote: > > --- > This

Review Request 109699: Simplify the behavior of the main UI file in the chat plasmoid

very hard to test sizes with plasmoidviewer and such), I still have the Icon Tasks eating up my space, but I guess I have to debug other code to get around that. At least now it doesn't get as squeezed. Thanks, Aleix Pol Gonzalez ___ Plasma-de

Review Request 109712: Make it possible to use action groups with QMenuItem

lasma/declarativeimports/plasmacomponents/qmenuitem.cpp e8d590d Diff: http://git.reviewboard.kde.org/r/109712/diff/ Testing --- I have some code using it locally in muon. It works fine. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list P

Re: Review Request 109712: Make it possible to use action groups with QMenuItem

n.cpp 169fd35 plasma/declarativeimports/plasmacomponents/qmenuitem.h 0f43418 plasma/declarativeimports/plasmacomponents/qmenuitem.cpp e8d590d Diff: http://git.reviewboard.kde.org/r/109712/diff/ Testing --- I have some code using it locally in muon. It works fine. Thanks, Aleix Pol Gon

Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

g per se, though... Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 109947: KTp Chat plasmoid: Improve integration with hiding panels

9fb78c9 Diff: http://git.reviewboard.kde.org/r/109947/diff/ Testing --- Self-conversation, as usual. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110382: Fix a crash that happens when you close some apps

ttp://git.reviewboard.kde.org/r/110382/#comment24040> note indentation is wrong here I've been using this patch since I commented in this bug, it's working fine (no crashes). - Aleix Pol Gonzalez On May 10, 2013, 12:57 p.m., Anne-Mar

Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110430/ --- (Updated May 14, 2013, 10:35 p.m.) Review request for kde-workspace and Pl

Re: Review Request 101543: Code review for the newspaper containment

/appletscontainer.cpp 1ba4d83 Diff: http://git.reviewboard.kde.org/r/101543/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

> On Aug. 6, 2013, 2:52 p.m., David Edmundson wrote: > > tier1/kconfig/src/gui/kconfigloader.h, line 112 > > > > > > This looks like it should be const > > > > I suspect it wasn't because KCoreConfigSelet

Re: Review Request 112033: Drop windowId property from PlasmaCore.Dialog

hack so the dialog doesn't appear in the tasks list. - Aleix Pol Gonzalez On Aug. 13, 2013, 4:47 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 112445: Port EffectWatcher to XCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112445/#review39791 --- What happened to this? It seems to make sense... - Aleix Pol

Review Request 113086: KDeclarative cleanup

7;re not moving the module to its tier yet) Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113086: KDeclarative cleanup

k. Still, we want to have the module unit-tested. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41215 ----------

Re: Review Request 113086: KDeclarative cleanup

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41220 ----------- On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote: >

Re: Review Request 113086: KDeclarative cleanup

.1 as PlasmaWidgets I'm unsure what to do with those. (can do in a further commit, we're not moving the module to its tier yet) Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 113179: Make the runners compile again

uilds, including kde-workspace. Couldn't test it, there's no tests for it or even an application to test it :/. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113179: Make the runners compile again

On Oct. 8, 2013, 9:15 p.m., Aleix Pol Gonzalez wrote: > > There's also runner-related code in > > src/declarativeimports/{core,runnermodel}, these should be reenabled as > > well. Possibly, they also need changes to make built. I had disabled this > > after a d

Re: Review Request 113179: Make the runners compile again

t.cpp d5142a2 Diff: http://git.reviewboard.kde.org/r/113179/diff/ Testing --- Everything builds, including kde-workspace. Couldn't test it, there's no tests for it or even an application to test it :/. Thanks, Aleix Pol Gonzalez _

Review Request 113345: Stop using Qt5Transitional in Plasma Frameworks

/ Testing --- Builds, tests still pass. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113345: Stop using Qt5Transitional in Plasma Frameworks

/scriptengines/javascript/CMakeLists.txt b339bbc Diff: http://git.reviewboard.kde.org/r/113345/diff/ Testing --- Builds, tests still pass. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Review Request 113920: Remove KDE4Support dependency from plasma-frameworks (almost)

src/shell/shellcorona.cpp 2519e29 Diff: http://git.reviewboard.kde.org/r/113920/diff/ Testing --- Builds, tests pass. I'm unsure what else to test. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/m

Re: Review Request 113920: Remove KDE4Support dependency from plasma-frameworks (almost)

---------- On Nov. 18, 2013, 5:17 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113920/ > ---

Re: Review Request 113920: Remove KDE4Support dependency from plasma-frameworks (almost)

/scripting/appinterface.cpp 63196f9 src/shell/scripting/scriptengine.cpp 1250c20 src/shell/shellcorona.cpp 2519e29 Diff: http://git.reviewboard.kde.org/r/113920/diff/ Testing --- Builds, tests pass. I'm unsure what else to test. Thanks, Ale

Review Request 114362: Properly place the panels in a multiscreen environment

--- Works on my system with 2 screens. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114362: Properly place the panels in a multiscreen environment

) - src/shell/panelview.cpp 2c80783 Diff: http://git.reviewboard.kde.org/r/114362/diff/ Testing --- Works on my system with 2 screens. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 114362: Properly place the panels in a multiscreen environment

- src/shell/panelview.cpp 2c80783 Diff: http://git.reviewboard.kde.org/r/114362/diff/ Testing --- Works on my system with 2 screens. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 114382: Reduce plasma warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114382/#review45485 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 10, 2013, 3

Re: Review Request 114683: Clean up target_link_libraries for KF5Plasma

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114683/#review46193 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 27, 2013

Re: Review Request 114925: Add a new component ModelMenu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114925/#review47104 --- Maybe call it ModelContextMenu? - Aleix Pol Gonzalez On

Review Request 115027: Port the share DataEngine from Kross to KJsEmbed

ataengines/share/shareservice.cpp 272a467 Diff: https://git.reviewboard.kde.org/r/115027/diff/ Testing --- I uploaded a paste with the half-ported plasmoid. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://ma

Re: Review Request 115027: Port the share DataEngine from Kross to KJsEmbed

ovider.cpp fc528f8 plasma/generic/dataengines/share/shareservice.h 9983292 plasma/generic/dataengines/share/shareservice.cpp 272a467 Diff: https://git.reviewboard.kde.org/r/115027/diff/ Testing --- I uploaded a paste with the half-ported plasmoid. Thanks, Aleix Po

Review Request 115348: Create a MimeDatabase component that maps QMimeDatabase

/declarativeimports/qtextracomponents/qtextracomponentsplugin.cpp d3f8149 Diff: https://git.reviewboard.kde.org/r/115348/diff/ Testing --- Works on my WIP changes for the QuickShare (was pastebin) plasmoid. Thanks, Aleix Pol Gonzalez ___ Plasma-devel

Re: Review Request 115348: Create a MimeDatabase component that maps QMimeDatabase

) plasmoid. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 115475: Split KRunner out of plasma-framework

/115475/diff/ Testing --- Everything still builds. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

. It makes sense to me, but I have no idea why it used to be this way. - Aleix Pol Gonzalez On Feb. 13, 2014, 10:14 a.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

> On Feb. 19, 2014, 10:06 a.m., Aleix Pol Gonzalez wrote: > > src/knotificationmanager.cpp, line 180 > > <https://git.reviewboard.kde.org/r/115695/diff/3/?file=243841#file243841line180> > > > > ? > > Martin Klapetek wrote: > Yet once again the

Re: Review Request 115475: Split KRunner out of plasma-framework

4fb602e examples/runner/homefilesrunner.h c535380 Diff: https://git.reviewboard.kde.org/r/115475/diff/ Testing --- Everything still builds. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

  1   2   3   4   5   6   7   8   9   10   >