D25694: Port away from DesktopIcon

2020-12-16 Thread Ahmad Samir
ahmadsamir added a comment. Ping :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25694 To: nicolasfella, #plasma Cc: ahmadsamir, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himc

Re: Using C++20 in Plasma

2021-08-06 Thread Ahmad Samir
ant/useful ones?). Is there any distro planning to ship future Plasma releases that does not have gcc 10 or clang 10? Cheers Nico -- Ahmad Samir

D26675: [sddm-theme] Don't have a broken reveal password button

2021-10-01 Thread Ahmad Samir
ahmadsamir added a comment. In D26675#678811 , @bharadwaj-raju wrote: > Is there an SDDM issue to track this? Because I edited the file to make `revealPasswordButtonShown` true, and the button shows up just fine. Which makes me think this might

D26675: [sddm-theme] Don't have a broken reveal password button

2021-10-01 Thread Ahmad Samir
ahmadsamir added a comment. One was to fix this is if sddm have copies of the needed password buttons, then it should work regardless of the installed icon themes. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26675 To: davidedmundson, #plasma Cc: ahmadsa

D26675: [sddm-theme] Don't have a broken reveal password button

2021-10-04 Thread Ahmad Samir
ahmadsamir added a comment. In D26675#678819 , @davidre wrote: > we could install an icon into hicolor as fallback Some time ago I tried finding which icon was being used, but I didn't get anywhere and moved on (I copied the theme folder,

Re: KickOff bug report page

2022-08-28 Thread Ahmad Samir
of the "plasmashell" product in bugzilla. Regards, Ahmad Samir OpenPGP_signature Description: OpenPGP digital signature

Re: Plasma-nm: passing on maintainership

2022-10-04 Thread Ahmad Samir
Thank you. Best regards, Jan Grulich Thanks for all the work (features and bugs alike, as you know software is always a mixed bag :D), and yes, indeed a very core component of Plasma. As Jonathan said, don't be a stranger, KDE has very good memory :) Regards, Ahmad Samir Op

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

2020-02-26 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 76447. ahmadsamir added a comment. target_link_libraries() KGuiAddons in the sysetmsettings5 target REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27518?vs=76355&id=76447 BRANCH l-khelp (branched from mast

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

2020-02-27 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R124:0be65944f311: If KHelpCenter isn't available fallback to opening doc at docs.kde.org (authored by ahmadsamir). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

2020-03-02 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY A "Regular" font will have an empty styleName e.g. "DejaVu Sans,12,-1,5,50,0,0,0,0,0" so that setBold(true) can

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

2020-03-02 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 76779. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Remove setNeedsSave(false) from load(), doesn't seem to be needed any more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2778

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

2020-03-02 Thread Ahmad Samir
ahmadsamir added a comment. TODO: fix the font dialog to select the correct "Regular"-like style (I have a working patch but needs more work). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27785 To: ahmadsamir, #plasma, davidedmundson Cc: plasma-devel, Orag

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

2020-03-03 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, broulik, ervin, meven. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY When using ajustAllFonts(), try to set the fixed width/Monospace font from the font family

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

2020-03-03 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 76868. ahmadsamir added reviewers: broulik, ervin, meven. ahmadsamir added a comment. Tweak REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27785?vs=76779&id=76868 BRANCH l-fonts-kcm-nearest (branched from m

D27830: [Fonts KCM] Make the font selection dialog highlight the correct style

2020-03-04 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, broulik, ervin, meven. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY KConfig will clear the styleName font property for "Regular"-like font styles (so that set

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

2020-03-04 Thread Ahmad Samir
ahmadsamir added a comment. FTR, removing setNeedsSave(false) from load(), it seems to work sometimes, and then some other times it doesn't work (i.e. changing anything, Apply doesn't get enabled)... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27785 To:

D27857: Port some usage of QRegExp to QRegularExpression

2020-03-04 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added a reviewer: Plasma. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY [0-9] is \d TEST PLAN make && ctest REPOSITORY R120 Plasma Workspace BRANCH l-qregexp-QRE (branched from master) REVISIO

D27830: [Fonts KCM] Make the font selection dialog highlight the correct style

2020-03-05 Thread Ahmad Samir
ahmadsamir added a comment. FTR, I had submitted this https://codereview.qt-project.org/c/qt/qtbase/+/292695 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27830 To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven, bport Cc: plasma-devel, Orage, L

D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-03-07 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added a reviewer: Plasma. Herald added a project: Plasma. ahmadsamir requested review of this revision. TEST PLAN make && ctest klipper still seems to work REPOSITORY R120 Plasma Workspace BRANCH l-klipper (branched from master) REVISION DETA

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

2020-03-09 Thread Ahmad Samir
ahmadsamir added a comment. In D27808#624506 , @bport wrote: > With your change, we are not allowed anymore to change for example only font and keeping different size, style for each kind of font (window, menu, toolbar...), right ? IIUC,

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

2020-03-09 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77258. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir removed a reviewer: bport. ahmadsamir added a comment. More detailed commit message REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

2020-03-09 Thread Ahmad Samir
ahmadsamir marked 3 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > bport wrote in fonts.cpp:115 > You can use && to have only one if there OK. > bport wrote in fonts.cpp:552 > Those change will compare font twice, here and on setters so I will keep old > code ther

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

2020-03-09 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77264. ahmadsamir marked 3 inline comments as done. ahmadsamir retitled this revision from "[Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary" to "[Fonts KCM] Change how nearestExistingFonts() finds a matching font". ahmadsa

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

2020-03-09 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77265. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Tweak commit message REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27785?vs=77264&id=77265 BRANCH arcpatch-D27785 (branche

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

2020-03-09 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77268. ahmadsamir retitled this revision from "[Fonts KCM] Change how nearestExistingFonts() finds a matching font" to "[Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary". ahmadsamir edited the summary of this revision. ahma

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

2020-03-09 Thread Ahmad Samir
ahmadsamir planned changes to this revision. ahmadsamir added a comment. It seems I messed up the branches stuff (or phabricator works in a way I don't understand), so I think it's best to work at one diff at a time, instead of wasting time trying to make sense of this situation :/ (I wil

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

2020-03-09 Thread Ahmad Samir
ahmadsamir added a comment. In D27808#625052 , @meven wrote: > Porting with such feature regression is hard to justify. I honestly don't know how many users actually use that feature; if it's still widely used, then yeah, that would defin

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

2020-03-10 Thread Ahmad Samir
ahmadsamir added a comment. And another question, "General", "Menu", "Toolbar", how many users actually set these three to individual font families/styles/sizes? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27808 To: ahmadsamir, #plasma, davidedmundson, br

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

2020-03-10 Thread Ahmad Samir
ahmadsamir added a comment. In D27808#625186 , @meven wrote: > In D27808#625181 , @ahmadsamir wrote: > > > And another question, "General", "Menu", "Toolbar", how many users actually set these three

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

2020-03-10 Thread Ahmad Samir
ahmadsamir added a comment. In D27808#625227 , @cfeck wrote: > We already lost fractional point sizes when porting from KFontDialog to QFontDialog. Yeah, I never understood why they opted for integer values only (I will dig in upstream l

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

2020-03-11 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77442. ahmadsamir retitled this revision from "[Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary" to "[Fonts KCM] Change how nearestExistingFonts() finds a matching font". ahmadsamir edited the summary of this revision. ahma

D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-03-11 Thread Ahmad Samir
ahmadsamir added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27914 To: ahmadsamir, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezh

D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

2020-03-12 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, apol, davidedmundson. Herald added a project: Plasma. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R126 KDE CLI Utilities BRANCH l-qregexp (branched from master) REVISION DETAIL htt

D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

2020-03-12 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77481. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Fix commit message REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28000?vs=77480&id=77481 BRANCH l-qregexp (branched fro

D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

2020-03-12 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in kstart.cpp:184 > Wouldn't it be easier here to just do `windowtitle.compare(info.name(), > Qt::CaseInsensitive)` and skip the regex? I thought about that, but looking at the code I found: void KStart::sendRule() { KXMess

D28042: [DrKonqi] Port QRegExp to QRegularExpression

2020-03-14 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, sitter, apol. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::exactMatch() by using QRegularExpression::anchoredPattern(), unless the pattern is al

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

2020-03-16 Thread Ahmad Samir
ahmadsamir added a comment. In D27785#628110 , @bport wrote: > Ok for me but need to wait approval on font dialog review (to ensure correct font style is selected when editing) Thanks. The font dialog review, D27808

D27675: feat: avoid duplicated text when assembling user-facing output names

2020-03-16 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > utils.cpp:64 > +return append(name, QLatin1Char('(') + output->name() + > QLatin1Char(')')); > } > } If I am reading this correctly, you could keep the old code and use simplified(): const QString outName = output->n

D28042: [DrKonqi] Port QRegExp to QRegularExpression

2020-03-16 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77744. ahmadsamir added a comment. Fix comment grammar REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28042?vs=77606&id=77744 BRANCH l-QRE-port (branched from master) REVISION DETAIL https://phabricator.kde.org

D28042: [DrKonqi] Port QRegExp to QRegularExpression

2020-03-16 Thread Ahmad Samir
ahmadsamir added a comment. In D28042#628179 , @sitter wrote: > I wouldn't terribly mind a second pair of eyes. > > Code generally looks good to me though, so if nobody else comments feel free to land in a couple days. OK, thanks. RE

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

2020-03-16 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, dfaure, davidedmundson, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY QMimeDatabase re-adds/prepends the "main" glob pattern (the

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

2020-03-16 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77754. ahmadsamir added a comment. Tweak comment REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28079?vs=77753&id=77754 BRANCH l-mainglobpattern (branched from master) REVISION DETAIL https://phabrica

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

2020-03-17 Thread Ahmad Samir
ahmadsamir added a comment. For background see: https://bugs.kde.org/show_bug.cgi?id=414742 I may be wrong, but personally I think QMimeDatabase is acting sensibly by not allowing to remove the "main" glob pattern of a mimetype. Also IIUC it seems other tools are sort of doing the sa

D28095: Bump required version of KF5 to 5.69.0

2020-03-17 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY KCrash::setErrorMessage() was introduced in 5.69.0. REPOSITORY

D28095: Bump required version of KF5 to 5.69.0

2020-03-17 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R871:ce461918868d: Bump required version of KF5 to 5.69.0 (authored by ahmadsamir). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28095?vs=77812&id=77813 REVISION DETA

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

2020-03-17 Thread Ahmad Samir
ahmadsamir added a comment. I spent some time looking (and hacking at a kdeplatformfontdialoghelper...) at the code in kdeplatformfiledialoghelper, KFontChooser and KFontDialog, and I am starting to think that moving KFontDialog to KWidgetAddons (where KFontChooser and KFontRequester live) i

D27857: Port some usage of QRegExp to QRegularExpression

2020-03-18 Thread Ahmad Samir
ahmadsamir added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27857 To: ahmadsamir, #plasma, davidedmundson, apol, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenB

D27857: Port some usage of QRegExp to QRegularExpression

2020-03-18 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77898. ahmadsamir marked 2 inline comments as done. ahmadsamir removed reviewers: davidedmundson, apol, broulik. ahmadsamir added a comment. Address comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27

D28075: [kstyle] Properly unregister widgets in ShadowHelper

2020-03-18 Thread Ahmad Samir
ahmadsamir added a comment. FWIW, I have the kdatetimeedittest unit test from KWidgetAddons fail with a SIGSEGV even after building breeze with this diff: Thread 1 "kdatetimeeditte" received signal SIGSEGV, Segmentation fault. 0x70c6c770 in qDeleteAll::const_iterator> (begin

D28075: [kstyle] Properly unregister widgets in ShadowHelper

2020-03-18 Thread Ahmad Samir
ahmadsamir added a comment. Could be something on my system no idea what though. Sorry for the noise. Anyway, the important thing is that the test passes on the CI system. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28075 To: zzag, #plasma, cblack Cc: ahma

D27857: Port some usage of QRegExp to QRegularExpression

2020-03-18 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in server.cpp:671 > Why the changes from [0-9] to \d? Less cluttered; but maybe not as readable. I'll revert it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27857 To: ahmadsamir, #plasma Cc: p

D27857: Port some usage of QRegExp to QRegularExpression

2020-03-18 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77905. ahmadsamir added a comment. Verbatim REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27857?vs=77898&id=77905 BRANCH l-qregexp-QRE (branched from master) REVISION DETAIL https://phabricator.kde.or

D27857: Port some usage of QRegExp to QRegularExpression

2020-03-18 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77906. ahmadsamir added reviewers: davidedmundson, apol, broulik. ahmadsamir added a comment. Verbatim REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27857?vs=77905&id=77906 BRANCH l-qregexp-QRE (branched

D27857: Port some usage of QRegExp to QRegularExpression

2020-03-18 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f444ebe595a2: Port some usage of QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27857?vs=77906&id=7

D28132: [Calculator Runner] Minor code optimisation

2020-03-18 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, apol. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY Remove redunant QString::contains() checks. Create one QRegularExpression object and use setPattern(). TEST PLAN make

D28132: [Calculator Runner] Minor code optimisation

2020-03-18 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R120:cd37cc6926c3: [Calculator Runner] Minor code optimisation (authored by ahmadsamir). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28132?vs=77945&id=77957

D28135: Port away from deprecated QSet/QList methods in some places

2020-03-19 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, apol. Herald added a project: Plasma. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R120 Plasma Workspace BRANCH l-qset-fromlist (branched from master) REVISION DETAIL

D28135: Port away from deprecated QSet/QList methods in some places

2020-03-19 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > anthonyfieroni wrote in runnermodel.cpp:179 > Here should be `m_runners = runners` to be exactly same as previous. I don't > see much benefit of having duplicate items. IIUC, the original code used toSet() to remove duplicates from both "m_run

D28135: Port away from deprecated QSet/QList methods in some places

2020-03-19 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > anthonyfieroni wrote in runnermodel.cpp:179 > But toSet() returns new container m_runners and runners are unmodified. I don't mind reverting that bit, but it seems wasteful to me to throw newRunners away, it is sorted and has no duplicates

D28042: [DrKonqi] Port QRegExp to QRegularExpression

2020-03-19 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R871:8d8062fe6bdc: [DrKonqi] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28042?vs=77744&id=77995 REVISIO

D28027: fix line rating for new format when function name is missing

2020-03-19 Thread Ahmad Samir
ahmadsamir added a comment. This doesn't apply cleanly. REPOSITORY R871 DrKonqi BRANCH parse-rate REVISION DETAIL https://phabricator.kde.org/D28027 To: sitter, cfeck, ngraham Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB

D28027: fix line rating for new format when function name is missing

2020-03-19 Thread Ahmad Samir
ahmadsamir added a comment. In D28027#630512 , @sitter wrote: > D28026 Ah, yes, that's where those "packagekit" lines are. Thanks :) REPOSITORY R871 DrKonqi BRANCH parse-rate REVISION DETAIL ht

D28098: remove pointless and arbitrary 4 line frame limit

2020-03-19 Thread Ahmad Samir
ahmadsamir added a comment. In D28098#629338 , @bcooksley wrote: > There should be no further changes to Dr Konqi at this time as it fails to build from source on both FreeBSD and Windows. > Please see the relevant CI jobs for more informatio

D28098: remove pointless and arbitrary 4 line frame limit

2020-03-19 Thread Ahmad Samir
ahmadsamir added a comment. This makes sense; also it fixes a part of the backtraceparsertest unit test, test_bug168000, which currently fails on master (output after export'ing QT_LOGGING_RULES="*drkonqi*=true"): 3: QDEBUG : BacktraceParserTest::btParserUsefulnessTest(test_bug168000)

D28026: further constrict line parsing of .so files

2020-03-20 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > backtraceparsergdb.cpp:75 > if (!regExp.cap(7).isEmpty()) { //we have file information (stuff > after from|at) > bool file = regExp.cap(8) == QLatin1String("at"); //'at' means > we have a source file (likely) >

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

2020-03-21 Thread Ahmad Samir
ahmadsamir abandoned this revision. ahmadsamir added a comment. OK. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D28079 To: ahmadsamir, #plasma, dfaure, davidedmundson, apol Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cbla

CI mail filtering (was Re: Manner in which kde-gtk-config development is conducted)

2020-03-22 Thread Ahmad Samir
uilds that have some unit tests failure). I suggest that if you commit regulary to a KDE repo to make a habit of checking the results of the unit tests on the CI every now and then (jenkins has a nice web interface). Unit tests could pass locally and fail on the CI for some reason. [...] My, beginner-dev, 2 p's, -- Ahmad Samir

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

2020-03-23 Thread Ahmad Samir
ahmadsamir added a comment. This failed to build on the CI https://build.kde.org/job/Plasma/job/plasma-desktop/, I guess you'll need to bump the min required version of KF5 to 5.69.0. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27503 To: bport, #plasma,

D28232: [SpellChecking KCM] Fix the build

2020-03-24 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, bport, meven, crossi, ervin. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY QList/QSet iterator-based ctors are available since Qt 5.14, so we could make the code conditional b

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

2020-03-24 Thread Ahmad Samir
ahmadsamir added a comment. Should be fixed by D28232 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27503 To: bport, #plasma, meven, crossi, ervin Cc: usta, ahmadsamir, ngraham, plasma-devel, Orage, LeGast00n, The-Feren

D28135: Port away from deprecated QSet/QList methods in some places

2020-03-24 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 78355. ahmadsamir added a comment. QStringList has a sort() method REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28135?vs=77979&id=78355 BRANCH l-qset-fromlist (branched from master) REVISION DETAIL h

D28232: [SpellChecking KCM] Fix the build

2020-03-25 Thread Ahmad Samir
ahmadsamir added a comment. In D28232#634281 , @bport wrote: > Next version of plasma will depend on Qt 5.14 AFAIK so it's not a problem to depend on it But the CI still uses 5.12 for the opensuse image, and probably 5.13 for the freebsd

D28232: [SpellChecking KCM] Fix the build

2020-03-25 Thread Ahmad Samir
ahmadsamir added a comment. I don't know when the CI will be updated, probably soon based on what I read on IRC #kde-devel, but until then isn't it better to keep the CI working for plasma-desktop? I could rework the patch to make it conditional on 5.14 and keep the iterator-based ctors as-i

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

2020-03-25 Thread Ahmad Samir
ahmadsamir added a comment. I am not so sure about the QPlatform integration bit, it looks easier/cleaner to just use KFontChooserDialog; QFontDialog isn't widely used in KDE code, so porting to KFontChooserDialog is doable (though that sounds like going back in time to using KFontDialog in

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

2020-03-26 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > export_scheme_dialog.cpp:46 > int item=0; > -Q_FOREACH(QString component, mComponents) > +for(QString component : qAsConst(mComponents)) > { const QString & > export_scheme_dialog.cpp:74 > +const auto buttons = mButtons.b

D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

2020-03-26 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 78519. ahmadsamir retitled this revision from "[Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog" to "[Fonts KCM] Use KFontChooserDialog instead of QFontDialog". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for thi

D28232: [SpellChecking KCM] Fix the build

2020-03-26 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 78554. ahmadsamir added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28232?vs=78347&id=78554 BRANCH l-fix-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D282

D28232: [SpellChecking KCM] Fix the build

2020-03-26 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R119:646bd3eecc72: [SpellChecking KCM] Fix the build (authored by ahmadsamir). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28232?vs=78554&id=78555 REVISION DE

D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-03-27 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 78634. ahmadsamir added a comment. Rebase; and friendly ping REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27914?vs=77170&id=78634 BRANCH l-klipper (branched from master) REVISION DETAIL https://phabr

D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-03-27 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in urlgrabber.h:185 > Why did you change how it works right here? I find it confusing to call the pattern "regExp" and the QRegExp object "m_myRegExp". REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.o

D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-03-27 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in urlgrabber.h:185 > Then call it m_regularExpression? Another point (which I forgot since it has been some time since I last looked at this patch), QRegExp stores the match info in itself, whereas QRegularExpression stores the ma

D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-03-27 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in urlgrabber.h:185 > Then you want to store a match? The code stores the QRegularExpression::capturedTexts(), m_regexCapturedTexts, which is eventually what ClipCommandProcess uses. REPOSITORY R120 Plasma Workspace REVISION DET

D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-03-28 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in urlgrabber.h:185 > I think it's a silly way to do the port but okay, probably works and we get > to move on. What is silly about it? The original code in ClipCommandProcess used: const QStringList matches = action.regExpMatches(

D28423: [kioclient] Fix 'kioclient5 --commands' usage messages

2020-03-30 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY It should use 'kioclient5'. REPOSITORY R126 KDE CLI Utilities BRANCH

D28423: [kioclient] Fix 'kioclient5 --commands' usage messages

2020-03-30 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R126:30a713025624: [kioclient] Fix 'kioclient5 --commands' usage messages (authored by ahmadsamir). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28423?vs=788

D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-04-01 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R120:bcfd7f28370d: [Kilpper] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27914?vs=78634&id=79040

D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

2020-04-01 Thread Ahmad Samir
ahmadsamir added a comment. Ping. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D28000 To: ahmadsamir, #plasma, apol, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngra

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

2020-04-01 Thread Ahmad Samir
ahmadsamir abandoned this revision. ahmadsamir added a comment. Not needed with D27808 , which will use KFontChooserDialog everywhere. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27785 To: ahmadsamir, #plasma, davidedmu

D27830: [Fonts KCM] Make the font selection dialog highlight the correct style

2020-04-01 Thread Ahmad Samir
ahmadsamir abandoned this revision. ahmadsamir added a comment. See D27808 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27830 To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven, bport Cc: plasma-devel, Orage

D28519: [KMenuEdit] Port QRegExp to QRegularExpression

2020-04-02 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, mlaurent. Herald added a project: Plasma. ahmadsamir requested review of this revision. TEST PLAN The code compiles and kmenuedit still starts as expected REPOSITORY R103 KMenu Editor BRANCH l-QRE (branch

D28519: [KMenuEdit] Port QRegExp to QRegularExpression

2020-04-03 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 79188. ahmadsamir edited the test plan for this revision. ahmadsamir removed a subscriber: apol. ahmadsamir added a comment. Add proper test plan REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28519?vs=79152&id=

D28519: [KMenuEdit] Port QRegExp to QRegularExpression

2020-04-03 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R103:1e30c84ab32b: [KMenuEdit] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28519?vs=79188&id=79194

D28519: [KMenuEdit] Port QRegExp to QRegularExpression

2020-04-03 Thread Ahmad Samir
ahmadsamir added a comment. In D28519#640339 , @apol wrote: > It could make sense for you to test that the names are properly parsed besides just making sure it starts. Done. REPOSITORY R103 KMenu Editor REVISION DETAIL https://phab

D28534: [Klipper] Upate the klipper docbook after porting to QRegularExpression

2020-04-03 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, apol, broulik. Herald added projects: Plasma, Documentation. Herald added a subscriber: kde-doc-english. ahmadsamir requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH l-klipper-docs (

D28534: [Klipper] Upate the klipper docbook after porting to QRegularExpression

2020-04-03 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 79200. ahmadsamir added a comment. Bump date and version REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28534?vs=79197&id=79200 BRANCH l-klipper-docs (branched from master) REVISION DETAIL https://phab

D28534: [Klipper] Upate the klipper docbook after porting to QRegularExpression

2020-04-03 Thread Ahmad Samir
ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > yurchor wrote in index.docbook:34 > Can you bump the date and version? > > Thanks in advance for your work. Done. Thanks. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.k

D28534: [Klipper] Upate the klipper docbook after porting to QRegularExpression

2020-04-03 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. ahmadsamir marked an inline comment as done. Closed by commit R120:a8fb4ce827ab: [Klipper] Upate the klipper docbook after porting to QRegularExpression (authored by ahmadsamir). REPOSITORY R120 Plasma Workspace CHANGES

D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

2020-04-04 Thread Ahmad Samir
ahmadsamir added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27808 To: ahmadsamir, #plasma, davidedmundson, broulik, meven, cfeck, bport Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, r

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

2020-04-07 Thread Ahmad Samir
ahmadsamir added a comment. In D27518#643466 , @sitter wrote: > FYI linking a library without actually using any symbols is not going to do anything in practice because many distros link with --as-needed which undoes unnecessary linking. also se

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

2020-04-07 Thread Ahmad Samir
ahmadsamir added a comment. In D27518#643502 , @sitter wrote: > My point is that this diff adds kguiaddons as a link library but doesn't actually use any symbol, so it may as well not be a link library (or something ought to call some function o

  1   2   >