graesslin added inline comments.
INLINE COMMENTS
> xdgshell_interface.cpp:40
> +int attempt = 0;
> +connect(pingTimer, &QTimer::timeout, q, [this, serial, attempt]()
> mutable {
> +++attempt;
what's the idea behind a mutable lambda?
> xdgshell_interface.h:458
> + */
> +
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Several of the subclasses are already derived from QObject.
The main reason is that the class should be moved out of KWin core in
o
Hi all,
I solved my problem by adding my own template-layout in
.local/share/plasma/layout-templates/.
Thank you for your help. About the syntax of
org.kde.plasma.desktop-layout.js if you can explain or give me some
documents I'll very appreciate.
I'm going to write a blog about this and hope
maxrd2 added a reviewer: sars.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma, sars
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
davidedmundson added a comment.
Thanks, but do you know why the apps datasource doesn't have that entry after
a while?
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma, sars
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezh
maxrd2 added a comment.
Am not sure why apps.data["org.kde.ksysguard.desktop"] becomes undefined.
Think it might be a bug in PlasmaCore.DataSource? I haven't noticed any log
messages apart that TypeError.
Will try to see if sourceDisconnected/Removed is signaled at some point.
It will
maxrd2 removed a reviewer: sars.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
davidedmundson added a comment.
The problem I have is that if we see a bug, and then work round it instead of
understanding it, we still have a bug - and that will just come up again in a
different place again and again.
> I have also noticed with this change that there is no (few second
davidedmundson marked an inline comment as done.
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in xdgshell_interface.cpp:40
> what's the idea behind a mutable lambda?
the captured "attempt" variable is modified inside the lambda
REPOSITORY
R127 KWayland
REVISION DET
maxrd2 added a comment.
Great will make those changes/additions then.
Do you know why was KService::serviceByName() deprecated in KDE 4?
(https://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKService.html#a2c5b00fd381b9843b6ba99da692c90ae)
REPOSITORY
R114 Plasma Addons
REVISION
maxrd2 added a comment.
Also seems KService::serviceByName() was removed from KF5.. so it's ok just
to re-add it?
https://github.com/KDE/kservice/blob/master/src/services/kservice.h
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma
Cc:
davidedmundson added a comment.
sorry ::serviceByDesktopName() isn't deprecated and does what we want.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jens
maxrd2 updated this revision to Diff 19134.
maxrd2 edited the summary of this revision.
maxrd2 added a comment.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
Added KRun::openService() method
REPOSITORY
R296 KDeclarative
CHANGES SI
maxrd2 updated this revision to Diff 19136.
maxrd2 added a comment.
Plasmoid uses KRun::openService() to launch ksysguard
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7648?vs=19134&id=19136
BRANCH
launch-change
REVISION DETAIL
https://phabrica
maxrd2 added a comment.
There it goes... updated the qml and added KRunProxy changes here:
https://phabricator.kde.org/D7676
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwo
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R114 Plasma Addons
BRANCH
launch-change
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolf
maxrd2 added a dependency: D7676: Added openService() method to KRunProxy.
REPOSITORY
R114 Plasma Addons
BRANCH
launch-change
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai
maxrd2 added a comment.
I don't have full developer account so i can't land this one. It also needs
https://phabricator.kde.org/D7676 for this to work.
REPOSITORY
R114 Plasma Addons
BRANCH
launch-change
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma, davidedmun
rkflx added a comment.
Are you sure? In
https://phabricator.kde.org/R119:8eaf1e15ad8662b0ef72d83a242893b27f8058df it
seemed to work fine. You can check in https://identity.kde.org whether you are
in the "developers" group and you have the correct ssh key set up. `ssh
g...@git.kde.org info`
adridg created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
text is wrong
TEST PLAN
re-generate APIdox and read text
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricato
ltoscano added a reviewer: mart.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D7681
To: adridg, dfaure, mart
Cc: plasma-devel, apol, mart, hein
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7681
To: adridg, dfaure, mart
Cc: plasma-devel, apol, mart, hein
davidedmundson updated this revision to Diff 19148.
davidedmundson marked an inline comment as done.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
Rename grab signal
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https
Hey Zlatan,
On Sat, 2 Sep 2017 17:23:09 +0200
Zlatan Todoric wrote:
> (Cleared all previous mails to make this one more visible, feel free
> to respond on this one while quoting previous replies in this thread)
>
> Hi all,
>
> so I had discussion with our CEO and he is of course absolutely in.
2017-09-03 23:17 GMT+02:00 Sebastian Kügler :
> Hey Zlatan,
> [...]
>> so I had discussion with our CEO and he is of course absolutely in.
>> To make clear our standpoint - both GNOME and KDE *will* be first
>> class citizen on Librem5. So there is no favorite between two, but
>> both are equal in
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:f9e5b852faa7: Add ~/.local/share/icons to icons search
paths (authored by abondrov).
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
abondrov added a comment.
In https://phabricator.kde.org/D5093#142799, @rkflx wrote:
> Pushing or landing might not work if you use the wrong prefix as the push
target. It should be `g...@git.kde.org:`. You can check with `git remote -v`.
Thanx for your help! After adding these l
On 08/30/2017 10:31 PM, Matthias Klumpp wrote:
> I was made aware of that effort already a few weeks ago, and it is
> looking great! I guess the default Matrix app in the Librem phone
> would have to be something focused on person-to-person communication
> and tight integration with the user's co
https://bugs.kde.org/show_bug.cgi?id=381288
Nate Graham changed:
What|Removed |Added
Flags||Usability+
--
You are receiving this mail becaus
ngraham added a reviewer: VDG.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D7424
To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg
Cc: sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, apol, mart, lukas
30 matches
Mail list logo
