broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This adjusts the "configure" dialog in the same way as the "about" dialog I
fixed in
https://phabricator.kde.org/R120:2f66c0d11c68f13dd81d6a9
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This will have it show the actual application name instead of the description.
BUG: 358423
FIXED-IN: 5.11.0
CHANGELOG: Application
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
You're not covered by any messages.sh but using i18n
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6441
To: broulik, #plasma, davidedmun
broulik updated this revision to Diff 16037.
broulik added a comment.
Add Message.sh
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6441?vs=16036&id=16037
REVISION DETAIL
https://phabricator.kde.org/D6441
AFFECTED FILES
containmentactions/app
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:bdaaaedbfbbe: [AppLauncher Containment Action] Add option
to "show apps by name" (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6441
davidedmundson added a comment.
I would expect either:
if (ctx)
else {
// do what the old code did
}
or to be changing a bunch of QML code somewhere.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6440
To: broulik, #plasma
Cc: davide
broulik added a comment.
> // do what the old code did
"WindowModal" without a window makes it applicationmodal which is bad.
> or to be changing a bunch of QML code somewhere.
Yes, I will change plasma-desktop ConfigurationContainmentActions accordingly.
REPOSITORY
R120 Plasm
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This allows the config UI to know when to enable the Apply button.
Currently we only do that when the shortcut or actions themselves change b
broulik added inline comments.
INLINE COMMENTS
> currentcontainmentactionsmodel.cpp:217
> QObject::connect(configDlg, &QDialog::accepted, pluginInstance,
> -[configDlg, pluginInstance] () {
> +[this, configDlg, pluginInstance] () {
> pluginInstance->c
mart updated this revision to Diff 16044.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
- pingDelayed signal
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6418?vs=15997&id=16044
BRANCH
mart/xdgv6
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
mart/xdgv6ping
REVISION DETAIL
https://phabricator.kde.org/D6418
To: mart, #plasma, davidedmundson, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezh
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6343
To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:fd81e9f468bc: Add a check for whether the item isn't
actually visible (authored by apol).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6343?vs=15746&id=16046
RE
apol created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
They were just assumed to be QStrings so far, although all the code
was in place.
TEST PLAN
Used it in Discover
REPOSITORY
R169 Kirigami
mart closed this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6418
To: mart, #plasma, davidedmundson, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
BUG:381505
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6447
AFFECTED FILES
containments/desktop/package/contents/ui/FolderView.qml
containments
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6447
To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreute
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6445
To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This allows to open the location of the folder the wallpaper is in.
BUG: 371247
FIXED-IN: 5.11.0
TEST PLAN
F3797447: Screenshot_20170
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
nice addition
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6450
To: broulik, #plasma, #vdg, mart
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, al
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0a86c4de3ed9: [Image Wallpaper] Add "Open Containing
Folder" button (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6450?vs=16054&id=
mart added inline comments.
INLINE COMMENTS
> broulik wrote in currentcontainmentactionsmodel.cpp:217
> Hmm I pass in "this" but it's nowhere guarded :/
yeah, it may crash.. whatever is in the 3rd param of the connect is the one you
can not worry about, the other one may get dangling..
the only
mart abandoned this revision.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D6419
To: mart, #plasma, #kwin, davidedmundson, graesslin
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Till now
DelayedJobCleaner connect(m_weaver, SIGNAL(finished()), this,
SLOT(checkIfFinished()));
was alw
mart reclaimed this revision.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D6419
To: mart, #plasma, #kwin, davidedmundson, graesslin
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R308 KRunner
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6453
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensre
mart abandoned this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5399
To: mart, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
This revision was automatically updated to reflect the committed changes.
Closed by commit R308:abd6d21d7215: Add missing Q_OBJECT macro (authored by
davidedmundson).
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6453?vs=16059&id=16060
REVISION DETAIL
http
mart added inline comments.
INLINE COMMENTS
> panelconfigview.cpp:69
> KWindowSystem::setState(winId(), NET::KeepAbove);
> -setFlags(Qt::WindowFlags((flags() | Qt::FramelessWindowHint |
> Qt::WindowStaysOnTopHint) & (~Qt::WindowDoesNotAcceptFocus)));
> KWindowSystem::forceActiveWin
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
when the window gets moved, position the shellsurface immediately
rather than in an event: otherwise it's too late and having a moment
in whic
davidedmundson added a comment.
> otherwise it's too late
too late for what?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6455
To: mart, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, s
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> mart wrote in panelconfigview.cpp:69
> note: removing the whole line seems to be necessary as seems that setting any
> flag does break focus
I can see
graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When clicking the hide button provided by the virtual keyboard, the
keyboard hides, but the state is not updated. This means the animation
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
ensure-state-keyboard-active-5.10
REVISION DETAIL
https://phabricator.kde.org/D6456
To: graesslin, #plasma, sitter, davidedmundson
Cc: plasma-devel, ZrenBot, pro
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5004afe62d16: [lookandfeel/lockscreen] Fix state handling
when clicking the keyboard's own… (authored by graesslin).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:113be5fac81a: Restore active client after ending showing
desktop (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6420?vs=15964&id=16074
REVISI
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:43816119e9ec: Skip Shader self test for Mesa >= 17
(authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6426?vs=15967&id=16073
REVISION DETAIL
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:be89c16b3884: [platforms/x11] Request OpenGL 2.1 instead
of 1.2 (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6401?vs=15901&id=16075
REVISIO
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:630514d52ab7: Remove roundtrip to XServer from
Workspace::xStackingOrder Introduce a method… (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6323?vs=15707&id=16076#toc
39 matches
Mail list logo
