D6336: [AppMenu Applet] Wire up DBusMenuImporter::actionActivationRequested

2017-06-22 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6336 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D6335: [Appmenu Applet] Workaround Connections bug in Qt >= 5.8

2017-06-22 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6335 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D6336: [AppMenu Applet] Wire up DBusMenuImporter::actionActivationRequested

2017-06-22 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:92a7089e9a10: [AppMenu Applet] Wire up DBusMenuImporter::actionActivationRequested (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D63

D6335: [Appmenu Applet] Workaround Connections bug in Qt >= 5.8

2017-06-22 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f00e4eb97e5d: [AppMenu Applet] Workaround Connections bug in Qt >= 5.8 (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6335?vs=15724&

D6324: Make sure we won't modify the aspect ratio of the icons

2017-06-22 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D6324 To: apol, #kirigami, leinir, mart Cc: plasma-devel, apol, mart

D6324: Make sure we won't modify the aspect ratio of the icons

2017-06-22 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. Looks good for the initial case of getting rid of the obviously broken looking aspect ratio at the very least, though i think exposing the property might still be good... But, at the very least, it matches the HIG so that's cool :) (i do

D6324: Make sure we won't modify the aspect ratio of the icons

2017-06-22 Thread Aleix Pol Gonzalez
apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D6324 To: apol, #kirigami, leinir, mart Cc: plasma-devel, apol, mart

D6324: Make sure we won't modify the aspect ratio of the icons

2017-06-22 Thread David Edmundson
davidedmundson added a comment. Cropping seems an odd choice. In Plasma/KIconLoader we do PreserveAspectFit / KeepAspectRatio. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D6324 To: apol, #kirigami, leinir, mart Cc: davidedmundson, plasma-devel, apol, mart

D6324: Make sure we won't modify the aspect ratio of the icons

2017-06-22 Thread Aleix Pol Gonzalez
apol added a comment. In https://phabricator.kde.org/D6324#118669, @davidedmundson wrote: > Cropping seems an odd choice. > > In Plasma/KIconLoader we do PreserveAspectFit / KeepAspectRatio. My thinking was that this could potentially mess the icons' margins. REPOSITORY R169

D6323: Remove roundtrip to XServer from Workspace::xStackingOrderIntroduce a method Workspace::markXStackingOrderAsDirty

2017-06-22 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH xstacking-no-roundtrip REVISION DETAIL https://phabricator.kde.org/D6323 To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, harde

Re: Kirigami in Frameworks

2017-06-22 Thread Marco Martin
On Wed, Jun 21, 2017 at 6:22 PM, Jonathan Riddell wrote: > On 21 June 2017 at 15:00, Marco Martin wrote: >> As there were no replies for quite a while, i assume there are no >> particular objections. >> >> so, how to proceed? what needs to be doe to do the actual move? > > Does it comply with the

D6343: Add a check for whether the item isn't actually visible

2017-06-22 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY if width or height is 0 we just get warnings such as: QImage::scaled: Image is a null image And in the end we're performing void operatio

D6344: [platforms/x11] Add support for GLX_NV_robustness_video_memory_purge

2017-06-22 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Based on earlier phab-request https://phabricator.kde.org/D2079. Adds the nvidia memory purge extension to the robust context creation.

D6047: WIP: Support XDG v6

2017-06-22 Thread Martin Flöser
graesslin added a comment. could you please upload a version with context? INLINE COMMENTS > mart wrote in xdgshell_interface.h:80 > from kwin, client.cpp: > i guess that's the kwin part that will have to use this. > it uses a single timer, and tries for a couple of timeout, as soon as the >

D6334: [kcms/touchpad] Fix crash with 'Drag me' in X11 test area

2017-06-22 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R119:5c3b8c7afa4a: Fix crashes with 'Drag me' in touchpad test area (authored by cfeck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6334?vs=15723&id=15751 RE

D6332: [kcms/touchpad] Fix warning 'returning reference to temporary'

2017-06-22 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R119:838777eaa6f0: Fix warning 'returning reference to temporary' (authored by cfeck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6332?vs=15721&id=15752 REVI

D6334: [kcms/touchpad] Fix crash with 'Drag me' in X11 test area

2017-06-22 Thread Christoph Feck
cfeck added a comment. Pushed to 5.10 and merged to master. Feel free to cherry-pick to 5.8 branch. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6334 To: cfeck, #plasma, knambiar, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D6350: Use KFileWidget::setSelectedUrl, which exists since KF 5.33.

2017-06-22 Thread David Faure
dfaure created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This fixes support for ":" in filenames. BUG: 376365 REPOSITORY R135 Integration for Qt applications in Plasma BRANCH setSelectedUrl

D6351: KDE QFileDialog helper: support name filters without parenthesis.

2017-06-22 Thread David Faure
dfaure created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The QFileDialog documentation says these are equivalent: dialog.setNameFilter("All C++ files (*.cpp *.cc *.C *.cxx *.c++)"); dialog.s

D6350: Use KFileWidget::setSelectedUrl, which exists since KF 5.33.

2017-06-22 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH setSelectedUrl REVISION DETAIL https://phabricator.kde.org/D6350 To: dfaure, #plasma, fvogt, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai

D6351: KDE QFileDialog helper: support name filters without parenthesis.

2017-06-22 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. BRANCH wildcard REVISION DETAIL https://phabricator.kde.org/D6351 To: dfaure, #plasma, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6351: KDE QFileDialog helper: support name filters without parenthesis.

2017-06-22 Thread David Faure
This revision was automatically updated to reflect the committed changes. Closed by commit R135:4736950ec2e7: KDE QFileDialog helper: support name filters without parenthesis. (authored by dfaure). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6351?vs=15765&id=15769#toc REPOSITORY R13

D6350: Use KFileWidget::setSelectedUrl, which exists since KF 5.33.

2017-06-22 Thread David Faure
dfaure closed this revision. dfaure added a comment. Pushed in b785b9c (stupid `arc land` merged two commits) REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D6350 To: dfaure, #plasma, fvogt, apol Cc: plasma-devel, ZrenBot, progwolff,