mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6161
To: sitter, #plasma, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:295af397fb2e: Add a integration test suite and fix a
signal connect bug when attaching reports (authored by sitter).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6161?vs=15417&id=15624#toc
R
davidedmundson updated this revision to Diff 15634.
davidedmundson edited the summary of this revision.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6047?vs=15020&id=15634
REVISION DETAIL
https://phabricator.kde.org/D6047
AFFECTED FILES
autotests/client/CMakeLists.txt
autotests
davidedmundson updated this revision to Diff 15638.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Use std::max
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6164?vs=15311&id=15638
BRANCH
master
REVISIO
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
isn't a bit heavy building a list just for this?
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6164
To: davidedmundson, #plasma, mart
Cc: graesslin, ma
davidedmundson added a comment.
> isn't a bit heavy building a list just for this?
std::max takes an initialiser-list directly as an argument, it's not
converting this into a vector or anything that would invovle copying or mallocs.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAI
On Sun, Jun 18, 2017 at 11:39 PM, wrote:
> Hi,
> I'm developing my application using Kirigami 2 and I really like the
> PageRow component which allows simple navigation between pages and makes
> it easy to target phones and tablets with one code base. However I find
> it rather limiting to have o
jgrulich created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
I've made few improvements which should help and make installation or update
process with flatpak backend a bit better experience:
1.
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R134 Discover Software Store
BRANCH
Plasma/5.10
REVISION DETAIL
https://phabricator.kde.org/D6298
To: jgrulich, apol
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuter
apol added a comment.
All in all, it looks good to me, much better than the previous approach.
Thanks!
INLINE COMMENTS
> Transaction.h:65
> +/// Transaction is done, but there was an error during transaction
> +DoneWithErrorStatus
> };
`FailedStatus`?
REPOSITORY
R134
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
make the behavior similar to Dialog
create a plasmashell surface only when isVisible() as
some expose events can arrive there too, and also no
broulik added a comment.
Classic case of „hilft's nix, schad's nix“, fine with me, didn't notice any
change but others might beg to differ.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6299
To: mart, #plasma
Cc: broulik, plasma-devel, ZrenBot, spstarr, p
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6299
To: mart, #plasma, davidedmundson
Cc: broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,
a
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:3a2ad5ca8b6d: Improvements in installation or updates for
flatpak backend (authored by jgrulich).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D629
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:b7cb301deb3b: Make shadows work for windows 100% width or
height (authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6164?vs=15638&id=15648
R
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
There was a regression introduced with bug fix
https://phabricator.kde.org/R108:eec6afe6f5fef80f519c7afb33e4fd568d74aab0 which
added
a
stikonas accepted this revision.
stikonas added a comment.
This revision is now accepted and ready to land.
I've also tested this patch on a few full screen games. That bug is gone.
REPOSITORY
R108 KWin
BRANCH
fix-edge-x11-update-blocking-5.10
REVISION DETAIL
https://phabricator.kde.or
hein updated this revision to Diff 15668.
hein added a comment.
- Don't break the popupDialog binding. It's a super binding, really, and this
patch didn't know how to appreciate it properly.
- Opening the popup should imply selecting, it avoids other state weirdness
in double-click-to-open
Zren added a comment.
>
https://cgit.kde.org/plasma-desktop.git/commit/?id=f49ca6ee277142539e0302f2848c79ff41d319cf
@hein Good catch with the `&& isRootView`. It's just optimization since the
extraSpace for the popup is 0 right? Now that I think on it, not sure why I
made the variables
Hi, thanks for your interest:)
Unfortunately I don't have a Phabricator account (I'm not a KDE
developer), so before the conversation moves there I'll describe how I
used, and am using now, activities in my application to show potential
use cases of Kirigami. Sorry, the post is quite long.
Initia
20 matches
Mail list logo
