ngraham created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Makes `/usr/bin/plasmashell --version` the canonical source of truth for the
Plasma version. Resolves https://bugs.kde.org/show_bug.cgi?id=377
ivan updated this revision to Diff 13509.
ivan added a comment.
The combo box now has:
| Recently used |
| Often used|
Checkboxes are "recent"/"often used"
And the same for the text in the menu
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5378?vs=13283&id=13509
ivan added a comment.
p.s. As for the default behaviour, I would not make it the default just yet.
We need to test whether some things regarding scoring should be changed.
REVISION DETAIL
https://phabricator.kde.org/D5378
To: ivan, mart, hein
Cc: plasma-devel, spstarr, progwolff, lesliezha
anthonyfieroni added a reviewer: Plasma.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D5471
To: ngraham, #plasma
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
ltoscano added a comment.
I can't comment on the content of the patch, but I have a comment on the
titles and the summary.
The content of title+summary+test plan will become the git commit message, so
I would:
- change the title in a small summary of the change
- in the body of th
ngraham retitled this revision from
"https://bugs.kde.org/show_bug.cgi?id=377994"; to "Prefer `plasmashell
--version` to get Plasma version".
ngraham edited the summary of this revision.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D5471
To: ngraham, #plasma
Cc:
ngraham added a comment.
Thanks! I've implemented the requested changes.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D5471
To: ngraham, #plasma
Cc: ltoscano, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
sitter added a comment.
plasma.desktop is provided by us
https://cgit.kde.org/plasma-workspace.git/tree/plasma.desktop.cmake and set
programmatically to the very same version you'd get with --version. There's not
much to be done if distros mess this up.
I should think the solution to yo
fvogt added a comment.
I don't know why openSUSE started replacing the upstream plasma5 session file
with something that is basically an exact copy, I was not involved in the
process.
However, I also think that it is wrong and needs to be cleaned up.
I can only think of a single valid
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
Fine by me :)
You did forgot an "&" (making it by reference). On the other hand, this is a
POD type where performance wise this wouldn't matter at all.
REPOSITORY
R108 KWin
BRANCH
n
ngraham added a comment.
Gotcha. I'll contact the openSUSE KDE packagers and see what they have to say.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D5471
To: ngraham, #plasma
Cc: fvogt, sitter, ltoscano, plasma-devel, spstarr, progwolff, lesliezhai,
ali-moham
ngraham added a comment.
Started a mailing list thread and filed
https://bugzilla.opensuse.org/show_bug.cgi?id=1034345
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D5471
To: ngraham, #plasma
Cc: fvogt, sitter, ltoscano, plasma-devel, spstarr, progwolff, leslie
drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
QJsonArray::operator[] returns QJsonValueRef which seems to crash
when trying to convert to object.
Using QJsonArray::at() instead which ret
broulik added a comment.
What about `first()`? In contrast to QList et al it's safe in JSON (also
returns `QJsonValue`)
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D5478
To: drosca, #plasma
Cc: broulik, plasma-devel, spstarr, progwolff, lesliezhai, ali-moha
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R114 Plasma Addons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5478
To: drosca, #plasma, broulik
Cc: broulik, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterbe
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:bd07284ec84a: Fix crash in JSON traversal in Bing potd
provider (authored by drosca).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5478?vs=13518&id=13519
R
mart added a comment.
ok, so let's go with this.
REVISION DETAIL
https://phabricator.kde.org/D5378
To: ivan, mart, hein
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/718/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 17 Apr 2017 02:05:43 +
Build duration: 18 min
CHANGE SET
Revision e1378142dab571358e82526e5185bb3e26a3
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/121/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 17 Apr 2017 03:06:54 +
Build duration: 18 min
CHANGE SET
Revision 0448e66453ba98402839c15f3
19 matches
Mail list logo
