dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfiledialog_unittest.cpp:84
> +
> +QMimeType headerMime =
> QMimeDatabase().mimeTypeForName(QStringLiteral("text/x-chdr"));
> +QMimeType jsonM
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:2132b1e0c829: [effects] Use arg="true" in the kcfg files
(authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D3571?vs=8703&id=13452#toc
REPOSITORY
R108 KWin
CHANGES SINCE
elvisangelaccio added inline comments.
INLINE COMMENTS
> dfaure wrote in kfiledialog_unittest.cpp:84
> Why use QMimeDatabase, just to then use name()? You could just put
> "text/x-chdr" in the data row, no?
Leftover from the previous patch, yes doesn't make sense now.
> dfaure wrote in kfiledi
elvisangelaccio added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in qfiledialogtest.cpp:116
> ...or maybe we can turn the assert in a qWarning()? Otherwise if
> isMimeFilter() is false we get a name filter instead of a mimetype, a bit
> misleading?
The problem is that if `isMimeF
dfaure added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in kfiledialog_unittest.cpp:116
> No, selectedMimeTypeFilter() is only in 5.9 so that wouldn't compile
Oh I see. The QCOMPARE is just so that a failure happens. Pretty pointless,
it's not testing anything from Qt. I would jus
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
During pointer motion we already had the condition that an update of
focused pointer surface can only happen when no button is pressed.
subdiff added a comment.
Can somebody else (with better shell scripting skills than myself) take a
look as well?
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5250
To: jamesl, #plasma
Cc: subdiff, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreute
elvisangelaccio updated this revision to Diff 13457.
elvisangelaccio added a comment.
- Removed pointless QMimeDatabase usage in the test
- Only run unit test when building against 5.9
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricato
elvisangelaccio marked 3 inline comments as done.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D5446
To: elvisangelaccio, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, ap
elvisangelaccio edited the summary of this revision.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D5446
To: elvisangelaccio, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas,
markg added inline comments.
INLINE COMMENTS
> pointer_input.cpp:440
> +auto areButtonsPressed = [this] {
> +for (auto it = m_buttons.constBegin(), end = m_buttons.constEnd();
> it != end; it++) {
> +if (it.value() == InputRedirection::PointerButtonPressed) {
Just curiou
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
On Wayland it can happen that a window is still in the stacking order
although it is not visible. This is mostly the case for Plasma win
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
Imho, it looks a lot better! Nice job!
Don't push it just yet though. Wait for the VDG to chime in.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5424
T
anthonyfieroni added inline comments.
INLINE COMMENTS
> kdeplatformfiledialoghelper.h:64-67
> +#if QT_VERSION >= QT_VERSION_CHECK(5, 9, 0)
> +QString selectedMimeTypeFilter() const Q_DECL_OVERRIDE;
> +void selectMimeTypeFilter(const QString &filter) Q_DECL_OVERRIDE;
> +#endif
Better over
lueck updated this revision to Diff 13464.
lueck added a comment.
use phrase suggested by Fabian Vogt
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5445?vs=13423&id=13464
REVISION DETAIL
https://phabricator.kde.org/D5445
AFFECTED FILES
doc/kco
fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.
Looks good to me, thanks!
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5445
To: lueck, #plasma, #documentation, mart, fvogt
Cc: ltoscano, plasma-devel, sps
Marco Martin wrote:
>> Am I right that the argument `QFlags state` should simply be `State
>> state`?
>
> can you do a phab review about it?
Of course, but that seemed a bit overkill if this is an evident error, or if
ultimately the runtime behaviour remains the same.
I understand from a diago
yuenlim created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
A basic-ish nextcloud purpose plugin for use with quickshare. Uses the
owncloud kaccount provider (had a hoot of a time figuring that out!).
elvisangelaccio added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kdeplatformfiledialoghelper.h:64-67
> Better overrites them, then ifdef in implementation
Not possible, only QPlatformFileDialogHelper >= 5.9 has those methods.
REPOSITORY
R135 Integration for Qt applications in
graesslin added a subscriber: broulik.
graesslin added inline comments.
INLINE COMMENTS
> markg wrote in pointer_input.cpp:440
> Just curious, why do you define end as opposed tho this:
> for (auto it = m_buttons.constBegin(); it != m_buttons.constEnd(); it++) {
>
> }
>
> Another route you can
graesslin added a comment.
neat :-) Looking forward to use it
REPOSITORY
R495 Purpose Library
REVISION DETAIL
https://phabricator.kde.org/D5464
To: yuenlim, apol, #plasma
Cc: graesslin, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:12935c0ed304: update baloo kcm docbook (authored by
lueck).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5445?vs=13464&id=13473
REVISION DETAIL
https://
markg added inline comments.
INLINE COMMENTS
> graesslin wrote in pointer_input.cpp:440
> > Just curious, why do you define end as opposed tho this:
>
> Because @broulik tends to point out that it is not cached.
>
> > Another route you can go which looks much cleaner imho (requires Qt 5.7
> >
graesslin updated this revision to Diff 13474.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Use range-based for loop with qAsConst
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5461?vs=13456&id=13474
BRANCH
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/716/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 15 Apr 2017 15:49:47 +
Build duration: 21 min
CHANGE SET
Revision 12935c0ed304e7644c4062d65b26c5026064
mck182 added a comment.
While I like this, I wonder - for apps that will send "settings"
action there will now be no way to access the KNotification
settings, right (from the notification itself)? As in, the app can
use the "settings" action for an entirely different thing, thus
blockin
broulik added a comment.
if you use KNotifications you cannot influence the name of the action anyway,
it's just Action %1
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5424
To: broulik, #vdg, #plasma, markg
Cc: mck182, markg, plasma-devel, spstarr, progw
mck182 accepted this revision.
mck182 added a comment.
Ah, I see. Good to go then, unless you want to wait for VDG input.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5424
To: broulik, #vdg, #plasma, markg, mck182
Cc: mck182, markg, plasma-devel, spstarr,
Marco Martin wrote:
> can you do a phab review about it?
https://phabricator.kde.org/D5470
https://bugs.kde.org/show_bug.cgi?id=378823
Bug ID: 378823
Summary: EPOD POTD display header image instead of the real
photo
Product: Plasma Workspace Wallpapers
Version: 5.9.4
Platform: Archlinux Packages
O
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/717/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 16 Apr 2017 02:06:05 +
Build duration: 26 min
CHANGE SET
Revision 21153be000ce88e8f3fae862d0039f7e55b4
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/854/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 16 Apr 2017 02:06:20 +
Build duration: 24 min
CHANGE SET
Revision e38d186e8c8678659b1860f52d197a8940
32 matches
Mail list logo
