This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5dff3bc6869a: [Windowed Widgets Runner] Fix
mimeDataForMatch (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5257?vs=13005&id=13016
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This makes it easier to see what item the menu or popup is for.
In fact, the item should have stayed highlighted when the context menu is
op
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/104/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 31 Mar 2017 08:09:29 +
Build duration: 19 min
CHANGE SET
Revision 5dff3bc6869a14cd422d268
anthonyfieroni added inline comments.
INLINE COMMENTS
> Task.qml:107
>
> -tasks.createContextMenu(task).show();
> }
It's interesting to me, what's the problem here?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5260
To: broulik, #plasma
broulik added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in Task.qml:107
> It's interesting to me, what's the problem here?
The line per se is fine but I need to keep a reference to the contextMenu in
the `property QtObject contextMenu` or else the other places which do
`task.cont
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5256
To: broulik, #plasma, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a3a7b95f5f41: [Notifications] Port from ProcessRunner to
KCMShell.open and respect KIOSK… (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5260
To: broulik, #plasma, hein
Cc: anthonyfieroni, plasma-devel, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:72f5d68657af: [Task Manager] Keep entry highlighted when
context menu or group dialog is open (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kd
broulik closed this revision.
broulik added a comment.
Submitted as https://phabricator.kde.org/D5260 which was merged to master and
adjusted for changes (essentially becoming this patch)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5255
To: broulik, #plas
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/688/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 31 Mar 2017 09:25:56 +
Build duration: 8 min 25 sec
CHANGE SET
Revision 1f8050e174f7161f303d3d7839fafaf
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/103/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 31 Mar 2017 09:21:34 +
Build duration: 17 min
CHANGE SET
Revision 1f8050e174f7161f303d3d783
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Previously we updated the prop after checking for
AbstractTasksModel::IsDemandingAttention on window closure, but
as the window is gone, we can't actually get state for it anymore,
so we always nee
davidedmundson added inline comments.
INLINE COMMENTS
> subdiff wrote in drm_output.cpp:104
> Instead of dividing on every call, declare new private variable `QSize
> m_scaledSize = pixelSize() / scale()`, and update its value only when m_mode
> or the scale value is changed.
What benefit will
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
tested, works
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D5261
To: hein, #plasma, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-m
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:628593db4c65: Fix TasksModel.anyTaskDemandsAttention not
updating on window closure. (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D526
davidedmundson added a dependency: D3498: Add scaling to DRM backend.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3159
To: davidedmundson, graesslin, #plasma
Cc: broulik, graesslin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
davidedmundson added dependent revisions: D3159: Set wayland output scale,
D3494: Set m_client size in global compositor co-ordinates.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3498
To: davidedmundson, graesslin, subdiff, #plasma
Cc: subdiff, #kwin, plasma-devel, kwi
davidedmundson added a dependency: D3498: Add scaling to DRM backend.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3494
To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/105/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 31 Mar 2017 10:34:41 +
Build duration: 15 min
CHANGE SET
Revision 628593db4c65560ace95759
subdiff added inline comments.
INLINE COMMENTS
> davidedmundson wrote in drm_output.cpp:104
> What benefit will that have?
geometry() is called several times per frame. We can optimize here when we
don't do the division every time (maybe the compiler already does the saving, I
don't know).
Al
davidedmundson added inline comments.
INLINE COMMENTS
> subdiff wrote in drm_output.cpp:104
> geometry() is called several times per frame. We can optimize here when we
> don't do the division every time (maybe the compiler already does the saving,
> I don't know).
>
> Also this way we can mak
subdiff added inline comments.
INLINE COMMENTS
> davidedmundson wrote in drm_output.cpp:104
> It's good design to not have member variables that can ever be in a corrupt
> state, it reduces chance for bugs being introduced later, which is why I'm
> against changing it.
>
> Dividing two integer
broulik created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
When quick tiling animate the outline from the window geometry to the
position it would have afterwards.
This provides a visual hint to f
broulik edited the test plan for this revision.
broulik added a reviewer: VDG.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5262
To: broulik, #plasma, #kwin, #vdg
Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening,
jensreuterberg, abetts, sebas, apol
graesslin added inline comments.
INLINE COMMENTS
> geometry.cpp:3257
> if (maximizing)
> -outline()->show(electricBorderMaximizeGeometry(Cursor::pos(),
> desktop()));
> +outline()->show(electricBorderMaximizeGeometry(Cursor::pos(),
> desktop()), geometry());
> else
I'
graesslin added a dependent revision: D5263: Add callback functionality for
touch screen swipe gestures.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5252
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening,
jensreuterber
graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This is implemented through QActions following the general approach
inside KWin and not the older approach used by ScreenEdges for pointer
graesslin added a dependency: D5252: Introduce dedicated actions for touch
screen swipe gestures.
REVISION DETAIL
https://phabricator.kde.org/D5263
To: graesslin, #kwin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
Aiix created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Ref https://phabricator.kde.org/T5797
Amarok Player via Voice Commands, Play, Pause, Next, Previous Song
Integration for Mycroft.
TEST PLAN
This revision was automatically updated to reflect the committed changes.
Closed by commit R846:081368e4453e: Amarok Player Integration For Mycroft
(authored by Aiix).
REPOSITORY
R846 Mycroft Plasma integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5264?vs=13026&id=13027
RE
graesslin added a comment.
Just wondering: why dedicated to amarok instead of interacting with mpris?
That would allow to control any media player instead of just amarok.
REPOSITORY
R846 Mycroft Plasma integration
REVISION DETAIL
https://phabricator.kde.org/D5264
To: Aiix
Cc: graesslin,
Aiix added a comment.
In https://phabricator.kde.org/D5264#99248, @graesslin wrote:
> Just wondering: why dedicated to amarok instead of interacting with mpris?
That would allow to control any media player instead of just amarok
Amarok is the first implementation of interacting o
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5221
To: broulik, #plasma, hein, elvisangelaccio, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/689/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 01 Apr 2017 02:07:48 +
Build duration: 7 min 5 sec
CHANGE SET
Revision 7ce9bda5509d0ff2027ee8ef581da3e
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/104/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 01 Apr 2017 03:13:37 +
Build duration: 6 min 10 sec
CHANGE SET
Revision 417ca40011b694ddafe
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/106/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 01 Apr 2017 03:13:57 +
Build duration: 15 min
CHANGE SET
Revision 3468d970dbebf9892a3b164
37 matches
Mail list logo
