dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kio_desktop.cpp:171
> +// Set a descriptive display name for the root item
> +if (entry.stringValue(KIO::UDSEntry::UDS_NAME) == QLatin1String(".")) {
>
marten added a comment.
I'd done some porting away from kdelibs4 in this change, in particular
KMimeType -> QMime* but realized that it was getting a bit involved and would
be mixing up two unrelated changes (involving about 30 files for the whole of
kio-extras) . So I'll submit a separate
broulik updated this revision to Diff 12946.
broulik added a comment.
- Check for requested url path being "/"
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5221?vs=12919&id=12946
REVISION DETAIL
https://phabricator.kde.org/D5221
AFFECTED FILE
broulik edited the test plan for this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5221
To: broulik, #plasma, hein, elvisangelaccio, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This makes it consistent with Dolphin which, when cd'ing into a folder on
desktop:/ actually opens /home/foo/Desktop/path (the target URL set
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
I'm not super happy with the label thing though ... does it at least still
work correctly when Desktop is in Places?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4939
To: denisshienkov, volkov, afiestas, broulik, graesslin, davidedmundson, #plasma
Cc: graesslin, davidedmundson, broulik, plasma
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5216
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas,
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
interactive-selection-touch
REVISION DETAIL
https://phabricator.kde.org/D5203
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, progwolff, lesliezhai, al
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D5169
To: rthomsen, #plasma, elvisangelaccio, davidedmundson
Cc: cfeck, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuter
broulik added a comment.
> does it at least still work correctly when Desktop is in Places?
If you place a /home/foo/Desktop folder in places, it works fine, not with
desktop:/ (which isn't user-accessible from Dolphin unless you enter the URL
manually anyway)
REPOSITORY
R119 Plasma D
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
plasmawindowed didn't set any minimum size to its window,
so it could be resized unusably small.
it tried to find its attached Layout, but the
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:8d42e0072f46: [ModelContextMenu] Use Instantiator instead
of Repeater-and-reparent-hack (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabrica
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7e84eb6786eb: [Widget Explorer] Better align add widgets
menu (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5216?vs=12912&id=12951
R
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/685/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 29 Mar 2017 10:14:01 +
Build duration: 16 min
CHANGE SET
Revision 7e84eb6786ebd5bbfee1bbf95779b23f7a09
mart updated this revision to Diff 12952.
mart added a comment.
- access switchSize in minimumWidthChanged
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5235?vs=12949&id=12952
BRANCH
phab/plasmawindowed
REVISION DETAIL
https://phabricator.kd
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
I would prefer if this IMHO useless warning gets disabled.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5232
To: apol, #plasma, graesslin, davidedm
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
slidingpopups-no-unconditional-grab-unset-5.9
REVISION DETAIL
https://phabricator.kde.org/D5225
To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-
apol abandoned this revision.
apol added a comment.
In https://phabricator.kde.org/D5232#98689, @graesslin wrote:
> I would prefer if this IMHO useless warning gets disabled.
`override` adds useful semantics to your code, that's never useless.
Oh well...
REPOSITORY
R108 KWi
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
Not super pretty, especially emitting min size changed on every resize event
but works nicely.
REPOSITORY
R120 Plasma Workspace
BRANCH
phab/plasmawindowed
REVISION DETAIL
https://
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The former is deprecated and just returns uiDelegate() inside anyway.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e20f155190ac: Setting a sensible minimum size for
plasmawindowed (authored by mart).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5235?vs=12952&id=12957
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5236
To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
hein added a comment.
Make sure this really doesn't need a nullptr check though.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5236
To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/686/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 29 Mar 2017 12:14:35 +
Build duration: 6 min 15 sec
CHANGE SET
Revision 5a7b6860ff75d6a82a902aa63d27a2
broulik added a comment.
From KIOCore Job:
// Exists for historical reasons only
KJobUiDelegate *Job::ui() const
{
return uiDelegate();
}
so it shouldn't make any difference.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5236
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7d49b8ed2c8f: [Folder View] Port from deprecated ui() to
uiDelegate() (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5236?vs=12956&id=
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Forward plasmoid status to the SNI and when the applet changes its title or
icon update it.
TEST PLAN
Ran `plasmawindowed org.kde.plasma.me
broulik edited the test plan for this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5238
To: broulik, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5238
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Applets might populate the menu only on demand.
TEST PLAN
Right clicking now shows actions properly in media controller
REPOSITORY
R120 P
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d9d4737b3f54: [Plasma Windowed] Forward plasmoid status
to SNI and update title and icon live (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/687/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 29 Mar 2017 12:50:41 +
Build duration: 26 min
CHANGE SET
Revision 7d49b8ed2c8f65290c24bc2a8554e01955f5
ivanthekdefan added a comment.
In https://phabricator.kde.org/D5189#98557, @lueck wrote:
> Please readd the screenshots using the default design (
https://l10n.kde.org/docs/screenshots.php )
>
> Thanks
I have implemented most of your suggestions. I will be on the mailing list
leinir created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
If this code is the other way around, as the comment says, because of the
direct connect nature of same-thread signal/slot connection, we may e
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
- support one sni per applet
- fix commandline parsing when the process is already running
(--statusnotifier paramenter was breaking parsing)
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:785d85f3fe5a: Make the archiver KIOslave extensible
(authored by marten).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5112?vs=12896&id=12972#toc
REPOSITORY
R320 KIO Extras
CHANGES SINCE
graesslin added a comment.
In https://phabricator.kde.org/D5232#98698, @apol wrote:
> In https://phabricator.kde.org/D5232#98689, @graesslin wrote:
>
> > I would prefer if this IMHO useless warning gets disabled.
>
>
> `override` adds useful semantics to your code, that's never u
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
if the user code did something like
IconItem {
implicitWidth: 32
implicitHeight: 32
}
then never auto
davidedmundson added inline comments.
INLINE COMMENTS
> iconitem.cpp:89
> {
> +if (m_implicitHeightSetByUser) return;
> if (!m_imageIcon.isNull()) {
this line seems leftover from something?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D52
mart updated this revision to Diff 12975.
mart added a comment.
- remove leftover
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5243?vs=12974&id=12975
BRANCH
phab/implicitSize
REVISION DETAIL
https://phabricator.kde.org/D5243
AFFE
mart updated this revision to Diff 12977.
mart marked an inline comment as done.
mart added a comment.
- use q_revision
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5243?vs=12975&id=12977
BRANCH
phab/implicitSize
REVISION DETAIL
h
mart updated this revision to Diff 12978.
mart added a comment.
- revisions not useful here
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5243?vs=12977&id=12978
BRANCH
phab/implicitSize
REVISION DETAIL
https://phabricator.kde.org/D
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c24ae6602b0d: Connect aboutToHide signal from QMenu to
relevant libdbusmenu-qt slot (authored by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/103/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 29 Mar 2017 15:35:58 +
Build duration: 14 min
CHANGE SET
Revision c24ae6602b0d01cb629e17c
broulik created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
When an application is not responding, its window is desaturated to
communicate this. Also "(Not Responding)" is added to the title bar.
T
broulik updated this revision to Diff 12983.
broulik added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- Fix couple of typos and remove debug
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5245?vs=12981&id=12983
REVISION DET
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Please adjust the autotests/test_*_effectloader.cpp - they would fail as you
added an effect. Also please try running all autotests, we have some tests for
the kill timeout,
kvermette added a comment.
My only concern is that many windows with the Breeze style have very little
colour, some (like Kate) might not see the effect be distinguishable at all.
Should we perhaps consider using an overlay colour selected from the colour
scheme which we know will stand out?
https://bugs.kde.org/show_bug.cgi?id=363147
--- Comment #7 from Dominik Haumann ---
@James: You have to create a patch at phabricator.kde.org (make an account at
identity.kde.org first). Then, you patch is much more visible to developers.
--
You are receiving this mail because:
You are the assi
https://bugs.kde.org/show_bug.cgi?id=363147
--- Comment #8 from James Lee ---
Dominik, I tried, but due to the binary data in this patch, it was too large
for Phabricator, by an order of magnitude.
--
You are receiving this mail because:
You are the assignee for the bug.
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When dropping a color code from an text editor, try to figure out the color
and add it to the history.
TEST PLAN
Dragged a couple of color
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
When using a regular JavaScript Array as model and omitting certain roles
(e.g. not having a "text" for a separator) it
apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> plasmawindowedcorona.cpp:64
> v->show();
> -
> +qWarning()<<"AA"< KConfigGroup appletsGroup(KSharedConfig::openConfig(), "Applets");
!
> plasmawind
nowicki created this revision.
nowicki added a project: KWin.
Restricted Application edited projects, added Plasma; removed KWin.
Restricted Application added a subscriber: KWin.
REVISION SUMMARY
I have been using my laptop to display content on a projector and sometimes I
have encountered some
https://bugs.kde.org/show_bug.cgi?id=363147
Christoph Feck changed:
What|Removed |Added
Resolution|--- |DUPLICATE
Status|UNCONFIRMED
https://bugs.kde.org/show_bug.cgi?id=348603
Christoph Feck changed:
What|Removed |Added
CC||ja...@james.tl
--- Comment #4 from Christoph F
graesslin added a comment.
In https://phabricator.kde.org/D5245#98866, @kvermette wrote:
> My only concern is that many windows with the Breeze style have very little
colour, some (like Kate) might not see the effect be distinguishable at all.
Should we perhaps consider using an overlay
luebking added a comment.
In https://phabricator.kde.org/D5245#98917, @graesslin wrote:
> This is something we do not know. We do not know what color scheme the
window uses. Given that a desaturation is probably the best we can do.
Lower brightness?
REPOSITORY
R108 KWin
REVISI
graesslin added a comment.
I think the effect system is the wrong place for it - at least if we want to
add it to KWin directly. The transformation should be done directly in the
Scene.
INLINE COMMENTS
> projector.cpp:101-126
> +if (m_cursorTexture && m_cursorVisible) {
> +QPoin
https://bugs.kde.org/show_bug.cgi?id=363147
--- Comment #10 from James Lee ---
So that's how it's going to be. Guess I won't be contributing to KDE anymore.
--
You are receiving this mail because:
You are the assignee for the bug.
nowicki added a comment.
In https://phabricator.kde.org/D5249#98921, @graesslin wrote:
> I think the effect system is the wrong place for it - at least if we want
to add it to KWin directly. The transformation should be done directly in the
Scene.
I have done it this way initiall
broulik added a comment.
> Lower brightness?
I actually increase the brightness to produce this washed-out effect but
admittedly it doesn't look as good in less graphically intensive apps (I used
Gwenview in the screenshot where you can tell easily but in Kwrite you probably
can't). I'l
https://bugs.kde.org/show_bug.cgi?id=363147
andreas.sturmlech...@gmail.com changed:
What|Removed |Added
CC||andreas.sturmlechner@gmail.
https://bugs.kde.org/show_bug.cgi?id=363147
--- Comment #12 from James Lee ---
Created attachment 104804
--> https://bugs.kde.org/attachment.cgi?id=104804&action=edit
Phabricator Error on Patch Upload
I literally can't upload this patch to Phabricator. Because it contains new
sizes of the cur
luebking added a comment.
ftr, not sure about --transform correctnes, but metamodes
ViewportIn/ViewportOut work flawless on at least the nvidia blob.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5249
To: nowicki, #plasma, graesslin
Cc: luebking, kwin, plasma-devel,
https://bugs.kde.org/show_bug.cgi?id=363147
--- Comment #13 from andreas.sturmlech...@gmail.com ---
I can see where the web interface would limit you like that, but that shouldn't
happen if you had a clone of the repository, worked in a branch and submitted
your diff using arcanist.
Seems like ht
broulik marked 2 inline comments as done.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5245
To: broulik, #plasma, #kwin, #vdg, graesslin
Cc: luebking, kvermette, graesslin, plasma-devel, kwin, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f81c73b8e25b: Drop remote ioslave, which is now in KIO
5.32 (authored by elvisangelaccio).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3531?vs=11556&id=
broulik updated this revision to Diff 12992.
broulik edited the test plan for this revision.
broulik added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
- Base frozenapp effect on dialogparent code, this fixes minimizing of frozen
windows and also switching des
jamesl created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Breeze ships with 24 and 48 px cursors, and recently added 36 px in
https://phabricator.kde.org/D4358. However, with modern screen resolution
https://bugs.kde.org/show_bug.cgi?id=363147
--- Comment #14 from James Lee ---
For what it's worth, this page
https://community.kde.org/Infrastructure/Github_Mirror, and probably
Phabricator, didn't exist when I submitted this bug report and patch.
I tried uploading the patch with Arcanist and i
jamesl added a comment.
This is what you should see when you run the build script:
> ./build.sh
Checking requirements... DONE
Preprocessing cursor configs... DONE
Generating Breeze...
Making folders... DONE
Generating simple cursor pixmaps... DONE
Generating
fredrik added a comment.
In https://phabricator.kde.org/D5245#98926, @broulik wrote:
> > Lower brightness?
>
> I actually increase the brightness to produce this washed-out effect but
admittedly it doesn't look as good in less graphically intensive apps (I used
Gwenview in the screen
https://bugs.kde.org/show_bug.cgi?id=363147
Christoph Feck changed:
What|Removed |Added
Resolution|DUPLICATE |---
Status|RESOLVED
subdiff added a comment.
Script looks very nice! I will test run it tomorrow. One thing we have to
keep in mind when adding additional cursor sizes is the automatic (resolution
dependent) cursor size mode. Adding many sizes with small differences could
make the chosen size ambiguous or the a
subdiff added a reviewer: Plasma.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5250
To: jamesl, #plasma
Cc: subdiff, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
jamesl updated this revision to Diff 12997.
jamesl added a comment.
cursor build.sh: Remove execute bit; add 36 px size
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5250?vs=12994&id=12997
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5250
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The new touch gestures activated for the same actions as configured for
mouse pointer actions. This has disadvantages as the only config
denisshienkov added a comment.
Who can do push this patch? As I have not rigths and have not a developer
account.
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4939
To: denisshienkov, volkov, afiestas, broulik, graesslin, davidedmundson, #plasma
Cc: graesslin,
80 matches
Mail list logo
