D4508: Plasma controls based on QtQuickControls2

This revision was automatically updated to reflect the committed changes. Closed by commit R242:76af5399dd95: Plasma controls based on QtQuickControls2 (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4508?vs=11960&id=12454

D5034: Add support for x-gvfs style options in fstab

broulik added inline comments. INLINE COMMENTS > broulik wrote in fstabdevice.cpp:40-41 > I wondered that too, that's in the original patch, though, didn't really look > into where this will end up, though :D Just checked, this way round it makes more sense. The vendor will be the host name an

D5034: Add support for x-gvfs style options in fstab

broulik updated this revision to Diff 12456. broulik edited the summary of this revision. broulik added a comment. - Use QStringRef - Drop swap of vendor/product, this will be done in a separate patch REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5034?vs=1

D5034: Add support for x-gvfs style options in fstab

broulik updated this revision to Diff 12457. broulik added a comment. - Cache mountOptions or else it falls out of scope and QStringRef crashes (now I know why I should cache it :D) REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5034?vs=12456&id=12457 REVIS

D4969: open applet handles when the toolbox is open

mart added a comment. In https://phabricator.kde.org/D4969#93430, @davidedmundson wrote: > Can we re-use isUserConfiguring? i don't think so, because isUserConfiguring means the config dialog is open. at most, i would move it in an extra property in the root item REPOSITORY R11

D5012: Delay notifications until desktop session has loaded

vpilo added reviewers: graesslin, dfaure, davidedmundson, broulik, mck182. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo, #plasma, #plasma_workspaces, graesslin, dfaure, davidedmundson, broulik, mck182 Cc: graesslin, dfaure, davidedmundson, bro

D4799: Delay notifications until desktop session has loaded

vpilo added reviewers: davidedmundson, dfaure, broulik, graesslin, mck182. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, graesslin, mck182 Cc: plasma-devel, davidedmundson, dfaure, br

D5036: UI fixes for logout dialog

mart added inline comments. INLINE COMMENTS > broulik wrote in shutdowndlg.cpp:200 > From what I can tell KWin doesn't support different background contrasts, ie. > once you click Leave you'll change your Panel background contrast. > > Bhushan experienced the same when running a plasmoid in pla

D5036: UI fixes for logout dialog

mart added a comment. In https://phabricator.kde.org/D5036#94741, @broulik wrote: > Background is quite dark for me now :/ eh, the problem was mainly that there wasn't enough contrast. i agree that it looks a bit dark, but if the priority is to ensure the text pops out, it kinda

D5036: UI fixes for logout dialog

mart updated this revision to Diff 12459. mart added a comment. - adress comments - panel contrast still altered, probably a bug in the effect REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5036?vs=12437&id=12459 BRANCH phab/logoutpretty REVI

D4989: more aggressively repaint when the shadow changes

mart added inline comments. INLINE COMMENTS > graesslin wrote in toplevel.cpp:325 > We do have the repaints already. Check the dirtyRect and the following > addLayerRepaint. > > Instead of adding a new call lets fix it. isn't dirtyrect only the new decoration geometry, while oldvisiblerect the

D4969: open applet handles when the toolbox is open

mart added a comment. tested it more, and this is normal, even with the old way. I don't think there is much that can be done in general, because when the applet changes containment, its appletappearance (and its mouseeventlistener used to drag ght thing around) gets deleted, and the applet

D4974: add packagestructure for KWin/Decoration

mart updated this revision to Diff 12462. mart added a comment. Restricted Application edited projects, added Plasma; removed KWin. add packagestructure for KWin/Decoration use a KPackage/PackageStructure for aurorae themes as well Patch by Demitrius Belai REPOSITORY R108 KWin CHA

D4974: add packagestructure for KWin/Decoration

mart added a comment. err sorry, it's the correct patch now REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4974 To: mart, #plasma Cc: graesslin, plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4989: more aggressively repaint when the shadow changes

mart added inline comments. INLINE COMMENTS > anthonyfieroni wrote in toplevel.cpp:337 > About me, rectangle should not be translated to pos, cause it does not > contain shadow (who stays not updated) shadow()->shadowRegion().boundingRect() is a rectangle always in relative coorninates from th

D4989: more aggressively repaint when the shadow changes

mart updated this revision to Diff 12463. mart added a comment. Restricted Application edited projects, added Plasma; removed KWin. try to unite old and new rects REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4989?vs=12328&id=12463 BRANCH arcpatch-D4989 R

D4989: more aggressively repaint when the shadow changes

mart added inline comments. INLINE COMMENTS > graesslin wrote in toplevel.cpp:325 > We do have the repaints already. Check the dirtyRect and the following > addLayerRepaint. > > Instead of adding a new call lets fix it. you mean something like this? REPOSITORY R108 KWin REVISION DETAIL h

D5045: new logout effect

mart created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY new logout effect: it's just a slow fade in of the logout greeter (window is usable immediately tough TEST PLAN logout greeter now f

D5046: UI feedback when checking for updates

leinir created this revision. leinir added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This provides some very light user feedback when the update check has not been completed. It

D5048: store contrast matrix per-window

mart created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY as different windows can have different contrast region parameters, store color matrices per window TEST PLAN logout window doesn't

D5050: Increase the margins in ActionButtons

apol created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY See https://phabricator.kde.org/M93/300/ REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D5050 AFFE

D5050: Increase the margins in ActionButtons

apol added a comment. F2805868: Spectacle.y23669.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D5050 To: apol, #kirigami Cc: plasma-devel, apol

D5048: store contrast matrix per-window

broulik added a comment. BUG: 339237 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5048 To: mart, #plasma, graesslin Cc: broulik, plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

D5045: new logout effect

broulik added inline comments. INLINE COMMENTS > main.js:24 > +var logoutEffect = { > +duration: animationTime(800), > +isLogoutWindow: function (window) { Connect to configurationChanged and update that time then (done in all other effects) REPOSITORY R108 KWin REVISION DETAIL ht

D5045: new logout effect

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. When adding a new effect the auto tests for the effect loader need to be adjusted as otherwise it fails because it finds effects it doesn't know of. REPOSITORY R108 KWin

D5045: new logout effect

graesslin added a comment. Please do not delete the shaders! They are still used by the blur effect for cheap fullscreen blur! INLINE COMMENTS > main.js:28 > +var windowClass = window.windowClass; > +if (windowClass === "ksmserver ksmserver") { > +return true; is

D5048: store contrast matrix per-window

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Looks ok to me. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D5048 To: mart, #plasma, graesslin Cc: broulik, plasma-devel, kwin, #kwin, progw

D4989: more aggressively repaint when the shadow changes

graesslin added inline comments. INLINE COMMENTS > mart wrote in toplevel.cpp:325 > you mean something like this? yeah, though we kind of already had this. We have the old shadow region in the dirtyRect (line 326) and in line 332 we combine it with the new shadow rect. Your change only result

D4974: add packagestructure for KWin/Decoration

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH phab/auroraestructure REVISION DETAIL https://phabricator.kde.org/D4974 To: mart, #plasma, graesslin Cc: graesslin, plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed,

D4806: [greeter] Send the auth result through the server instead return value

graesslin added a comment. ping! This is security relevant code. I don't want to push without anybody looking at it! REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4806 To: graesslin, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterber

D5012: Delay notifications until desktop session has loaded

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo, #plasma, #plasma_workspaces, graesslin, dfaure, davidedmundson, broulik, mck182 Cc: graesslin, dfaure, davide

D5034: Add support for x-gvfs style options in fstab

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. The patch looks good to me (without testing this locally here). I think the one QStringRef can be turned by to QStringList, since you finally need the QString anyways it seems... INLIN

D4939: Get rid of KDELibs4Support

denisshienkov updated this revision to Diff 12475. denisshienkov edited the summary of this revision. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4939?vs=12250&id=12475 REVISION DETAIL https://phabricator.kde.org/D4939 AFFECTED FILES CMakeLists.txt daemon/CMakeLists.txt daem

D4939: Get rid of KDELibs4Support

denisshienkov updated this revision to Diff 12476. denisshienkov edited the summary of this revision. denisshienkov set the repository for this revision to R122 Powerdevil. REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4939?vs=12475&id=12476 REVISION DETAI

D4939: Get rid of KDELibs4Support

denisshienkov marked an inline comment as done. denisshienkov added inline comments. INLINE COMMENTS > volkov wrote in CMakeLists.txt:111 > Copy them here. Are you sure that I need to copy a files as kf5_org.freedesktop.PowerManagement.xml and kf5_org.freedesktop.PowerManagement.Inhibit.xml f

D5025: Do not use fixed steps when scrolling on battery icon

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH batteryscroll REVISION DETAIL https://phabricator.kde.org/D5025 To: fvogt, #plasma, broulik Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts

D5025: Do not use fixed steps when scrolling on battery icon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:82a44a3f264c: Do not use fixed steps when scrolling on battery icon (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5025?vs=12405&id=12

D5053: Fix terminology: use Plasma for the desktop

ltoscano created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use Plasma when the sentence refers to the desktop. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.

D5053: Fix terminology: use Plasma for the desktop

ltoscano added a comment. I'm not sure whether this is really about Plasma startup, or some modules work even when kded5 is started outside Plasma. I'm a bit lost about the current status. Otherwise I would have pushed the change directly. REPOSITORY R119 Plasma Desktop REVISION DETA

D5053: Fix terminology: use Plasma for the desktop

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D5053 To: ltoscano, apol Cc: apol, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensre

D5054: Make sure clock in lock screen is displayed within screen

xuetianweng created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY On certian screen setup, e.g. 2560x1440 with scale factor 2, the clock text will be displayed outside the screen. This change make the clock align with the top of the screen instead of use mar

D4996: Fix invalid reference of toolTipArea.

xuetianweng added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4996 To: xuetianweng, hein, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5054: Make sure clock in lock screen is displayed within screen

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I recently fixed this in master. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5054 To: xuetianweng, #plasma, graesslin Cc: graesslin, p