Re: Plasmoid's TextField on Panel?

2017-03-02 Thread Marco Martin
On Thursday 02 March 2017 05:35:02 Zoltan Gyarmati wrote: > Dear All, > > I'm developing a simple plasmoid which has a few TextFields (imported > from org.kde.plasma.components 2.0) on it. When i add the plasmoid to > the desktop or run it with plasmawindowed the TextField accepts the > keyboard i

D4851: Implement FadingMaterial frag/vert shaders on core profile

2017-03-02 Thread Marco Martin
mart accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR242 Plasma Framework (Library)BRANCHmasterREVISION DETAILhttps://phabricator.kde.org/D4851EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: davidedmundson, Plasma, mar

D4837: Applet: Make volume indicator icon bigger

2017-03-02 Thread David Rosca
This revision was automatically updated to reflect the committed changes.Closed by commit R115:7b6c94185164: Applet: Make volume indicator icon bigger (authored by drosca). View RevisionREPOSITORYR115 Plasma Audio Volume AppletCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D4837?vs=11935&id=1

D4843: PulseObject: Also use "media.icon_name" for icon

2017-03-02 Thread David Rosca
This revision was automatically updated to reflect the committed changes.Closed by commit R115:1966f954cf0a: PulseObject: Also use "device.icon_name" for icon (authored by drosca). View RevisionREPOSITORYR115 Plasma Audio Volume AppletCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D4843?vs=11

[Diff] D4848: Split frag and vert code of FadingNode into separate files

2017-03-02 Thread Marco Martin
mart accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR242 Plasma Framework (Library)REVISION DETAILhttps://phabricator.kde.org/D4848EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: davidedmundson, Plasma, martCc: mart, b

Re: [KDE4] what component does the screenlocking?

2017-03-02 Thread René J . V . Bertin
On Thursday March 2 2017 10:31:54 Duncan wrote: >others will still have those one or two X-based apps they want/need to >continue to run on a modern Linux/Wayland-based desktop a decade, even >two, from now. If you have picked up the clamour not so long ago when a rumour made the rounds that r

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 647 - Still Unstable!

2017-03-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/647/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 02 Mar 2017 11:04:26 + Build duration: 29 min CHANGE SET Revision e5378ca2efc90a128e6cc1e5cef8afa973d8

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 86 - Still Unstable!

2017-03-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 02 Mar 2017 11:12:36 + Build duration: 27 min CHANGE SET Revision d34275c934ed465557918578ea

D4879: notifications: Correctly display the file in jobs

2017-03-02 Thread Marco Martin
mart added a comment. View Revision In D4879#91664, @xuetianweng wrote: (If not, ship this. it seems fine) Label0 is also used elsewhere. We could add another value to engine though, not sure if worth it. it's used in the job delegate and as an error message when the transfer fails. maybe having

[Diff] D4887: [Folder View] Support undo keyboard shortcut

2017-03-02 Thread Kai Uwe Broulik
broulik added a comment. View RevisionHold on, crashes when I undo without being able to undo.REPOSITORYR119 Plasma DesktopREVISION DETAILhttps://phabricator.kde.org/D4887EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: broulik, Plasma, heinCc: plasma-devel, progwolf

D4887: [Folder View] Support undo keyboard shortcut

2017-03-02 Thread Kai Uwe Broulik
broulik added reviewers: Plasma, hein. View RevisionREPOSITORYR119 Plasma DesktopREVISION DETAILhttps://phabricator.kde.org/D4887EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: broulik, Plasma, heinCc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D4870: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Marco Martin
mart added a comment. View Revisionthis makes the virtual keyboard always enabled on every system tough?REPOSITORYR120 Plasma WorkspaceREVISION DETAILhttps://phabricator.kde.org/D4870EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: graesslin, PlasmaCc: mart, plasma-d

[Diff] D4870: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Marco Martin
mart added a dependent revision: D4889: [lookandfeel] Add virtual keyboard to the LockScreen. View RevisionREPOSITORYR120 Plasma WorkspaceREVISION DETAILhttps://phabricator.kde.org/D4870EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: graesslin, PlasmaCc: mart, plasm

D3697: Fix progress bar color

2017-03-02 Thread Anton Anikin
antonanikin updated this revision to Diff 12053.antonanikin added a comment.Restricted Application added a project: Plasma.Restricted Application added a subscriber: plasma-devel. View Revision Use QPalette::HighlightedText instead QPalette::Window REPOSITORYR31 BreezeCHANGES SINCE LAST UPDATEhttps

[Diff] D4887: [Folder View] Support undo keyboard shortcut

2017-03-02 Thread Kai Uwe Broulik
broulik updated this revision to Diff 12056.broulik added a comment. View Revision Don't crash if we cannot undo (trigger() apparently doesn't check enabled()) REPOSITORYR119 Plasma DesktopCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D4887?vs=12055&id=12056REVISION DETAILhttps://phabricator

D4870: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Marco Martin
mart added a dependent revision: D4892: [lookandfeel] Add virtual keyboard to the LockScreen. View RevisionREPOSITORYR120 Plasma WorkspaceREVISION DETAILhttps://phabricator.kde.org/D4870EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: graesslin, PlasmaCc: mart, plasm

D4891: Port away from setRoleNames where easily possible

2017-03-02 Thread Kai Uwe Broulik
broulik created this revision.Restricted Application added projects: Plasma, Frameworks.Restricted Application added subscribers: Frameworks, plasma-devel. View RevisionREVISION SUMMARYIt is deprecated. Instead re-implement roleNames(). Done in places where only static roles were used.TEST PLANStil

D4870: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Marco Martin
mart added a dependent revision: D4890: [lookandfeel] Add virtual keyboard to the LockScreen. View RevisionREPOSITORYR120 Plasma WorkspaceREVISION DETAILhttps://phabricator.kde.org/D4870EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: graesslin, PlasmaCc: mart, plasm

[Diff] D4870: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Marco Martin
mart added a dependent revision: D4893: Layout and animations on the on screen keyboard. View RevisionREPOSITORYR120 Plasma WorkspaceREVISION DETAILhttps://phabricator.kde.org/D4870EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: graesslin, PlasmaCc: mart, plasma-dev

D4893: Layout and animations on the on screen keyboard

2017-03-02 Thread Marco Martin
mart created this revision.Restricted Application added a project: Plasma.Restricted Application added a subscriber: plasma-devel. View RevisionREVISION SUMMARYuse a state machine to define in a cleaner way the layout of the lock screen when the keyboard is open on closed. animate between the state

[Diff] D4890: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Marco Martin
mart created this revision.mart added a project: Plasma. View RevisionREVISION SUMMARYThis change integrates QtVirtualKeyboard into the Lock screen UI. A new button is added to the bottom row to toggle the appearance of the virtual keyboard. The actual keyboard is integrated through a Loader so th

[Diff] D4892: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Marco Martin
mart created this revision.mart added a project: Plasma. View RevisionREVISION SUMMARYThis change integrates QtVirtualKeyboard into the Lock screen UI. A new button is added to the bottom row to toggle the appearance of the virtual keyboard. The actual keyboard is integrated through a Loader so th

D4875: Fix actions overlay position not adjusting when switching view modes at runtime.

2017-03-02 Thread Marco Martin
mart accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR119 Plasma DesktopBRANCHmehREVISION DETAILhttps://phabricator.kde.org/D4875EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: hein, Plasma, broulik, martCc: plasma-deve

D4874: Fix hover out when exiting visible frame.

2017-03-02 Thread Kai Uwe Broulik
broulik accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR119 Plasma DesktopBRANCHmehREVISION DETAILhttps://phabricator.kde.org/D4874EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: hein, Plasma, broulik, martCc: plasma-d

D4871: Enable qtvirtualkeyboard QT_IM_MODULE for greeter

2017-03-02 Thread Marco Martin
mart accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR133 KScreenLockerBRANCHqtvirtualkeyboardREVISION DETAILhttps://phabricator.kde.org/D4871EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: graesslin, Plasma, martCc: pl

[Diff] D4893: Layout and animations on the on screen keyboard

2017-03-02 Thread Marco Martin
mart added a comment. View Revisionin action https://www.youtube.com/watch?v=UEHckh8PeccREPOSITORYR120 Plasma WorkspaceREVISION DETAILhttps://phabricator.kde.org/D4893EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: mart, Plasma, graesslinCc: plasma-devel, progwolff,

D4889: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Marco Martin
mart created this revision.mart added a project: Plasma. View RevisionREVISION SUMMARYThis change integrates QtVirtualKeyboard into the Lock screen UI. A new button is added to the bottom row to toggle the appearance of the virtual keyboard. The actual keyboard is integrated through a Loader so th

D4870: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Marco Martin
mart added inline comments. View RevisionINLINE COMMENTSView InlineLockScreenUi.qml:128 ColumnLayout { anchors.fill: parent I would prefer not to have this layout, or can be also tried alternatively, just a Column (which doesn't resize its children) i would add a state machine

D4886: [Folder View] Offer "Empty Trash" also for trash link

2017-03-02 Thread Kai Uwe Broulik
broulik created this revision.Restricted Application added a project: Plasma.Restricted Application added a subscriber: plasma-devel. View RevisionREVISION SUMMARYSo far we offered "Empty Trash" only when Folder View points to trash:/ but on the desktop you have a trash link which didn't have this.

[Diff] D4870: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Marco Martin
mart added a comment. View Revisiondon't know if is just a local screwup, but now it takes a long time to load with the console output: QDBusConnection: warning: blocking call took a long time (25370 ms, max for this thread is 200 ms) to service "org.kde.keyboard" path "/Layouts" interface "org.fre

[Diff] D4887: [Folder View] Support undo keyboard shortcut

2017-03-02 Thread Kai Uwe Broulik
broulik created this revision.Restricted Application added a project: Plasma.Restricted Application added a subscriber: plasma-devel. View RevisionREVISION SUMMARYMy first reaction when having done something stupid is to hit Ctrl+Z. This didn't work with FolderView.TEST PLANPressed Delete to trash

[Diff] D4894: [Folder View] Hide item label while renaming

2017-03-02 Thread Kai Uwe Broulik
broulik created this revision.Restricted Application added a project: Plasma.Restricted Application added a subscriber: plasma-devel. View RevisionREVISION SUMMARYWhen item has multiple lines and you clear the rename input field, it would shrink to one line revealing the original text underneath.TE

[Diff] D4895: [Folder View] Cancel rename when scrolling

2017-03-02 Thread Kai Uwe Broulik
broulik created this revision.Restricted Application added a project: Plasma.Restricted Application added a subscriber: plasma-devel. View RevisionREVISION SUMMARYWhen renaming and then starting a scroll (e.g. using mouse wheel) cancel renaming. This prevents the editor floating in mid-air and also

D4874: Fix hover out when exiting visible frame.

2017-03-02 Thread Eike Hein
This revision was automatically updated to reflect the committed changes.Closed by commit R119:54309e677bbf: Fix hover out when exiting visible frame. (authored by hein). View RevisionREPOSITORYR119 Plasma DesktopCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D4874?vs=12027&id=12067REVISION D

D4896: [Folder View] Fix rename editor position in popup with icon mode

2017-03-02 Thread Kai Uwe Broulik
broulik created this revision.Restricted Application added a project: Plasma.Restricted Application added a subscriber: plasma-devel. View RevisionREVISION SUMMARYCheck for icon mode instead of popup for positioning, sizing, and styling of editorTEST PLAN Rename one-line file on desktop containment

[Diff] D4886: [Folder View] Offer "Empty Trash" also for trash link

2017-03-02 Thread Eike Hein
hein accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR119 Plasma DesktopREVISION DETAILhttps://phabricator.kde.org/D4886EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: broulik, Plasma, heinCc: plasma-devel, progwolff, l

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 648 - Still Unstable!

2017-03-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/648/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 02 Mar 2017 14:56:58 + Build duration: 14 min CHANGE SET Revision 54309e677bbfd1ad350cfd17500925be5222

D4875: Fix actions overlay position not adjusting when switching view modes at runtime.

2017-03-02 Thread Eike Hein
This revision was automatically updated to reflect the committed changes.Closed by commit R119:0accf128d4cd: Fix actions overlay position not adjusting when switching view modes at runtime. (authored by hein). View RevisionREPOSITORYR119 Plasma DesktopCHANGES SINCE LAST UPDATEhttps://phabricator.kd

D4887: [Folder View] Support undo keyboard shortcut

2017-03-02 Thread Eike Hein
hein accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR119 Plasma DesktopREVISION DETAILhttps://phabricator.kde.org/D4887EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: broulik, Plasma, heinCc: plasma-devel, progwolff, l

[Diff] D4895: [Folder View] Cancel rename when scrolling

2017-03-02 Thread Eike Hein
hein accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR119 Plasma DesktopREVISION DETAILhttps://phabricator.kde.org/D4895EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: broulik, Plasma, heinCc: plasma-devel, progwolff, l

[Diff] D4867: [Menu] Improved available space correction for openRelative

2017-03-02 Thread Eike Hein
hein accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR242 Plasma Framework (Library)REVISION DETAILhttps://phabricator.kde.org/D4867EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: subdiff, Plasma, heinCc: plasma-devel,

[Diff] D4897: [Folder View] Cancel renaming if focus is lost or popup closes

2017-03-02 Thread Kai Uwe Broulik
broulik created this revision.Restricted Application added a project: Plasma.Restricted Application added a subscriber: plasma-devel. View RevisionREVISION SUMMARYThis way when clicking outside a FolderView applet on desktop it will cancel renaming. Also, when closing a popup.TEST PLANStarted renam

D4897: [Folder View] Cancel renaming if focus is lost or popup closes

2017-03-02 Thread Eike Hein
hein accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR119 Plasma DesktopREVISION DETAILhttps://phabricator.kde.org/D4897EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: broulik, Plasma, heinCc: plasma-devel, progwolff, l

D4894: [Folder View] Hide item label while renaming

2017-03-02 Thread Eike Hein
hein accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR119 Plasma DesktopREVISION DETAILhttps://phabricator.kde.org/D4894EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: broulik, Plasma, heinCc: plasma-devel, progwolff, l

D4896: [Folder View] Fix rename editor position in popup with icon mode

2017-03-02 Thread Eike Hein
hein accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR119 Plasma DesktopREVISION DETAILhttps://phabricator.kde.org/D4896EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: broulik, Plasma, heinCc: plasma-devel, progwolff, l

[Diff] D4868: [TaskManager] For contextMenuComponent placement use accurate enum on right edge

2017-03-02 Thread Eike Hein
hein accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR119 Plasma DesktopREVISION DETAILhttps://phabricator.kde.org/D4868EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: subdiff, Plasma, heinCc: plasma-devel, progwolff, l

D4897: [Folder View] Cancel renaming if focus is lost or popup closes

2017-03-02 Thread Kai Uwe Broulik
broulik added inline comments. View RevisionINLINE COMMENTSView InlineFolderViewLayer.qml:140 folderView.currentIndex = -1; folderView.model.clearSelection(); folderView.cancelRename(); } Whoops, removing this was actually not intentional

D4887: [Folder View] Support undo keyboard shortcut

2017-03-02 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.Closed by commit R119:3491607e70be: [Folder View] Support undo keyboard shortcut (authored by broulik). View RevisionREPOSITORYR119 Plasma DesktopCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D4887?vs=12056&id=12071REVI

D4894: [Folder View] Hide item label while renaming

2017-03-02 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.Closed by commit R119:b4d8de1ed9ec: [Folder View] Hide item label while renaming (authored by broulik). View RevisionREPOSITORYR119 Plasma DesktopCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D4894?vs=12064&id=12072REVI

D4895: [Folder View] Cancel rename when scrolling

2017-03-02 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.Closed by commit R119:3dc7b62129c5: [Folder View] Cancel rename when scrolling (authored by broulik). View RevisionREPOSITORYR119 Plasma DesktopCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D4895?vs=12065&id=12073REVISI

[Diff] D4886: [Folder View] Offer "Empty Trash" also for trash link

2017-03-02 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.Closed by commit R119:30b875939abf: [Folder View] Offer "Empty Trash" also for trash link (authored by broulik). View RevisionREPOSITORYR119 Plasma DesktopCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D4886?vs=12052&id=

[Diff] D4766: Start looking for the parent from the view itself

2017-03-02 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 12075.apol added a comment. View RevisionImprove behavior when there's no actions on the menu If there's no actions, we don't want to squeeze the component below anymore. Allows for UI's such as https://phabricator.kde.org/M91REPOSITORYR169 KirigamiCHANGES SINCE

[Diff] D4896: [Folder View] Fix rename editor position in popup with icon mode

2017-03-02 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.Closed by commit R119:12bd5f33d502: [Folder View] Fix rename editor position in popup with icon mode (authored by broulik). View RevisionREPOSITORYR119 Plasma DesktopCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D4896?v

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 649 - Still Unstable!

2017-03-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/649/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 02 Mar 2017 15:32:19 + Build duration: 15 min CHANGE SET Revision 30b875939abf3e465030680b5e97e80490df

[Diff] D4891: Port away from setRoleNames where easily possible

2017-03-02 Thread Marco Martin
mart accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR242 Plasma Framework (Library)REVISION DETAILhttps://phabricator.kde.org/D4891EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: broulik, Plasma, martCc: plasma-devel,

[Diff] D4892: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Marco Martin
mart abandoned this revision. View RevisionREPOSITORYR120 Plasma WorkspaceREVISION DETAILhttps://phabricator.kde.org/D4892EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: mart, PlasmaCc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

[Diff] D4898: Improve behavior when there's no actions on the menu

2017-03-02 Thread Aleix Pol Gonzalez
apol created this revision.Restricted Application added a project: Kirigami.Restricted Application added a subscriber: plasma-devel. View RevisionREVISION SUMMARYIf there's no actions, we don't want to squeeze the component below anymore. Allows for UI's such as https://phabricator.kde.org/M91REPOS

[Diff] D4898: Improve behavior when there's no actions on the menu

2017-03-02 Thread Marco Martin
mart accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR169 KirigamiBRANCHmasterREVISION DETAILhttps://phabricator.kde.org/D4898EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: apol, Kirigami, martCc: plasma-devel, apol

D4899: [Folder View] Workaround label eliding bug

2017-03-02 Thread Kai Uwe Broulik
broulik created this revision.Restricted Application added a project: Plasma.Restricted Application added a subscriber: plasma-devel. View RevisionREVISION SUMMARYEven though we set maximumLineCount to 1 at which point it should never wrap, it sometimes prematurely elides text seemingly randomly in

D4889: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Marco Martin
mart abandoned this revision. View RevisionREPOSITORYR120 Plasma WorkspaceREVISION DETAILhttps://phabricator.kde.org/D4889EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: mart, PlasmaCc: plasma-devel, mart, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

[Diff] D4890: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Marco Martin
mart abandoned this revision. View RevisionREPOSITORYR120 Plasma WorkspaceREVISION DETAILhttps://phabricator.kde.org/D4890EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: mart, PlasmaCc: plasma-devel, mart, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D4900: RFC: [Folder View] Use fallback icon if failed to load

2017-03-02 Thread Kai Uwe Broulik
broulik created this revision.Restricted Application added a project: Plasma.Restricted Application added a subscriber: plasma-devel. View RevisionREVISION SUMMARYWhen an icon failed to load, show the "unknown" icon instead of a gap. We don't want to check for icon availability in the model for per

D4766: Start looking for the parent from the view itself

2017-03-02 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.Closed by commit R169:2e652af5cb9d: Start looking for the parent from the view itself (authored by apol). View RevisionCHANGED PRIOR TO COMMIThttps://phabricator.kde.org/D4766?vs=12075&id=12080#tocREPOSITORYR169 KirigamiCHANGE

D4765: Make DesktopIcon aware of iamgeproviders and embedded ressources

2017-03-02 Thread Marco Martin
mart accepted this revision.mart added inline comments.This revision is now accepted and ready to land. View RevisionINLINE COMMENTSView Inlinedesktopicon.cpp:145 { if(icon.canConvert()) { m_icon = icon.value(); if (m_source == icon) return; use {} also for on

[Diff] D4765: Make DesktopIcon aware of iamgeproviders and embedded ressources

2017-03-02 Thread Marco Martin
mart added inline comments. View RevisionINLINE COMMENTSView Inlinedesktopicon.cpp:257 break; case QVariant::String:{ img = findIcon(size); {} not needed hereREPOSITORYR169 KirigamiREVISION DETAILhttps://phabricator.kde.org/D4765EMAIL PREFERENCEShttps://phabricator.

D4900: RFC: [Folder View] Use fallback icon if failed to load

2017-03-02 Thread Eike Hein
hein added a comment. View RevisionShould this be in IconItem instead? Q_PROPERTY(QString fallbackSource), etc.REPOSITORYR119 Plasma DesktopREVISION DETAILhttps://phabricator.kde.org/D4900EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: broulik, Plasma, heinCc: plasm

[Diff] D4870: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Marco Martin
mart accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR120 Plasma WorkspaceBRANCHlockscreen-virtual-keyboardREVISION DETAILhttps://phabricator.kde.org/D4870EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: graesslin, Plasm

D4879: notifications: Correctly display the file in jobs

2017-03-02 Thread Xuetian Weng
xuetianweng added a comment. View Revision In D4879#91745, @mart wrote: In D4879#91664, @xuetianweng wrote: (If not, ship this. it seems fine) Label0 is also used elsewhere. We could add another value to engine though, not sure if worth it. it's used in the job delegate and as an error message

[Diff] D4898: Improve behavior when there's no actions on the menu

2017-03-02 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.Closed by commit R169:a90b442d06b3: Improve behavior when there's no actions on the menu (authored by apol). View RevisionREPOSITORYR169 KirigamiCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D4898?vs=12076&id=12081REVIS

[Diff] D4900: RFC: [Folder View] Use fallback icon if failed to load

2017-03-02 Thread Marco Martin
mart added a comment. View Revision In D4900#91982, @hein wrote: Should this be in IconItem instead? Q_PROPERTY(QString fallbackSource), etc. you mean a second icon name for when loading the main one failed?REPOSITORYR119 Plasma DesktopREVISION DETAILhttps://phabricator.kde.org/D4900EMAIL PREFERE

[Diff] D4900: RFC: [Folder View] Use fallback icon if failed to load

2017-03-02 Thread Eike Hein
hein added a comment. View RevisionYep, then the view caring about complexity like "GridView doesn't recycle items, so when the item goes out of view and comes back, it will essentially re-evaluate this." becomes unneeded, and the preview problem goes away because we don't throw the real source awa

D4900: RFC: [Folder View] Use fallback icon if failed to load

2017-03-02 Thread Marco Martin
mart added a comment. View Revision In D4900#91990, @hein wrote: Yep, then the view caring about complexity like "GridView doesn't recycle items, so when the item goes out of view and comes back, it will essentially re-evaluate this." becomes unneeded, and the preview problem goes away because we d

[Diff] D4900: RFC: [Folder View] Use fallback icon if failed to load

2017-03-02 Thread Kai Uwe Broulik
broulik added a comment. View RevisionShould this be in IconItem instead? Q_PROPERTY(QString fallbackSource), etc. Good idea. Back in the days we had KIconLoader always return a "unknown" icon which was changed because it should be the view's responsibility to provide a fallback but now we have ga

Re: Plasmoid's TextField on Panel?

2017-03-02 Thread Zoltan Gyarmati
On 03/02/2017 10:34 AM, Marco Martin wrote: > On Thursday 02 March 2017 05:35:02 Zoltan Gyarmati wrote: >> Dear All, >> >> I'm developing a simple plasmoid which has a few TextFields (imported >> from org.kde.plasma.components 2.0) on it. When i add the plasmoid to >> the desktop or run it with pla

D4870: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Martin Gräßlin
graesslin added a comment. View Revisionthis makes the virtual keyboard always enabled on every system tough? Yes, but it only shows if actively enabled through the new added button. I want to do a compromise between helpful for touch screens and not annoying for no touch screens.REPOSITORYR120 Pl

D4871: Enable qtvirtualkeyboard QT_IM_MODULE for greeter

2017-03-02 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes.Closed by commit R133:c23f532224b7: Enable qtvirtualkeyboard QT_IM_MODULE for greeter (authored by graesslin). View RevisionREPOSITORYR133 KScreenLockerCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D4871?vs=12022&id=120

D4876: [lookandfeel] Add Input Method hints for the password field

2017-03-02 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes.Closed by commit R120:1ce5ed3b7e0d: [lookandfeel] Add Input Method hints for the password field (authored by graesslin). View RevisionREPOSITORYR120 Plasma WorkspaceCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D4876?vs

D4870: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-02 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes.Closed by commit R120:b6705f8d73bd: [lookandfeel] Add virtual keyboard to the LockScreen (authored by graesslin). View RevisionCHANGED PRIOR TO COMMIThttps://phabricator.kde.org/D4870?vs=12034&id=12092#tocREPOSITORYR120 Plasma

D4877: [lookandfeel] Improve positioning of Clock

2017-03-02 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes.Closed by commit R120:097db85e297a: [lookandfeel] Improve positioning of Clock (authored by graesslin). View RevisionREPOSITORYR120 Plasma WorkspaceCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D4877?vs=12037&id=12091RE

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 650 - Still Unstable!

2017-03-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/650/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 02 Mar 2017 19:49:53 + Build duration: 5 min 33 sec CHANGE SET Revision 67e490f48d2c29554fb0872aec4e1d

D4868: [TaskManager] For contextMenuComponent placement use accurate enum on right edge

2017-03-02 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes.Closed by commit R119:67e490f48d2c: [TaskManager] For context menu placement use accurate enum on right edge (authored by subdiff). View RevisionREPOSITORYR119 Plasma DesktopCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org

[kio-extras] [Bug 375249] "File not found" when trying to open file from nfs

2017-03-02 Thread Luca Weiss
https://bugs.kde.org/show_bug.cgi?id=375249 --- Comment #3 from Luca Weiss --- So after quite a bit of debugging I have found out that apparently the problem is that my NFS server has a share that's not available for my IP address (only for another one) and fhStatus.fhs_status (in nfsv3.cpp->open

[kio-extras] [Bug 375249] "File not found" when trying to open file from nfs

2017-03-02 Thread Luca Weiss
https://bugs.kde.org/show_bug.cgi?id=375249 --- Comment #4 from Luca Weiss --- Created attachment 104327 --> https://bugs.kde.org/attachment.cgi?id=104327&action=edit Workaround patch, not a proposed patch! -- You are receiving this mail because: You are the assignee for the bug.

D4903: Drop building QPulseAudioPrivate library

2017-03-02 Thread David Rosca
drosca created this revision.Restricted Application added a project: Plasma.Restricted Application added a subscriber: plasma-devel. View RevisionREVISION SUMMARYWe don't install headers for the library and nothing in Plasma uses it, so just move everything into QML import plugin.TEST PLANBuilds an

D4839: kio_mtp: add write permissions to root storage folder

2017-03-02 Thread Kai Uwe Broulik
broulik added a reviewer: dfaure. View RevisionREPOSITORYR320 KIO ExtrasREVISION DETAILhttps://phabricator.kde.org/D4839EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: elvisangelaccio, Plasma, dfaureCc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterber

D4370: Set a longer wallpaper transition time

2017-03-02 Thread Kai Uwe Broulik
broulik accepted this revision.broulik added a comment.This revision is now accepted and ready to land. View RevisionJust noticed I hadn't set my sails for adventure when I first saw this. Let's go with this I'd say.INLINE COMMENTSView Inlinemain.xml:30 name="TransitionAnimationDuration" type=

D4358: [cursors] Add 36px (1.5 scaling) size for Breeze and Breeze Snow Cursors

2017-03-02 Thread Kai Uwe Broulik
broulik added a comment. View RevisionI guess this is good to go? (btw I think the credit in the BUG line will break auto-closing that bug :D)REPOSITORYR31 BreezeREVISION DETAILhttps://phabricator.kde.org/D4358EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: subdiff

D2975: [shell] Event compress resizePanel

2017-03-02 Thread Kai Uwe Broulik
broulik added a comment. View RevisionIs this obsolete then?REPOSITORYR120 Plasma WorkspaceREVISION DETAILhttps://phabricator.kde.org/D2975EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: bshah, PlasmaCc: broulik, mart, hein, plasma-devel, progwolff, lesliezhai, ali-

D4867: [Menu] Improved available space correction for openRelative

2017-03-02 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes.Closed by commit R242:daee27f0962d: [Menu] Improve available space correction for openRelative (authored by subdiff). View RevisionCHANGED PRIOR TO COMMIThttps://phabricator.kde.org/D4867?vs=12015&id=12094#tocREPOSITORYR242 Pl

D4904: [Applet] Open contextMenu relatively to visual parent contextMenuButton

2017-03-02 Thread Roman Gilg
subdiff created this revision.subdiff added a project: Plasma. View RevisionREVISION SUMMARYThis will open the context menu aligned to its button and will not hide the button if there is not enough space for it: F2675613: 1.png F2675614: 2.png Thanks to @broulik for the advice.REPOSITORYR115 Plas

D4904: [Applet] Open contextMenu relatively to visual parent contextMenuButton

2017-03-02 Thread David Rosca
drosca accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR115 Plasma Audio Volume AppletREVISION DETAILhttps://phabricator.kde.org/D4904EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: subdiff, Plasma, droscaCc: plasma-dev

D4904: [Applet] Open contextMenu relatively to visual parent contextMenuButton

2017-03-02 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes.Closed by commit R115:d8b305292240: [Applet] Open contextMenu relatively to visual parent contextMenuButton (authored by subdiff). View RevisionREPOSITORYR115 Plasma Audio Volume AppletCHANGES SINCE LAST UPDATEhttps://phabrica

D4358: [cursors] Add 36px (1.5 scaling) size for Breeze and Breeze Snow Cursors

2017-03-02 Thread Roman Gilg
subdiff added a comment. View RevisionFrom my side it's good to go. I thought somebody maybe wants to test it beforehand. Otherwise I can commit it tomorrow likewise.REPOSITORYR31 BreezeREVISION DETAILhttps://phabricator.kde.org/D4358EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/email

D3805: Per-activity favorites (WIP)

2017-03-02 Thread Ivan Čukić
ivan updated this revision to Diff 12098.ivan added a comment. View RevisionI need help with this one. I've temporarily added ModelTest and two QListViews to show the contents of the models. KActivities::Stats::ResultModel has no problems according to both the ModelTest and the QListView it is sh

D4905: Disable editing of 'Global Shortcuts' component names

2017-03-02 Thread Christoph Feck
cfeck created this revision.cfeck added a project: Plasma.Restricted Application added a subscriber: plasma-devel. View RevisionREVISION SUMMARYDouble clicking component names in systemsettings5 > Global Shortcuts starts name editing, which does not seem to be intended (the changes are not saved).

D4905: Disable editing of 'Global Shortcuts' component names

2017-03-02 Thread Kai Uwe Broulik
broulik accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR119 Plasma DesktopREVISION DETAILhttps://phabricator.kde.org/D4905EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: cfeck, davidedmundson, broulikCc: plasma-devel,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 651 - Failure!

2017-03-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/651/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 02 Mar 2017 23:26:48 + Build duration: 7 min 21 sec CHANGE SET Revision 94d0d421b2e0313e785e65db9cc3da9

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 87 - Still Unstable!

2017-03-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/87/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 02 Mar 2017 23:26:13 + Build duration: 17 min CHANGE SET Revision 20f678e1835beef7c5d746d201

D4905: Disable editing of 'Global Shortcuts' component names

2017-03-02 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes.Closed by commit R119:cafc7d5a448a: Disable editing of 'Global Shortcuts' component names (authored by cfeck). View RevisionREPOSITORYR119 Plasma DesktopCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D4905?vs=12099&id=12

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 652 - Still unstable!

2017-03-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/652/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 03:12:36 + Build duration: 16 min CHANGE SET Revision 8f3c819bbfe63d768aba1745db36c27a5b7c

  1   2   >