[Differential] [Closed] D4794: Fix default fixed font in fonts kcm

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d02de0db36a3: Fix default fixed font in fonts kcm (authored by fvogt). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4794?vs=11826&id=11841 REVISION DETAIL

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 81 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/81/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 26 Feb 2017 09:04:05 + Build duration: 5 min 42 sec CHANGE SET Revision 26cc9e021159669e579c

[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

anthonyfieroni added a comment. > ! In https://phabricator.kde.org/D4491#90001, @jsalatas wrote: > I like the idea but ElideMiddle doesn't seem to work for me: Seems that it just keeps the left part of the text that it can fit and ignores anything else :\ Yeah, looks like only ElideRi

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 637 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/637/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 26 Feb 2017 09:05:50 + Build duration: 15 min CHANGE SET Revision 26cc9e021159669e579ce839887a1ec0c694

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

hpereiradacosta added a comment. Hello Roman, I disagree that the current toolbutton design "doesn't fit the overall design". It is (to me at least) consistent with the widget style (in e.g. toolbars), and all the other "squarish" elements of breeze. On the contrary, I would find the

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

broulik added a comment. I agree with Hugo. I also never liked the faint blue press effect of buttons that was introduced in the Breeze revamp in 5.5 to begin with, having that as normal state now is a no-go for me. Also, you can't just randomly change the behavior of ToolButtonStyle, i

[Differential] [Closed] D4767: Applet: Fix binding loop on ListItem height

This revision was automatically updated to reflect the committed changes. Closed by commit R115:a82bccea2d33: Applet: Fix binding loop on ListItem height (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4767?vs=11780&id=1

[Differential] [Closed] D4770: KCM: Only scroll when mouse is over tabbar

This revision was automatically updated to reflect the committed changes. Closed by commit R115:8b2acc7c6f42: KCM: Only scroll when mouse is over tabbar (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4770?vs=11786&id=11

[Differential] [Closed] D4781: Add Module class + disable advanced options when module-gconf is not loaded

This revision was automatically updated to reflect the committed changes. Closed by commit R115:817af4b68f6b: Add Module class + disable advanced options when module-gconf is not loaded (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabric

[Differential] [Updated, 56 lines] D4689: IconItem: Add roundToIconSize property

drosca updated this revision to Diff 11845. drosca added a comment. Add default is true REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4689?vs=11551&id=11845 BRANCH arcpatch-D4689 REVISION DETAIL https://phabricator.kde.org/D4689 A

[Differential] [Request, 52 lines] D4806: [greeter] Send the auth result through the server instead return value

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Given that we have the protocol and don't use the legacy conv any more there is no need to go through exit code mapping. By not using exit

[Differential] [Updated, 63 lines] D4806: [greeter] Send the auth result through the server instead return value

graesslin updated this revision to Diff 11848. graesslin added a comment. Also adjust unit test for the change REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4806?vs=11847&id=11848 BRANCH auth-result-through-server REVISION DETAIL https://phabri

[Differential] [Updated] D4780: [kcheckpass] Drop the conv_legacy support

graesslin added a dependent revision: D4806: [greeter] Send the auth result through the server instead return value. REVISION DETAIL https://phabricator.kde.org/D4780 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma Cc: plasma-devel, prog

[Differential] [Updated] D4806: [greeter] Send the auth result through the server instead return value

graesslin added dependencies: D4785: Add a small test application for kcheckpass, D4780: [kcheckpass] Drop the conv_legacy support. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4806 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

subdiff added a comment. I see where you're coming from. You're right, that the rounded edges don't fit so well to other Plasma element. So I would try to find another design, because I still think the current ToolButton is ugly. Let me make it more clear, what I dislike about the current (f

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

ltoscano added a comment. In https://phabricator.kde.org/D4797#90068, @subdiff wrote: > This looks weird, because painting a whole button is not a small hint for the user that he can interact with the element but looks more like a completely new independent button suddenly being created.

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

hpereiradacosta added a comment. Hi Roman, > Would you support the idea of using the KToolBar ToolButton design for the QML ToolButton aswell? It looks way better in my opinion and it would make the use of tool buttons more consistent. Yes, I would support this. It would be more con

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

broulik added a comment. > Would you support the idea of using the KToolBar ToolButton design for the QML ToolButton aswell? Good idea. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4797 EMAIL PREFERENCES https://phabricator.kde.org/setti

[Differential] [Updated, 77 lines] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

ppalaga updated this revision to Diff 11852. ppalaga added a comment. > The comparisons (thanks for going to the length to make them) look OK, at least for "let's go with this and check for feedback". Let's go ahead! Nice to heard that :) I am updating the diff so that the configurat

[Differential] [Updated, 169 lines] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

subdiff updated this revision to Diff 11853. subdiff added a comment. Replicate the design of QToolButton (used for example in the tool bars of System Settings and Dolphin). F2617274: Spectacle.oB6068.png REPOSITORY R242 Plasma Framework (Library)

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

hpereiradacosta added a comment. + 1 for me. Looks good! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4797 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma Cc: ltoscano, broulik, hpereiradaco

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

broulik added a comment. Design looks ok but still you can't change `ToolButtonStyle`, instead, the Breeze Plasma theme needs to be changed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4797 EMAIL PREFERENCES https://phabricator.kde.org/setti

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

subdiff added a comment. In https://phabricator.kde.org/D4797#90126, @broulik wrote: > Design looks ok but still you can't change `ToolButtonStyle`, instead, the Breeze Plasma theme needs to be changed. Sorry, I didn't quite get it the last time you mentioned it. I think I unders

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

hpereiradacosta added a comment. > Also I tested it now with the Oxygen and United themes, and `QToolButton` has still the same flat frame line in highlight color around it in when hovered like in Breeze, so it seems to be independent of the theme in `QToolButton` as well. In the Oxygen case

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

broulik added a comment. > So changing only the theme would mean to change the svg of `ButtonStyle`, which is not desirable. Then we need to introduce new elements in `widgets/button.svg` or a new `widget/toolbutton.svg` for `ToolButton` which is used and falls back to the old behavior

[Differential] [Commented On] D4711: Ungrab mouse on menu close

anthonyfieroni added a comment. Yep, same faulty beharior present in all Qt apps, Qupzilla, QtCreator, etc. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4711 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: a

[Differential] [Requested Changes] D4689: IconItem: Add roundToIconSize property

sebas requested changes to this revision. sebas added a comment. This revision now requires changes to proceed. I think a problem with using roundToIconSize as isolated property is that it really isn't. It has intended effects on the sizing of the item, but the current version of the patch do

[Differential] [Accepted] D4785: Add a small test application for kcheckpass

sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R133 KScreenLocker BRANCH kcheckpass-testapp REVISION DETAIL https://phabricator.kde.org/D4785 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma

[Differential] [Requested Changes] D807: Fix for Bug 357684

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. As far as i can see this was never commited and now does not apply anymore. Can you please update it? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAI

[Differential] [Closed] D2301: [Kicker] Add missing config-workspace.h include to appentry.cpp

aacid closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2301 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: abondrov, hein, sebas Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abett

[Differential] [Closed] D3344: Remove deprecated --shut-up start flag

This revision was automatically updated to reflect the committed changes. Closed by commit R120:dc21a1996edb: Remove deprecated --shut-up start flag (authored by tigerfoot, committed by aacid). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3344?vs=81

[Differential] [Requested Changes] D3484: Center systemmonitor window properly on multi-screen setup

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. @graesslin so how do we move forward with this, i.e. how can this work with Wayland? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3484 EMAIL P

[kio-extras] [Bug 364642] 16.04.3: kio_sftp is broken

https://bugs.kde.org/show_bug.cgi?id=364642 Janek Bevendorff changed: What|Removed |Added CC||k...@jbev.net --- Comment #6 from Janek Beve

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 84 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/84/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 26 Feb 2017 23:36:00 + Build duration: 27 min CHANGE SET Revision dc21a1996edb98916224fb9d

[Differential] [Closed] D1161: PanelView length cleanup

aacid closed this revision. aacid added a comment. https://phabricator.kde.org/R120:12f7cbf50df173691f4d60291908cfc11268d8e2 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1161 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D3484: Center systemmonitor window properly on multi-screen setup

graesslin added a comment. In https://phabricator.kde.org/D3484#90292, @aacid wrote: > @graesslin so how do we move forward with this, i.e. how can this work with Wayland? It cannot. It is not the business of Windows to place themselves. That is also on X11 bad and breaking with

[Differential] [Closed] D4785: Add a small test application for kcheckpass

This revision was automatically updated to reflect the committed changes. Closed by commit R133:711565e4195a: Add a small test application for kcheckpass (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4785?vs=11812&id=11878 REVI

[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

anthonyfieroni added a comment. At least i plan to commit it from tomorrow release, so title 1 line or 2 lines ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4491 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthony