[Differential] [Commented On] D4599: Allow for a header outside of the page in a ScrollablePage, with flexible height

mart added a comment. that's what i get with it: a reserved space, always blank in every page, it was clearly not tested enough. I don't think is the right way to go about it, i wonder how much is possible to (ab)use the regular header property for pages F2489421: Spectacle.Zb7238.png

[Differential] [Commented On] D4599: Allow for a header outside of the page in a ScrollablePage, with flexible height

mart added a comment. stock ListView already has some api to control its own header. by default it scrolls away, otherwise it can be either fixed or being an hybrid on scrolling away and fixed title ListView.PullBackHeader (the one actually interesting i think, but different apps will need

[Differential] [Commented On] D4606: don't show 0% when no battery

mart added a comment. In https://phabricator.kde.org/D4606#86236, @broulik wrote: > Does it even make sense to show this thing if there's no battery? We already show a cross on the icon then, don't we? Makes it a bit redundant. On the other hand it could be confusing to have the option c

[Differential] [Updated, 283 lines] D4576: [WIP]: integrate drop menu and filecopy drop menu

mart updated this revision to Diff 11368. mart added a comment. - use dropjobs instead of directly accessing its qmenu REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4576?vs=11307&id=11368 BRANCH arcpatch-D4576 REVISION DETAIL https

[Differential] [Request, 13 lines] D4620: allow to add application actions on an open menu

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY even if the menu has already been created, cause setapplicationActions to add actions in th

[Differential] [Updated, 19 lines] D4574: [WIP]: unify file drop menu and containment

mart updated this revision to Diff 11370. mart added a comment. - pass directly the dropJob REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4574?vs=11232&id=11370 BRANCH arcpatch-D4574 REVISION DETAIL https://phabricator.kde.org/D4574 AFFECTED

[Differential] [Updated, 11 lines] D4620: allow to add application actions on an open menu

mart updated this revision to Diff 11371. mart added a comment. - remove useless signal REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4620?vs=11369&id=11371 BRANCH phab/setActionsLater REVISION DETAIL https://phabricator.kde.org/D4620 AFFECTED FILES s

[Differential] [Abandoned] D4575: add a popupmenuabouttoshow version that exposes the menu

mart abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4575 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: hein, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4620: allow to add application actions on an open menu

hein added a comment. Much nicer than the other approach, just one question. INLINE COMMENTS > dropjob.cpp:324 > +for (QMenu *menu : d->m_menus) { > +if (!d->m_appActions.isEmpty() || !d->m_pluginActions.isEmpty()) { > +menu->addSeparator(); Should this be && instead

[Differential] [Accepted] D3684: Media Controls on lock screen

graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. From my side it can go in even without the config option. Let's better integrate the new features early and add the config lateron REPOSITORY R120 Plasma Workspace REVISION DETAIL https://

[Differential] [Commented On] D4606: don't show 0% when no battery

mart added a comment. In https://phabricator.kde.org/D4606#86236, @broulik wrote: > the idea was to stilòl have the badge show up to not make that option look "broken". tough also having the checkbox greyed out makes sense too ah, found another reason why keeping the badge would b

[Differential] [Closed] D3684: Media Controls on lock screen

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f32960cf3805: Add Media Controls on lock screen (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3684?vs=9030&id=11374 REVISION DETAI

[Differential] [Updated, 4 lines] D4606: don't show 0% when no battery

mart updated this revision to Diff 11375. mart added a comment. - e i18n for the placeholder REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4606?vs=11328&id=11375 BRANCH arcpatch-D4606 REVISION DETAIL https://phabricator.kde.org/D4606 AFFECT

[Differential] [Request, 861 lines] D4623: Split KWin::Xkb into a dedicated .h and .cpp

graesslin created this revision. graesslin added reviewers: KWin, Plasma. graesslin added a task: T5221: Split Xkb into dedicated .h and .cpp. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Closes https://phabricator.k

[Differential] [Accepted] D4623: Split KWin::Xkb into a dedicated .h and .cpp

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH split-xkb-dedicated-file REVISION DETAIL https://phabricator.kde.org/D4623 EMAIL PREFERENCES https://phabricator.kde.org/s

[Differential] [Accepted] D4606: don't show 0% when no battery

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D4606 REVISION DETAIL https://phabricator.kde.org/D4606 EMAIL PREFERENCES https://phabricator.kde.org

[Differential] [Closed] D4606: don't show 0% when no battery

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9131740a82f8: don't show 0% when no battery (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4606?vs=11375&id=11379 REVISION DETAIL ht

[Differential] [Commented On] D4414: don't regenerate frames when setting every property

drosca added a comment. I now get tons of binding loop errors from FrameSvgItem, it also breaks delegates in networkmanager and bluetooth applets. On the screenshot you can see that the last 3 delegates (HUAWEI, UPC and Internet) are slightly moved to the left and hovering over them will cor

[Differential] [Changed Subscribers] D4620: allow to add application actions on an open menu

dfaure added inline comments. INLINE COMMENTS > hein wrote in dropjob.cpp:324 > Should this be && instead of ||? "Add actions if either of those is not > empty" seems weird, what's the reasoning? It's a copy of the if() on line 311. But there it makes sense. Here not so much ;) What if there

[Differential] [Commented On] D3684: Media Controls on lock screen

andreaska added a comment. thanks well done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3684 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, mart, #plasma, graesslin Cc: andreaska, graessli

[Differential] [Abandoned] D4599: Allow for a header outside of the page in a ScrollablePage, with flexible height

apol abandoned this revision. apol added a comment. Yep, `headerPositioning: ListView.OverlayHeader` was what I was looking for, thanks a lot for the hint! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D4599 EMAIL PREFERENCES https://phabricator.kde.org/